GNU bug report logs - #48186
[PATCH] gnu: emacs-rime: Adjust to changes in emacs-build-system.

Previous Next

Package: guix-patches;

Reported by: luhui <luhuins <at> 163.com>

Date: Mon, 3 May 2021 13:45:01 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48186 in the body.
You can then email your comments to 48186 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#48186; Package guix-patches. (Mon, 03 May 2021 13:45:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to luhui <luhuins <at> 163.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 03 May 2021 13:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: luhui <luhuins <at> 163.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-rime: Adjust to changes in emacs-build-system.
Date: Mon, 3 May 2021 21:43:42 +0800
[Message part 1 (text/plain, inline)]
Because of the update of emacs-build-system it cannot run correctly, fix it.
[0001-gnu-emacs-rime-Adjust-to-changes-in-emacs-build-syst.patch (text/plain, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#48186; Package guix-patches. (Tue, 11 May 2021 16:18:02 GMT) Full text and rfc822 format available.

Message #8 received at 48186 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: luhui <luhuins <at> 163.com>
Cc: 48186 <at> debbugs.gnu.org
Subject: Re: bug#48186: [PATCH] gnu: emacs-rime: Adjust to changes in
 emacs-build-system.
Date: Wed, 12 May 2021 00:16:45 +0800
[Message part 1 (text/plain, inline)]
I think #:include is better.

[0001-gnu-emacs-rime-Adjust-to-changes-in-emacs-build-syst.patch (text/x-patch, inline)]
From 3e4c22f82ad038e89de866198dccc7e793d185b6 Mon Sep 17 00:00:00 2001
From: Zheng junjie <873216071 <at> qq.com>
Date: Tue, 11 May 2021 23:44:44 +0800
Subject: [PATCH] gnu: emacs-rime: Adjust to changes in emacs-build-system.

* gnu/packages/emacs-xyz.scm (emacs-rime):[arguments]: Use #:include rather
than #:phases to add librime-emacs.so.
---
 gnu/packages/emacs-xyz.scm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index fc4c03965e..ff90c6bd3a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -97,6 +97,7 @@
 ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 Eugene Klimov <lipklim <at> mailbox.org>
+;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -25720,7 +25721,8 @@ REPL appropriate to the current major mode.")
         (base32 "1a50cziwg7lpgh26yvwxs46jfyfq1m0l6igbg5g5m288mz4d3an9"))))
     (build-system emacs-build-system)
     (arguments
-     '(#:phases
+     '(#:include (cons "\\.so$" %default-include)
+       #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-rime-data-path
            (lambda* (#:key inputs #:allow-other-keys)
@@ -25732,13 +25734,7 @@ REPL appropriate to the current major mode.")
              #t))
          (add-before 'install 'build-emacs-module
            (lambda _
-             (invoke "make" "lib")))
-         (add-after 'install 'install-emacs-module
-           (lambda* (#:key outputs #:allow-other-keys)
-             (install-file "librime-emacs.so"
-                           (string-append (assoc-ref outputs "out")
-                                          "/share/emacs/site-lisp"))
-             #t)))))
+             (invoke "make" "lib"))))))
     (inputs
      `(("librime" ,librime)
        ("rime-data" ,rime-data)))
-- 
2.31.1

[Message part 3 (text/plain, inline)]
-- 
over

Information forwarded to guix-patches <at> gnu.org:
bug#48186; Package guix-patches. (Tue, 11 May 2021 17:33:01 GMT) Full text and rfc822 format available.

Message #11 received at 48186 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Z572 <873216071 <at> qq.com>, luhui <luhuins <at> 163.com>
Cc: 48186 <at> debbugs.gnu.org
Subject: Re: bug#48186: [PATCH] gnu: emacs-rime: Adjust to changes in
 emacs-build-system.
Date: Tue, 11 May 2021 19:32:48 +0200
Am Mittwoch, den 12.05.2021, 00:16 +0800 schrieb Z572:
> I think #:include is better.
So do I.  Pushed as bb29c2657281dd2bc76c2fdb643bff4f3e4caed4.
Thanks.





bug closed, send any further explanations to 48186 <at> debbugs.gnu.org and luhui <luhuins <at> 163.com> Request was from Liliana Marie Prikler <liliana.prikler <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 01 Dec 2021 17:51:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 30 Dec 2021 12:24:14 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 79 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.