GNU bug report logs - #48194
[PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48194 in the body.
You can then email your comments to 48194 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2.
Date: Mon,  3 May 2021 17:20:34 +0200

* gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags.
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 481ab46b6e..1052351357 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -3834,6 +3834,8 @@ practically any type of media.")
     (build-system gnu-build-system)
     (arguments
      '(#:tests? #f ; see above TODO
+       #:configure-flags
+       (list "--with-libcurl" "--with-libtinyxml2")
        #:phases
        ;; build scripts not in root of archive
        (modify-phases %standard-phases
-- 
2.31.1

Message #10 received at 48194-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 48194-done <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Tue, 11 May 2021 12:31:36 +0200

Hi,

Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags.

Applied, thanks!

Message #13 received at 48194 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 48194 <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Tue, 11 May 2021 12:51:24 +0200

Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags.

Actually no, this one appears to break ‘mediainfo’ as I wrote in my
other message.

Message #20 received at 48194 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48194 <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Tue, 11 May 2021 14:14:30 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Michael Rohleder <mike <at> rohleder.de> skribis:
>
>> * gnu/packages/video.scm (libmediainfo)[arguments]: Add configure-flags.
>
> Actually no, this one appears to break ‘mediainfo’ as I wrote in my
> other message.

The consumer (mediainfo) needs curl and tinyxml2 inputs:

[0001-gnu-mediainfo-Fix-usage-of-libcurl-and-tinyxml2.patch (text/x-patch, inline)]

>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Tue, 11 May 2021 14:05:13 +0200
Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2.

* gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2.
---
 gnu/packages/video.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 481ab46b6e..630edf49b6 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -3834,6 +3834,8 @@ practically any type of media.")
     (build-system gnu-build-system)
     (arguments
      '(#:tests? #f ; see above TODO
+       #:configure-flags
+       (list "--with-libcurl" "--with-libtinyxml2")
        #:phases
        ;; build scripts not in root of archive
        (modify-phases %standard-phases
@@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)...
        ("libtool" ,libtool)
        ("pkg-config" ,pkg-config)
        ("zlib" ,zlib)
+       ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files.
+       ("tinyxml2" ,tinyxml2)
        ("libmediainfo" ,libmediainfo)
        ("libzen" ,libzen)))
     (build-system gnu-build-system)
-- 
2.31.1

[Message part 3 (text/plain, inline)]

-- 
A million monkeys pounding on a million typewriters will never produce 
Shakespeare. The experiment's been tried; we got USENET instead.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 48194 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 48194 <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Tue, 11 May 2021 14:30:38 +0200

Michael Rohleder <mike <at> rohleder.de> skribis:

>>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Tue, 11 May 2021 14:05:13 +0200
> Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2.
>
> * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2.

Please mention [arguments] and [propagated-inputs].


>  gnu/packages/video.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 481ab46b6e..630edf49b6 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -3834,6 +3834,8 @@ practically any type of media.")
>      (build-system gnu-build-system)
>      (arguments
>       '(#:tests? #f ; see above TODO
> +       #:configure-flags
> +       (list "--with-libcurl" "--with-libtinyxml2")
>         #:phases
>         ;; build scripts not in root of archive
>         (modify-phases %standard-phases
> @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)...
>         ("libtool" ,libtool)
>         ("pkg-config" ,pkg-config)
>         ("zlib" ,zlib)
> +       ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files.
> +       ("tinyxml2" ,tinyxml2)

Shouldn’t we also remove them from ‘native-inputs’, which looks bogus
anyway?

Thanks,
Ludo’.

Message #26 received at 48194 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 48194 <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Sun, 06 Jun 2021 15:17:09 +0200

Ping!  :-)

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Michael Rohleder <mike <at> rohleder.de> skribis:
>
>>>>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001
>> From: Michael Rohleder <mike <at> rohleder.de>
>> Date: Tue, 11 May 2021 14:05:13 +0200
>> Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2.
>>
>> * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2.
>
> Please mention [arguments] and [propagated-inputs].
>
>
>>  gnu/packages/video.scm | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> index 481ab46b6e..630edf49b6 100644
>> --- a/gnu/packages/video.scm
>> +++ b/gnu/packages/video.scm
>> @@ -3834,6 +3834,8 @@ practically any type of media.")
>>      (build-system gnu-build-system)
>>      (arguments
>>       '(#:tests? #f ; see above TODO
>> +       #:configure-flags
>> +       (list "--with-libcurl" "--with-libtinyxml2")
>>         #:phases
>>         ;; build scripts not in root of archive
>>         (modify-phases %standard-phases
>> @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)...
>>         ("libtool" ,libtool)
>>         ("pkg-config" ,pkg-config)
>>         ("zlib" ,zlib)
>> +       ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files.
>> +       ("tinyxml2" ,tinyxml2)
>
> Shouldn’t we also remove them from ‘native-inputs’, which looks bogus
> anyway?
>
> Thanks,
> Ludo’.

Message #29 received at 48194 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48194 <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Wed, 09 Jun 2021 08:27:52 +0200

[Message part 1 (text/plain, inline)]

Hey Ludo!

Thanks for the ping and sorry for the delay!

I hope, this patch is better/pushable ;)

[0001-gnu-libmediainfo-Fix-usage-of-libcurl-and-libtinyxml.patch (text/x-patch, inline)]

>From 7e998af5b498388e5ffcf2491c6c934bf49b5c98 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Wed, 9 Jun 2021 08:12:40 +0200
Subject: [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2.

* gnu/packages/video.scm (libmediainfo): Fix usage of libcurl and libtinyxml2.
[arguments]: Add configure-flags.
[native-inputs]: Move zlib, tinyxml2, curl, libzen to ...
[propagated-inputs]: ... Here.
(mediainfo):
[native-inputs]: Remove zlib, libzen. Move libmediainfo to ...
[inputs]: ... Here.
---
 gnu/packages/video.scm | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a694d4bb43..5c028016cf 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -3850,14 +3850,17 @@ practically any type of media.")
      `(("autoconf" ,autoconf)
        ("automake" ,automake)
        ("libtool" ,libtool)
-       ("pkg-config" ,pkg-config)
-       ("zlib" ,zlib)
+       ("pkg-config" ,pkg-config)))
+    (propagated-inputs
+     `(("zlib" ,zlib)
        ("tinyxml2" ,tinyxml2)
-       ("curl" ,curl)
+       ("curl" ,curl) ; In Requires.private of libmediainfo.pc.
        ("libzen" ,libzen)))
     (build-system gnu-build-system)
     (arguments
      '(#:tests? #f ; see above TODO
+       #:configure-flags
+       (list "--with-libcurl" "--with-libtinyxml2")
        #:phases
        ;; build scripts not in root of archive
        (modify-phases %standard-phases
@@ -3910,10 +3913,9 @@ MPEG-2, MPEG-4, DVD (VOB)...
      `(("autoconf" ,autoconf)
        ("automake" ,automake)
        ("libtool" ,libtool)
-       ("pkg-config" ,pkg-config)
-       ("zlib" ,zlib)
-       ("libmediainfo" ,libmediainfo)
-       ("libzen" ,libzen)))
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libmediainfo" ,libmediainfo)))
     (build-system gnu-build-system)
     (arguments
      '(#:tests? #f ; lacks tests
-- 
2.32.0

[Message part 3 (text/plain, inline)]

-- 
I've finally learned what "upward compatible" means.  It means we get to
keep all our old mistakes.    Dennie van Tassel

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 48194-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 48194-done <at> debbugs.gnu.org
Subject: Re: bug#48194: [PATCH] gnu: libmediainfo: Fix usage of libcurl and
 libtinyxml2.
Date: Sat, 12 Jun 2021 00:40:05 +0200

Hi,

Michael Rohleder <mike <at> rohleder.de> skribis:

>>From 7e998af5b498388e5ffcf2491c6c934bf49b5c98 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Wed, 9 Jun 2021 08:12:40 +0200
> Subject: [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2.
>
> * gnu/packages/video.scm (libmediainfo): Fix usage of libcurl and libtinyxml2.
> [arguments]: Add configure-flags.
> [native-inputs]: Move zlib, tinyxml2, curl, libzen to ...
> [propagated-inputs]: ... Here.
> (mediainfo):
> [native-inputs]: Remove zlib, libzen. Move libmediainfo to ...
> [inputs]: ... Here.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.