GNU bug report logs - #48215
[PATCH 0/1] Fix broken crm114 package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48215 in the body.
You can then email your comments to 48215 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 0/1] Fix broken crm114 package
Date: Tue,  4 May 2021 10:31:03 +0530

Hi,

Our crm114 package broke due to the recent change in the emacs-build-system
installing emacs lisp files in their own subdirectories. This patch fixes the
build and makes it more robust to any future changes in the
emacs-build-system.

Arun Isaac (1):
  gnu: crm114: Install emacs mode using emacs-build-system install
    phase.

 gnu/packages/mail.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
2.31.0

Message #8 received at 48215 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 48215 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: crm114: Use emacs-build-system install phase.
Date: Tue,  4 May 2021 10:36:51 +0530

* gnu/packages/mail.scm (crm114)[arguments]: Install the crm114 emacs mode
using the install phase from emacs-build-system, instead of in the custom
pre-install phase. Run the make-autoloads phase after this new
install-emacs-mode phase.
---
 gnu/packages/mail.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index e4ddf5ee9b..ea5a3d2b1e 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -4432,12 +4432,11 @@ score.")
                ;; Install mail related crm scripts.
                (for-each (lambda (file)
                            (install-file file (string-append out "/bin")))
-                         (list "mailfilter.crm" "mailreaver.crm" "mailtrainer.crm"))
-               ;; Create emacs site-lisp directory so that the install phase
-               ;; can install crm-mode.
-               (mkdir-p (string-append out "/share/emacs/site-lisp")))))
+                         (list "mailfilter.crm" "mailreaver.crm" "mailtrainer.crm")))))
+         (add-after 'install 'install-emacs-mode
+           (assoc-ref emacs:%standard-phases 'install))
          ;; Run phases from the emacs build system.
-         (add-after 'install 'make-autoloads
+         (add-after 'install-emacs-mode 'make-autoloads
            (assoc-ref emacs:%standard-phases 'make-autoloads))
          (add-after 'make-autoloads 'enable-autoloads-compilation
            (assoc-ref emacs:%standard-phases 'enable-autoloads-compilation))
-- 
2.31.0

Message #13 received at 48215-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 48215-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: crm114: Use emacs-build-system install phase.
Date: Wed, 05 May 2021 10:11:53 +0200

Pushed as c1036042a52ea25fa833b5b30d18b9f198b74727.
Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.