Received: (at 48225) by debbugs.gnu.org; 8 May 2021 12:41:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 08 08:41:19 2021 Received: from localhost ([127.0.0.1]:50061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lfMGl-000783-Hp for submit <at> debbugs.gnu.org; Sat, 08 May 2021 08:41:19 -0400 Received: from mout02.posteo.de ([185.67.36.66]:38643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <glv@HIDDEN>) id 1lfMGk-00077w-59 for 48225 <at> debbugs.gnu.org; Sat, 08 May 2021 08:41:18 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id CCFA52400FD for <48225 <at> debbugs.gnu.org>; Sat, 8 May 2021 14:41:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1620477671; bh=MM09+O7MOox6dkvCNcDUmzgwYfVmDn28o0u7cL2PXOM=; h=From:To:Cc:Subject:Date:From; b=rwJaseoDKuUa44jQ3W5oevHwNauEjo7nTUwG+ENJsIcYeiyb0fcFc3U2NObSDnm7l +JLarkrvejh2HdL5YVVmPGFNRoBSCOUVe+CSdouYULhJ7UlX2dQEkNx0RRpIrU8hD4 N5WKOrRRBG/aiKrduRsIAydY8OVFDa9aVBsQKNjR0LgoV04E5UT6qiIEUtKl4AHum1 9Ra02i2bQuBNxtwu1Re1UBW68xHUO+m5neL30/5OGlyS829on6X4pfbZzdTmbDiOcV ooocU8gZwQfkrgTqKo4UeF4VNlcUx8oQB3hMkjwA8F8MdZrCruhXhU4u4/XNWak4p1 QYsxeOhHycrcg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fcn461P3Mz6tmH; Sat, 8 May 2021 14:41:10 +0200 (CEST) References: <87o8dqy636.fsf@yamatai> <CAO+9K5rF6hte3U=cga27p9K7uou8B_=csjXZb0QHc_DjxyOhsg@HIDDEN> <8735v0b53e.fsf@yamatai> <87v97t8qrc.fsf@HIDDEN> From: Guillaume Le Vaillant <glv@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: bug#48225: Wrong result of package-name->name+version In-reply-to: <87v97t8qrc.fsf@HIDDEN> Date: Sat, 08 May 2021 12:41:09 +0000 Message-ID: <87r1ihieje.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48225 Cc: 48225 <at> debbugs.gnu.org, Leo Prikler <leo.prikler@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s <ludo@HIDDEN> skribis: > Hi Guillaume, > > Guillaume Le Vaillant <glv@HIDDEN> skribis: > >> From 1e37a89b943a818b5274c1d5f31143ca48bad40a Mon Sep 17 00:00:00 2001 >> From: Guillaume Le Vaillant <glv@HIDDEN> >> Date: Thu, 6 May 2021 10:32:56 +0200 >> Subject: [PATCH] build-system: asdf: Work around package-name->name+vers= ion >> bug. >> >> This patch modifies how the name of the main Common Lisp system is extra= cted >> from the full Guix package name to work around bug#48225 concerning the >> 'package-name->name+version' function. >> >> Fixes <https://issues.guix.gnu.org/41437>. >> >> * guix/build-system/asdf.scm (asdf-build): Fix 'systems' function. >> * guix/build/asdf-build-system.scm (main-system-name): Fix it. > > If it works for you, sounds good to me. Please do rebuild as many CL > packages, with different CL implementations, to make sure we do not > overlook any corner case. > >> + (let* ((lisp-prefix (string-append lisp-type "-")) >> + (package-name (hyphen-separated-name->name+version >> + (if (string-prefix? lisp-prefix name) >> + (string-drop name >> + (string-length lisp-pr= efix)) >> + name)))) >> + `(quote ,(list package-name))) > > I=E2=80=99d like to see a FIXME in there: this is all guesswork and we sh= ould > eventually replace guesses with known-good info. > > What would it take to pass the right package name and implementation > name upfront from the package? > > Thanks, > Ludo=E2=80=99. I tried rebuilding all the sbcl-*, cl-* and ecl-* packages, as well as stumpwm, uglify-js and nyxt, and I didn't see new failures. I pushed the patch as 2fa8fd4af59af0de392352915fa50fc21a4cf98a. When 'package-name->name+version' returns a bad result leading to an incorrect default Lisp system name being computed, it can be overridden using the '#:asd-systems' parameter of 'asdf-build-system', which should work around the problem in almost all cases. However I suppose other build systems could have issues if they make use of 'package-name->name+version' on a package with a name like "abc-123-def-1.2.3" (depending how they use the result). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYJaG5Q8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j9xigD/U6jKF9r1pA36vLz2ylC/jR55bxg/UjOys3lz MipayOQBAJRyhM74/cziP6bpAzuhap7LEB+tCWrL9qXbp0yZSXGv =DUq0 -----END PGP SIGNATURE----- --=-=-=--
bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.Received: (at 48225) by debbugs.gnu.org; 8 May 2021 10:27:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 08 06:27:30 2021 Received: from localhost ([127.0.0.1]:49367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lfKBF-0003B7-Nh for submit <at> debbugs.gnu.org; Sat, 08 May 2021 06:27:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1lfKBD-0003Az-Qc for 48225 <at> debbugs.gnu.org; Sat, 08 May 2021 06:27:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56660) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1lfKB7-00072M-Ai; Sat, 08 May 2021 06:27:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60478 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1lfKB6-00031A-CE; Sat, 08 May 2021 06:27:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Guillaume Le Vaillant <glv@HIDDEN> Subject: Re: bug#48225: Wrong result of package-name->name+version References: <87o8dqy636.fsf@yamatai> <CAO+9K5rF6hte3U=cga27p9K7uou8B_=csjXZb0QHc_DjxyOhsg@HIDDEN> <8735v0b53e.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 08 May 2021 12:27:19 +0200 In-Reply-To: <8735v0b53e.fsf@yamatai> (Guillaume Le Vaillant's message of "Thu, 06 May 2021 09:10:13 +0000") Message-ID: <87v97t8qrc.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48225 Cc: 48225 <at> debbugs.gnu.org, Leo Prikler <leo.prikler@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Guillaume, Guillaume Le Vaillant <glv@HIDDEN> skribis: > From 1e37a89b943a818b5274c1d5f31143ca48bad40a Mon Sep 17 00:00:00 2001 > From: Guillaume Le Vaillant <glv@HIDDEN> > Date: Thu, 6 May 2021 10:32:56 +0200 > Subject: [PATCH] build-system: asdf: Work around package-name->name+versi= on > bug. > > This patch modifies how the name of the main Common Lisp system is extrac= ted > from the full Guix package name to work around bug#48225 concerning the > 'package-name->name+version' function. > > Fixes <https://issues.guix.gnu.org/41437>. > > * guix/build-system/asdf.scm (asdf-build): Fix 'systems' function. > * guix/build/asdf-build-system.scm (main-system-name): Fix it. If it works for you, sounds good to me. Please do rebuild as many CL packages, with different CL implementations, to make sure we do not overlook any corner case. > + (let* ((lisp-prefix (string-append lisp-type "-")) > + (package-name (hyphen-separated-name->name+version > + (if (string-prefix? lisp-prefix name) > + (string-drop name > + (string-length lisp-pre= fix)) > + name)))) > + `(quote ,(list package-name))) I=E2=80=99d like to see a FIXME in there: this is all guesswork and we shou= ld eventually replace guesses with known-good info. What would it take to pass the right package name and implementation name upfront from the package? Thanks, Ludo=E2=80=99.
bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.
Received: (at 48225) by debbugs.gnu.org; 6 May 2021 09:10:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 06 05:10:34 2021
Received: from localhost ([127.0.0.1]:37092 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lea1h-0005Hh-Mv
for submit <at> debbugs.gnu.org; Thu, 06 May 2021 05:10:34 -0400
Received: from mout02.posteo.de ([185.67.36.66]:47021)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <glv@HIDDEN>) id 1lea1d-0005Ha-Ey
for 48225 <at> debbugs.gnu.org; Thu, 06 May 2021 05:10:32 -0400
Received: from submission (posteo.de [89.146.220.130])
by mout02.posteo.de (Postfix) with ESMTPS id D89C6240107
for <48225 <at> debbugs.gnu.org>; Thu, 6 May 2021 11:10:23 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1620292223; bh=8gYOlMXTYT8p3vmqXXyQ14CkA886vUbayoLdIXx8VmA=;
h=From:To:Cc:Subject:Date:From;
b=BU8hAfpP3BeFS+KHwmbT/SQYPiLQ9VUBK9AKZAKi21fUeyERM6tFEi420h4ls6GQP
8Qwbxjk/u1gRxnlSCDfReRch7ggykt80ef/NSArxpHzesGyjwrXEkQXccd4Dbvq4iX
g3XhdKg7NqOmXMmTMLIqVsONF9WwwxxGfZBNXF27vwxEw3xIoONo59lLesH3qTnTYV
ZCpCl5uJPdD4qh8tlbKVQuh9DXQiU7bvJJGn3ecUt6Unyj6xcIujns4iz7vud8rXiK
0yDS+xfzrsWsHmJB3/DAfhDI+RLSE68ooVxxEkWCHtEdCxw4PTJkt8pFVI/o3g1f1R
4zm3jZ7VAPAww==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4FbSTk0yzRz6tmF;
Thu, 6 May 2021 11:10:17 +0200 (CEST)
References: <87o8dqy636.fsf@yamatai>
<CAO+9K5rF6hte3U=cga27p9K7uou8B_=csjXZb0QHc_DjxyOhsg@HIDDEN>
From: Guillaume Le Vaillant <glv@HIDDEN>
To: Sharlatan Hellseher <sharlatanus@HIDDEN>
Subject: Re: bug#48225: Wrong result of package-name->name+version
In-reply-to: <CAO+9K5rF6hte3U=cga27p9K7uou8B_=csjXZb0QHc_DjxyOhsg@HIDDEN>
Date: Thu, 06 May 2021 09:10:13 +0000
Message-ID: <8735v0b53e.fsf@yamatai>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48225
Cc: 48225 <at> debbugs.gnu.org, Leo Prikler <leo.prikler@HIDDEN>,
Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Ludovic Court=C3=A8s <ludo@HIDDEN> skribis:
> [...]
> A better fix would be to not guess and instead pass #:name and #:version
> to all the build phases, with the value taken from the <package> object.
> (That=E2=80=99s a world-rebuild fix though.)
>
> WDYT?
>
>> This is related to issue #48208, and also probably to issue #41437.
>
> Perhaps we can find a workaround for these?
Sharlatan Hellseher <sharlatanus@HIDDEN> skribis:
> If chaining `package-name->name+version` function may affect a large
> layer of infrastructure here is could a quick adhoc workaround:
>
> sbcl-3d-vectors -> sbcl-cl3d-vectors
> sbcl-3d-vectors -> sbcl-three-d-vectors
> sbcl-3d-vectors -> sbcl-iiid-vectors
>
> Or use any predictable common prefix which could be use and replaced
> after the function is reviewed.
I agree that having '#:name' and '#:version' available in the build
phases would be ideal.
Meanwhile I found a workaround for the asdf-build-system that fixes
bug#41437 and allows building the 'sbcl-3d-vectors' and
'sbcl-3d-matrices' packages of bug#48208 without having to mangle the
package names. It rebuilds all the Common Lisp packages, but that
doesn't take too much time.
WDYT?
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-build-system-asdf-Work-around-package-name-name-vers.patch
Content-Transfer-Encoding: quoted-printable
From=201e37a89b943a818b5274c1d5f31143ca48bad40a Mon Sep 17 00:00:00 2001
From: Guillaume Le Vaillant <glv@HIDDEN>
Date: Thu, 6 May 2021 10:32:56 +0200
Subject: [PATCH] build-system: asdf: Work around package-name->name+version
bug.
This patch modifies how the name of the main Common Lisp system is extracted
from the full Guix package name to work around bug#48225 concerning the
'package-name->name+version' function.
Fixes <https://issues.guix.gnu.org/41437>.
* guix/build-system/asdf.scm (asdf-build): Fix 'systems' function.
* guix/build/asdf-build-system.scm (main-system-name): Fix it.
=2D--
guix/build-system/asdf.scm | 15 +++++++--------
guix/build/asdf-build-system.scm | 12 ++++++------
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/guix/build-system/asdf.scm b/guix/build-system/asdf.scm
index 28403a1960..8f9d63337f 100644
=2D-- a/guix/build-system/asdf.scm
+++ b/guix/build-system/asdf.scm
@@ -291,16 +291,15 @@ set up using CL source package conventions."
(imported-modules %asdf-build-system-modules)
(modules %asdf-build-modules))
=20
=2D ;; FIXME: The definition of 'systems' is pretty hacky.
=2D ;; Is there a more elegant way to do it?
(define systems
(if (null? (cadr asd-systems))
=2D `(quote
=2D ,(list
=2D (string-drop
=2D ;; NAME is the value returned from `package-full-name'.
=2D (hyphen-separated-name->name+version name)
=2D (1+ (string-length lisp-type))))) ; drop the "<lisp>-" pr=
efix.
+ (let* ((lisp-prefix (string-append lisp-type "-"))
+ (package-name (hyphen-separated-name->name+version
+ (if (string-prefix? lisp-prefix name)
+ (string-drop name
+ (string-length lisp-prefi=
x))
+ name))))
+ `(quote ,(list package-name)))
asd-systems))
=20
(define builder
diff --git a/guix/build/asdf-build-system.scm b/guix/build/asdf-build-syste=
m.scm
index 6ad855cab2..5a4fc44aef 100644
=2D-- a/guix/build/asdf-build-system.scm
+++ b/guix/build/asdf-build-system.scm
@@ -52,12 +52,12 @@
(string-append %source-install-prefix "/systems"))
=20
(define (main-system-name output)
=2D (let ((package-name (package-name->name+version
=2D (strip-store-file-name output)))
=2D (lisp-prefix (string-append (%lisp-type) "-")))
=2D (if (string-prefix? lisp-prefix package-name)
=2D (string-drop package-name (string-length lisp-prefix))
=2D package-name)))
+ (let* ((full-name (strip-store-file-name output))
+ (lisp-prefix (string-append (%lisp-type) "-"))
+ (package-name (if (string-prefix? lisp-prefix full-name)
+ (string-drop full-name (string-length lisp-pref=
ix))
+ full-name)))
+ (package-name->name+version package-name)))
=20
(define (lisp-source-directory output name)
(string-append output (%lisp-source-install-prefix) "/" name))
=2D-=20
2.31.1
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYJOydQ8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j82kgD/eEaXWTxKV/UFOUDeOPSe0b46+I0jAIyDAu5x
0aRyvxgBAJZHbQ4n9rEnP3BeGJi1H0/V0uNF+ipQ/q9QfKLnjoJ/
=LsaU
-----END PGP SIGNATURE-----
--==-=-=--
bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.Received: (at 48225) by debbugs.gnu.org; 5 May 2021 21:27:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 05 17:27:40 2021 Received: from localhost ([127.0.0.1]:34592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1leP3U-0004lq-HG for submit <at> debbugs.gnu.org; Wed, 05 May 2021 17:27:40 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:43719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sharlatanus@HIDDEN>) id 1leP3S-0004lh-Qf for 48225 <at> debbugs.gnu.org; Wed, 05 May 2021 17:27:39 -0400 Received: by mail-wr1-f42.google.com with SMTP id s8so3354307wrw.10 for <48225 <at> debbugs.gnu.org>; Wed, 05 May 2021 14:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=AuLdoNzLP6U+6A2VoCkscKVfPApHI9KJL2BIR72B9zE=; b=FOZd+4p0jyTuvMJkszWDSD71M3E/JM/DUci96ltIazEzZmEutHoUZqwgwE4Oxjkxq+ OsySUbCKo3gi3K7tDHtKIRvZtqjXhGesGJYxf9rnqbzxZedMDBe851MCiNteJFzE+GLh 855vMJE1cgoGCTvRNSKonDtgIJmFMq+r8SzwunRth4vLJoIWDyp0RmTnxgYPbyyTQTtr 0VVpNugOmOBBs8xHHCZE7/q8/KY28VOdbjpVbK1C3SfCEysrybpK23kWuPLQYpCC4CYy AnZqGMIDNdX/7Z864cWLd8oYtS7hUH6KZ+iKp5vwglR1fdivkF21lyk9T2RKrtdWXEYA K6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=AuLdoNzLP6U+6A2VoCkscKVfPApHI9KJL2BIR72B9zE=; b=ZFgsJSUQnSNcvLuDE67MceX3/a3PeaIJQTGrlsP/tNojrk4QloWzgLpr1sudR2v4gL kVwh7gZ/JUhgxLNJZgSpHBiWlxHqkC7s90jOX4qqHhEFpjhjB1JrDnUw1YjjssH7Zegr BcYqPqlZnnk4kNVxwrjCu4xAkPAdlG9ef1Dg7FFwgSJZDmblfD2xr3y+aoLFKmRhlZLC wb/8bVPA59JY2MpQ6gC20Lv+oTTMX0w3oBQxk6kXdVPEfBJ1mzyVfqy60CK068D1eG4U 6IiSGz/cxlqPDb6UXJBs2NsyX022kjNSbUgD/Vr/fnnQl+5kIiPO+Fsbj10SwMQwhdKt ewpw== X-Gm-Message-State: AOAM5335J9qaBkfs9x8fxij9MwbWy+z4GZWSRT6+9Yx4UYl4v5C+LtUy RTDXtVqPbvHQDDJZeNNwlABCrWo9v1zdMQy/MTonGTyW0So= X-Google-Smtp-Source: ABdhPJyWPbKFuEAzqofNC1c1+Xsjy+hFvLkAA9GgK9cwoiCopj5tCkLGk8z0wT88PWq4gpPpLBAiGZSP/IjLcdGX91g= X-Received: by 2002:adf:f683:: with SMTP id v3mr1092366wrp.133.1620250052841; Wed, 05 May 2021 14:27:32 -0700 (PDT) MIME-Version: 1.0 From: Sharlatan Hellseher <sharlatanus@HIDDEN> Date: Wed, 5 May 2021 21:27:22 +0000 Message-ID: <CAO+9K5rF6hte3U=cga27p9K7uou8B_=csjXZb0QHc_DjxyOhsg@HIDDEN> Subject: Simple workaround To: 48225 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48225 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) SGksDQoNCklmIGNoYWluaW5nICBgcGFja2FnZS1uYW1lLT5uYW1lK3ZlcnNpb25gIGZ1bmN0aW9u ICBtYXkgYWZmZWN0IGEgbGFyZ2UNCmxheWVyIG9mIGluZnJhc3RydWN0dXJlIGhlcmUgaXMgY291 bGQgYSBxdWljayBhZGhvYyB3b3JrYXJvdW5kOg0KDQpzYmNsLTNkLXZlY3RvcnMgLT4gc2JjbC1j bDNkLXZlY3RvcnMNCnNiY2wtM2QtdmVjdG9ycyAtPiBzYmNsLXRocmVlLWQtdmVjdG9ycw0Kc2Jj bC0zZC12ZWN0b3JzIC0+IHNiY2wtaWlpZC12ZWN0b3JzDQoNCk9yIHVzZSBhbnkgcHJlZGljdGFi bGUgY29tbW9uIHByZWZpeCB3aGljaCBjb3VsZCBiZSB1c2UgYW5kIHJlcGxhY2VkDQphZnRlciB0 aGUgZnVuY3Rpb24gaXMgcmV2aWV3ZWQuDQotLSANCuKApiDQvdCw0Ygg0YDQsNC30YPQvCAtINC/ 0YDQtdCy0L7RgdGF0L7QtNC90LDRjyDQvtCx0YrRj9GB0L3QuNGC0LXQu9GM0L3QsNGPINC80LDR iNC40L3QsCDQutC+0YLQvtGA0LDRjyDRgdC/0L7RgdC+0LHQvdCwDQrQvdCw0LnRgtC4INGB0LzR i9GB0Lsg0L/QvtGH0YLQuCDQsiDRh9C10Lwg0YPQs9C+0LTQvdC+LCDQuNGB0YLQvtC70LrQvtCy 0LDRgtGMINC70Y7QsdC+0Lkg0YTQtdC90L7QvNC10L0sINC90L4NCtGB0L7QstC10YDRiNC10L3Q vdC+INC90LUg0LIg0YHQvtGB0YLQvtGP0L3QuNC4INC/0YDQuNC90Y/RgtGMINC80YvRgdC70Ywg 0L4g0L3QtdC/0YDQtdC00YHQutCw0LfRg9C10LzQvtGB0YLQuC4NCg==
bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.Received: (at 48225) by debbugs.gnu.org; 4 May 2021 20:08:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 04 16:08:28 2021 Received: from localhost ([127.0.0.1]:55159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1le1LI-0007qT-J2 for submit <at> debbugs.gnu.org; Tue, 04 May 2021 16:08:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1le1LG-0007qM-9P for 48225 <at> debbugs.gnu.org; Tue, 04 May 2021 16:08:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59355) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1le1LB-0005x9-0x; Tue, 04 May 2021 16:08:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60592 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1le1L8-00079U-Ml; Tue, 04 May 2021 16:08:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Guillaume Le Vaillant <glv@HIDDEN> Subject: Re: bug#48225: Wrong result of package-name->name+version References: <87o8dqy636.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 =?utf-8?Q?Flor=C3=A9al?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 04 May 2021 22:08:17 +0200 In-Reply-To: <87o8dqy636.fsf@yamatai> (Guillaume Le Vaillant's message of "Tue, 04 May 2021 13:35:41 +0000") Message-ID: <87pmy6l0su.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48225 Cc: 48225 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Guillaume, Guillaume Le Vaillant <glv@HIDDEN> skribis: > The 'package-name->name+version' function defined in > "guix/build/utils.scm" returns a wrong result if there is a '-' > followed by a number in the package name: > > (use-modules ((guix build utils))) > (package-name->name+version "sbcl-3d-vectors-3.1.0-1.29bb968") > > $1 =3D "sbcl" > $2 =3D "3d-vectors-3.1.0-1.29bb968" > > > It should be: > > $1 =3D "sbcl-3d-vectors" > $2 =3D "3.1.0-1.29bb968" > > Can someone think of an elegant modification for > 'package-name->name+version' so that it finds where the version is > even if there are several hyphens before of after it (as in > "sbcl-3d-vectors-3.1.0-1.29bb968" or "nyxt-2-pre-release-6")? It=E2=80=99s implements a heuristic meant to work for most packages. It=E2= =80=99s hard to tweak that without breaking something else instead. (Plus, =E2=80=9Cnyxt-2-pre-release-6=E2=80=9D looks really bogus to me.) A better fix would be to not guess and instead pass #:name and #:version to all the build phases, with the value taken from the <package> object. (That=E2=80=99s a world-rebuild fix though.) WDYT? > This is related to issue #48208, and also probably to issue #41437. Perhaps we can find a workaround for these? Thanks, Ludo=E2=80=99.
bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.Received: (at 48225) by debbugs.gnu.org; 4 May 2021 19:39:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 04 15:39:32 2021 Received: from localhost ([127.0.0.1]:55005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1le0tH-0007YQ-QB for submit <at> debbugs.gnu.org; Tue, 04 May 2021 15:39:31 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:22834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <leo.prikler@HIDDEN>) id 1le0tE-0007YK-Ob for 48225 <at> debbugs.gnu.org; Tue, 04 May 2021 15:39:30 -0400 Received: from nijino.local (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FZVXX5Nncz3wGC; Tue, 4 May 2021 21:39:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1620157164; bh=R37ACKQmbfaOLeL+x4/z6BA/SR0782oCxSCRPwfRrpw=; h=Subject:From:To:Date:In-Reply-To:References; b=Mi5vLS9022hcPpw+kD/NdGARLXblqvPZ0/7kolBkLPpZu1sobWMy11TbtDvd6kWjH EYhPgJ/QaqYKZOih3X+QQC2jyGeIAy83oxK3t7BFceg7K/dn8Z6DuIp2RTLHd011Xr gY4L5y6YdJlJpAqjv7oWTcbl7he3BWe7h0ceRDEc= Message-ID: <240d6f2933bcf78ef7d08eb2003d562b10cca2bc.camel@HIDDEN> Subject: Re: Wrong result of package-name->name+version From: Leo Prikler <leo.prikler@HIDDEN> To: Guillaume Le Vaillant <glv@HIDDEN>, 48225 <at> debbugs.gnu.org Date: Tue, 04 May 2021 21:39:24 +0200 In-Reply-To: <87o8dqy636.fsf@yamatai> References: <87o8dqy636.fsf@yamatai> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48225 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Am Dienstag, den 04.05.2021, 13:35 +0000 schrieb Guillaume Le Vaillant: > Hi, > > The 'package-name->name+version' function defined in > "guix/build/utils.scm" returns a wrong result if there is a '-' > followed by a number in the package name: > > --8<---------------cut here---------------start------------->8--- > (use-modules ((guix build utils))) > (package-name->name+version "sbcl-3d-vectors-3.1.0-1.29bb968") > > $1 = "sbcl" > $2 = "3d-vectors-3.1.0-1.29bb968" > --8<---------------cut here---------------end--------------->8--- > > It should be: > > --8<---------------cut here---------------start------------->8--- > $1 = "sbcl-3d-vectors" > $2 = "3.1.0-1.29bb968" > --8<---------------cut here---------------end--------------->8--- > > Can someone think of an elegant modification for > 'package-name->name+version' so that it finds where the version is > even if there are several hyphens before of after it (as in > "sbcl-3d-vectors-3.1.0-1.29bb968" or "nyxt-2-pre-release-6")? > > This is related to issue #48208, and also probably to issue #41437. I don't think there's any way to cleverly match this. For all we know, 3d could be a version, we have 2019c, 2021a, 1a, 9d, 9100h and 063a already. Perhaps we should forward name and version as keyword arguments, so that we don't have to reconstruct them, or alternatively use a different delimiter (e.g. @) I'm honestly surprised, that many other stuff "works fine" despite the fact, that they'd probably also suffer from this bug. Can anyone tell me why emacs-2048-game builds?
bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 4 May 2021 13:35:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 04 09:35:56 2021 Received: from localhost ([127.0.0.1]:53268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ldvDQ-0007py-Ea for submit <at> debbugs.gnu.org; Tue, 04 May 2021 09:35:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:37176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <glv@HIDDEN>) id 1ldvDM-0007ps-3L for submit <at> debbugs.gnu.org; Tue, 04 May 2021 09:35:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <glv@HIDDEN>) id 1ldvDL-0000nX-Pe for bug-guix@HIDDEN; Tue, 04 May 2021 09:35:51 -0400 Received: from mout02.posteo.de ([185.67.36.66]:52135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <glv@HIDDEN>) id 1ldvDI-0003qg-7h for bug-guix@HIDDEN; Tue, 04 May 2021 09:35:51 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 30A642400FD for <bug-guix@HIDDEN>; Tue, 4 May 2021 15:35:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1620135344; bh=ks2BNSVIJNGVmM4F9psH1Xy0tVCh4hiduQ8dkS2dotM=; h=From:To:Subject:Date:From; b=L28aSxNDns6kBRTFvPsieGFl4RdKItOBZWnf8ViFeC2dU4qNbA5dU4VTI6z7tA8p4 GlxT39Ttr5mtpP18emvnTIG/RegW/gdwQlipE1rCmsnm9f2Q9HsXkzn166vkzEQlNW vTa7N4W+6ihGdLJ63OQIBVaCL9wfbPWVmHv5nLXeDxRyLNw6RBBnFI8qszxx9/hJV5 NttK7ewmFbYOuhrf7B8MgqGtlJn/PCiDsb+TAdxZaaSJ16qFQlupuXATYMdZ7GrPw1 x4Nux9S71UiNvH+XY10+iXp7vxV69pn+pLZIgaZdwgfUynaZJnYwQuXZgOAkqCwug0 2xE+HGx2W89ag== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FZLSv0pkRz6tm5 for <bug-guix@HIDDEN>; Tue, 4 May 2021 15:35:42 +0200 (CEST) From: Guillaume Le Vaillant <glv@HIDDEN> To: bug-guix@HIDDEN Subject: Wrong result of package-name->name+version Date: Tue, 04 May 2021 13:35:41 +0000 Message-ID: <87o8dqy636.fsf@yamatai> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=glv@HIDDEN; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) Hi, The 'package-name->name+version' function defined in "guix/build/utils.scm" returns a wrong result if there is a '-' followed by a number in the package name: --8<---------------cut here---------------start------------->8--- (use-modules ((guix build utils))) (package-name->name+version "sbcl-3d-vectors-3.1.0-1.29bb968") $1 = "sbcl" $2 = "3d-vectors-3.1.0-1.29bb968" --8<---------------cut here---------------end--------------->8--- It should be: --8<---------------cut here---------------start------------->8--- $1 = "sbcl-3d-vectors" $2 = "3.1.0-1.29bb968" --8<---------------cut here---------------end--------------->8--- Can someone think of an elegant modification for 'package-name->name+version' so that it finds where the version is even if there are several hyphens before of after it (as in "sbcl-3d-vectors-3.1.0-1.29bb968" or "nyxt-2-pre-release-6")? This is related to issue #48208, and also probably to issue #41437.
Guillaume Le Vaillant <glv@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#48225; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.