GNU bug report logs -
#48230
[PATCH] tests: go: Rename and fix duplicate test.
Previous Next
Reported by: Tobias Geerinckx-Rice <me <at> tobias.gr>
Date: Tue, 4 May 2021 20:56:02 UTC
Severity: normal
Tags: patch
Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48230 in the body.
You can then email your comments to 48230 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#48230
; Package
guix-patches
.
(Tue, 04 May 2021 20:56:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Tobias Geerinckx-Rice <me <at> tobias.gr>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 04 May 2021 20:56:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* tests/go.scm: Rename "go-version omited 'v' character" to
"go-version without 'v' prefix" and change the code to match.
---
Hi all,
Found on a typo hunt.
This is my best-effort guess at what was intended. Maybe I'm mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead? Let me know!
Kind regards,
T G-R
tests/go.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/go.scm b/tests/go.scm
index c33a834f69..565a0d451d 100644
--- a/tests/go.scm
+++ b/tests/go.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright � 2021 Fran�ois Joulaud <francois.joulaud <at> radiofrance.com>
+;;; Copyright � 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
"v1.0.2"
(go-version->git-ref "v1.0.2"))
-(test-equal "go-version omited 'v' character"
- "v1.0.2"
- (go-version->git-ref "v1.0.2"))
+(test-equal "go-version without 'v' prefix"
+ "1.0.2"
+ (go-version->git-ref "1.0.2"))
(test-equal "go-version with embedded git-ref"
"65e3620a7ae7"
--
2.31.1
Reply sent
to
Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
:
You have taken responsibility.
(Wed, 05 May 2021 05:05:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Tobias Geerinckx-Rice <me <at> tobias.gr>
:
bug acknowledged by developer.
(Wed, 05 May 2021 05:05:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 48230-done <at> debbugs.gnu.org (full text, mbox):
Hi Tobias!
Tobias Geerinckx-Rice <me <at> tobias.gr> writes:
> * tests/go.scm: Rename "go-version omited 'v' character" to
> "go-version without 'v' prefix" and change the code to match.
> ---
>
> Hi all,
>
> Found on a typo hunt.
Eh, thank you!
> This is my best-effort guess at what was intended. Maybe I'm
> mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to
> "v1.0.2" instead? Let me know!
I wasn't sure anymore, so I looked at the code; go-version->git-ref is a
no-op (leaves the version string intact) unless it matches
%go-pseudo-version-rx.
> tests/go.scm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/go.scm b/tests/go.scm
> index c33a834f69..565a0d451d 100644
> --- a/tests/go.scm
> +++ b/tests/go.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright 2021 Franois Joulaud <francois.joulaud <at> radiofrance.com>
> +;;; Copyright 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
> "v1.0.2"
> (go-version->git-ref "v1.0.2"))
>
> -(test-equal "go-version omited 'v' character"
> - "v1.0.2"
> - (go-version->git-ref "v1.0.2"))
> +(test-equal "go-version without 'v' prefix"
> + "1.0.2"
> + (go-version->git-ref "1.0.2"))
That test doesn't have much value based on my above analysis. I suggest
we drop it; it's testing the same thing as the "v1.0.2" case.
I've removed it and pushed with commit 2354d79b88.
Thank you!
Maxim
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 02 Jun 2021 11:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 325 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.