GNU bug report logs - #48280
28.0.50; Fix moving directories with the same name to trash

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48280 in the body.
You can then email your comments to 48280 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Codruț Constantin Gușoi <mail <at> codrut.pro>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Fix moving directories with the same name to trash
Date: Fri, 07 May 2021 19:31:23 +0000

[Message part 1 (text/plain, inline)]

Hello,

I've attached a patch for this bug I was dealing with while trying out
28.0.50 commit a2842a11728336fc8110eedb5176ecfbe71bbc79.

Refs: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47135
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47135>

To reproduce, save this to a `bug.el` file:

```elisp

(setq delete-by-moving-to-trash t)

(let ((test-dir "~/test123"))
   (progn
     (message "Creating directory: 1")
     (make-directory test-dir)
     (message "Deleting directory: 1")
     (delete-directory test-dir t t)

     (message "Creating directory: 2")
     (make-directory test-dir)
     (message "Deleting directory: 2")
     (delete-directory test-dir t t)

     (message "Success!")))
```

And execute with: `emacs -nw -Q -l ./bug.el`.

Expected: "Success!"
Actual: "Renaming: Not a directory, /home/me/test123,
/home/me/.local/share/Trash/files/test123Wiibmk"

Please let me know what you think, looking forward to getting this fixed.

Cheers,
Codruț

www.codrut.pro

[0001-Fix-moving-directories-with-the-same-name-to-trash.patch (text/x-patch, attachment)]

Message #8 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Codruț Constantin Gușoi <mail <at> codrut.pro>
Cc: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50; Fix moving directories with the same name
 to trash
Date: Sat, 08 May 2021 13:40:25 +0200

Codruț Constantin Gușoi <mail <at> codrut.pro> writes:

> I've attached a patch for this bug I was dealing with while trying out
> 28.0.50 commit a2842a11728336fc8110eedb5176ecfbe71bbc79.

Thanks; applied to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Codruț Constantin Gușoi <mail <at> codrut.pro>
Cc: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50; Fix moving directories with the same name
 to trash
Date: Sat, 08 May 2021 13:44:13 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thanks; applied to Emacs 28.

This problem is also talked about in bug#47960, and I think the patch
there is more correct, so I've reverted your patch for now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Codruț Constantin Gușoi <mail <at> codrut.pro>
To: larsi <at> gnus.org
Cc: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50;
 Fix moving directories with the same name to trash
Date: Sat, 08 May 2021 11:53:07 +0000

[Message part 1 (text/plain, inline)]

Hello Lars,

Yes, I'm willing to sing the documents but I'll required alot of hand holding throughout the process. Please be patient with me, let's discuss this outside of the bug report mailing list.

Cheers,
Codruț

www.codrut.pro
-------- Original Message --------
On 8 May 2021, 12:40, Lars Ingebrigtsen wrote:

> Codruț Constantin Gușoi <mail <at> codrut.pro> writes:
>
>> I've attached a patch for this bug I was dealing with while trying out
>> 28.0.50 commit a2842a11728336fc8110eedb5176ecfbe71bbc79.
>
> Thanks; applied to Emacs 28.
>
> This change was small enough to apply without assigning copyright to the
> FSF, but for future patches you want to submit, it might make sense to
> get the paperwork started now, so that subsequent patches can be applied
> speedily. Would you be willing to sign such paperwork?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no

[Message part 2 (text/html, inline)]

Message #27 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50; Fix moving directories with the same name
 to trash
Date: Sat, 08 May 2021 14:03:42 +0200

Codruț Constantin Gușoi <mail <at> codrut.pro> writes:

> Yes, I'm willing to sing the documents but I'll required alot of hand holding
> throughout the process. Please be patient with me, let's discuss this outside of the
> bug report mailing list.

(Form sent off-list.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #30 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Codruț Constantin Gușoi <mail <at> codrut.pro>
To: larsi <at> gnus.org
Cc: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50;
 Fix moving directories with the same name to trash
Date: Wed, 19 May 2021 10:29:55 +0000

[Message part 1 (text/plain, inline)]

Hello again,

Looks like this issue is still present, my patch has been reverted and https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47960#19 was not applied.

Honestly I don't really care which ones gets done as long as we have a fix merged in. Is there anything I can do to get this moving?

Cheers,
Codruț

www.codrut.pro

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, May 8th, 2021 at 12:53 PM, Codruț Constantin Gușoi <mail <at> codrut.pro> wrote:

> Hello Lars,
>
> Yes, I'm willing to sing the documents but I'll required alot of hand holding throughout the process. Please be patient with me, let's discuss this outside of the bug report mailing list.
>
> Cheers,
> Codruț
>
> www.codrut.pro
> -------- Original Message --------
> On 8 May 2021, 12:40, Lars Ingebrigtsen < larsi <at> gnus.org> wrote:
>
>> Codruț Constantin Gușoi <mail <at> codrut.pro> writes:
>>
>>> I've attached a patch for this bug I was dealing with while trying out
>>> 28.0.50 commit a2842a11728336fc8110eedb5176ecfbe71bbc79.
>>
>> Thanks; applied to Emacs 28.
>>
>> This change was small enough to apply without assigning copyright to the
>> FSF, but for future patches you want to submit, it might make sense to
>> get the paperwork started now, so that subsequent patches can be applied
>> speedily. Would you be willing to sign such paperwork?
>>
>> --
>> (domestic pets only, the antidote for overdose, milk.)
>> bloggy blog: http://lars.ingebrigtsen.no

[Message part 2 (text/html, inline)]

Message #33 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Codruț Constantin Gușoi <mail <at> codrut.pro>
Cc: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50; Fix moving directories with the same name
 to trash
Date: Tue, 25 May 2021 00:23:15 +0200

Codruț Constantin Gușoi <mail <at> codrut.pro> writes:

> Looks like this issue is still present, my patch has been reverted and
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47960#19 was not applied.
>
> Honestly I don't really care which ones gets done as long as we have a fix merged
> in. Is there anything I can do to get this moving?

We were just waiting for Gregory's paperwork to be completed before
applying his patch.  That's now complete, and I've now applied the fix.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #42 received at 48280 <at> debbugs.gnu.org (full text, mbox):

From: Codruț Constantin Gușoi <mail <at> codrut.pro>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48280 <at> debbugs.gnu.org
Subject: Re: bug#48280: 28.0.50;
 Fix moving directories with the same name to trash
Date: Mon, 24 May 2021 23:11:28 +0000

Awesome, just compiled it and it works perfectly! Thank you for the help.

Cheers,
Codruț

www.codrut.pro

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, May 24th, 2021 at 11:23 PM, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Codruț Constantin Gușoi mail <at> codrut.pro writes:
>
> > Looks like this issue is still present, my patch has been reverted and
> >
> > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47960#19 was not applied.
> >
> > Honestly I don't really care which ones gets done as long as we have a fix merged
> >
> > in. Is there anything I can do to get this moving?
>
> We were just waiting for Gregory's paperwork to be completed before
>
> applying his patch. That's now complete, and I've now applied the fix.
>
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> (domestic pets only, the antidote for overdose, milk.)
>
> bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.