GNU bug report logs - #48284
Dovecot <namespace-configuration> has two ‘location’ fields

Previous Next

To reply to this bug, email your comments to 48284 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: <bug-guix <at> gnu.org>
Subject: Dovecot <namespace-configuration> has two ‘location’ fields
Date: Sat, 08 May 2021 15:02:06 +0200

I just noticed this compiler warning:

--8<---------------cut here---------------start------------->8---
gnu/services/mail.scm:431:0: warning: shadows previous definition of `%namespace-configuration-location-procedure' at gnu/services/mail.scm:431:0
<unknown-location>: warning: shadows previous definition of `namespace-configuration-location' at <unknown-location>
--8<---------------cut here---------------end--------------->8---

I believe this comes from the fact that ‘define-configuration’
automatically introduces a ‘location’ field (for the source code
location of <namespace-configuration> instantiations), which clashes
with this one:

--8<---------------cut here---------------start------------->8---
  (location
   (string "")
   "Physical location of the mailbox. This is in same format as
mail_location, which is also the default for it.")
--8<---------------cut here---------------end--------------->8---

I think this was revealed by the fix in commit
dd0826fbf345dfe7289cf943ed2d29edc51d543f.

Probably the only sane way to address it is by renaming the field above.

Thoughts?

Ludo’.

Message #8 received at 48284 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48284 <at> debbugs.gnu.org
Subject: Re: bug#48284: Dovecot <namespace-configuration> has two
 ‘location’ fields
Date: Tue, 18 May 2021 08:35:47 -0400

Hi Ludo,

Ludovic Courtès <ludo <at> gnu.org> writes:

> I just noticed this compiler warning:
>
> gnu/services/mail.scm:431:0: warning: shadows previous definition of `%namespace-configuration-location-procedure' at gnu/services/mail.scm:431:0
> <unknown-location>: warning: shadows previous definition of `namespace-configuration-location' at <unknown-location>
>
>
> I believe this comes from the fact that ‘define-configuration’
> automatically introduces a ‘location’ field (for the source code
> location of <namespace-configuration> instantiations), which clashes
> with this one:
>
>   (location
>    (string "")
>    "Physical location of the mailbox. This is in same format as
> mail_location, which is also the default for it.")
>
> I think this was revealed by the fix in commit
> dd0826fbf345dfe7289cf943ed2d29edc51d543f.
>
> Probably the only sane way to address it is by renaming the field above.

We could also rename the define-configuration produced %location field
accessor to something more explicit such as $name-source-location
instead of $name-location, no?

I don't think that field is being used much at all, given it was
effectively broken prior to the above commit, so renaming it should go
mostly unnoticed.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.