GNU bug report logs - #48291
[PATCH] - updated lisp library unix-opts.

Previous Next

Package: guix-patches;

Reported by: cage <cage-dev <at> twistfold.it>

Date: Sat, 8 May 2021 17:30:01 UTC

Severity: normal

Tags: patch

Merged with 48292

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48291 in the body.
You can then email your comments to 48291 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#48291; Package guix-patches. (Sat, 08 May 2021 17:30:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to cage <cage-dev <at> twistfold.it>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 08 May 2021 17:30:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: guix-patches <at> gnu.org
Subject: [PATCH] - updated lisp library unix-opts.
Date: Sat, 8 May 2021 19:29:16 +0200
Hi!

I found this library outdated, this patch makes guix uses a commit with
new features added.

Bye!
C.

---
 gnu/packages/lisp-xyz.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 0824fa1d82..275517654f 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -3276,19 +3276,21 @@ settings ensure a very simple mode of operation, similar to that provided by
   (sbcl-package->ecl-package sbcl-cl-json))
 
 (define-public sbcl-unix-opts
+  (let ((commit "0e61f34b2ecf62288437810d4abb31e572048b04")
+        (revision "1"))
   (package
     (name "sbcl-unix-opts")
-    (version "0.1.7")
+    (version (git-version "0.1.7" revision commit))
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/libre-man/unix-opts")
-             (commit version)))
+             (commit commit)))
        (file-name (git-file-name "unix-opts" version))
        (sha256
         (base32
-         "08djdi1ard09fijb7w9bdmhmwd98b1hzmcnjw9fqjiqa0g3b44rr"))))
+         "16mcqpzwrz808p9n3wwl99ckg3hg7yihw08y1i4l7c92aldbkasq"))))
     (build-system asdf-build-system/sbcl)
     (home-page "https://github.com/hankhero/cl-json")
     (synopsis "Unix-style command line options parser")
-- 
2.31.1





Information forwarded to guix-patches <at> gnu.org:
bug#48291; Package guix-patches. (Sat, 08 May 2021 21:29:02 GMT) Full text and rfc822 format available.

Message #8 received at 48291 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: cage <cage-dev <at> twistfold.it>, 48291 <at> debbugs.gnu.org
Subject: Re: [bug#48291] [PATCH] - updated lisp library unix-opts.
Date: Sat, 08 May 2021 23:28:11 +0200
[Message part 1 (text/plain, inline)]
cage schreef op za 08-05-2021 om 19:29 [+0200]:
> Hi!
> 
> I found this library outdated, this patch makes guix uses a commit with
> new features added.

There is a strong preference for only using versions that are ‘official releases’
‘blessed’ by upstream, and not some random commit, unless there are compelling
reasons to do otherwise.

I see the 0.1.7 commit dates from 2017.  If there are new features and/or bug fixes,
maybe ask upstream to make a new release?  If there are important bug fixes and
upstream doesn't feel ready for a new release, we can cherry-pick the bug fixes
via the 'patches' mechanism.

Or maybe we could just use the commit, I dunno. But then a comment should be added
explaining why a particular commit is used instead of an official release.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Merged 48291 48292. Request was from Maxime Devos <maximedevos <at> telenet.be> to control <at> debbugs.gnu.org. (Sat, 08 May 2021 21:30:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#48291; Package guix-patches. (Sun, 09 May 2021 10:11:02 GMT) Full text and rfc822 format available.

Message #13 received at 48291 <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: cage <cage-dev <at> twistfold.it>, 48291 <at> debbugs.gnu.org
Subject: Re: [bug#48291] [PATCH] - updated lisp library unix-opts.
Date: Sun, 9 May 2021 12:10:32 +0200
Hi!

[...]

>
> There is a strong preference for only using versions that are ‘official releases’
> ‘blessed’ by upstream, and not some random commit, unless there are compelling
> reasons to do otherwise.

I  can totally  see the  point here,  i have  sent this  patch because
another program  i have packaged (tinmop)  uses a new version  of this
library and simply crash if called with any command line switch. :(

So i have asked upstream to tag the current commit (or any commit they
choose,  of course)  as new  release,

https://github.com/libre-man/unix-opts/issues/35

so i  suppose we  just have  to wait. :)

Thanks for your reply!
C.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 30 Dec 2021 12:24:14 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 79 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.