GNU bug report logs - #48296
[PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48296 in the body.
You can then email your comments to 48296 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: guix-patches <at> gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>
Subject: [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Sat,  8 May 2021 23:41:24 +0300

* gnu/packages/databases.scm (python-sqlalchemy-stubs): New variable.
---
 gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 2777293200..54cf394d17 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
 ;;; Copyright © 2021 David Larsson <david.larsson <at> selfhosted.xyz>
 ;;; Copyright © 2021 Pjotr Prins <pjotr.guix <at> thebird.nl>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -114,6 +115,7 @@
   #:use-module (gnu packages popt)
   #:use-module (gnu packages protobuf)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-check)
   #:use-module (gnu packages python-crypto)
   #:use-module (gnu packages python-science)
   #:use-module (gnu packages python-web)
@@ -2926,6 +2928,30 @@ simple and Pythonic domain language.")
 (define-public python2-sqlalchemy
   (package-with-python2 python-sqlalchemy))
 
+(define-public python-sqlalchemy-stubs
+  (package
+    (name "python-sqlalchemy-stubs")
+    (version "0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "sqlalchemy-stubs" version))
+       (sha256
+        (base32
+         "1bppjmv7v7m0q8gwg791pgxbx4ay7mna0zq204pn9vw28kfxcrf6"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-mypy" ,python-mypy)
+       ("python-typing-extensions"
+        ,python-typing-extensions)))
+    (home-page
+     "https://github.com/dropbox/sqlalchemy-stubs")
+    (synopsis "SQLAlchemy stubs and mypy plugin")
+    (description "This package contains type stubs and a mypy plugin to
+provide more precise static types and type inference for SQLAlchemy
+framework.")
+    (license license:expat)))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")
-- 
2.31.1

Message #8 received at 48296 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: BonfaceKilz <me <at> bonfacemunyoki.com>, 48296 <at> debbugs.gnu.org
Subject: Re: [bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Sun, 09 May 2021 16:18:34 +0530

[Message part 1 (text/plain, inline)]

Hi Bonface,

> +    (license license:expat)))

Save minor cosmetic changes, this packages LGTM. But, there is some
confusion with the license. The LICENSE file is Apache 2.0, but setup.py
says "MIT License". Could you clarify this with upstream?

Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 48296 <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 48296 <at> debbugs.gnu.org
Subject: Re: [bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Mon, 10 May 2021 12:38:36 +0300

[Message part 1 (text/plain, inline)]

Hi Arun!

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

> Hi Bonface,
>
>> +    (license license:expat)))
>
> Save minor cosmetic changes, this packages LGTM. But, there is some
> confusion with the license. The LICENSE file is Apache 2.0, but setup.py
> says "MIT License". Could you clarify this with upstream?
>
Thanks for catching that. I've just created an
issue here: https://github.com/dropbox/sqlalchemy-stubs/issues/216


-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 48296-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>
Cc: 48296-done <at> debbugs.gnu.org
Subject: Re: [bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Wed, 12 May 2021 16:16:09 +0530

[Message part 1 (text/plain, inline)]

> Thanks for catching that. I've just created an
> issue here: https://github.com/dropbox/sqlalchemy-stubs/issues/216

Thanks for reporting the bug. I changed the license in your package
description, made a few cosmetic changes and pushed to master.

Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 48296-done <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 48296-done <at> debbugs.gnu.org
Subject: Re: [bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Wed, 12 May 2021 16:47:49 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

>> Thanks for catching that. I've just created an
>> issue here: https://github.com/dropbox/sqlalchemy-stubs/issues/216
>
> Thanks for reporting the bug. I changed the license in your package
> description, made a few cosmetic changes and pushed to master.
>
> Thanks!
>
Thanks for taking the time to work on this. FWIW,
upstream updated the setup.py too.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 48296-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>
Cc: 48296-done <at> debbugs.gnu.org
Subject: Re: [bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Sat, 15 May 2021 13:18:43 +0530

[Message part 1 (text/plain, inline)]

> Thanks for taking the time to work on this. FWIW,
> upstream updated the setup.py too.

That's great, thank you! Next time we update this package, we will have
the fixed setup.py too.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 48296-done <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 48296-done <at> debbugs.gnu.org
Subject: Re: [bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.
Date: Mon, 17 May 2021 10:02:40 +0300

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> anaandika:

>> Thanks for taking the time to work on this. FWIW,
>> upstream updated the setup.py too.
>
> That's great, thank you! Next time we update this package, we will have
> the fixed setup.py too.
>

Yup. This makes sense.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.