GNU bug report logs - #48408
BUGFIX: window-default-font-height: check for nil string

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Boruch Baum <boruch_baum@HIDDEN>; dated Fri, 14 May 2021 01:16:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 19 May 2021 11:29:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 19 07:29:48 2021
Received: from localhost ([127.0.0.1]:58229 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ljKOa-00020E-06
	for submit <at> debbugs.gnu.org; Wed, 19 May 2021 07:29:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47418)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ljKOY-000201-AW
 for 48408 <at> debbugs.gnu.org; Wed, 19 May 2021 07:29:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45192)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1ljKOS-00013F-Tj; Wed, 19 May 2021 07:29:40 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1362
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ljKOS-0000TN-6i; Wed, 19 May 2021 07:29:40 -0400
Date: Wed, 19 May 2021 14:29:49 +0300
Message-Id: <83cztnq7v6.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20210519040053.7u7n73smu2hnczap@HIDDEN> (message
 from Boruch Baum on Wed, 19 May 2021 00:00:53 -0400)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN>
 <20210519040053.7u7n73smu2hnczap@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: rudalics@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Wed, 19 May 2021 00:00:53 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: martin rudalics <rudalics@HIDDEN>, 48408 <at> debbugs.gnu.org
> 
> 1) In working on this bug, I noticed that the mode line on the GUI frame
>    was not correctly indicating the frame name. Should I file that as a
>    separate bug? Add it to some other current outstanding bug? Let it
>    stand as part of this report?

GUI frame or TTY frame?  GUI frames by default don't have names, you
need to give them a name if you want.

If all I said above doesn't help, then yes, please report a bug with
all the details.

> 2) Likewise, for more than two years I've intermittently been having a
>    'grave' emacs bug that I never reported on this list because I
>    couldn't ever figure out how to reproduce it. In working on this bug,
>    I seem to have figured out the problem (but not a solution):
> 
>    2.1) Whenever a minibuffer is active in one frame, the other windows
>         on that frame are navigable and operable. However, all elements
>         of all other frames are completely frozen.
> 
>    2.2) This most commonly seems to have been happening to me when
>         composing an email message using mutt, which I have configured
>         to use emacsclient as its editor.
> 
>    2.3) Up until now, my work-around has been to `pkill emacsclient` and
>         restart the client (this doesn't cause any data loss, since all
>         data is on the server).

It's a "feature": Emacs can read input only from one frame at a time.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 19 May 2021 10:39:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 19 06:39:39 2021
Received: from localhost ([127.0.0.1]:58186 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ljJc2-0000ks-Ri
	for submit <at> debbugs.gnu.org; Wed, 19 May 2021 06:39:39 -0400
Received: from mout.gmx.net ([212.227.17.20]:44117)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1ljJbw-0000kb-Rq
 for 48408 <at> debbugs.gnu.org; Wed, 19 May 2021 06:39:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621420766;
 bh=4fBq7WK6JqAGdDZ5gHAc4bSXc0+hc7AEjwLwAOjAB3A=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=X6aVdOE+U0LZ7PNqgkxDFhipHbilaA5jW4Brgp1ZXW6Ui2qi3j2VIvq+cUraWuVbd
 7DnqXG6rZYObF2trtifW7KhYBAST+uCZIOI6rinL4ZuWmepPx3MaEvIDQ5+POucgBy
 lKU059/+K+lW+HqGgCBfKLi8Ews5MPLinZvO5+u0=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1N49hB-1lIx4O42Wv-0102ik; Wed, 19 May 2021 12:39:26 +0200
Date: Wed, 19 May 2021 06:39:23 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Message-ID: <20210519103923.gbraw4ieek3wu3cp@HIDDEN>
References: <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN>
 <20210519040053.7u7n73smu2hnczap@HIDDEN>
 <b5492d66-12fe-6037-651f-d65913a9464e@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b5492d66-12fe-6037-651f-d65913a9464e@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:E/t1X7N3c+hAlLmGr0H41+LTKOcgyAIRoZBKhWExIdg9nIGzH0w
 AikM4BQibFaYbV44aiw7aot1stXaVV9DCJOtTUlytOkvsgLEP59OA56JcMWg+wDdqILre4i
 COqZ4PgRT7hIB3WQ7/pr8Z57Zy60qSUtVnZLA12Nnffd64hQH12w9kz7zva1l7c2tElDIE3
 rlPjzY3RaWIk0V2KJvztQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:jWc58jKoG+U=:P6T9L4Og3bmTvQNnhUBn0u
 hhFXYJztPFZ5hcaIWX3iRqIn6Aj9CJ9Aq1GAcN/xc01Wxd/IHA2EXUremr+ShY7pisdDNHFVe
 38wEf2pEKD8r5/kenBBP+CoJHlmTAt23r/Z2YaVpphG2+FxQUSxWmcPsymOt/EbQqFmQvzXrU
 5e9jiu10Qj3UE2lNZt7xM1RqREWs0RTOohz7gESlpcxBDWpA6CdZ4JXtpmf9VfXfKyo9oix+c
 wpaiUTlAtvTFPAzThnKcdp/QqD6/CKgGLcR9lPMud8Ldp0GsVTkCWU1m/7Qd2id+/s6Y+j8zZ
 t0s4vpINiQ9ZQdAdb3Q4KNNKVItT/UG5KwQUY2MFmgaOdS9FC7BWUFag2s4++CeCp8drlFMqN
 me2ihgpUn/qpDdwbg7k3cMvAmmkOsSmDiCKBopX6k1np18aouGWg4rc7I5GTtbdH6Lt/AY0oJ
 9Wd88Rj5GQNdxaazHTek/BNvWCcuAdmDcieXmBI4l8jvulu+upckHwsJKBJbJzWD45dWd2QMm
 1MD1t5cML0mARpB52EdO05g4/rRCev376yBVfbp61RZ8V2X8H9bd0Uik73Ez43palTDGkcHKT
 Vy0e/zCPbqavUMbIG2LlrxwOIuBKXSW3TmSIDboSKSXWf4mxv93es6PGFsKYQR0sU712wGzXk
 O2DNbGbS3x5E209cTEeiJ1z+Qc2s+AmQD7MC/O6K6BGIN1dJxbCJcqydWiy0ojFG7BzKQlA8H
 jkEmq4MkAr4MmWL0DLJDNc9cmLByK3b/cnQwPwtruc+hJsykgOFMpSxLUInhSDTXwH4ttPSmw
 XqJaijYjhRC2K2EKGc7eeeNFEm0t/RNV2coTIbBANii1W170BO3kHk7Yg8jFkj6CbwPm8NMY8
 zPe0sfy2TdoloUP8naWVPEP0T6miTrsDlnhivrQ2zeI1vtTWhzVanQ3duTt8dORFKJADxQFbE
 4XlwT9W/3jAU8vxLXvs5VmSMs9y8Z82bkcn+I9YNefGG2q6ESTwJP+KOMPsytoAYj/p6f6+11
 PeEpkDhQUZ/4Cf8KR2GlFkWgl1vz3wu/IzDkUJTANgHTDSwLN6PD3XvG221/L4mlhYGbaZ+Ad
 xL8Xi4J5GhKx8ojibaezqUkZG5E2OMQkVYVaB5UKe8PkxpFGG9xN5QIGiBD/xOy04XXVrL5xb
 i25pmF2dQH1e37RipkRupZtkxK/hpm5kYLcA5ZZi5yx9Z58C6cH8SMV14kS00JjEm13p4=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: Eli Zaretskii <eliz@HIDDEN>, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2021-05-19 09:45, martin rudalics wrote:
> > 1) In working on this bug, I noticed that the mode line on the GUI fra=
me
> >     was not correctly indicating the frame name.
>
> What do you use to indicate the frame name in the mode line?

Nothing. It's however the default mode-line is configured. From the
describe-variable page for `mode-line-format':

("%e" mode-line-front-space mode-line-mule-info mode-line-client
mode-line-modified mode-line-remote mode-line-frame-identification
mode-line-buffer-identification " " mode-line-position
 (vc-mode vc-mode) " " mode-line-modes mode-line-misc-info
mode-line-end-spaces)

> If you have a title bar, does it correctly display the frame name?

Yes.

> Note also that "the" mode line is ambiguous - with split windows a
> frame usually has several mode lines.

Performing 'C-x 3' does present two mode lines, both of which fail to
identify the GUI frame. In both cases, the mode line(s) read(s):

   U:@**-   *scratch*   All of 0     (1,0)

>
> >     2.1) Whenever a minibuffer is active in one frame, the other windo=
ws
> >          on that frame are navigable and operable. However, all elemen=
ts
> >          of all other frames are completely frozen.
>
> What happens when you type C-x 5 o or C-x 5 2 in the navigable frame?

Initially, I thought the system responded fine to either commands, but
then got a shock. I used a GUI frame for testing the navigable frame,
Pressed M-x, then C-x 5 2. A second GUI frame *was* created. However,
upon performing Alt-TAB to have the underlying operating system (window
manager, really) switch me to the tmux window in which I had prior emacs
-nw frames, all were frozen and remained in their frozen state until
exiting the minibuffer (The M-x on the GUI frame). What's more
surprising to me was that when I tried M-x C-x 5 0 (yes, I misread your
suggestion of 'o' as zero), the -nw frames also froze, even though the
GUI frame no longer existed! I wasn't expecting that at all. To top
things off, the -nw frames unfroze when re-launching a GUI frame (using
the operating system's xdg-desktop method). When the -nw frames
un-froze, they displayed the 'type-ahead' characters that I mashed while
the frames were frozen.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 19 May 2021 07:45:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 19 03:45:15 2021
Received: from localhost ([127.0.0.1]:57909 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ljGtH-0004M7-0T
	for submit <at> debbugs.gnu.org; Wed, 19 May 2021 03:45:15 -0400
Received: from mout.gmx.net ([212.227.15.19]:40535)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1ljGtE-0004Dg-Ke
 for 48408 <at> debbugs.gnu.org; Wed, 19 May 2021 03:45:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621410306;
 bh=OlgdgZBA353cpE4AwqoLyyCPcsR3x1ysg1yQ2wTT7JQ=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=VcEbCapKBy+Hxs12f+hl4488iGdYR3If6/H+WxpLSB4oFpSIsCtDLlV9Ir1oF41ZK
 FHVSupqEGk4faS6IDnSvmWOpuanFIzn2xMuGYqkFxsfw8pLfErXzzE8aOaq/IpWnOm
 O5RCE6sKcHO+6l5rROMkyfLTAt5f6NR0izv3hE+M=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.159]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McY8d-1lBKFb2Ht7-00czlm; Wed, 19
 May 2021 09:45:06 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
To: Boruch Baum <boruch_baum@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN>
 <20210519040053.7u7n73smu2hnczap@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <b5492d66-12fe-6037-651f-d65913a9464e@HIDDEN>
Date: Wed, 19 May 2021 09:45:05 +0200
MIME-Version: 1.0
In-Reply-To: <20210519040053.7u7n73smu2hnczap@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:AhWXcbEnMf3W2ZW3veJ8FUyn5qDWrPzPRShFOvMfZzOT+GtgHsx
 J0o+t7x4/5LshdGIM/P/xvTnkdp7Mr8ilaksesxK4wiP4s3533ekK2wX94+15iALNOvPCxD
 H1Okbk5WGgUw9sNa56srrqkMaIoDDJKuokzoOeFCQZ+gkQ3KttJVD2OdiA5Lxf6tvsZLCRV
 do303l3L+jod6X0RT8KYQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:JtIZvX75WK4=:j6y0RZFWgXX5od9nopNsIh
 eeiKocsyPXvRpFGziLd3u+bihRgRG4fZ4GJhCjMTalgkNL9z84FlVVxSvskLHENCj0f0LrfuB
 Xcy3eQ7b9XpjC0uYtkV1h+6sPeT1oYuDBNGTqixb14H+wvj5f/1mHSP3UjtN7uE50ZlRNcDKh
 jcg0BOOTf6dmA32938o9EUBrIYeyMjMASjiAP8O8lxh5HbmMkquI1Cf3xhQm9GEyA510bIoBU
 qoffZumZYIucuxNseBqmzVTVOOgFarNJtkUBwNeKdqWCpIDAakVPNT3EbGGDet2Cbq8tO0Yfj
 LOzrc3bHBFs2uFQ5PWYXZ3YQim4bl6+aR9nozUY4igMLEp1jyCIEkW+DqEx02mo8R+DLaiMG3
 RE0FbzDtDeV93Yh8Ecde+e3eWP2c+2yAfacOqYLd5uT1i6udK+8pUEvK5kqjUY7FCHp7AsGWh
 jcr6BQ39+2kvQQ/XKFoq6LQ+ZGGxlJoFs6b2l1AqRkiYdp6Ay5sR/cREXbQB34d9IaRpn99IE
 xZCv2us3EYAkjP55Cu/7Aktc5dSw+UTUU94XRP3QLgCx6seO/ZV3hENe5VOhoYbQKiWZypj07
 /rmtVEpHd2KNzNnsQgT2AyhQvgEzKDvZ/cbsDTUKg5iR5JhotEq8+b/AxQnLg/hcC++ZE2LwR
 2H+/0EIVeYmWpYWY6z3FsSPgxTDyYuTVqY7yrHWVO+bwyYyp2dJ1O4M3bARHPMTj9wJWb8UZf
 gQJEao3OxBK0Z/4FfjrXLZJ62eVd3a1L8YVbPT7tJt7TDuW93zJ1Jd1mJmWpGz+SIQDe7a09a
 jmswBchvxHROTZGFXXMAbHCZqL0ejzr5qpoWBpq7h790dd8thkf3DP+3Mbj1iIC8TkODqfl9K
 wHFHW9PcJS7s/aDGv/MMBapzikIVQAmGyqUAnGpEjwC1hpCKVfUwz0X7U0J6sN5E3iYfwEaN4
 qhYrt0P9haGBOjWtWUMzIe+sFzK4gCRpO+v2WRiiyAXgWkQdInSVBfESVHUwa4DtLZP4s+iwL
 iOuPKQx7hMtBeU3z9FJPJ9LOT3D85D1keDlaSAlnxSu2hDxHyfq6F+capqinZKVZrUpF42omM
 O+nwBIkhWCL5OOgaKBmqW8iZcDSkcHnA0rOOu7oz0Ge17viY1j01en1jSAAK29AKacQktkBFp
 ADeZ2t3upgGpSrQu5fmJzgKWKw97SvY8G71tYjvfvRlVCHDDa/Wquzim0PiDLvc3cSgp0=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 > 1) In working on this bug, I noticed that the mode line on the GUI frame
 >     was not correctly indicating the frame name.

What do you use to indicate the frame name in the mode line?  If you
have a title bar, does it correctly display the frame name?  Note also
that "the" mode line is ambiguous - with split windows a frame usually
has several mode lines.

 >     2.1) Whenever a minibuffer is active in one frame, the other windows
 >          on that frame are navigable and operable. However, all elements
 >          of all other frames are completely frozen.

What happens when you type C-x 5 o or C-x 5 2 in the navigable frame?

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 19 May 2021 04:01:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 19 00:01:11 2021
Received: from localhost ([127.0.0.1]:57723 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ljDOQ-00070K-OB
	for submit <at> debbugs.gnu.org; Wed, 19 May 2021 00:01:11 -0400
Received: from mout.gmx.net ([212.227.17.20]:49535)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1ljDOJ-0006zb-8x
 for 48408 <at> debbugs.gnu.org; Wed, 19 May 2021 00:01:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621396856;
 bh=GOWbDKD624YqokiCOqssDR0LYAxr3yTpWFTeAM1r1UE=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=SjnAObtU3uUs3EThDRHRXZqd44Ny/92vL6xSEHZcczhZdbgx0NK1yn9LJxAFCT5wc
 WYwdC4BhbmuYKU9I6MIey90aaKQFw9WLsp1qnOS1sLEYqrWb1lQdxlbFpJzh1TGqiA
 a82UFCU9n7mwAJdz6bXGtzKOSZrGWx1BlmD5UcCM=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1M8QWG-1lndEW08zg-004RyT; Wed, 19 May 2021 06:00:56 +0200
Date: Wed, 19 May 2021 00:00:53 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Message-ID: <20210519040053.7u7n73smu2hnczap@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83pmxrulm4.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:vo0lJrYmtYhtP7oJXZGeNhYBrRXcn9ixnzJXdY+AhXO1Vr0ZORo
 SoYmPbWDrX53pam+1JJNgxxGZf0C8sWZuPkkq/j16x5oHi1CYipnrFPIUhkX7HTxLks5SMN
 gYXUoV8YSBz5jygPKJQLORBTbCFfHkM/JKZEu/ILqHjktBZkfxxq2PE8oAIA4nJ/wcKXCtq
 8FmbRr1VQkVSxgcMMo2ew==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Ke8NL+5tyq4=:KQ5gdjx/+nY4dBfDaNZKLL
 rDZKtC0eydxalHEhq6pOYTisaaTcw8YZr2DXBN0G++opy3Ly+I52byuHxQONqQhVEryh/9U6E
 HTCMV7FPi36+Q+9dpzdVIp6whcp8/6xsQm1M/7OZbl4QpwZvh4f6JUUba3J9IB57W2nd9GhKw
 px//Zg1yEFkjIR0Svn/vASGHm0GLWeWrFytiJPhjpvnTlM1B8oEzNaSxICOBeDSqjTLKoya9z
 5w3T7wXfFa9sy3N5hofre0O2kdM8SqVZGxiKkJ305OKvsD2E8KhszSHxxW7TuOs6GWRIzFUxw
 VmTsc3gfrltnI+0bmYzHhrGBAJQS2+Xsw86nJSmWHUjfRMB8nYnVWNuD7zGUsfSyt0rJbENdB
 fhBETo3OPq4mbqrHAYLa+aj23mn5npX+aAm9xbxMuB2YxvUOSBJM8RcRVRLftbdmWzfoUsGsf
 ruibc8s6tkLOgcneIxUg8Uhxkh9exElse4MtTP2FEOo3iVevXRJtxkWTegUCV/DnZQB3g6KOd
 8KaZoH+pdLSGqQImMxrNxaJwe1qu8XUDIjx3KjdKnR1vuHVO/n8kySORsWUwmHFz/IZ50kL/w
 NU48DApG/mDOgWufHBXGp0OcquKqswsLo7vSbhyYZ9TEubPrHiKqXsSo+O/OEsJTx/fVDRJRP
 RhgVbMiwHlRFLFlaKfr8fnCj7QJd2HTP3xPGEP7JPnstZ7nD7vmKsEYrEDFOG8TQc75Rq8KlY
 ODwcq07i9VqLFDoY9XaubTiaC0qDznWni/SndDu1GiM8/DhLHt0jRONfDUq08AE0Q/QGRERP0
 GrwV7haRexn1idrlJRN9E4tstDKxV/LkgT0KQ7F63BaKNJc0KGvOYnfD29RoenoJMjF6S5NyU
 5eFbfVWjmLFPIH9LiWrN6UHWZiwK9uiIGproibHR565d1zMXC23QYbF4Y8MVS7XQ/4EM4PD/O
 igv7bOsuFqhnu6wj8/pgqqMisMwHY2HMHz+xtTUvkqs6crmDw/xU0b/RIzutq6x1jr80XHczJ
 +YVq768JnPvW5rQdjSLVsCweUjTJ5Jcce+435DULoQzoBmHJdIN1xhnMzuNKCkpjkEIZpHf8k
 knGFg4gBjtvaFTjp1yWRxjN7p+os1Ks1PR+wLsLFdCcGHnq6F4w3eCZUGk0oK/7XeTybdM/Kf
 xgfk/8exOdUDG2UqfU6Ut+/X/Z14Mq8JgYlcKuQVq//AwQLFc6RsTLhG8sDaSxrmWr3G8=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: martin rudalics <rudalics@HIDDEN>, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2021-05-16 11:30, Eli Zaretskii wrote:
> Which is a Good Thing, because I've changed my mind.  Please try the
> much simpler patch below.
> ...
> -    (if (and (display-multi-font-p (frame-parameter frame 'display))
> +    (if (and (not (eq (framep frame) t))
> +             (display-multi-font-p (frame-parameter frame 'display))

This patch does do the job; The bug does not happen with this patch.

Two other things, though:

1) In working on this bug, I noticed that the mode line on the GUI frame
   was not correctly indicating the frame name. Should I file that as a
   separate bug? Add it to some other current outstanding bug? Let it
   stand as part of this report?

2) Likewise, for more than two years I've intermittently been having a
   'grave' emacs bug that I never reported on this list because I
   couldn't ever figure out how to reproduce it. In working on this bug,
   I seem to have figured out the problem (but not a solution):

   2.1) Whenever a minibuffer is active in one frame, the other windows
        on that frame are navigable and operable. However, all elements
        of all other frames are completely frozen.

   2.2) This most commonly seems to have been happening to me when
        composing an email message using mutt, which I have configured
        to use emacsclient as its editor.

   2.3) Up until now, my work-around has been to `pkill emacsclient` and
        restart the client (this doesn't cause any data loss, since all
        data is on the server).


=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 09:36:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 05:36:16 2021
Received: from localhost ([127.0.0.1]:49728 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liDC4-0003Je-HY
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 05:36:16 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46456)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1liDC3-0003JS-NB
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 05:36:16 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45750)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1liDBy-0000Ab-0V; Sun, 16 May 2021 05:36:10 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2934
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1liDBx-0006nr-B8; Sun, 16 May 2021 05:36:09 -0400
Date: Sun, 16 May 2021 12:36:08 +0300
Message-Id: <83fsynuik7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
In-Reply-To: <a9fd9c0d-c5e1-d18d-d77d-14c9d9c190af@HIDDEN> (message from
 martin rudalics on Sun, 16 May 2021 11:28:00 +0200)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN> <c73f5a0c-9704-a666-d5d9-11091151e717@HIDDEN>
 <83lf8fukdu.fsf@HIDDEN> <83im3jujtg.fsf@HIDDEN>
 <a9fd9c0d-c5e1-d18d-d77d-14c9d9c190af@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
> From: martin rudalics <rudalics@HIDDEN>
> Date: Sun, 16 May 2021 11:28:00 +0200
> 
>  > Actually, no, I do have an opinion on that: face-font can return a
>  > string even on a TTY frame, at least in a build --without-x.  (Which
>  > seems to be an inconsistency in and of itself, btw.)
>  >
>  > In general, trusting frame parameters too much is IME not a good idea,
>  > as they are too loosely defined.
> 
> Is it possible that `window-font-width' and `window-font-height' run
> into a similar problem when `face-font' returns nil?

I don't think so, because they call display-multi-font-p without
arguments.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 09:28:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 05:28:10 2021
Received: from localhost ([127.0.0.1]:49719 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liD4E-00036n-FY
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 05:28:10 -0400
Received: from mout.gmx.net ([212.227.17.22]:51403)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1liD4C-00036Y-Pf
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 05:28:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621157282;
 bh=0t768rHwm/wF4/vEAyfiqawtbgunuqg1eyXQrweE7ks=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=HH0wqxOT8wOc6EqEOOwlNSpv58A8VKSFeoyWOLESUY9gKHQLEo/TT+W3UWVLfiuPI
 9O1BDa36il8FwalqdTACLRBbxtTAApo4JUd0DfGVdQZXasVNDDrleL+2eu1KBZii4e
 AbxfbqJ5eVOhMnS3jwjPeXptjskwBI63Dg5NPIuw=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.102]) by mail.gmx.net (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2Dx8-1lLQVw1OVK-013bne; Sun, 16
 May 2021 11:28:02 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
To: Eli Zaretskii <eliz@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN> <c73f5a0c-9704-a666-d5d9-11091151e717@HIDDEN>
 <83lf8fukdu.fsf@HIDDEN> <83im3jujtg.fsf@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <a9fd9c0d-c5e1-d18d-d77d-14c9d9c190af@HIDDEN>
Date: Sun, 16 May 2021 11:28:00 +0200
MIME-Version: 1.0
In-Reply-To: <83im3jujtg.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:cNvJYOFk4/YtgCQvntJjEhvzFAanCvpESaVCNv4I/8CyDmqfkye
 lRdFJ7JinenCOUDX9m0fB5+hEsLUraa5iezG0Xf2fQnx1gprss0ta5c9p1l0CbIDsiCAWqY
 tmJBMNmg2GJJBeEsMd2Ejk8dsumBom2STHNexc/f+t6xkohAi1HNTvtr28/goBIsTp0szks
 wi+9IdxP3xJg1F+5X3mtw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:wKv/u1a1QJ8=:cxbVm4WVbNYUrc8NG95W5W
 jVkCF2VHGdk5IJJNxHxkgw7jF9NVuJ0PRrBq7Lk2Nc6ZNQr5Dt7ToLqYijbe8MRpGL9DcpVBl
 cS6L4aKGdUfnBVp9fHtZBwh/gcZlmWI72oRv3/wn/kZp0z5I/1J45cojH8NqawCY1Kat5dGee
 DwxEZPTGMWGsMsclEb7pVf7HbMM8ZKewqlR0SARufOC88yzZlgp2FH4H+SvtJGbbGlAYOzs+I
 aqhrVK6NLv2ulM06CoIUsJonnLArLZcErHQQFkQ7+I/FScAm2KRAPGgbAPEFVdjyWI/JZTvBN
 tX/qM1Tj0gEp3xKd8wyi7Kv39D3raR8sqFlkO/mlK5af9a5eSmaJ6PWVp7irjj3yvoh0336XD
 pF9IpxaXR6+fHmovo1KCZn10Ac9MzVKqtApkmlJ/KStloBWt17eqSFVBR2BDxJfbjQZkHjogR
 a04uVepz9O+i6ncxknDEc+LLx5/w/GBF4TNXuVv5smHvonCQO07+Wa0uK3ZMZUWsg+YUR4Arm
 XkYeQKOKsmUvCR4Ae8cvus2RDQ/z6xp0j+p6BPCmuuDr3icUD48UYUoQZ1P8v41vXUqJy9N1i
 HDETzptyf6fJkrpVtz4/bVgL72HlL2WZGNEnrNYHnJIiRBzApt9/sAOE2KLA3RV8Or7S/B8Ks
 6DMgrf341qTP5LGjP9udymdzIlDpzD0anLujXTHNbznQpZEBofPbVyCCpuSQaO5ctkmi2Qgny
 92EuiP7wJ4K8AfsmW5dGmD+yBQqvyRVOFfVKqtccOZejxn6btTTLwBmkdWQaClbEyww4GO24x
 eBR7rviCGHdZbY+mqhohWqlNBf+3ZFa5J5R6EL9WkDBWYJyRCcK8uoBx+4YkCCx5XoudgmrRe
 x/H2vplquYJPkSvBxGjEXoqgLM9mWmPUjnM6MXyEOZRRw+zQ9IkaDJrq2PLFlYFeHiOFf9Cbe
 4W4UlRY5vzILbydUcpG+ZIE4L6KnU96DqOwzklxviibUWB/Gyo/uNwfYAqWYxZ5Y6+qLvXbDz
 cRDxON1vZd0i2mVAy0r9AMfceuPCKFIxWtXqRHlEadVV1QytuDQOQEPx5gdZDIfJi5NHOc9Gk
 5FhZw0UQNFHzRKGaEVAG3GuxdwujhEKtMQuA94IibF0X6vkfFbH3MSjy8YXX+pD2SyXu1lnqJ
 0ByYLQUrsq6buJMIHeqaKKpR3MrKseqiqCQLNgt89MnFiUZ54tg0WeRy/bbLlbCwHi9+c=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 > Actually, no, I do have an opinion on that: face-font can return a
 > string even on a TTY frame, at least in a build --without-x.  (Which
 > seems to be an inconsistency in and of itself, btw.)
 >
 > In general, trusting frame parameters too much is IME not a good idea,
 > as they are too loosely defined.

Is it possible that `window-font-width' and `window-font-height' run
into a similar problem when `face-font' returns nil?

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 09:09:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 05:09:04 2021
Received: from localhost ([127.0.0.1]:49709 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liClk-0002fK-HF
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 05:09:04 -0400
Received: from eggs.gnu.org ([209.51.188.92]:42530)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1liClj-0002er-3O
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 05:09:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45234)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1liCld-0000BN-M2; Sun, 16 May 2021 05:08:57 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1126
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1liCld-0001Yw-5X; Sun, 16 May 2021 05:08:57 -0400
Date: Sun, 16 May 2021 12:08:59 +0300
Message-Id: <83im3jujtg.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: rudalics@HIDDEN
In-Reply-To: <83lf8fukdu.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 16
 May 2021 11:56:45 +0300)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN> <c73f5a0c-9704-a666-d5d9-11091151e717@HIDDEN>
 <83lf8fukdu.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 16 May 2021 11:56:45 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
> 
> > OK.  But was Boruch's original idea just checking for
> > 
> > (stringp default-font)
> > 
> > worse?
> 
> I'm asking for your opinion about that ;-)

Actually, no, I do have an opinion on that: face-font can return a
string even on a TTY frame, at least in a build --without-x.  (Which
seems to be an inconsistency in and of itself, btw.)

In general, trusting frame parameters too much is IME not a good idea,
as they are too loosely defined.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 08:56:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 04:56:56 2021
Received: from localhost ([127.0.0.1]:49693 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liCZz-0002Kd-Rg
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 04:56:56 -0400
Received: from eggs.gnu.org ([209.51.188.92]:40394)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1liCZx-0002KP-Qh
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 04:56:54 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44838)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1liCZs-0000qu-Gg; Sun, 16 May 2021 04:56:48 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4337
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1liCZo-0006sH-D7; Sun, 16 May 2021 04:56:46 -0400
Date: Sun, 16 May 2021 11:56:45 +0300
Message-Id: <83lf8fukdu.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
In-Reply-To: <c73f5a0c-9704-a666-d5d9-11091151e717@HIDDEN> (message from
 martin rudalics on Sun, 16 May 2021 10:35:31 +0200)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN> <c73f5a0c-9704-a666-d5d9-11091151e717@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 48408 <at> debbugs.gnu.org
> From: martin rudalics <rudalics@HIDDEN>
> Date: Sun, 16 May 2021 10:35:31 +0200
> 
>  > Martin, same question about this one.  I decided that there's nothing
>  > wrong with how we compute frame-type in the display-*-p predicates;
>  > it's window-default-font-height that trusts the 'display' frame
>  > parameter too much.  WDYT?
> 
> OK.  But was Boruch's original idea just checking for
> 
> (stringp default-font)
> 
> worse?

I'm asking for your opinion about that ;-)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 08:35:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 04:35:39 2021
Received: from localhost ([127.0.0.1]:49673 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liCFP-0001m8-QA
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 04:35:39 -0400
Received: from mout.gmx.net ([212.227.15.19]:54411)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1liCFO-0001lt-Br
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 04:35:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621154132;
 bh=xvG0WiIjwS+hp1D8tyUqr2WrhOSCvnGCruV8zk5fCGo=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Q3m6rckCgq0yu+gqYsSpElhCsRCG2GSny2ShsAsTS8wmLgmDtnV7LfTfjVCcK1ydI
 ocPDrZXLJGBs7Xd9ZR2zVEApXwjJtJGKPtqoghx7a+HlUHCkdzosEZ25DMqUvsSvUQ
 gbFjBy6sqJ7d7/rhW7qjnGu2qh6+gLsFC9bl/kUE=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.102]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxDp4-1lWxv227WC-00xapb; Sun, 16
 May 2021 10:35:32 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
To: Eli Zaretskii <eliz@HIDDEN>, Boruch Baum <boruch_baum@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
 <83pmxrulm4.fsf@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <c73f5a0c-9704-a666-d5d9-11091151e717@HIDDEN>
Date: Sun, 16 May 2021 10:35:31 +0200
MIME-Version: 1.0
In-Reply-To: <83pmxrulm4.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:m08RDPjNw0+Hy6Yq/iwAsjsJFIuhEg1CEoesObLf1OHePHeWZlf
 bJUDBxGAmTTExJQbmZ7utV2SpNrSCfWVs7iwV1mSmxqG0HuUrQlPuBQmZnH6Kn5c11TncAt
 KRMhCzevv+iFbIgUCcNExSWv2IK+8z0/6t9+TNtfODcukfaWcUBwFPNA5ytReB4YTH30VMW
 fr7JfjnAxSzhAX+XsoP0Q==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:NlKWjvdnlVY=:ZlH6jkBgH289dXDI9sD9AC
 U+8QYv7Bfqhy1pmGaOyvQupVVjutboJ+qH8LSl2z9gqoU6hFJnAnUm9E7mT+P/LkUT2xd6M7D
 crWY+0aZs/XIZglhyrOrEjzcDt2F8qmx9S163CfstAa/zJK8SifGwX6P9Eevt6Yfs3XMBrlJ9
 f6vwMArBhtDWSampQTehkssGzXBG6Rgu5U1nJMoaIP16JSBu0DD5SZeFn+5FZUM10wXYj8LC1
 gcCPxrA+dJocPwWGrWprAhamYn3WF+n0fphRMDkrnvUY8MjDA2akq/m2cIwuSYXs2iKZlAtZs
 8/lEc8OyglYveHD6KIYCHrLxVsYFmkotM19ymFhbxFQ6+CmoaDrJZM6I1k58cw4iLYnsmSzJl
 mGKBo1qNgT7GqYDES/eIt6B+asfYyJMxV/e4hP65pXJPUOgH++4y1Qpj9MDc6XO7PxNhaG6iM
 vHBzk30xmA7sayMZgPkTqX+GohuQdYphR3gTWi8OjmlZobcYYU3rYYRYsSWGfvDCAZuV1v5+I
 +b4enFtQhWNhMPU7QSnxuChIVnWoXWMc0xyATwxueTXvrD8GPvn4ijaHAuP74W8EdFTD36pBv
 WVPt3OBAPsq1D17sHoakjqAM4Af5cUq3y8RfyEj1jFkJvXAc/ENGZwjWTc1oI0hosKMYfw0cu
 kPc8Vffy7BK/NH6QNP3PDCfB6S4fv7vpDGaymEpbkN3IgSXkVkhGSMQFGfIBHkxzmh3KA5IEw
 O8xeltcrI8V9fF5ujWK9IV3b2v2U1UM/ykQFlbxVLaEM9iJc4xgRSfP2ly9/5wTFatP05fs6q
 1sm1VR0TsffuKtIPueHrZmsF6gSIhkbDQA6CJutmAjy7H4kCWFm+7vrZlR5mYjlfLXM5SYtSQ
 ZzDOmew8mS6pmlrbOCNfWMVdT38OFi5/6cB7/hrKSxBG7pI6kNjF89LqZPx4dazCtbkTEdc3j
 RvhAQ6l4A/ivpcwf3ygeUHr/aQCR3VqAE5yPVC80khAo7iEmspkKAIw3fT8+Kfxdlpsfuc1B0
 sVSFhjJFsLKP6rzSySNKn8TQzypxJOQjRvglzSngea47AJgO9/r1M/zf4IoUxboyT46v5zF9D
 348WwyxTQsGKAXI/2Y/hTX3bn7z6NFuJVn43On1FbR/RgAk15wuqknSAECg50DkzbtGy81gKo
 AfKjHe8jKiR/gA5GZHId+vu7mnYlKoDoHdfA2MSK8Jb9SWeRBqeLHv67ZgPcoW7/qKKgw=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 > Martin, same question about this one.  I decided that there's nothing
 > wrong with how we compute frame-type in the display-*-p predicates;
 > it's window-default-font-height that trusts the 'display' frame
 > parameter too much.  WDYT?

OK.  But was Boruch's original idea just checking for

(stringp default-font)

worse?

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 08:31:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 04:31:14 2021
Received: from localhost ([127.0.0.1]:49664 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liCB8-0001di-5i
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 04:31:14 -0400
Received: from mout.gmx.net ([212.227.15.18]:52661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1liCB6-0001dT-QF
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 04:31:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621153867;
 bh=1QOmv/FYgGZ9lxTOcdlKX0XT5c3drU0LXfKw3NeKo/s=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=HL1syhgr56dbfBL3F3XpYHUheIueAG1pU6JgJeIBf6Y7nNeu08NX7ed8W3PdWlu8r
 rYIOOAfedfFPIi2kC+Y/q5vY4VMavbPn8lbDdKiKwg0eN0CBCskpX3FayvjffHJOa1
 1yb8d+0p238V7jc4wnopcCgc0tOvuudfpoHaHxxY=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.102]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MHG8g-1ldoTK3BXU-00DFFS; Sun, 16
 May 2021 10:31:06 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
To: Eli Zaretskii <eliz@HIDDEN>, boruch_baum@HIDDEN
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <59cdc2fc-461b-a25c-e734-c173f4a53a38@HIDDEN>
Date: Sun, 16 May 2021 10:31:05 +0200
MIME-Version: 1.0
In-Reply-To: <83tun3ur7h.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:xGGmbCInkw7Zm9yg7CMxSKGPlRHoc7GJAONUCUhNkpkSfMQqCWD
 NLnE7k9QbLnfWnlCerFW1cDLNQ0HUGriuLVwsuGAYLjSPnfQJGREERvtZjgfNRUuOiu5YKw
 vlVcNNg/cCIgkdJPGoyWAJzALNRmDpvfkKMIgYWoJWzqLZUlm5Mx8IJHQz0WLvLZTPmjkZg
 wQwHpWa+mro7kmawSSNBA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:lb1hk0MqZwk=:6ezrzxBKBTRZwNLre8dDSA
 n5Pubvffy7LYpzgJ4x16Sow59IJ/R3vEeqEATmkOLMgD7C1qYzliYAmb4MV8qD+hdJEoUXsHa
 +fPDj7FUo/jgQoANONFb6cTTWbdzK4YWLVwPPTAa+bNGVCWHvjDeZmz3UIFhcjlev0bYsGkc0
 PnNZtluQkA2paX8TOCFiIl/UJEcnaSZBiV4CYeZy13kdWp7jFR42yJ44LJ/XJMdWQVtf7LZcG
 5nV93G0mDZRwt+z8Wi8r8Qu7kwK8IiifKE5ESdGGBzAJ+v3lFWMeld2suZ+M0J9UxXTMmY9Wg
 zcNvhVJSF7bSj5yGUyPL4wu2TSKomatet0BgpkR1nvvuLFwf0P9Ocgz2BAFgZRdMs95H2vbPp
 +3W70uUPyn8iSmr2AEQJfEHzHBvrN108jAE5SkxntHv03hn6O+B/GvpVxyoyGG/j3T7bNsMbf
 Ai2ns4xeLqSr1vJ9Z9a4maVIURQrlaVwEPUAQFoXZ3GRzAc4MZLrp4GtFL2MwdJ5ziya/LNlH
 wWE4PWdXn8N8hRt4mGC1avBNertX1bIHoFJzPM5JAbAcElY71n9vPzkV0n6yX51Y8wVU8TiZU
 /+eaCP9sMEhkHLEAkzGlejeNIkEeFVOO2U6LywVzshjHjVBOG5KaoUFOwvC0gMG3PNUSgziw3
 yw33HQ+yVhDb4jlBwJSYR0bBq4wJn5P2HEN5iuJGwdwGTyRN+EhvgmM24SyVCHyhegza/C9kA
 QpN7yYIbZjnWxcQxRM/vl7m02UbIQLbKAh6+B2jW6SolX/3VB/Y5ntruUd0XpuSPJRPqR6NR3
 s0Mv8l69ACh7B5kewTw8jEWGj1al6Jk3CMemLLQ2hyqdQFJIMHCtXfWCMUB4EOBfQ/mODbL2A
 f4qS7CxSQ8D29SwELCpZtZFJuU4OQgmu79GBE5tAD2g3sStIP30hlUGzpaxeHXk0Ac1pXzlsJ
 Ybaq5YFHnOEYRr8+PQ3fbR/vOOmLxMHEgdU4yeyHwdUJodPsiAm9phsDhTgqZwOoxy2Nhojln
 TbR8aCP+1HW488ksWW8bgjtp8FMYf2jRxVwQWoj0toC9C7iTEznHEvQWSSOOnZFZKS4LXwheD
 5u1UvMfZ8TSuccA4svYoO9dTKysu50vwbl7sQzFstbIcxsdxSj5zaf/xeYO/wZ1H3PVkUKZBq
 yGW7zO4OyDhnksLHFeCFBkg/wJpb2NfETM6/bz5s6r8kozyUz/STfnu9UqPn568EroXVA=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 > Martin, any comments on this change?  AFAIU we had this subtlety
 > waiting to bite us since about forever.

I've been always confused by the polymorphism of arguments like TERMINAL
or DISPLAY so I'm hardly qualified to comment on this.  Just install it.

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 08:30:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 04:30:20 2021
Received: from localhost ([127.0.0.1]:49649 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liCAG-0001bS-E5
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 04:30:20 -0400
Received: from eggs.gnu.org ([209.51.188.92]:36190)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1liCAE-0001bA-Kh
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 04:30:19 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44408)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1liCA9-0008SQ-6S; Sun, 16 May 2021 04:30:13 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2523
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1liCA8-00039X-OB; Sun, 16 May 2021 04:30:13 -0400
Date: Sun, 16 May 2021 11:30:11 +0300
Message-Id: <83pmxrulm4.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>, martin rudalics <rudalics@HIDDEN>
In-Reply-To: <20210516065904.5wweuipi23oy5g2x@HIDDEN> (message
 from Boruch Baum on Sun, 16 May 2021 02:59:05 -0400)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN> <83tun3ur7h.fsf@HIDDEN>
 <20210516065904.5wweuipi23oy5g2x@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 16 May 2021 02:59:05 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> 
> On 2021-05-16 09:29, Eli Zaretskii wrote:
> > Boruch, can you try the patch below?
> 
> The hunks don't patch cleanly, but I can try doing it
> manually ... after yom tov. Chag Sameyach.

Which is a Good Thing, because I've changed my mind.  Please try the
much simpler patch below.

Martin, same question about this one.  I decided that there's nothing
wrong with how we compute frame-type in the display-*-p predicates;
it's window-default-font-height that trusts the 'display' frame
parameter too much.  WDYT?

diff --git a/lisp/window.el b/lisp/window.el
index 026cde5..4b99b77 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -8786,7 +8786,11 @@ window-default-font-height
   (let* ((window (window-normalize-window window t))
 	 (frame (window-frame window))
 	 (default-font (face-font 'default frame)))
-    (if (and (display-multi-font-p (frame-parameter frame 'display))
+    ;; Client frames can have the 'display' parameter set like for X
+    ;; frames, even though they are TTY frames, so make sure we won't
+    ;; be duped by that up front with 'framep'.
+    (if (and (not (eq (framep frame) t))
+             (display-multi-font-p (frame-parameter frame 'display))
 	     (not (string-equal (frame-parameter frame 'font) default-font)))
         (aref (font-info default-font frame) 3)
       (frame-char-height frame))))




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 06:32:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 02:32:42 2021
Received: from localhost ([127.0.0.1]:49596 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liAKQ-00079L-1B
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 02:32:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50130)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1liAKN-000798-Vr
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 02:32:40 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42600)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1liAKI-00006S-QO; Sun, 16 May 2021 02:32:34 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3196
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1liAKG-0008Ow-HX; Sun, 16 May 2021 02:32:34 -0400
Date: Sun, 16 May 2021 09:32:34 +0300
Message-Id: <83sg2nur25.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20210516060512.sx3go2zr35izujlo@HIDDEN> (message
 from Boruch Baum on Sun, 16 May 2021 02:05:12 -0400)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN>
 <20210516060512.sx3go2zr35izujlo@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 16 May 2021 02:05:12 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: 48408 <at> debbugs.gnu.org
> 
> I have several frames: at least one is definitely a gui frame (ie. it
> appears in its own gui 'window' after being created via a gui menu which
> seems to have accessed a gui emacsclient.desktop file), and at least one
> is definitely a tty frame (ie. my original 'emacs -nw' invocation, from
> within tmux).
> 
> In performing the final test again:
> 
> > > >   (frames-on-display-list ":0.0")
> 
> on tty frame: (#<frame F153 0x5599a3a9d710>)
> on gui frame: (#<frame F153 0x5599a3a9d710>)
> 
> So the output remains the same, but what you didn't ask me to report was
> the mode line output, which differs:
> 
> on tty frame: -UUU:@**--F139  *Ibuffer*
> on gui frame: -UUU:@**--      *Scratch*
> 
> Yes, the mode line displays a frame ID different than the
> frames-on-display-list output.
> 
> Frame 153 does exist: It is the frame created by my email client (mutt)
> to compose this email message). So, it would be the most recent tty
> frame created, although the GUI frame was created after.

Quite a mess, huh.

> Can you reproduce this?

No, I don't have access to a system where I can create this situation,
sorry.

But I sent a potential fix a few moments ago.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 06:29:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 02:29:33 2021
Received: from localhost ([127.0.0.1]:49591 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1liAHN-00073K-8e
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 02:29:33 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49682)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1liAHL-000737-6k
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 02:29:31 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42532)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1liAHE-0006pA-OW; Sun, 16 May 2021 02:29:24 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2999
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1liAHD-0006TE-Eb; Sun, 16 May 2021 02:29:24 -0400
Date: Sun, 16 May 2021 09:29:22 +0300
Message-Id: <83tun3ur7h.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: boruch_baum@HIDDEN, martin rudalics <rudalics@HIDDEN>
In-Reply-To: <83zgwvuu5z.fsf@HIDDEN> (message from Eli Zaretskii on Sun, 16
 May 2021 08:25:28 +0300)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 16 May 2021 08:25:28 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> Cc: 48408 <at> debbugs.gnu.org
> 
> > on tty frame: (#<frame F152 0x5599a3b27720>)
> > on gui frame: (#<frame F152 0x5599a3b27720>)
> 
> Thanks.  So you have just one frame in that session, which is a TTY
> frame?  I thought it was a session with both GUI and TTY frames, is
> that not so?
> 
> Anyway, the above probably means we set up frame parameters
> incorrectly somewhere.  Hmm...

Turns out it's a feature, see this comment in server.el:

       ;; Note: TTY frames still get a `display' parameter set to the value of
       ;; $DISPLAY.  This is useful when running from that tty frame
       ;; sub-processes that want to connect to the X server, but that means we
       ;; have to be careful here not to be tricked into thinking those frames
       ;; are on `display'.

Boruch, can you try the patch below?

Martin, any comments on this change?  AFAIU we had this subtlety
waiting to bite us since about forever.

diff --git a/lisp/frame.el b/lisp/frame.el
index aff1d47..f6d6ddd 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -2025,11 +2025,23 @@ frame-size-changed-p
 
 (declare-function msdos-mouse-p "dosfns.c")
 
+(defun frame-type (&optional display)
+  "Return the type of frames on DISPLAY.
+DISPLAY can be a display name, a frame, or nil (meaning the selected
+frame's display).
+This function is almost like `framep-on-display', but it is safer
+when a session has both text-mode and GUI client frames, because
+text-mode frames can still have a non-nil `display' frame parameter."
+  (cond
+   ((null display) (framep (selected-frame)))
+   ((framep display) (framep display))
+   (t (framep-on-display display))))
+
 (defun display-mouse-p (&optional display)
   "Return non-nil if DISPLAY has a mouse available.
 DISPLAY can be a display name, a frame, or nil (meaning the selected
 frame's display)."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((eq frame-type 'pc)
       (msdos-mouse-p))
@@ -2062,7 +2074,8 @@ display-graphic-p
 that use a window system such as X, and false for text-only terminals.
 DISPLAY can be a display name, a frame, or nil (meaning the selected
 frame's display)."
-  (not (null (memq (framep-on-display display) '(x w32 ns)))))
+  (let ((frame-type (frame-type display)))
+    (not (null (memq frame-type '(x w32 ns))))))
 
 (defun display-images-p (&optional display)
   "Return non-nil if DISPLAY can display images.
@@ -2083,7 +2096,7 @@ display-selections-p
 via special system buffers called `selection' or `clipboard'.
 DISPLAY can be a display name, a frame, or nil (meaning the selected
 frame's display)."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((eq frame-type 'pc)
       ;; MS-DOS frames support selections when Emacs runs inside
@@ -2099,7 +2112,7 @@ display-symbol-keys-p
   "Return non-nil if DISPLAY supports symbol names as keys.
 This means that, for example, DISPLAY can differentiate between
 the keybinding RET and [return]."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (or (memq frame-type '(x w32 ns pc))
         ;; MS-DOS and MS-Windows terminals have built-in support for
         ;; function (symbol) keys
@@ -2111,7 +2124,7 @@ display-screens
   "Return the number of screens associated with DISPLAY.
 DISPLAY should be either a frame or a display name (a string).
 If DISPLAY is omitted or nil, it defaults to the selected frame's display."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-screens display))
@@ -2131,7 +2144,7 @@ display-pixel-height
 refers to the pixel height for all physical monitors associated
 with DISPLAY.  To get information for each physical monitor, use
 `display-monitor-attributes-list'."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-pixel-height display))
@@ -2151,7 +2164,7 @@ display-pixel-width
 refers to the pixel width for all physical monitors associated
 with DISPLAY.  To get information for each physical monitor, use
 `display-monitor-attributes-list'."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-pixel-width display))
@@ -2191,7 +2204,7 @@ display-mm-height
 refers to the height in millimeters for all physical monitors
 associated with DISPLAY.  To get information for each physical
 monitor, use `display-monitor-attributes-list'."
-  (and (memq (framep-on-display display) '(x w32 ns))
+  (and (memq (frame-type display) '(x w32 ns))
        (or (cddr (assoc (or display (frame-parameter nil 'display))
 			display-mm-dimensions-alist))
 	   (cddr (assoc t display-mm-dimensions-alist))
@@ -2212,7 +2225,7 @@ display-mm-width
 refers to the width in millimeters for all physical monitors
 associated with DISPLAY.  To get information for each physical
 monitor, use `display-monitor-attributes-list'."
-  (and (memq (framep-on-display display) '(x w32 ns))
+  (and (memq (frame-type display) '(x w32 ns))
        (or (cadr (assoc (or display (frame-parameter nil 'display))
 			display-mm-dimensions-alist))
 	   (cadr (assoc t display-mm-dimensions-alist))
@@ -2228,7 +2241,7 @@ display-backing-store
 the question is inapplicable to a certain kind of display.
 DISPLAY can be a display name or a frame.
 If DISPLAY is omitted or nil, it defaults to the selected frame's display."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-backing-store display))
@@ -2241,7 +2254,7 @@ display-save-under
   "Return non-nil if DISPLAY's screen supports the SaveUnder feature.
 DISPLAY can be a display name or a frame.
 If DISPLAY is omitted or nil, it defaults to the selected frame's display."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-save-under display))
@@ -2254,7 +2267,7 @@ display-planes
   "Return the number of planes supported by DISPLAY.
 DISPLAY can be a display name or a frame.
 If DISPLAY is omitted or nil, it defaults to the selected frame's display."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-planes display))
@@ -2269,7 +2282,7 @@ display-color-cells
   "Return the number of color cells supported by DISPLAY.
 DISPLAY can be a display name or a frame.
 If DISPLAY is omitted or nil, it defaults to the selected frame's display."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-color-cells display))
@@ -2286,7 +2299,7 @@ display-visual-class
 `static-color', `pseudo-color', `true-color', or `direct-color'.
 DISPLAY can be a display name or a frame.
 If DISPLAY is omitted or nil, it defaults to the selected frame's display."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((memq frame-type '(x w32 ns))
       (x-display-visual-class display))
@@ -2342,7 +2355,7 @@ display-monitor-attributes-list
 in a graphical display is dominated by exactly one physical
 monitor at a time, though it can span multiple (or no) physical
 monitors."
-  (let ((frame-type (framep-on-display display)))
+  (let ((frame-type (frame-type display)))
     (cond
      ((eq frame-type 'x)
       (x-display-monitor-attributes-list display))





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 06:05:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 02:05:24 2021
Received: from localhost ([127.0.0.1]:49573 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1li9u0-0006Up-4J
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 02:05:24 -0400
Received: from mout.gmx.net ([212.227.15.15]:38361)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1li9tx-0006UX-OM
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 02:05:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621145115;
 bh=YZUpAIkuQG8meOw70aOZpZrJUAdRDQZtOt5EPjN9AaE=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=Y2IJtfIpB3L7vMhvDSx7h/lsvJcwGIwZj99M8ul2aF/WHsymUwCN/pTwBWf3mR5aU
 t7WufeUHXViTt1zl9T7IAz9WCRgISrJFd2jtbR7MURJNDxdMWfSS6kCLhV8z/E+uhU
 eJX2ibWS6DwvKjbsUtfNI8rgt8ciYXPYclcD6Gzk=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1M3DJv-1lljrq0lUD-003gl0; Sun, 16 May 2021 08:05:15 +0200
Date: Sun, 16 May 2021 02:05:12 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Message-ID: <20210516060512.sx3go2zr35izujlo@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
 <83zgwvuu5z.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83zgwvuu5z.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:q6w9jgl30BIfNA9CDs7wL1FWMll4P/T2JZ/TL9b54nN/2C7fM62
 VueiAIQHEwxYQZD9Ph7pkIBCWZF/1rDZsBjZsFFId5rl2+5i4e/6UjHPCpMBdzqR52XR+1w
 GmT3rtTNF5HXxvUeY8u1okEviW45DlcfBn/vc96buHWDOLLDiHToxFs2SMJRRIUFpk1DHre
 n+J891R2P8wVka8z8DHwA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:WBV9SmH/R20=:ApkqOAD0RsQkMP73Jo/Orp
 V8djfNpKwhL/aUJ5+AwXJ2lbbJEpZxhLnoO/BCseLxDZL6a6hL1KhG2QdB4Os6CyLN/DNtb9e
 JxEGahvH8vKoEuU7fIzQpKFnGgO9Ou6KjaWnY5Sz+y/HxKBrlFYAT8ezQigpz4j+bOLpE3KgY
 aS3aLDstbzyhM6zm63tDyp3m55uJfrSDnhKu/M+2zBRTS49kbsUiV3rpzFKb4dDollcM5rW5B
 uTCPyXzP8lBtmHUH7qwN1zlNE3fNvsF3/fHPzLyA4OgnevbMfeSIOHt8yllYX7fxwzkZ1K9QE
 c8/ouwY0OyszITFIe06ieCt+mnN9cOIrqFrdDCgJa9F8pRhAylOB/itNpx/zwnqpthdkRdieH
 0g+RIHaE0nCwrFRIbwwwhSMRN3IX/uzUUx0x3xZFMXmQh8ghUGy09EWwE0QoOJUzVFXG+kpSl
 zvfsgwvj+ZGozhAFKaihjeOznMzk1xkNYAQU1T0kU+AmXxz15ccAoqTxNHMUPaHB+AqGm7aEK
 YNRGyT33B5RzpokarC96DxJktOpfSIgIIMy0MNuGyzc5B3oVWFssV0FDx8vrtUbFAapfesDkl
 wpZpsCcYgryf1PDA/OSpNvBYGXGQp08AHbPHNi73JwFuJYjEVbeYxcMUnLpRxpsz2tmSosEOE
 1DxUJWVskPy72m4IG7Llak71U/ovjPy1opKhuQmugC1qqjc2mLTe0BEmTU81eOpuwRRvJpifn
 3bTx5ig/Nzb0Alqpz5bGJVqVkWAwRScK8HM36qz+1hw7ySzhpCdrvuLgKQjThZIi5x/SnhWcj
 V44KZ7qvCIqZ6emjHnCADAl6k3HoWLFcByRQp+gJQ2NyEZcDXpDPkV7L3o/4eyivojv54VEcl
 M4jP8Di4ySg9oBGgKMhbsMV08Sbd1uncHjnCQar17GkzWptwEWRna4tGOklEaWUjcUhE2t19/
 GXJ4Xfy5nJPg75Kkj8jiS7wEcAQ5mOAZomj9xUXmOS8nyI/8mDFxLEAqRZLM11kjFmfgN1XEC
 CNKZ+AK/8W1nl3QdyoyMjRMy74c7kUt5dPAXl1WQ0gWXdotWXK8tzNxvdaV26ONZexpa+q1Dc
 xKXUkEiTaR4SWfFAfnVeNjd3h+pm+tPEFPsIcLqCLtKkqhd3HyF3KsEOAXnFH9I+hyZ37ws2F
 /k+8Gaf3R5GKc5AqhDjLAqM3CgRq7U4gq+tZ+dN16MGYcsHGVXZZm9YAKx34jzY2ALrjQ=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2021-05-16 08:25, Eli Zaretskii wrote:
> > Date: Sun, 16 May 2021 00:42:15 -0400
> > From: Boruch Baum <boruch_baum@HIDDEN>
> > Cc: 48408 <at> debbugs.gnu.org
> >
> > On 2021-05-16 07:22, Eli Zaretskii wrote:
> > >   (terminal-live-p ":0.0")
> >
> > on tty frame: nil
> > on gui frame: nil
> >
> > >   (framep ":0.0")
> >
> > on tty frame: nil
> > on gui frame: nil
> >
> > >   (frames-on-display-list ":0.0")
> >
> > on tty frame: (#<frame F152 0x5599a3b27720>)
> > on gui frame: (#<frame F152 0x5599a3b27720>)
>
> Thanks.  So you have just one frame in that session, which is a TTY
> frame?  I thought it was a session with both GUI and TTY frames, is
> that not so?

I have several frames: at least one is definitely a gui frame (ie. it
appears in its own gui 'window' after being created via a gui menu which
seems to have accessed a gui emacsclient.desktop file), and at least one
is definitely a tty frame (ie. my original 'emacs -nw' invocation, from
within tmux).

In performing the final test again:

> > >   (frames-on-display-list ":0.0")

on tty frame: (#<frame F153 0x5599a3a9d710>)
on gui frame: (#<frame F153 0x5599a3a9d710>)

So the output remains the same, but what you didn't ask me to report was
the mode line output, which differs:

on tty frame: -UUU:@**--F139  *Ibuffer*
on gui frame: -UUU:@**--      *Scratch*

Yes, the mode line displays a frame ID different than the
frames-on-display-list output.

Frame 153 does exist: It is the frame created by my email client (mutt)
to compose this email message). So, it would be the most recent tty
frame created, although the GUI frame was created after.

Changing buffers on either frame does not alter the mode-line output for
frame.

Performing 'C-x 5 b' (M-x select-frame-by-name) on either gui or the
non-mutt tty frame only offers one completion candidate option: F139.
The mutt tty frame offers the single completion candidate F153.

Manually create a second frame on the non-mutt tty (C-x 5 2, C-x 5 ,foo).

Perform M-x select-frame-by-name again, and on the non-mutt tty frame
get two completion options: F139 and foo. On the mutt tty frame, just
F153. On the GUI frame, although the mode line hasn't changed, the only
completion candidate is 'emacs@E15' (E15 being the device hostname).
This completion candidate never appears in the tty frame.

> Anyway, the above probably means we set up frame parameters
> incorrectly somewhere.  Hmm...

Can you reproduce this?

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 05:25:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 01:25:34 2021
Received: from localhost ([127.0.0.1]:49559 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1li9HR-0005Ix-Nu
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 01:25:33 -0400
Received: from eggs.gnu.org ([209.51.188.92]:42274)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1li9HQ-0005Ik-MP
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 01:25:33 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:41004)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1li9HL-000263-AS; Sun, 16 May 2021 01:25:27 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2749
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1li9HK-0006Mp-UZ; Sun, 16 May 2021 01:25:27 -0400
Date: Sun, 16 May 2021 08:25:28 +0300
Message-Id: <83zgwvuu5z.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20210516044215.23yd5ae3yeby6kaq@HIDDEN> (message
 from Boruch Baum on Sun, 16 May 2021 00:42:15 -0400)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
 <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sun, 16 May 2021 00:42:15 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: 48408 <at> debbugs.gnu.org
> 
> On 2021-05-16 07:22, Eli Zaretskii wrote:
> >   (terminal-live-p ":0.0")
> 
> on tty frame: nil
> on gui frame: nil
> 
> >   (framep ":0.0")
> 
> on tty frame: nil
> on gui frame: nil
> 
> >   (frames-on-display-list ":0.0")
> 
> on tty frame: (#<frame F152 0x5599a3b27720>)
> on gui frame: (#<frame F152 0x5599a3b27720>)

Thanks.  So you have just one frame in that session, which is a TTY
frame?  I thought it was a session with both GUI and TTY frames, is
that not so?

Anyway, the above probably means we set up frame parameters
incorrectly somewhere.  Hmm...




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 04:42:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 00:42:26 2021
Received: from localhost ([127.0.0.1]:49524 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1li8bh-0004Az-VF
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 00:42:26 -0400
Received: from mout.gmx.net ([212.227.15.18]:44399)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1li8bg-0004Al-Fh
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 00:42:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621140138;
 bh=n4JpORZSZrNnkeZNJ0Shl2j+Jg6/CpV4CWrE54yVH6A=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=QYTbrrvIolugpPKo+VWRXC4jUClyLIsk6zaUqwd+TuRrPob78t+CHD/I64kP1cRzo
 RVsqZAfpbYv0byGICArH/+CCHdUcZSW/iNcZribxznp1Qs53XRKD8co1ZZznZH/GoQ
 aVfbWtPGIuVkZnnqXeJqJGhYwmdLzAjXKyBHruvU=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1MPXhA-1m4lpY0DCs-00MbuL; Sun, 16 May 2021 06:42:18 +0200
Date: Sun, 16 May 2021 00:42:15 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Message-ID: <20210516044215.23yd5ae3yeby6kaq@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
 <835yzjwbnj.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <835yzjwbnj.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:SyXFXBceiRgnBMWf5eu1t8rhVmFkVexluXdZkXEcC6UXkZ7UdGJ
 15FkIMGPBiczDMjlpfIYpVlRZxwVnMMxO484Hhnu2pFdAioLUkkR19W/QaI0OohI8rP6B7r
 +neY1ANDRLUo4/elz9QL1DxIeuYRjoeUzdNNX11ZYUyenUZ8le8SBxp4JbG3RbV0KjXm7+C
 IjSc8CZfnT8KvKgBauXpg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:ctAMgSSfxFQ=:LGVo00fFK7n4oHFa9tajQX
 DKLeDz7H9XjiejmnDZmSYb8EtB91GPRenks26eMGQ4NR1gZvO03XPZVcorko9fOTWyN/+XRDD
 KrOp5WXUhHh5Prb9Oox/cOUb/8GWHhFGJlZ7n9P08EH44Lk3V2C2u5HYnuc6o+AFRyW55IHRa
 QvZMMNZRSOyPkdCMNbRljSMVV2DQhRteLq5hEgk3L+uHmkdTVXymP+RwcoRsyF4BojZkMSqVB
 dSgkKi1Z22qRnXLZpRrAJPhOPjr1ZLWbmbpM7D8x6nyvF+GlcxF8S9Qu4TtUVdl2NXlxsMYQF
 ieo1Ab5gSbIYGJV+1SqqvzXqc13hXIaiJOh8H0SWlTbOhD/fZMidq+kDKPvsSvMM2xxwZcsSf
 2Q209pjnkKq2GAwTxp5dlOO+Dxl7mJ8UXKYN3uaEGyNJHgWtyu12pLc1AjruUOyGqzfJnUX1w
 Czi2hO8+2rdxEf4oNAfee6wljYFOlSY05ldSbg5D3MGMWl4I7hOVS5gFSF/IWOfnhEqp8faiV
 Tt/NqxK95CUFLtRaUqY3APSUniYvqIhPQXnDIdGJnqE2DOk/9ioiFxwU81P3f3oitegiJvojk
 T3067NcoL+cT8tyrevK9pvytbC2Vkz4zw9X2J/BgHy+JQ7HIQ5ZvXtLBiekZJ6Ug9nhYxuCYz
 Gq1XujEqVZDiIOIgINJbMyh2UBuUK6PwswTgPpSP0clJUL4p+2c0Qne0YXWD/VF0IhOJWl0DA
 bzrPL+avlGZAsEyHgpWAtf7NfmvVHiv3cfRY3HEVZuNTPNUVZrKgCfVaq8CujEXxu8MWslfEm
 fOj+ZCcIPCdWXZFn5tXgt1HZFyyZFRPYvVzXxZQerJAppHra5H292LZni045ItOhcYEGz9bbq
 wNO68lfZRA8AihDwQVQPoIGKY1bQpUftif4o7zXSm02FpE8Pp6dS/RRPpfakR/6QEYlLg17DY
 oO/OifO2cRO5VBOqqQD7yBEkZWRkgYA/sGwwtivrhN6XmzLnyl38jS4aGqSESFAw4aIAabkfw
 HHgJg9La3EnnsUZ4uPprkdBFN7PEOD66pnwsIEeHyRC4g3nB2ljdM7g5/3lIyDGZLB6aNM5zu
 YwFwFR3uZEFDGi4iqpfxhfoSITNfeurbC8Ja1mOfXzyF2cSoeOAlWyCf5WZ+XsMKay2u9P4XZ
 Han2LtgcsE2nCqqsC/3WYwJLRa83InFEvqIBuiehbPXQmtqdYkkYwZF/gSiNTEbrpZq7A=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2021-05-16 07:22, Eli Zaretskii wrote:
>   (terminal-live-p ":0.0")

on tty frame: nil
on gui frame: nil

>   (framep ":0.0")

on tty frame: nil
on gui frame: nil

>   (frames-on-display-list ":0.0")

on tty frame: (#<frame F152 0x5599a3b27720>)
on gui frame: (#<frame F152 0x5599a3b27720>)

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 04:22:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 16 00:22:35 2021
Received: from localhost ([127.0.0.1]:49508 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1li8IV-0003iL-1t
	for submit <at> debbugs.gnu.org; Sun, 16 May 2021 00:22:35 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60746)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1li8IT-0003i9-Sc
 for 48408 <at> debbugs.gnu.org; Sun, 16 May 2021 00:22:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38972)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1li8IO-00079M-CH; Sun, 16 May 2021 00:22:28 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2789
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1li8IK-0000vB-7M; Sun, 16 May 2021 00:22:26 -0400
Date: Sun, 16 May 2021 07:22:24 +0300
Message-Id: <835yzjwbnj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20210516030618.7caj6icukblavhbp@HIDDEN> (message
 from Boruch Baum on Sat, 15 May 2021 23:06:18 -0400)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
 <20210516030618.7caj6icukblavhbp@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sat, 15 May 2021 23:06:18 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> Cc: 48408 <at> debbugs.gnu.org
> 
> >   M-: (frame-parameter nil 'display) RET
> 
> ":0.0"

That's the cause of the problem: it should say nil instead.

Can you step through framep-on-display in that case and tell what does
each of the expressions in 'or' there yield for that frame?  That is,
each one of these:

  (terminal-live-p ":0.0")
  (framep ":0.0")
  (frames-on-display-list ":0.0")

My bet is that the 3rd one produces the bad result.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 03:11:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 15 23:11:51 2021
Received: from localhost ([127.0.0.1]:49467 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1li7C2-00023W-Sx
	for submit <at> debbugs.gnu.org; Sat, 15 May 2021 23:11:51 -0400
Received: from mout.gmx.net ([212.227.15.15]:42195)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1li7C1-00023I-9i
 for 48408 <at> debbugs.gnu.org; Sat, 15 May 2021 23:11:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621134703;
 bh=475Af1azGtuOic+y2jto69Tkrdrt7si2mMBQMRgBi/I=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=E9kjS0sI0y0E6i9/LIIFCsZgEB8BgiVn3SY1JbQtRufXf936b1YmZHd0+9q/yUmxD
 EZ/A3dMjvTjkYDr3lXI4SrI5DrAvulbZr1B+ViyZ8YwkLPePsyUStVFXD5IXLt5Zya
 0VLcvtj2pGG6EHOdgfoK5YEk3R5VZsJrrqwUpLz0=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1M2f5Z-1lmEBl49vz-004Ejn; Sun, 16 May 2021 05:11:43 +0200
Date: Sat, 15 May 2021 23:11:40 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Message-ID: <20210516031140.euml2py2aixmr5dg@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:syj28yjGIQiEPcBAGAf4SSFHbq835E8sc73BEgJl3XDzXU4AC18
 Se3Vp/p7rc1V1hJfDbTZcRQ5Y5LSqpkwpW8/cQwYNDiQHudvSYJIjwlDHGKYUCHVq8yqSpx
 Lp/XeDgOCEPG/fstPlkdAxxADJXYuSLXM+GMESIX31cDzfCBT4EGmaQAw0+2uFe+VFFXK8f
 DamuOAbeHRBBvpGhSM3wg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:YUJNzMzdLW8=:XNjf4r7ZgxP2bIFuK/qsOB
 Hp/qvDwu4dGkgCuNMZxEPkk9I7R3fm7AV9N9FZUoWXPwYbMXa8WT4T67XC0cbQkj2yDgFPbeT
 DeMYIVNIOK2BlrzmX9eyq3icChsgG1lZZwvaumoisrFsSdZUEK4JijnzLTCcKcVnEZbsPZk82
 DOr9yh0XvOaDRNXItnfWGIWzzimmgaNHdS7vcsWt1ALjoH3LpWhI1yfMWctTvqDR5EVF2L+Ju
 +YuRzhX1owAHgCfvBj6sJzbm0F6l5a9nu4XKTvHmB9Ie9qJ61nVCpt2zHgudfTaa0iuRw9+tR
 o713ZY/Mvsw534U5jgGP331KKdFyrLH0ENajht7qPfavVUT1RHs/w8aA9HeGksejzdfRad7rF
 sYCLKSA+CYQeff1OCniKPq6IhYY7v3b6CYQib2aySPAaeNgkxrqsIzFhBjQmjMVKZPuOEsm1k
 QZeKn9qsH7hjRaUdFKgYKLqLO3Vy+5ph+0WWZLm2CKNcVpgN0yErOm+/8VJxK3bVPGr9M5bQ/
 sG62ouqFvbpsng8Hq6CejT5CJVMD7Y2H7smlzLiipfRSpI1HQWHRBDRzn7UsNt8g6zoy7a5wz
 n3X5X/hbLz5pWre5yII5E4rrnHBnHyUG1U7SqRWYEEnMUW0Bv9dGLzjWZ9ijOtRboHnD3d3cj
 /BSQN2i5giHnFKSb1kTK7eKcfTz3hgqCtAITQ9/eGKMCiPImALYL1KYZKGZwQp3d/Zty9Y9DB
 CwleVsIhSA4UoswGNTxIW+oxCAqOlCMTNH15mKq8/xgNpMq6xQTedhBb1goQJ6qs+P6leNDZU
 HyrwIbpqws+yO+B1eY2pnVmG3vEp1EtkwHk3/f8/WbEgQoNMCNBOEv1V0xLkvPYSd17LKXIIo
 riymwZ7BTwKYhY5MPpKwPwYrpAJRVGJCOLIdmftSfJeTfX1VaAexn5yq2LlinbNfyq+t2+zxD
 5W9WXFltkDsnoiE1NXzk7hYtCI1ElWQA4VFzdwToR1/GwRNP8ZDbwI3gJ9ulyMmRRfwipilg2
 8cFLUfoet3ceR1S4QgqrfRkTH1X0kt6Z8QygB2NF5WjlRgpV5XpWcoy/58PbCFmG38QnKHS3n
 rS5BcnqtjkLj/oQKWh6Jqxn6lqgt9L0UVx7TK9WTuEXVEAICvE239AsgbXpq/+5XxCQU4mYP+
 p+9qvqVKF0bTzdhxwNnHyss1dUwNfhRALBhDnDv1DaECGKDJMbeQqGWk0giDYqyS6SJ64=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 2021-05-14 09:09, martin rudalics wrote:
> > In package windows.el, function `window-default-font-height' calls
> > function `face-font', which can return a nil value, but performs a
> > `string-equal' operation on the output without checking for that
> > possibiliy.
>
> Please report this to the author(s) of that package.

I made a typo in calling it 'windows.el' instead of 'window.el'. I am
reporting on the emacs core package 'window.el':
;; Maintainer: emacs-devel@HIDDEN

> What is `default-font'?

nil

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 16 May 2021 03:06:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 15 23:06:30 2021
Received: from localhost ([127.0.0.1]:49463 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1li76s-0001wL-AM
	for submit <at> debbugs.gnu.org; Sat, 15 May 2021 23:06:30 -0400
Received: from mout.gmx.net ([212.227.15.18]:40815)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1li76q-0001w5-Bm
 for 48408 <at> debbugs.gnu.org; Sat, 15 May 2021 23:06:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1621134382;
 bh=9luwuz9CnMfH2bVdEdByQcUMtobCRN1/ARDxQrKsiAw=;
 h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
 b=CMZAZnaormUYJEkhh0SbeTtQibEKIcnB+PBQgeM0umVYr6rBzzmCgUQH8SAoIUlzJ
 4J3V5o727LAcjI/4LAczZ59er/F6WLuA5ZhiL94u8/BdAgtyM4+xl399OQfOvUJC2Y
 OaYfuiIax7I+p7iqD+o0ntNg65VtAFfHI3QlcI8A=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id
 1M6lpM-1lqMyZ20PW-008NNv; Sun, 16 May 2021 05:06:21 +0200
Date: Sat, 15 May 2021 23:06:18 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Message-ID: <20210516030618.7caj6icukblavhbp@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <83mtsxzund.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83mtsxzund.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:JifXswoiI7FpejoHE0/OqdNX1mAvlIYQf92k4CROuR0Rz/fYAxy
 +o/L1cJwYj5sylBuRD3Y+wMSppmVfELE3CVtE8+bG7esfEhkn1R1LQaJFTByKpzXqMwA/Pr
 zXfAyYByDn2Tm/AOqDIZJZde5VROuzSRoCXE03S/rBjqLE9wQyDdZc0n3wvVsWddDsWlEq3
 4OTGltN8TmnOBSQ/D4/hg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Io6COX4YZPw=:R2UPBWT9n4RKev5OYelJAM
 z2fvKDCY5liLjKOdz3btsrt5/vHs31k5FpZUGDE1+2BFtDssUzUep7F0UYCTiMimXescb0Tum
 c5ddodv1LWUgctNrFgL+huLt5by9MzcWeHv8MOZHrtp9F75HInEyqbkSbcxqfkg0+GAKjLN8H
 JuSoojwCuz5bIuR4+35fW9ofLEFUHlIR1JCOM0d8rUtRj8xLPnT+5tdTJy6SjE4HFaLS+hbRM
 /xq0fOrp1GBDUWls2AUV+q6uMUBu0DK/mVnv6BirEFjwp+GvpwOAE59LT5CQY7n5XlotE877+
 SfxGEHN/Ix87dSkM3eaxyDBrcZhtXbot2EIXvt0w3A5R8to21ipJsHNB4F64pqCYycR3zl+hs
 PmggZzRAkB29CRt7BYvV6F6SYOJM5sM3ABRGKZ8S/obcK4GYyJ5fLufVx5Ph3hc62h3IGPM7+
 xWBlcb+jH8jsQJtbDq8DPot8z03N1j2CyiiiAAq3H1ca7eMvcaapoYYLIOq4SzCia7r9+g90X
 dTsApXVmBtUsXQ/0NBnxnes9dIRhympmsZ5hQtMKG/N9C4NJX8vaF1IH3Qhln38YuXEb8A1ZP
 t2lFa2n/6noNLpJ2TCBgcRSZyLgwuhypbxM+ejEM9S86sFc5mBVrwiVMZVw0U4dzE6csJuWqF
 2P4RhoSHL24P9809J0tNR+rS+IXaDbiPl4oK7N9F38gFCOwiHCeJ8Rn1OAgc/2rE62eiesl0Q
 WiOZU5a5qYUH1xgm4qupUIPZSEWqLLvLiUBAW/suhkQUtxFsP/2cyL1r1a0p1C8nfL/Jb/yF8
 uoPiSHIJDJQLcUE8Zez7RXFKirqTPaqdxOf636syQU6a+SW6cOdM1qQ5RHk6/A/ftV5HVhmJ5
 eJZrGaMABToNxYVkFK2FgNgKYfFTw1EZZvKhXPKHNaRjCAXEqJqIWi6grO/V1UxE+fZ3Q8C0T
 qYX+YwY8MrWitVOc4Xr7ZGzC5djZhE1ZsvKCvM3Jkbzh4kq5xj6PcwCDgp5TeYru3yDiOoyux
 Bh2M8t1CxSE1HLRInKWGmR8FJUxAoLHulG5/E/dgwFl324iRD//5o7jX8LPjUDi4Rx0uo3Qak
 mcQMVHi0oN5nVegtb1IjzX4Gzmv3HllsnJETuzs7YBSSC8RXZw/Gn9SxSz8dePwl1QjdXEiC7
 IBWaTpucW4AmyNXaNSJCkisUTtNHFNrgPGTibzGo0D0ZJMYQ24fPsNLfX9azH1T0devKc=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 2021-05-14 09:39, Eli Zaretskii wrote:
> Can you tell what does the below produce on the TTY frame where you
> have this problem?
>
>   M-: (frame-parameter nil 'display) RET

":0.0"

>   M-: (window-frame (window-normalize-window nil t)) RET

#<frame F139 0x5599a30eaf90>

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 14 May 2021 10:45:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 06:45:18 2021
Received: from localhost ([127.0.0.1]:45160 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhVJl-0006fX-Ey
	for submit <at> debbugs.gnu.org; Fri, 14 May 2021 06:45:17 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44536)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1lhVJh-0006Vo-Ah
 for 48408 <at> debbugs.gnu.org; Fri, 14 May 2021 06:45:16 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:34598)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1lhVJb-0005fH-L8; Fri, 14 May 2021 06:45:07 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2891
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1lhVJa-0005V1-GE; Fri, 14 May 2021 06:45:07 -0400
Date: Fri, 14 May 2021 13:45:18 +0300
Message-Id: <834kf5zj9d.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
In-Reply-To: <25ac01b7-c6ef-3554-60d0-25ddead80495@HIDDEN> (message from
 martin rudalics on Fri, 14 May 2021 10:15:58 +0200)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
 <139ea227-861b-b3c3-c36a-9b7ac30a5acb@HIDDEN> <83bl9dzsg5.fsf@HIDDEN>
 <25ac01b7-c6ef-3554-60d0-25ddead80495@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
> From: martin rudalics <rudalics@HIDDEN>
> Date: Fri, 14 May 2021 10:15:58 +0200
> 
>  >> Sorry.  This function is missing from my current window.el here ...
>  >
>  > Really?  It is still there on today's master.  So I wonder what kind
>  > of revolution do you have waiting in the wings...
> 
> Nothing special.  Just a function that takes its buffer's face remapping
> into account.  But it lacks an alias and is apparently just as broken as
> the old one, see below.

Yes, the same problem should affect this version as well, since it
still assumes (correctly) that if the frame supports fonts, the
default font's name is a string.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 14 May 2021 08:16:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 04:16:13 2021
Received: from localhost ([127.0.0.1]:44947 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhSzV-0002IG-7K
	for submit <at> debbugs.gnu.org; Fri, 14 May 2021 04:16:13 -0400
Received: from mout.gmx.net ([212.227.15.18]:51425)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1lhSzO-0002HS-Sx
 for 48408 <at> debbugs.gnu.org; Fri, 14 May 2021 04:16:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1620980160;
 bh=lAeIJpuPrwhPhhXhJ1dMLFfqAAzr2M28hQVq8ilqKvE=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Jrkv3EgBDRtOuZJ8BdPZCEETjOmzCK9XHvdIuwbZtB0b1BA/2etyQ7ugoGveIl9Qe
 xjh9Bm+ITy6YlJ3aKQbehPMQzXfnnadvOYxvR3BLB1R8n3d3bDFs3SzsVrdomJ+6Ez
 AwKZrJrGHuTc1b4Tb9nbGee191YkSRoGvi0Ot97k=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.218]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MI5UD-1lkRfz0FfD-00F9sm; Fri, 14
 May 2021 10:16:00 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
To: Eli Zaretskii <eliz@HIDDEN>
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
 <139ea227-861b-b3c3-c36a-9b7ac30a5acb@HIDDEN> <83bl9dzsg5.fsf@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <25ac01b7-c6ef-3554-60d0-25ddead80495@HIDDEN>
Date: Fri, 14 May 2021 10:15:58 +0200
MIME-Version: 1.0
In-Reply-To: <83bl9dzsg5.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:8c6TCb8x2lzgyicEk3Fu07JgNE1JPmFCGeXeESS+WFiaJxnYwNN
 Hhb95FBx/wdWVGDwO6abA40kC0gBH+uwTx0JlYShSiraGKEA4mni+GtsoI5S0jXqscC3Yn+
 ilsp/v9ywGcDe8juyNbOyf7lu0w7pLrFoMtOdy0awfDwnM+c5b/X7Wkb1IAU62bAUtxAvFx
 95kHRJ4c8USMo6Qc+knFw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:SfouZK4+FMo=:o9hcXovku181/A4AIkCjQ5
 JLvEFeyrKX/hiKvmnyMzgsoqwvCkZYIgB7W911mSMeBNWO+CcjoNvCpM7N8iLpWUdDtLfQ2Px
 RrWzv5iUSf5mOrILmRfZBzERQGx2BlBuMn+9/7SLSd8tnVxGOTLr9uNDDmIV6eogVrfxshiCX
 U03kzWtufO8fwqDi9TG/4iiMJev4J4cyDeGe98VBhGm87q6o/NRGG5pZFpQRndnw95e5tq2iI
 t34vFOfOZp3HFf9UUUDsJ0oJTHUiiei9myLUpeq1KW8bGo1Ju0oB7jZXTJ4UFcTQCKCA4wBsI
 4qBQG7eIAWzC3A1Wf5q8WrqGPMWlYxBKaSuMYKSn9gmdUZuM3aexawBeN7BvGjv70FAkeIYlx
 nx85noKZeHVk/wdxjVyB1kYew4MdfqMIikmZiP/fAtcchAE6C6aVRMqFDDi9+fWhPquWz4ebo
 bYKzbTr4sBHBQPLCpFbL9MBSfeA5Fz8rMbKd7KYMtiwmFGVwSSEYGBWPSaZ+AVGMjqoZZJRsC
 MXVXgyKkMyHcC/YF5i1ySOQuzWBX/kBqJ/IDHaYVWjRatK5hXNV5e1/jy19a2HL0/DctBSI1x
 3OFGxPSLvDHnT7+yk7sIPFBKE3TnL2pEpG4Sv8TupoRVdoD8l4hzESCchWmG9fb0PZTl5MDpt
 TaogmzO52vSMwpsLjZr2i+/X6dRPQAgDX1E9QZ358WsUWkcnKrW/yjd2Wu+N2NuvkUiKYpPD6
 rwIMvo5sks33z6I+xo5mqw250YURBsj+2rdmvSevHrBMT59coHrl/dJ1DBitMYR/mpPUXkyIl
 938b8E3bs4oMOAXa80AvvlmSsAd6VtRrzgLXF1ro6D+4RedwriX7zl+uAqdLW1lQUI7xf0Ebq
 QKbyFiNx0qOU7/hSRAHK2PTilenjIFn4202WLjO9uSmeDojcD55q5tXc2MF1yFZZfW+38RrSC
 mZEs4SJIkUp7nBdAby9envOElF5X1rDQAh4Tj2qJ0x/+fp1HzO0IQTvi0V2ciwwpTCipfjuu4
 v+dcecnoUonhQ/rK3bfa3fiQautdg4Qy9i0IPydps9tFllfF8hwZRCT6D8jOb9wC8gULeptaH
 WbwHscbPdCJ7N6ItIytFYYJdJdBBOek7TA2T6iD+/XaFKMFIFdKUF3V1sjNwqbjQcnyxF3UtU
 GPkFJABKJcFOe1Na20M9di8huf0yDMMZ7edhIJdsbYPTHa0p13EtObVmf8y9VGb3Y5lDo=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 >> Sorry.  This function is missing from my current window.el here ...
 >
 > Really?  It is still there on today's master.  So I wonder what kind
 > of revolution do you have waiting in the wings...

Nothing special.  Just a function that takes its buffer's face remapping
into account.  But it lacks an alias and is apparently just as broken as
the old one, see below.

martin


(defun window-face-font-height (&optional window buffer-or-name face)
   "Return font height in pixels of FACE for BUFFER-OR-NAME in WINDOW.
WINDOW must be a live window and defaults to the selected one.
BUFFER-OR-NAME may be a buffer or the name of an existing buffer
and defaults to WINDOW's buffer.  FACE must specify a valid face
and defaults to the default face.

The return value accounts for any remapping of FACE's font (see
`face-remapping-alist') in BUFFER-OR-NAME.  If no such remapping
has been specified, return the height of the font of FACE for
WINDOW's frame.  If BUFFER-OR-NAME does not specify WINDOW's
buffer, calculate the return value with WINDOW's buffer
temporarily set to the buffer specified by BUFFER-OR-NAME."
   (let* ((window (window-normalize-window window t))
          (frame (window-frame window)))
     (if (display-multi-font-p frame)
         (let* ((buffer (if buffer-or-name
                            (window-normalize-buffer buffer-or-name)
                          (window-buffer window)))
                (face (or face 'default))
                (font (if (eq window (selected-window))
                          (window--buffer-face-font buffer face)
                        (with-selected-window window
                          (window--buffer-face-font buffer face))))
                (frame-font (frame-parameter frame 'font)))
	  ;; Avoid calling `font-info' if the font whose info we want is
	  ;; the same as the corresponding frame's default font since
	  ;; `font-info' is expensive for some fonts, see bug #14838.
           (if (and font (not (string-equal font frame-font)))
               (aref (font-info font frame) 3)
             (frame-char-height frame)))
       (frame-char-height frame))))




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 14 May 2021 07:26:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 03:26:44 2021
Received: from localhost ([127.0.0.1]:44840 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhSDc-0007H6-7k
	for submit <at> debbugs.gnu.org; Fri, 14 May 2021 03:26:44 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55206)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1lhSDa-0007Gt-LB
 for 48408 <at> debbugs.gnu.org; Fri, 14 May 2021 03:26:43 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45208)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1lhSDU-00042E-Pc; Fri, 14 May 2021 03:26:36 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2549
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1lhSDU-00072S-Ct; Fri, 14 May 2021 03:26:36 -0400
Date: Fri, 14 May 2021 10:26:50 +0300
Message-Id: <83bl9dzsg5.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
In-Reply-To: <139ea227-861b-b3c3-c36a-9b7ac30a5acb@HIDDEN> (message from
 martin rudalics on Fri, 14 May 2021 09:15:09 +0200)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
 <139ea227-861b-b3c3-c36a-9b7ac30a5acb@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: boruch_baum@HIDDEN, 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: martin rudalics <rudalics@HIDDEN>
> Date: Fri, 14 May 2021 09:15:09 +0200
> 
>  >  > In package windows.el, function `window-default-font-height' calls
>  >  > function `face-font', which can return a nil value, but performs a
>  >  > `string-equal' operation on the output without checking for that
>  >  > possibiliy.
>  >
>  > Please report this to the author(s) of that package.
> 
> Sorry.  This function is missing from my current window.el here ...

Really?  It is still there on today's master.  So I wonder what kind
of revolution do you have waiting in the wings...




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 14 May 2021 07:15:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 03:15:18 2021
Received: from localhost ([127.0.0.1]:44825 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhS2Y-0006zd-Lp
	for submit <at> debbugs.gnu.org; Fri, 14 May 2021 03:15:18 -0400
Received: from mout.gmx.net ([212.227.15.19]:57451)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1lhS2W-0006zM-T8
 for 48408 <at> debbugs.gnu.org; Fri, 14 May 2021 03:15:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1620976511;
 bh=fo4TJjyNTN1nqFM7dNS/jk0uj4YAxIq5Kxpi7nPxP6Q=;
 h=X-UI-Sender-Class:Subject:From:To:References:Date:In-Reply-To;
 b=RsOTo4p+X95uwH/q2ffAJvugoy8d/NTNFPdq4OQGYlZWmMLuqarPp+q3PWbnAFDmv
 bldVUgACedYhrx+qFZLhLqGMt48lel0n52SamIKpFBKHquVwRfUMSdyK38z0aSpHyR
 F8/LoOSwryVA/46NM/MnOH1faZg1oEh5fx2oVHJQ=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.218]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4zAs-1lXjCs3YUm-010qBg; Fri, 14
 May 2021 09:15:10 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
From: martin rudalics <rudalics@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>, 48408 <at> debbugs.gnu.org
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
 <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
Message-ID: <139ea227-861b-b3c3-c36a-9b7ac30a5acb@HIDDEN>
Date: Fri, 14 May 2021 09:15:09 +0200
MIME-Version: 1.0
In-Reply-To: <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:fNyxFPPGq5ywxP/nq26ZhChdAu/os3PsATGlIjQsZLNfkU1hXMT
 Q66KIYOm2/ybJON89GB59el1crifhXD2I8oyj+xpMU2cjNmhk63lDdsRJeJG3M1WagHI4Vg
 BxRrS/QRSr4sFmjdqDutmUA20CUK7SGQ4O09wb0jV4T2UiA0RogpPWxzz3AYHpxyIhGXCLz
 RLcZlVA4sG8Mh98WhytXg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:HK4b85ZMZ8o=:Leq9e22N1ecMX952EzJhjH
 DyPhNBsueMsdZKj5qRZpC6L7tpQgo3DxBRJxHPJkXt1Yn+jVJmQabl1Tw2N7Ujl70lh1g5X7p
 1Kk7RaXtGq2yG418Fy6PClzrFtJ8p7Wv3U20l/kNzW8STyd0j3BEXVWfrscPkZNaaG9XOZv11
 vkFzpfefc9buc59hCAsZwZpw8zXEEEma1KLNXBnLQIL9MGWhfoMNrhFDQ7EqDAjCB7H9+XAOi
 tmnOOTxpcOjY2RecxDU8M5yLQhj6lKjJZpW2W/dx1Pyq+05v8/1tNorCUurqsbmce+QhbYktU
 S0VC2R5cD7XuzJLEaDthi/tIYMvgUTMwR1rHpuCSLJaFDaG2wPJax3NNPnfQBMWfh54zwOiFK
 YfLDnSg6XfoZMxpQ6knwcc8l442njwKHiELZugLD1OuUC7pgiNHvGFdWPieTfHdCVH5RXHK9o
 EthpbrgDRDTy7MrdIM6cW4bNCv8/V2sVcwjhmx8+U/ekd9H4Xa2FklgpO3O8ucr8x69RZQLx8
 aSc35GoyVfyjODx0Mhky8unzXudQPuqFV3ODg50wQUxpQLG1/c91SBvryEPuJGAf3nZLdqj1I
 8gP0FNLzkxozHxWYZcYrsyZ1HFgNT/SKMXKrfSSUuATTZquPNO0kN6RQ834+BuC8yf1BF0gk1
 HEOMKMpFXR+R2XbeK7BfK6NbGOiZ59mKzFvGPHaQpl4VDktH5dTht1WJh2YpRGVVeXKA8e6FS
 IwDckGPI5SedCk6F3spkAGrx7YFytf2F2m8sqr99/+dMlaZsvS6gfQw/vOUtqeWqeclX2soxs
 W7bhBm3uZUsGag99KrGm680xHMqrQK30YaZM1EVPjFE2NH8YROHqLX1mLuoVSfh5HSxYRRKON
 I8FtFyfHTIfkqp8/Up70UqR1BAT7R55XfJl4J9192cLeIyyGF3DDuS6xYVzqIZcaWvWSLRGYa
 fPXnNyLK2NREuRAWBKUH3zD18tGyYHqriLSEfs/wrM/lDEycrXI6lw6papxSIqt2IxIFz/Am7
 DVqSoW3tWUrdOx4xjGZ++aohG7ULjH65BpfHBkobUEZv/QZPFkBjxWAo/d0O+hCv6H73U1en3
 eypmPacG80PXGDwy/JxNFKpHx5uDTaqh0Z93bD1H1EAuT/A3kmTod8ohX21CJZAldM/BHJHAT
 NTGdqgjlq3dlPbTfTl3kL+gcUl92RytjnO50szlGg3AvyAkOJCG0lQ7cXhz44+PiB5BUg=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 >  > In package windows.el, function `window-default-font-height' calls
 >  > function `face-font', which can return a nil value, but performs a
 >  > `string-equal' operation on the output without checking for that
 >  > possibiliy.
 >
 > Please report this to the author(s) of that package.

Sorry.  This function is missing from my current window.el here ...

 >  > I came across this in an unusual case, of having an 'emacs -nw' server
 >  > an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
 >  >  From that point forward until the fix, every *second* attempt to use the
 >  > minibuffer on the 'emacsclient -nw' would fail.
 >  >
 >  > The fix I'm using is:
 >  >
 >  >      (if (and (display-multi-font-p (frame-parameter frame 'display))
 >  >               (stringp default-font)  ; <<<---!!!
 >
 > What is `default-font'?

... and so I didn't catch this one either.  I'll try to find out what
I'm doing differently now.

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 14 May 2021 07:09:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 03:09:47 2021
Received: from localhost ([127.0.0.1]:44820 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhRxD-0006qi-2D
	for submit <at> debbugs.gnu.org; Fri, 14 May 2021 03:09:47 -0400
Received: from mout.gmx.net ([212.227.15.18]:54341)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1lhRxB-0006qT-1w
 for 48408 <at> debbugs.gnu.org; Fri, 14 May 2021 03:09:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1620976179;
 bh=QM86YQtnGFCPfPhtgkI1vzBJydFFMpkjnDwNt3BBunc=;
 h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To;
 b=BSvBrjYb683Ir9xxIHmax+zG+CQk7YuQrXRWiXRonKMvW3utELTiaz1BJssPLdcSU
 eZYgIa45UoThxowHocKUf8zUrL0v8gzQ29cidwzmYE7SqbEhSJQr/8siAgmd1+vXyY
 V9F9LeFzaC171D0Rz6pP9D8Q0nvADEBJB03ya6i0=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.100] ([212.95.5.218]) by mail.gmx.net (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mq2j2-1lCDiq44iQ-00n8Pl; Fri, 14
 May 2021 09:09:39 +0200
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
To: Boruch Baum <boruch_baum@HIDDEN>, 48408 <at> debbugs.gnu.org
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@HIDDEN>
Date: Fri, 14 May 2021 09:09:38 +0200
MIME-Version: 1.0
In-Reply-To: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K1:M8u/b702adv8G+Y7gGY56RkpghH+Ytysb2/MJrspkxHhCt1NDAw
 Gr7Cb7lsfbt4j7uaDWRL/csv7EYFXUaGwXqQCMFP6IGnHdljssaebGe0TF2B2fQC+5hgWHR
 yAc4DSNTuKnwk9sxQ73JsOOpHFqzywgfLGMWJVOjfsuTLeetWVA2e4fhzlb2CdvxUAHyC7L
 sUrPH3xBeGN5VRkb9w2aQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:aGVrtbCndLo=:rApgsi5JPd5Hq1PIDNk/Uh
 G5ahVKvlO4N82s+6GlRCh7ZytH4dB8BG7FsVei1y2MZlRtZbYmMkzWNKY1Rt+jXuuiCBsuPI4
 9WKFEdR8aFNRYkZPTIItJ3CuAyC+Fn89sSfUE73RvBjdhKuYa6b4N0yahZCeyfSAxC93SfHJJ
 fLdWX1yyZl5OryJiuG42vYBp5Zm3lkHVni4Zlctb6Q1p+sDa1VHNnk9DIgKuRdhPmRHVH/nUH
 iMIYsmU1NXKJStPfkwtyRnLmg9VJRJc16cvB8yBXRSLA40w+sXejxHeTnAxC1wI6PAjw850AC
 IXmbKmoscXgW5Op9H4dFSHOBQsARh7LvMcmXLGt6vliAeXM94uoBcqODkmXo+3zY+izDZE8Dj
 QxD9ibmNi+vaEZtrae3UXYgZieSQp6KV3wq8lAQkbcGiNzmpMb+WV06zF15lS/Z2xt4RUIwYk
 bKKIDKxH9FjCv46i2+sgSw4TzcuYT3U3ERkce8F5+yjZ+13+aIn91edHsZQxr7tNOjQK5EYSX
 HUFc+vO4PHhLabxwneFX7prKZZt3+x4ZyraHIRK7zJ8PIfRGNXh5p2LL+0tkcuFYDoib32AXN
 WrSUktC1uwQ8Pv+IDPJhRmbWV8YWRkgy0xE1E8rqyYvZzTO9TrPudklBILgjfd1ZTLrMUGVTf
 eP8rzFzLJ/wejQ6GFQRvbcLb5YiuXfbiPcDu4AxmLVHodzwapCT96fSlhkZ2w5YRcv7cqToYv
 Cm8rxfzxE7nDdhgyLvH2K0kAPxSAkNwKOv9p/YIYe1hhJ8sK4GajVgdJe1w5dVSQhyuPu1znw
 6SxOeJZx8rAxBzg2s8hobAVspKQAMk28ayfUZCzQMrw3fx4S/A+Sr36DtQH/Ce7X9T39uwK28
 fwZqQR61ZFLhTCqHQQjWX1hPzrSve3eAju6eDiLh3brEupCXJU6eriJcfHouU4FpH8Zv+ods/
 liG9AHf+5jw/voE/RI0moNEz+6EkStGHPFTuvYGX0I92oVvP5vMThUu/5Ae+Dy9mxajp4S3d6
 pFQyY4UQFNPiwekCf5NQMjGg4F/Q1DHng0uO3VKpWyfMwI5XPgY6jlFnKw9XVcxiJb+FIqpaH
 /eW7Eh0ivpSaiYS3DO0r7b9FM3AHg0Qyh338zwDy5xMIi1RTuOkJMEaSeBgGfS2XG+Ojqo6Yh
 i0FQLZf2pMDiBrRAXbh7zTCImfa4Py5AEXdLRZDROxGr9klTPzoMvoBD7BaKJMaNLzCA0=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48408
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 > In package windows.el, function `window-default-font-height' calls
 > function `face-font', which can return a nil value, but performs a
 > `string-equal' operation on the output without checking for that
 > possibiliy.

Please report this to the author(s) of that package.

 > I came across this in an unusual case, of having an 'emacs -nw' server
 > an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
 >  From that point forward until the fix, every *second* attempt to use the
 > minibuffer on the 'emacsclient -nw' would fail.
 >
 > The fix I'm using is:
 >
 >      (if (and (display-multi-font-p (frame-parameter frame 'display))
 >               (stringp default-font)  ; <<<---!!!

What is `default-font'?

 > 	     (not (string-equal (frame-parameter frame 'font) default-font)))
 >
 > But there could be other considerations to performing things in another way.

martin




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at 48408 <at> debbugs.gnu.org:


Received: (at 48408) by debbugs.gnu.org; 14 May 2021 06:39:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 02:39:10 2021
Received: from localhost ([127.0.0.1]:44789 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhRTa-000665-M6
	for submit <at> debbugs.gnu.org; Fri, 14 May 2021 02:39:10 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46790)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1lhRTZ-00065t-P2
 for 48408 <at> debbugs.gnu.org; Fri, 14 May 2021 02:39:10 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44438)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1lhRTU-0006op-Bs; Fri, 14 May 2021 02:39:04 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3522
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1lhRTT-0005FB-K5; Fri, 14 May 2021 02:39:04 -0400
Date: Fri, 14 May 2021 09:39:18 +0300
Message-Id: <83mtsxzund.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
In-Reply-To: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN> (message
 from Boruch Baum on Thu, 13 May 2021 21:15:19 -0400)
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
References: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48408
Cc: 48408 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 13 May 2021 21:15:19 -0400
> From: Boruch Baum <boruch_baum@HIDDEN>
> 
> In package windows.el, function `window-default-font-height' calls
> function `face-font', which can return a nil value, but performs a
> `string-equal' operation on the output without checking for that
> possibiliy.
> 
> I came across this in an unusual case, of having an 'emacs -nw' server
> an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
> From that point forward until the fix, every *second* attempt to use the
> minibuffer on the 'emacsclient -nw' would fail.

This means the problem is either in window-normalize-window or in
frame-parameter or in display-graphic-p, and should be fixed there.
Can you tell what does the below produce on the TTY frame where you
have this problem?

  M-: (frame-parameter nil 'display) RET
  M-: (window-frame (window-normalize-window nil t)) RET

> The fix I'm using is:
> 
>     (if (and (display-multi-font-p (frame-parameter frame 'display))
>              (stringp default-font)  ; <<<---!!!
> 	     (not (string-equal (frame-parameter frame 'font) default-font)))

No, that's not the right fix, IMO.  The code already takes care of not
assuming default-font is a string when on TTY frames, but the
condition doesn't work in this case for some reason.  We need to
understand why and fix that there.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 May 2021 01:15:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 13 21:15:32 2021
Received: from localhost ([127.0.0.1]:44576 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lhMQO-0006M5-E5
	for submit <at> debbugs.gnu.org; Thu, 13 May 2021 21:15:32 -0400
Received: from lists.gnu.org ([209.51.188.17]:34352)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <boruch_baum@HIDDEN>) id 1lhMQJ-0006Lx-UU
 for submit <at> debbugs.gnu.org; Thu, 13 May 2021 21:15:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:47950)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
 id 1lhMQJ-0006nR-Ka
 for bug-gnu-emacs@HIDDEN; Thu, 13 May 2021 21:15:27 -0400
Received: from mout.gmx.net ([212.227.17.22]:52281)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
 id 1lhMQH-0005te-Ml
 for bug-gnu-emacs@HIDDEN; Thu, 13 May 2021 21:15:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1620954922;
 bh=OC/8CcWIczVmtfYnXuuJ2ijD0GksODIfp6NLdcz5xnE=;
 h=X-UI-Sender-Class:Date:From:To:Subject;
 b=ZUu2NF0qoNEIBtkjv0cHX7Zr1dajpw0V63c71smpzfUEzJUtTwvx74rMcxKPwQ0+B
 Mmrb6UrgiiIZ6zLNeOxhUYtWbtWXQsdWPm0YfGywxvPiJBIapgXzN92PPnpbRnuwBP
 hIf6WnogRLIePAkTW8/q9D0MnBHflWs7m4lRxQlY=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([96.224.230.212]) by mail.gmx.net
 (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id
 1N3KTy-1lYwCx3Bqs-010Nlx for <bug-gnu-emacs@HIDDEN>; Fri, 14 May 2021
 03:15:22 +0200
Date: Thu, 13 May 2021 21:15:19 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Emacs Bug Reporting <bug-gnu-emacs@HIDDEN>
Subject: BUGFIX: window-default-font-height: check for nil string
Message-ID: <20210514011519.vsy5jbhyxd4v6kpt@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:TvLimKYKXX0FhVTk2+vIK+/jPNwMRJHyICRWDacH77HgSAEwxjY
 /OoUz1/Nr5NkpszfC+mz+SCVhist229JDkB+1WUu4d2LuXYgH9oVMND5vJerJkqvBSpFqBG
 Kp7k4CXvYfLiFAi42xgrChz5lnbNAeVs03m6Iv8e/6HmpNICjgvFHh0a9E9AqXqqBlvfFF/
 ge5+q52Y2kMerGzwEyvmQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Q89yacU8JpA=:SQXwToPsw2x/DQuYm2E9Yu
 ZVHejL8Pz7KNEpjuuEHmHxvjlp4s+yJp0zdZIMY51RVcBSK4e5+CKOF1yqgzVAxTMeELY4dhK
 tjkLspEYbo35OxzYhrDkZegPW7CDerFB0mZapwgg87Xg6/H1FPJJ44TKFEcIYoeNKbN6KPebe
 RHTtLK0zG/qNtVfXYJVs+i673voDhVh7fVmd6yyJiI8Hq0DpPQVybjIE9IWGUAUmUHkkHAB8h
 RY1oK1GMzsLxIGorA3Spwln3TvJ43CzCKvXuWVnnAXsqOpiq4eain8V8qIgARSneq1955RpOX
 TFhEYtt8IikYcFrY1VbCbWlp48EXPzqwB5K2t4+8IL99Fkny9HiTM13ejiFJGeSR3upYzYkGR
 JEwFzcmj0vN7PLqAg8smzbfxvPAoOg65nYVt+TA+wE4O1xYm4Ea4b/wHR/d4W+6haQGhoTEUC
 M3aJ2Z/kWCNVqSAADDmbz0jr/Hvm+eGQOndgcWllAJwLqzHqxK9m92V1LqWMrQw8EjGflVG5C
 bOaQKRq85qK8uGw169z4R6SRDoUJdO5pjHM3edyYbbh3NEXI7wSdl7frlNGAonVLxZtEEcQLY
 CHs3WUmk0dUhrBKZiA55wo/M9rZa1loEJwaq91I5Qk8atQPcQId6SB9kIComqqk512w/76WwF
 MxdURuF4E/Am810jl785hCU84tQPgWlNYKIckSLhnyx7CVGPz/UBvbOqO/fLiuZWD2tXz+kSZ
 /z5XYaPzcb6WD0DPqclWOQlQ8tWoFOgBfr2K7SDDVVjDGjkNtpjdRzxG2k1vLhko1zTPfODPK
 +spuXyA8nDWMDBymUUUKmZNkzHp8+MM1BXTw3tKt5r3w2kPAaEwDLhvdTly25CyuqPOmn2rxl
 mx5Kb1zZQkwRDMuOGHlhB5DMQ6pBi5UfRJDrGHvlKoionH8YAZYuLuQLqQ1frTzW7k5MGGXD5
 uCTWC13Ne/TYxx6P7jHjd3b0vz9EAYxj7qyNjLqNx8da07a+mQ477eTN9yVfCvxA2O8fMWPpT
 qyTZB+qJ/QjMwkOgHVDaC51A28I9q8xM92MVcm7kJBtgv1Nmt8Qx7GbWzS21Ci8/kDpHgQAdO
 jO5mNk5l7bSKP1npeD3sH3Kpu1AkZHKiGpxbnpzxzEUhz4+WTM5X48DZtHJU+CVYR+QePUtt7
 lg/sZWcfke/snJHCOwlC06yXDP9DFpRGnnBKsKycUZL1oK679Cf1EAybI+UCLjhj/Somo=
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=212.227.17.22; envelope-from=boruch_baum@HIDDEN;
 helo=mout.gmx.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.6 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

In package windows.el, function `window-default-font-height' calls
function `face-font', which can return a nil value, but performs a
`string-equal' operation on the output without checking for that
possibiliy.

I came across this in an unusual case, of having an 'emacs -nw' server
an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
=46rom that point forward until the fix, every *second* attempt to use the
minibuffer on the 'emacsclient -nw' would fail.

The fix I'm using is:

    (if (and (display-multi-font-p (frame-parameter frame 'display))
             (stringp default-font)  ; <<<---!!!
	     (not (string-equal (frame-parameter frame 'font) default-font)))

But there could be other considerations to performing things in another wa=
y.

=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0




Acknowledgement sent to Boruch Baum <boruch_baum@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#48408; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 19 May 2021 11:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.