Received: (at 48427-done) by debbugs.gnu.org; 29 May 2023 11:17:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 07:17:07 2023
Received: from localhost ([127.0.0.1]:57208 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q3as6-0001DN-MF
for submit <at> debbugs.gnu.org; Mon, 29 May 2023 07:17:06 -0400
Received: from mail1.fsfe.org ([217.69.89.151]:47636)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jlicht@HIDDEN>) id 1q3as5-0001DF-7J
for 48427-done <at> debbugs.gnu.org; Mon, 29 May 2023 07:17:06 -0400
From: Jelle Licht <jlicht@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501;
t=1685359024;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=xSwUTjnsxHkREB9ehF9XMEIBFwoMsb+Pjm2maYGFIh8=;
b=oAQo0lTSCgopn6yFJzBUbv5PJDw2N5lv9BhxEH2tsws+d6QpE6eQ6UmuArCjFYdW1L+pth
U1k5KNxFR0RnqNkPuo0b4icc8d9myeGGoWmx9sB3N7hMuzMX46E3bXu0Bbs9KvYCPVWXlC
s4RV1IEmJVGZ/13NimBJDtrCiwKrASg=
To: Stefan =?utf-8?Q?Reich=C3=B6r?= <stefan@HIDDEN>
Subject: Re: bug#48427: [PATCH 3/5] gnu: Add python-aiostream.
In-Reply-To: <20210529203841.157978-1-stefan@HIDDEN> ("Stefan
=?utf-8?Q?Reich=C3=B6r=22's?=
message of "Sat, 29 May 2021 22:38:41 +0200")
References: <20210514211746.143145-3-stefan@HIDDEN>
<20210529203841.157978-1-stefan@HIDDEN>
Date: Mon, 29 May 2023 13:17:03 +0200
Message-ID: <87jzwro09c.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 48427-done
Cc: 48427-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Stefan Reich=C3=B6r <stefan@HIDDEN> writes:
> * gnu/packages/python-xyz.scm (python-aiostream): New variable.
[snip]
Superseded by commit ed18b697c4783f139e23731f5bd0b0ed197997bb, closing.
Stefan Reichör <stefan@HIDDEN>:Jelle Licht <jlicht@HIDDEN>:
Received: (at 48427) by debbugs.gnu.org; 29 May 2021 20:38:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 29 16:38:50 2021
Received: from localhost ([127.0.0.1]:57778 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ln5jN-0000Y0-Un
for submit <at> debbugs.gnu.org; Sat, 29 May 2021 16:38:50 -0400
Received: from dd3624.kasserver.com ([85.13.130.11]:41330)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefan@HIDDEN>) id 1ln5jM-0000Xs-E7
for 48427 <at> debbugs.gnu.org; Sat, 29 May 2021 16:38:48 -0400
Received: from localhost (217-149-163-5.nat.highway.telekom.at [217.149.163.5])
by dd3624.kasserver.com (Postfix) with ESMTPA id DC3695D404D4;
Sat, 29 May 2021 22:38:46 +0200 (CEST)
From: =?UTF-8?q?Stefan=20Reich=C3=B6r?= <stefan@HIDDEN>
To: 48427 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-aiostream.
Date: Sat, 29 May 2021 22:38:41 +0200
Message-Id: <20210529203841.157978-1-stefan@HIDDEN>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48427
Cc: =?UTF-8?q?Stefan=20Reich=C3=B6r?= <stefan@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
* gnu/packages/python-xyz.scm (python-aiostream): New variable.
---
Vinicius, thanks for your review.
Here is my attempt to follow your hints
gnu/packages/python-xyz.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9b9510f043..a465ecbda6 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -20232,6 +20232,35 @@ generators and Python 3.7's context managers into Python 3.5.")
manager compatible with @code{asyncio}.")
(license license:asl2.0)))
+(define-public python-aiostream
+ (package
+ (name "python-aiostream")
+ (version "0.4.3")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/vxgmichel/aiostream")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1r3x9qwl08yscmzvhafc6gsmq84lr17s6p7a1qxr49cmdvjzsc13"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:test-target "pytest"))
+ (native-inputs
+ `(("python-pytest" ,python-pytest)
+ ("python-pytest-asyncio" ,python-pytest-asyncio)
+ ("python-pytest-cov" ,python-pytest-cov)
+ ("python-pytest-runner" ,python-pytest-runner)))
+ (home-page "https://github.com/vxgmichel/aiostream")
+ (synopsis "Generator-based operators for asynchronous iteration")
+ (description "aiostream provides a collection of stream operators that can
+be combined to create asynchronous pipelines of operations. It can be seen as
+an asynchronous version of itertools, although some aspects are slightly
+different.")
+ (license license:gpl3)))
+
(define-public python-glob2
(package
(name "python-glob2")
--
2.25.1
guix-patches@HIDDEN:bug#48427; Package guix-patches.
Full text available.
Received: (at 48427) by debbugs.gnu.org; 18 May 2021 22:31:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 18 18:31:31 2021
Received: from localhost ([127.0.0.1]:57549 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lj8FO-0007gm-IG
for submit <at> debbugs.gnu.org; Tue, 18 May 2021 18:31:31 -0400
Received: from mout01.posteo.de ([185.67.36.65]:33861)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monego@HIDDEN>) id 1lj8FH-0007gT-2q
for 48427 <at> debbugs.gnu.org; Tue, 18 May 2021 18:31:29 -0400
Received: from submission (posteo.de [89.146.220.130])
by mout01.posteo.de (Postfix) with ESMTPS id A539C240027
for <48427 <at> debbugs.gnu.org>; Wed, 19 May 2021 00:31:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1621377076; bh=y4H8N5EHj5orogYZ4Ved4Xm4TTK3dHp87PKh065+Zp8=;
h=Subject:From:To:Date:From;
b=Lkb5wTJFoAMTHeTEBuD3sNO+Ue2I//PA6lrSqT4uQH8Q6Zg9Ehm9OznSZtnWt5yES
mq/DJFHr7+EK+P2lu3kqTzgk+9vrrwRXh2pgLE/5D2Qz8f+kAj0qrq/Tdr+3bpFdD+
l17iVJdN1zwm4dW+YYcVQuyPI55J/pAUGq6RdD9tOwQWTANCP71FW3LfEJh6m5TJEQ
P6TGrBQf3OFtH/VWtX+UFl6IJWqmFzVdnGGWzSsL8doMl/p4J2V4WvA9CWbmojgNu9
1+kp3v9P+Bvqwt1aIiFearzNXeXFDPNfKDsrPfT97yB07uJjvsKZ2XmyjK/nF9y7tS
4umgMPQQH+I+Q==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4Fl9hL6C5Gz9rxM;
Wed, 19 May 2021 00:31:14 +0200 (CEST)
Message-ID: <43a07625ab314d5a9f75a0e883de06c889d76c1e.camel@HIDDEN>
Subject: Re: [PATCH 3/5] gnu: Add python-aiostream.
From: Vinicius Monego <monego@HIDDEN>
To: Stefan =?ISO-8859-1?Q?Reich=F6r?= <stefan@HIDDEN>,
48427 <at> debbugs.gnu.org
Date: Tue, 18 May 2021 22:31:06 +0000
In-Reply-To: <20210514211746.143145-3-stefan@HIDDEN>
References: <20210514211746.143145-1-stefan@HIDDEN>
<20210514211746.143145-3-stefan@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48427
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Em sex, 2021-05-14 às 23:17 +0200, Stefan Reichör escreveu:
> * gnu/packages/python-xyz.scm (python-aiostream): New variable.
Thank you.
>
> +(define-public python-aiostream
> + (package
> + (name "python-aiostream")
> + (version "0.4.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "aiostream" version))
> + (sha256
> + (base32
> +
> "1k33bxrp24pa7c3hygzkv0lqvjil689aj442hzhgzv8vsbqmwd1n"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f)) ; tests fail, not sure why
Tests are not included in the PyPI tarball. That happens often in the
Python ecosystem, and in those cases we fetch directly from the
upstream repository.
After changing the source and adding #:test-target "pytest" to the
arguments (requires python-pytest-runner which is already there), I
could succesfully build the project with tests:
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/vxgmichel/aiostream")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"1r3x9qwl08yscmzvhafc6gsmq84lr17s6p7a1qxr49cmdvjzsc13"))))
(arguments
`(#:test-target "pytest"))
Note that python-build-system will run "python setup.py test" which is
used for unittest tests. If the project uses Pytest, as many do, we
often have to be explicit in the build either by adding #:test-target
"pytest" to the arguments and python-pytest-runner to native-inputs, or
by replacing the check phase and invoking pytest manually. Since
pytest-runner was deprecated recently, I believe the latter is the
better option from now on. The build could succeed without being
explicit, but you will see a message like "0 tests ran succesfully".
That may have happened in patches 2 and 5 from the series.
> + (home-page
> + "https://github.com/vxgmichel/aiostream")
> + (synopsis
> + "Generator-based operators for asynchronous iteration")
We don't break lines for the arguments of home-page and synopsis. The
pypi importer will add them by default, but they should be removed
while editing.
In the description, I'd replace "aiostream" with "@code{aiostream}".
The LICENSE file states GPL 3, though there are no copyright headers to
say "any later version". setup.py also says "gplv3". I'm guessing the
license should be gpl3 only, though I'm not sure about that one.
LGTM otherwise.
Could you check the rest of the series to see if the tests are running
correctly and then send a v2? I am not a committer and can't apply it
myself, so I have to leave that part for somebody else.
Vinicius
guix-patches@HIDDEN:bug#48427; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 14 May 2021 21:18:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 14 17:18:07 2021
Received: from localhost ([127.0.0.1]:47191 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lhfCB-0003r6-6l
for submit <at> debbugs.gnu.org; Fri, 14 May 2021 17:18:07 -0400
Received: from lists.gnu.org ([209.51.188.17]:60108)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefan@HIDDEN>) id 1lhfC7-0003qY-2F
for submit <at> debbugs.gnu.org; Fri, 14 May 2021 17:18:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48052)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <stefan@HIDDEN>) id 1lhfC6-00039s-Tj
for guix-patches@HIDDEN; Fri, 14 May 2021 17:18:02 -0400
Received: from dd3624.kasserver.com ([85.13.130.11]:55818)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <stefan@HIDDEN>) id 1lhfC5-0008GO-Ea
for guix-patches@HIDDEN; Fri, 14 May 2021 17:18:02 -0400
Received: from localhost (37-186-9-252.ip.as39912.net [37.186.9.252])
by dd3624.kasserver.com (Postfix) with ESMTPA id 6F7775D405CB;
Fri, 14 May 2021 23:17:59 +0200 (CEST)
From: =?UTF-8?q?Stefan=20Reich=C3=B6r?= <stefan@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 3/5] gnu: Add python-aiostream.
Date: Fri, 14 May 2021 23:17:44 +0200
Message-Id: <20210514211746.143145-3-stefan@HIDDEN>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20210514211746.143145-1-stefan@HIDDEN>
References: <20210514211746.143145-1-stefan@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: none client-ip=85.13.130.11; envelope-from=stefan@HIDDEN;
helo=dd3624.kasserver.com
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?q?Stefan=20Reich=C3=B6r?= <stefan@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
* gnu/packages/python-xyz.scm (python-aiostream): New variable.
---
gnu/packages/python-xyz.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 98368129ed..8e769c08f2 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -20187,6 +20187,36 @@ generators and Python 3.7's context managers into Python 3.5.")
manager compatible with @code{asyncio}.")
(license license:asl2.0)))
+(define-public python-aiostream
+ (package
+ (name "python-aiostream")
+ (version "0.4.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "aiostream" version))
+ (sha256
+ (base32
+ "1k33bxrp24pa7c3hygzkv0lqvjil689aj442hzhgzv8vsbqmwd1n"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:tests? #f)) ; tests fail, not sure why
+ ;; (native-inputs
+ ;; `(("python-pytest" ,python-pytest)
+ ;; ("python-pytest-asyncio" ,python-pytest-asyncio)
+ ;; ("python-pytest-cov" ,python-pytest-cov)
+ ;; ("python-pytest-runner" ,python-pytest-runner)))
+ (home-page
+ "https://github.com/vxgmichel/aiostream")
+ (synopsis
+ "Generator-based operators for asynchronous iteration")
+ (description
+ "aiostream provides a collection of stream operators that can be
+combined to create asynchronous pipelines of operations. It can be seen as an
+asynchronous version of itertools, although some aspects are slightly
+different.")
+ (license license:gpl3+)))
+
(define-public python-glob2
(package
(name "python-glob2")
--
2.25.1
Stefan Reichör <stefan@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#48427; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.