GNU bug report logs - #48536
‘emacs-org-super-agenda’ is broken.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48536 in the body.
You can then email your comments to 48536 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: bug-guix <at> gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: ‘emacs-org-super-agenda’ is broken.
Date: Thu, 20 May 2021 15:59:03 +0200

[Message part 1 (text/plain, inline)]

Hi,

Commit 71045f4e6425a686667cf30252a2a71cff36308b (“gnu: emacs-org: Update
to 9.4.6.”) seems to break a test in ‘emacs-org-super-agenda’[1], this
also breaks three other packages that depend on it.

Any ideas why this happens?

--8<---------------cut here---------------start------------->8---
Test org-super-agenda-test--:auto-tags backtrace:
  signal(error ("Test failed for body:a5c8edc0db4a93c039964c5762e70...
  error("Test failed for body:%s\nDIFF:\n %s" "a5c8edc0db4a93c039964c5
  (or (equal stored-result new-result) (if (and stored-result new-resu
  (let ((stored-result (gethash body-groups-hash org-super-agenda-test
  (if org-super-agenda-test-show-results nil (let ((stored-result (get
  (let ((body-groups-hash (secure-hash 'md5 (format "%S" (list '(org-a
  (progn (if (> (hash-table-count org-super-agenda-test-results) 0) ni
  (setq value-129 (progn (if (> (hash-table-count org-super-agenda-tes
  (unwind-protect (setq value-129 (progn (if (> (hash-table-count org-
  (if (unwind-protect (setq value-129 (progn (if (> (hash-table-count 
  (let (form-description-130) (if (unwind-protect (setq value-129 (pro
  (let ((value-129 (gensym "ert-form-evaluation-aborted-"))) (let (for
  (closure (t) nil (let ((value-129 (gensym "ert-form-evaluation-abort
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-super-agenda-test--:auto-tags :do
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("--eval" "(message \"Org version: %s\" (org-version)
  command-line()
  normal-top-level()
Test org-super-agenda-test--:auto-tags condition:
    (error "Test failed for body:a5c8edc0db4a93c039964c5762e70420
DIFF:
 @@ -10,6 +10,12 @@
  Tags: @town, personal
   test:       Scheduled:  TODO [#C] Get haircut                                                                       :personal:@town:
 
+ Tags: Emacs, computers, elisp, programming, software
+  ideas:      Scheduled:  SOMEDAY Rewrite Emacs in Common Lisp                            :Emacs:elisp:computers:software:programming:
+
+ Tags: Emacs, website
+  test:       Deadline:   CHECK /r/emacs                                                                               :website:Emacs:
+
  Tags: ambition, meetings, universe, world
   ambition:   Sched. 1x:  TODO [#A] Skype with president of Antarctica                             :universe:ambition:world::meetings:
 
@@ -35,15 +41,9 @@
  Tags: bills, spaceship
   test:       In  27 d.:  TODO [#A] Spaceship lease                                                                  :bills:spaceship:
 
- Tags: computers, elisp, emacs, programming, software
-  ideas:      Scheduled:  SOMEDAY Rewrite Emacs in Common Lisp                            :Emacs:elisp:computers:software:programming:
-
  Tags: dinner, food
   test:       18:00...... Scheduled:  TODO Order a pizza                                                                 :food:dinner:
 
- Tags: emacs, website
-  test:       Deadline:   CHECK /r/emacs                                                                               :website:Emacs:
-
  Other items
   test:        7:02...... Sunrise (12:04 of daylight)
                8:00...... ----------------
")
   FAILED   7/66  org-super-agenda-test--:auto-tags (0.076881 sec)
--8<---------------cut here---------------end--------------->8---

[1]: https://ci.guix.gnu.org/build/391929/details

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: bug-guix <at> gnu.org
Subject: Re: ‘emacs-org-super-agenda’ is broken.
Date: Thu, 20 May 2021 20:03:42 +0200

Hello,

Xinglu Chen <public <at> yoctocell.xyz> writes:

> Commit 71045f4e6425a686667cf30252a2a71cff36308b (“gnu: emacs-org: Update
> to 9.4.6.”) seems to break a test in ‘emacs-org-super-agenda’[1], this
> also breaks three other packages that depend on it.
>
> Any ideas why this happens?

Not really. It seems like a capitalization problem. Maybe we should skip
the failing test.

WDYT?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 48536 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 48536 <at> debbugs.gnu.org
Subject: Re: bug#48536: ‘emacs-org-super-agenda’
 is broken.
Date: Thu, 20 May 2021 22:25:15 +0200

[Message part 1 (text/plain, inline)]

On Thu, May 20 2021, Nicolas Goaziou wrote:

> Hello,
>
> Xinglu Chen <public <at> yoctocell.xyz> writes:
>
>> Commit 71045f4e6425a686667cf30252a2a71cff36308b (“gnu: emacs-org: Update
>> to 9.4.6.”) seems to break a test in ‘emacs-org-super-agenda’[1], this
>> also breaks three other packages that depend on it.
>>
>> Any ideas why this happens?
>
> Not really. It seems like a capitalization problem. Maybe we should skip
> the failing test.
>
> WDYT?

Yeah, that sounds good to me.

I have done that in the attached patch.

[0001-gnu-emacs-org-super-agenda-Disable-failing-test.patch (text/x-patch, inline)]

From 6a17f3a38be2df199ef003f101fcd1445e1ccfbf Mon Sep 17 00:00:00 2001
Message-Id: <6a17f3a38be2df199ef003f101fcd1445e1ccfbf.1621542224.git.public <at> yoctocell.xyz>
From: Xinglu Chen <public <at> yoctocell.xyz>
Date: Thu, 20 May 2021 22:18:31 +0200
Subject: [PATCH] gnu: emacs-org-super-agenda: Disable failing test.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/emacs-xyz.scm (emacs-org-super-agenda)[arguments]<#:phases>:
Disable the “org-super-agenda-test--:auto-tags” test.  The test failure was
caused by commit 71045f4e6425a686667cf30252a2a71cff36308b.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2af42f8842..294ed92981 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16169,7 +16169,7 @@ as well as functions for navigating between these headings.")
              ;; The following test fail (see:
              ;; https://github.com/alphapapa/org-super-agenda/issues/183).
              (substitute* "test/test.el"
-               ((".*org-super-agenda-test--:auto-map.*" all)
+               ((".*org-super-agenda-test--:auto-(map|tags).*" all)
                 (string-append all "  (skip-unless nil)\n")))
              #t)))))
     (native-inputs

base-commit: 7ff515aa511afbaf177a8bde68bde6a3878ca447
-- 
2.31.1

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 48536-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48536-done <at> debbugs.gnu.org
Subject: Re: bug#48536: ‘emacs-org-super-agenda’
 is broken.
Date: Thu, 20 May 2021 23:40:05 +0200

Hello,

Xinglu Chen <public <at> yoctocell.xyz> writes:

> Subject: [PATCH] gnu: emacs-org-super-agenda: Disable failing test.

That was quick! :)

Applied. Thank you!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.