GNU bug report logs - #48551
[PATCH] gnu: Add font-victor-mono

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48551 in the body.
You can then email your comments to 48551 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: aecepoglu <aecepoglu <at> fastmail.fm>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add font-victor-mono
Date: Fri, 21 May 2021 02:10:30 +0300

* gnu/packages/fonts.scm (font-victor-mono): New variable.
---
 gnu/packages/fonts.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 039a9e5b4a..8461729230 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1971,6 +1971,26 @@ always uses Farsi digits, and does not include Latin glyphs from Roboto.
             "file://LICENSE" "Bitstream Vera License")
            license:asl2.0))))           ; Latin glyphs from Roboto
 
+(define-public font-victor-mono
+  (package
+   (name "font-victor-mono")
+   (version "1.4.2")
+   (source (origin
+            (method url-fetch/zipbomb)
+            (uri (string-append
+                       "https://github.com/rubjo/victor-mono/raw/v"
+                       version
+                       "/public/VictorMonoAll.zip"))
+            (sha256 "01260vja0d22mcvkzspf0xnl7b851r0265arqkm12q1vagzyxvkm")))
+   (build-system font-build-system)
+   (synopsis "Font with support for italics and ligatures")
+   (description "Victor Mono is an open-source monospaced font with
+optional semi-connected cursive italics and programming symbol ligatures.
+This package provides only TrueType files (TTF).
+It comes in seven weights and Roman, Italic and Oblique styles.")
+   (home-page "https://rubjo.github.io/victor-mono")
+   (license license:expat)))
+
 (define-public font-meera-inimai
   (package
     (name "font-meera-inimai")
-- 
2.31.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: aecepoglu <aecepoglu <at> fastmail.fm>, 48551-done <at> debbugs.gnu.org
Cc: guix-patches <at> gnu.org
Subject: Re: [bug#48551] [PATCH] gnu: Add font-victor-mono
Date: Fri, 21 May 2021 13:35:34 +0200

On Fri, 2021-05-21 at 02:10 +0300, aecepoglu wrote:
> * gnu/packages/fonts.scm (font-victor-mono): New variable.
> ---
>  gnu/packages/fonts.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 039a9e5b4a..8461729230 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -1971,6 +1971,26 @@ always uses Farsi digits, and does not include
> Latin glyphs from Roboto.
>              "file://LICENSE" "Bitstream Vera License")
>             license:asl2.0))))           ; Latin glyphs from Roboto
>  
> +(define-public font-victor-mono
> +  (package
> +   (name "font-victor-mono")
> +   (version "1.4.2")
> +   (source (origin
> +            (method url-fetch/zipbomb)
> +            (uri (string-append
> +                       "https://github.com/rubjo/victor-mono/raw/v"
> +                       version
> +                       "/public/VictorMonoAll.zip"))
> +            (sha256
> "01260vja0d22mcvkzspf0xnl7b851r0265arqkm12q1vagzyxvkm")))
> +   (build-system font-build-system)
> +   (synopsis "Font with support for italics and ligatures")
> +   (description "Victor Mono is an open-source monospaced font with
> +optional semi-connected cursive italics and programming symbol
> ligatures.
> +This package provides only TrueType files (TTF).
> +It comes in seven weights and Roman, Italic and Oblique styles.")
> +   (home-page "https://rubjo.github.io/victor-mono")

I added a / to the end of the URI as indicated by "guix lint".

> +   (license license:expat)))
> +
>  (define-public font-meera-inimai
>    (package
>      (name "font-meera-inimai")

Otherwise, LGTM!  I pushed this patch (with the slight modification) in
652a03888e1609bd1a687326760436867fe2abb7.

Thank you!

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.