GNU bug report logs - #48573
[PATCH 0/2] gnu: botan: Update and respect #:tests?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48573 in the body.
You can then email your comments to 48573 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: botan: Update and respect #:tests?
Date: Fri, 21 May 2021 15:35:05 -0400 (EDT)

This seriers updates botan to the newest release, and improves the check 
phase to respect #:tests?

I've tested that it builds reproducably on x86_64-linux and that it builds 
(via qemu) for aarch64-linux. `guix refresh -l` reports one dependent 
package, rnp, which builds with this update.

Jack Hill (2):
  gnu: botan: Update to 2.18.1.
  gnu: botan: Respect #:tests?.

 gnu/packages/crypto.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.31.1

Best,
Jack

Message #8 received at 48573 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 48573 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: botan: Respect #:tests?.
Date: Fri, 21 May 2021 15:40:39 -0400

* gnu/packages/crypto.scm (botan)[arguments]: Respect #:tests? in the 'check
phase.
---
 gnu/packages/crypto.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index f333aced1b..674cb05801 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -976,7 +976,9 @@ SHA256, SHA512, SHA3, AICH, ED2K, Tiger, DC++ TTH, BitTorrent BTIH, GOST R
          (add-before 'check 'library-path-for-tests
            (lambda _ (setenv "LD_LIBRARY_PATH" (getcwd))))
          (replace 'check
-           (lambda _ (invoke "./botan-test"))))))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (if tests?
+                 (invoke "./botan-test")))))))
     (native-inputs
      `(("python" ,python-wrapper)
        ("python-docutils" ,python-docutils)))
-- 
2.31.1

Message #11 received at 48573 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 48573 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: botan: Update to 2.18.1.
Date: Fri, 21 May 2021 15:40:38 -0400

* gnu/packages/crypto.scm (botan): Update to 2.18.1.
---
 gnu/packages/crypto.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 2658c38cb4..f333aced1b 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -944,14 +944,14 @@ SHA256, SHA512, SHA3, AICH, ED2K, Tiger, DC++ TTH, BitTorrent BTIH, GOST R
 (define-public botan
   (package
     (name "botan")
-    (version "2.17.3")
+    (version "2.18.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://botan.randombit.net/releases/"
                                   "Botan-" version ".tar.xz"))
               (sha256
                (base32
-                "121vn1aryk36cpks70kk4c4cfic5g0qs82bf92xap9258ijkn4kr"))))
+                "0adf53drhk1hlpfih0175c9081bqpclw6p2afn51cmx849ib9izq"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases
-- 
2.31.1

Message #16 received at 48573-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 48573-done <at> debbugs.gnu.org
Subject: Re: [bug#48573] [PATCH 0/2] gnu: botan: Update and respect #:tests?
Date: Thu, 27 May 2021 13:56:40 -0400

On Fri, May 21, 2021 at 03:35:05PM -0400, Jack Hill wrote:
> This seriers updates botan to the newest release, and improves the check
> phase to respect #:tests?
> 
> I've tested that it builds reproducably on x86_64-linux and that it builds
> (via qemu) for aarch64-linux. `guix refresh -l` reports one dependent
> package, rnp, which builds with this update.

Thanks for the patch and for mentioning how you tested it! That's very
helpful.

Pushed as d1b3b5b73da9a87991246ec40f6fd64e70b4e33a

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.