Received: (at 48584) by debbugs.gnu.org; 25 May 2021 20:23:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 25 16:23:46 2021
Received: from localhost ([127.0.0.1]:47033 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lldac-0005Zv-Eh
for submit <at> debbugs.gnu.org; Tue, 25 May 2021 16:23:46 -0400
Received: from mail-oi1-f171.google.com ([209.85.167.171]:46821)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <p.stephani2@HIDDEN>) id 1lldaZ-0005Zi-TZ
for 48584 <at> debbugs.gnu.org; Tue, 25 May 2021 16:23:45 -0400
Received: by mail-oi1-f171.google.com with SMTP id x15so31443138oic.13
for <48584 <at> debbugs.gnu.org>; Tue, 25 May 2021 13:23:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=6FqmSHcNpA1IblSThcIPtPrQK+yqQ1LFRiR5TQvoWu4=;
b=C9+6EnY4LhX9q5yA633eblKs+hNwA0gX4eGZT09//FXwgByBGKthV/IW+bz4eMZ03y
wtNRy9oup2skyrjmQT307tvFFK7XFhSa3pBKCQRq1nI7eEe0NW2Q/VuKenc7lrbxjKAx
PDHcZ87SNDvNASmvMtYwwkbH8so9QsX/QemM45H+S7l7inh1PDhA3RTOe3dT+fie3J9a
8Fa9x/PeXmaifoSyjQuiGoQqp17cvEKNPACbyEKnOje3eV0qgdj6MuhAa1oZTCTkZlt4
wmohJORihOqf9qzZzomUz6r6PP4DOmcM/1QKWnZGXskhiYa+e6sTjamHBm/0Q++2xteo
fwgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=6FqmSHcNpA1IblSThcIPtPrQK+yqQ1LFRiR5TQvoWu4=;
b=gBzTawjMMmFGjmF2jK/FP4caK/0sVJUrrDa8NkRzXOak9rF+Tf9EqzfVraOHc0wksB
LZkIsYDjIzlRmq/ewlMg08dStaU4AioniDoKMUj/FGThUtghkP7egEx2S+cXzEEU+znU
Glv4EjKcGuGMvnfX0eHsFHQqUGCPiLigpJip2/5bkwEMLR/Za3Oewdkt2JLX/Zd1UjwD
vq3/8qMsK/pWp4OvLIpXNa0IanM6MZcLhhwTgHyNjN3aCHlN8MzxYdKulWa28PuOmO1S
edXHIROusLDbUtu6C5QWrRKQx4JcQrPagkXI9iaNfcJyDTPoKMs7k/0jsHASciLn2qCj
qlzQ==
X-Gm-Message-State: AOAM532M/xN8IzJS+awNlqO4g+ILqxB0WvBfqx2hlGoXfwR6Blyrk6gp
4OBV7UWFgPCXGAld5rmf5DOliRRMAKq667FD3AE=
X-Google-Smtp-Source: ABdhPJz+o7ntSrAltuPOp3QcEyf8PxBe0J5cnX+KNRLXZ5mWYTV/huGeHsGxiAMSkSr9UiEkgdko2LYb82ZVvftxUnY=
X-Received: by 2002:aca:4d01:: with SMTP id a1mr15452094oib.158.1621974218121;
Tue, 25 May 2021 13:23:38 -0700 (PDT)
MIME-Version: 1.0
References: <m2im3bvwsu.fsf@HIDDEN> <871r9uefvy.fsf@HIDDEN>
In-Reply-To: <871r9uefvy.fsf@HIDDEN>
From: Philipp Stephani <p.stephani2@HIDDEN>
Date: Tue, 25 May 2021 22:23:26 +0200
Message-ID: <CAArVCkSZt2-hfHr=-eXCYmuzZYpUuoyTEiY+pBNDZytC9ZyRfA@HIDDEN>
Subject: Re: bug#48584: 28.0.50; Incorrect hook ordering between local and
global hooks with depth
To: Lars Ingebrigtsen <larsi@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 48584
Cc: 48584 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
Am Di., 25. Mai 2021 um 22:07 Uhr schrieb Lars Ingebrigtsen <larsi@HIDDEN>:
>
> So... I don't see any obvious way to fix this, and perhaps we should
> just document that the order is undefined when you have both local and
> global hooks with the same name.
>
> Any opinions?
The order isn't undefined, and add-hook carefully distinguishes
between negative and nonnegative depths in this case. It's just that
the relative ordering of depths with the same sign but different
"localness" isn't considered/documented.
How about documenting something along those lines?
In "Running hooks", amend the paragraph
"If the hook variable is buffer-local, the buffer-local variable will
be used instead of the global variable. However, if the buffer-local
variable contains the element @code{t}, the global hook variable will
be run as well."
to say that the global hook is run at exactly the place where the "t" appears.
In "Setting hooks", amend the paragraph
"If @var{local} is non-@code{nil}, that says to add @var{function} to the
buffer-local hook list instead of to the global hook list. This makes
the hook buffer-local and adds @code{t} to the buffer-local value."
to specify where the "t" is added (IIUC it's appended if depth > 0 and
prepended otherwise).
bug-gnu-emacs@HIDDEN:bug#48584; Package emacs.
Full text available.Received: (at 48584) by debbugs.gnu.org; 25 May 2021 20:07:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 25 16:07:58 2021 Received: from localhost ([127.0.0.1]:46977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lldLK-0002u2-0I for submit <at> debbugs.gnu.org; Tue, 25 May 2021 16:07:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1lldLG-0002tm-Pq for 48584 <at> debbugs.gnu.org; Tue, 25 May 2021 16:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=h+JW82ZQ1Xl/tVyVd3q6I71+7+5A38gf41IPvGkYQKo=; b=pHTSXQrFd0rt9DAjs84IZueEF+ m6J8zDEWmKsr3J/oCC3BaWmfi+GGno0yVX/aqOfDBLs/6z0zoHf7DxnpkD+LOYmcHFcqPAFTMohbS uQfzdVKn7GIIgT0j/+QQYvJz0Poz2c90Bw4v7TBt8Nfqnr5bcKOidGS3R9SQ+KP2ri9o=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1lldL8-0004fK-15; Tue, 25 May 2021 22:07:48 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Philipp <p.stephani2@HIDDEN> Subject: Re: bug#48584: 28.0.50; Incorrect hook ordering between local and global hooks with depth References: <m2im3bvwsu.fsf@HIDDEN> X-Now-Playing: Satomimagae's _awa_: "Hono" Date: Tue, 25 May 2021 22:07:45 +0200 In-Reply-To: <m2im3bvwsu.fsf@HIDDEN> (Philipp's message of "Sat, 22 May 2021 13:21:21 +0200") Message-ID: <871r9uefvy.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp <p.stephani2@HIDDEN> writes: > Evaluate these forms: > > (add-hook 'my-hook (lambda () (message "Outer")) 20) > (with-temp-buffer > (add-hook 'my-hook (lambda () (message "Inner")) 10 :local) > (run-hooks 'my-hook)) > > Then in t [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48584 Cc: 48584 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Philipp <p.stephani2@HIDDEN> writes: > Evaluate these forms: > > (add-hook 'my-hook (lambda () (message "Outer")) 20) > (with-temp-buffer > (add-hook 'my-hook (lambda () (message "Inner")) 10 :local) > (run-hooks 'my-hook)) > > Then in the *Messages* buffer, "Inner" appears *after* "Outer" even > though the local function's depth is lower than the global one's. Looking at the code, the order is computed by `add-hook' by stashing data in the symbol plist of my-hook, but the hook function is then pushed onto either the local or the global version of the variable. So the ordering isn't global -- it's one ordering for the local and one for the global, and `run-hooks' doesn't say anything about what order the local and global values are run in? (The global value is run when `t' appears in the local value.) So... I don't see any obvious way to fix this, and perhaps we should just document that the order is undefined when you have both local and global hooks with the same name. Any opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#48584; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 22 May 2021 11:21:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 22 07:21:30 2021 Received: from localhost ([127.0.0.1]:38379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lkPhC-0001SD-G6 for submit <at> debbugs.gnu.org; Sat, 22 May 2021 07:21:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:44986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <p.stephani2@HIDDEN>) id 1lkPhA-0001S4-JK for submit <at> debbugs.gnu.org; Sat, 22 May 2021 07:21:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <p.stephani2@HIDDEN>) id 1lkPhA-0008To-7O for bug-gnu-emacs@HIDDEN; Sat, 22 May 2021 07:21:28 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:56045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <p.stephani2@HIDDEN>) id 1lkPh7-0008UV-Qx for bug-gnu-emacs@HIDDEN; Sat, 22 May 2021 07:21:27 -0400 Received: by mail-wm1-x332.google.com with SMTP id b7so11834554wmh.5 for <bug-gnu-emacs@HIDDEN>; Sat, 22 May 2021 04:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=dtMGqCcktWYEIvjFmnb++xvMGyg6sSYC0mrvhB8LXng=; b=JOuY1HSvxdZPY7QG3+i0Wmhc07NKEFmF0ILenDwoSfZ1Y/GT+Ula71X0qTGegCB+q3 A4Et1CUK2Ebp8sj2dYqLBW6gq1Xn9yv/s8uTBlWRBxsZPLi+ChqNYpl48aukn2gUJeGv ofdsUmtp5qT1iu6jYSJhTLV9/TtoyPdXams4ssgW1EamkiC0el9S1YVYvwZ0lO6lYYFw TMq3ZYjculO6FMeSPLZGe0C+D5KBXF055ajbPhzMn9P8AWK/8UQbgikhDm2zCDSEylJy r2J1KgoTynRFS9ppfzEDStolTUEtph4Kf8YApzPUVNWWP6dY19DemhIR0kLPRneIr6Ds eBvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=dtMGqCcktWYEIvjFmnb++xvMGyg6sSYC0mrvhB8LXng=; b=GaAZ0ulJPJLvKAWHTnCxeeDL0e/Dn/qybwK05XPKCM+RSJ6xCFCCF4OxpPU/E09yd1 emVZkZo6WxpEt7TvosXOK//m1c4TiJStURwYDMUYdAMrBNbOCW9oWmDypoqayvKnfhgo NA/M1ckQ+2ViZOsZfxDSYll3lYUZhfaOnhJlMIVz8n33JKCJRfutjwyfU7E9ayCNet4S YqvoNBBO6Y/gY/4sRaR53eh95sarqBKQyUyq6nlbi5BIqdhaaDd9mN9APjaNgvkNVdT2 SJXCVUzwc3rS27Nqo+CyDTlHGvJ8OPNkmuf6zhwNRuCr+XUi+W1Qqi6pk4NDK/l+0vCF YL7w== X-Gm-Message-State: AOAM533g4E5kjdu4ZMJWvyBHe9HlwmHCQ3zBCTMLe7gcp40cYTnCOKBu iSYuNC0E8LV+/a9eY39xO9/Hu4GmRe4gPA== X-Google-Smtp-Source: ABdhPJzTcW1GqenW0tpkhP8eOAm6oe13TmFbBuY8clLxJmWhVGjZowd1nCRgsMlADjoqj2yDdJg4fg== X-Received: by 2002:a05:600c:4ca7:: with SMTP id g39mr12613127wmp.1.1621682482898; Sat, 22 May 2021 04:21:22 -0700 (PDT) Received: from Philipps-MBP.fritz.box ([46.128.198.100]) by smtp.gmail.com with ESMTPSA id b10sm5288583wrt.24.2021.05.22.04.21.22 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 May 2021 04:21:22 -0700 (PDT) From: Philipp <p.stephani2@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 28.0.50; Incorrect hook ordering between local and global hooks with depth Date: Sat, 22 May 2021 13:21:21 +0200 Message-ID: <m2im3bvwsu.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=p.stephani2@HIDDEN; helo=mail-wm1-x332.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) Evaluate these forms: (add-hook 'my-hook (lambda () (message "Outer")) 20) (with-temp-buffer (add-hook 'my-hook (lambda () (message "Inner")) 10 :local) (run-hooks 'my-hook)) Then in the *Messages* buffer, "Inner" appears *after* "Outer" even though the local function's depth is lower than the global one's. In GNU Emacs 28.0.50 (build 124, aarch64-apple-darwin20.4.0, NS appkit-2022.44 Version 11.3.1 (Build 20E241)) of 2021-05-22 Repository revision: a3de48687eb28121f3dbfc20be19bd06c4cd6e98 Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.3.1 Configured using: 'configure --with-modules --without-xml2 --without-pop --with-mailutils --enable-gcc-warnings=warn-only --enable-checking=all --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0'' Configured features: ACL GNUTLS JSON LCMS2 MODULES NOTIFY KQUEUE NS PDUMPER PNG THREADS TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx gnutls puny dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 70771 6618) (symbols 48 8363 1) (strings 32 24252 2098) (string-bytes 1 793122) (vectors 16 16068) (vector-slots 8 212664 8593) (floats 8 26 28) (intervals 56 220 0) (buffers 992 10))
Philipp <p.stephani2@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#48584; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.