GNU bug report logs - #48601
[PATCH] Add support for plain SASL authentication to rcirc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48601 in the body.
You can then email your comments to 48601 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex McGrath <amk <at> amk.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add support for plain SASL authentication to rcirc
Date: Sun, 23 May 2021 13:16:19 +0100

[Message part 1 (text/plain, inline)]

This adds support for PLAIN SASL authentication to rcirc.
ietf rfc: https://datatracker.ietf.org/doc/html/rfc4616

Thanks,
Alex
    

[0001-Add-support-for-SASL-authentication-to-rcirc.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Date: Sun, 23 May 2021 13:16:02 +0100
Message-ID: <87lf85ir25.fsf <at> t480s.lan>

Message #8 received at 48601 <at> debbugs.gnu.org (full text, mbox):

From: Alex McGrath <amk <at> amk.ie>
To: 48601 <at> debbugs.gnu.org.
Subject: [PATCH v2] Add support for plain SASL authentication to rcirc
Date: Sun, 23 May 2021 17:24:13 +0100

[Message part 1 (text/plain, inline)]

This fixes a couple of problems with the previous patch.
Mainly it uses user-name instead of nick for the SASL auth

Thanks,
Alex

[0001-Add-support-for-SASL-authentication-to-rcirc.patch (text/x-diff, attachment)]

Message #11 received at 48601 <at> debbugs.gnu.org (full text, mbox):

From: Alex McGrath <amk <at> amk.ie>
To: 48601 <at> debbugs.gnu.org
Subject: [PATCH v3] Add support for plain SASL authentication to rcirc
Date: Mon, 24 May 2021 09:45:26 +0100

[Message part 1 (text/plain, inline)]

Sorry about the spam, should hopefully be a final version.  Freenode
wasnt negotiating sasl the same way as the server I was testing with but
I think it is correct now

Thanks again,
Alex

[0001-Add-support-for-SASL-authentication-to-rcirc.patch (text/x-diff, attachment)]

Message #14 received at 48601 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex McGrath <amk <at> amk.ie>
Cc: 48601 <at> debbugs.gnu.org
Subject: Re: bug#48601: [PATCH] Add support for plain SASL authentication to
 rcirc
Date: Tue, 25 May 2021 06:01:39 +0200

Alex McGrath <amk <at> amk.ie> writes:

> Sorry about the spam, should hopefully be a final version.  Freenode
> wasnt negotiating sasl the same way as the server I was testing with but
> I think it is correct now

Thanks; this looks useful, but it isn't a "small change", so we'd need
to get the copyright assigned to the FSF before applying.  Would you be
willing to sign such paperwork?

If so, the form below should get you started:


Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]

Message #19 received at 48601 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex McGrath <amk <at> amk.ie>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 48601 <at> debbugs.gnu.org
Subject: Re: bug#48601: [PATCH] Add support for plain SASL authentication to
 rcirc
Date: Thu, 24 Jun 2021 18:19:26 +0200

Alex McGrath <amk <at> amk.ie> writes:

> Subject: [PATCH] Add support for SASL authentication to rcirc

I see that Alex' copyright assignment is complete, so we can merge this
patch now.  But meanwhile, Philip has started a new branch for fixing up
various rcirc issues, so I wonder whether Philip wants to take this
patch via that branch, or whether I should apply it to the trunk.

Philip, do you have a preference here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 48601 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Alex McGrath <amk <at> amk.ie>, 48601 <at> debbugs.gnu.org
Subject: Re: bug#48601: [PATCH] Add support for plain SASL authentication to
 rcirc
Date: Thu, 24 Jun 2021 16:25:58 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Alex McGrath <amk <at> amk.ie> writes:
>
>> Subject: [PATCH] Add support for SASL authentication to rcirc
>
> I see that Alex' copyright assignment is complete, so we can merge this
> patch now.  But meanwhile, Philip has started a new branch for fixing up
> various rcirc issues, so I wonder whether Philip wants to take this
> patch via that branch, or whether I should apply it to the trunk.
>
> Philip, do you have a preference here?

I'm not sure right now when the branch will be mergable, so it is
probably better to apply the changes now, and then I can resolve the
(minor) conflict later.

-- 
	Philip K.

Message #25 received at 48601 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Alex McGrath <amk <at> amk.ie>, 48601 <at> debbugs.gnu.org
Subject: Re: bug#48601: [PATCH] Add support for plain SASL authentication to
 rcirc
Date: Thu, 24 Jun 2021 18:45:46 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> I'm not sure right now when the branch will be mergable, so it is
> probably better to apply the changes now, and then I can resolve the
> (minor) conflict later.

OK; I've now pushed Alex' patch to Emacs 28 (with some tiny changes).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.