GNU bug report logs - #48620
[PATCH] gnu: Add font-ipa-ex.

Previous Next

Package: guix-patches;

Reported by: Leo Prikler <leo.prikler <at> student.tugraz.at>

Date: Mon, 24 May 2021 08:48:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48620 in the body.
You can then email your comments to 48620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#48620; Package guix-patches. (Mon, 24 May 2021 08:48:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 24 May 2021 08:48:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add font-ipa-ex.
Date: Mon, 24 May 2021 10:46:45 +0200
* gnu/packages/fonts.scm (font-ipa-ex): New variable.
---
 gnu/packages/fonts.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 726bef183c..711344191c 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2031,6 +2031,49 @@ orthography of Roman glyphs of Meera Inimai are also based on this
 characteristic so that they sit smoothly with the Tamil glyphs.")
     (license license:silofl1.1)))
 
+(define-public font-ipa-ex
+  (package
+    (name "font-ipa-ex")
+    (version "004.01")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri (string-append "https://moji.or.jp/wp-content/ipafont/IPAexfont/"
+                                  "IPAexfont" (string-join (string-split version #\.) "")
+                                  ".zip"))
+              (sha256
+               (base32
+                "0jwpszgisrls1lsgq1ngcm99zjaikb8hshr02512qrzrnd53gy5w"))))
+    (build-system font-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'make-read-only
+           (lambda _
+             (for-each
+              (lambda (file)
+                (chmod file #o444))
+              (find-files "." #:directories? #f))
+             #t))
+         (add-after 'install 'install-doc
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((font+version (string-append
+                                  "IPAexfont"
+                                  ,(string-join (string-split version #\.) "")))
+                   (doc-dir (string-append (assoc-ref outputs "out")
+                                           "/share/doc/font-ipa-ex")))
+               (with-directory-excursion font+version
+                 (mkdir-p doc-dir)
+                 (copy-file (string-append "Readme_" font+version ".txt")
+                            (string-append doc-dir "/README"))
+                 (copy-file "IPA_Font_License_Agreement_v1.0.txt"
+                            (string-append doc-dir "/LICENSE")))
+               #t))))))
+    (home-page "https://moji.or.jp/ipafont/")
+    (synopsis "Japanese font from the Information-technology Promotion Agency")
+    (description "IPAex is fixed-width font that aims to improve the
+convenience of Japanese document creation.")
+    (license license:ipa)))
+
 (define-public font-ipa-mj-mincho
   (package
     (name "font-ipa-mj-mincho")
-- 
2.31.1





Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Sun, 22 May 2022 04:13:01 GMT) Full text and rfc822 format available.

Notification sent to Leo Prikler <leo.prikler <at> student.tugraz.at>:
bug acknowledged by developer. (Sun, 22 May 2022 04:13:01 GMT) Full text and rfc822 format available.

Message #10 received at 48620-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 48620-done <at> debbugs.gnu.org
Subject: Re: bug#48620: [PATCH] gnu: Add font-ipa-ex.
Date: Sun, 22 May 2022 00:12:19 -0400
Hello!

Leo Prikler <leo.prikler <at> student.tugraz.at> writes:

> * gnu/packages/fonts.scm (font-ipa-ex): New variable.
> ---
>  gnu/packages/fonts.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 726bef183c..711344191c 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -2031,6 +2031,49 @@ orthography of Roman glyphs of Meera Inimai are also based on this
>  characteristic so that they sit smoothly with the Tamil glyphs.")
>      (license license:silofl1.1)))
>  
> +(define-public font-ipa-ex
> +  (package
> +    (name "font-ipa-ex")
> +    (version "004.01")
> +    (source (origin
> +              (method url-fetch/zipbomb)
> +              (uri (string-append "https://moji.or.jp/wp-content/ipafont/IPAexfont/"
> +                                  "IPAexfont" (string-join (string-split version #\.) "")
> +                                  ".zip"))
> +              (sha256
> +               (base32
> +                "0jwpszgisrls1lsgq1ngcm99zjaikb8hshr02512qrzrnd53gy5w"))))
> +    (build-system font-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'make-read-only
> +           (lambda _
> +             (for-each
> +              (lambda (file)
> +                (chmod file #o444))
> +              (find-files "." #:directories? #f))
> +             #t))
> +         (add-after 'install 'install-doc
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((font+version (string-append
> +                                  "IPAexfont"
> +                                  ,(string-join (string-split version #\.) "")))
> +                   (doc-dir (string-append (assoc-ref outputs "out")
> +                                           "/share/doc/font-ipa-ex")))
> +               (with-directory-excursion font+version
> +                 (mkdir-p doc-dir)
> +                 (copy-file (string-append "Readme_" font+version ".txt")
> +                            (string-append doc-dir "/README"))
> +                 (copy-file "IPA_Font_License_Agreement_v1.0.txt"
> +                            (string-append doc-dir "/LICENSE")))
> +               #t))))))
> +    (home-page "https://moji.or.jp/ipafont/")
> +    (synopsis "Japanese font from the Information-technology Promotion Agency")
> +    (description "IPAex is fixed-width font that aims to improve the
> +convenience of Japanese document creation.")
> +    (license license:ipa)))
> +
>  (define-public font-ipa-mj-mincho
>    (package
>      (name "font-ipa-mj-mincho")

I made the following changes:

--8<---------------cut here---------------start------------->8---
1 file changed, 33 insertions(+), 28 deletions(-)
gnu/packages/fonts.scm | 61 +++++++++++++++++++++++++++++++++----------------------------

modified   gnu/packages/fonts.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Wamm K. D. <jaft.r <at> outlook.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2021 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2256,41 +2257,45 @@ (define-public font-ipa-ex
     (version "004.01")
     (source (origin
               (method url-fetch/zipbomb)
-              (uri (string-append "https://moji.or.jp/wp-content/ipafont/IPAexfont/"
-                                  "IPAexfont" (string-join (string-split version #\.) "")
-                                  ".zip"))
+              (uri (string-append
+                    "https://moji.or.jp/wp-content/ipafont/IPAexfont/"
+                    "IPAexfont" (string-join (string-split version #\.) "")
+                    ".zip"))
               (sha256
                (base32
                 "0jwpszgisrls1lsgq1ngcm99zjaikb8hshr02512qrzrnd53gy5w"))))
     (build-system font-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'make-read-only
-           (lambda _
-             (for-each
-              (lambda (file)
-                (chmod file #o444))
-              (find-files "." #:directories? #f))
-             #t))
-         (add-after 'install 'install-doc
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let ((font+version (string-append
-                                  "IPAexfont"
-                                  ,(string-join (string-split version #\.) "")))
-                   (doc-dir (string-append (assoc-ref outputs "out")
-                                           "/share/doc/font-ipa-ex")))
-               (with-directory-excursion font+version
-                 (mkdir-p doc-dir)
-                 (copy-file (string-append "Readme_" font+version ".txt")
-                            (string-append doc-dir "/README"))
-                 (copy-file "IPA_Font_License_Agreement_v1.0.txt"
-                            (string-append doc-dir "/LICENSE")))
-               #t))))))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'make-read-only
+            (lambda _
+              ;; Otherwise the files have the executable bit set.
+              (for-each (lambda (file)
+                          (chmod file #o444))
+                        (find-files "." #:directories? #f))))
+          (add-after 'install 'install-doc
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((font+version
+                     #$(string-append
+                        "IPAexfont"
+                        (string-join (string-split version #\.) "")))
+                    (doc-dir (string-append #$output "/share/doc/" #$name)))
+                (with-directory-excursion font+version
+                  (mkdir-p doc-dir)
+                  (copy-file (string-append "Readme_" font+version ".txt")
+                             (string-append doc-dir "/README"))
+                  (copy-file "IPA_Font_License_Agreement_v1.0.txt"
+                             (string-append doc-dir "/LICENSE")))))))))
     (home-page "https://moji.or.jp/ipafont/")
     (synopsis "Japanese font from the Information-technology Promotion Agency")
-    (description "IPAex is fixed-width font that aims to improve the
-convenience of Japanese document creation.")
+    (description "IPAex Fonts are suitable for both display and printing.
+This is a modernized version of IPA Fonts that aims to provide a good balance
+for authoring Japanese documents mixed with Western characters, while
+following Japanese printing tradition.  Japanese characters (Kanji, Kana and
+punctuation marks) are full width mono-space pitch, and Western characters are
+proportional pitch.")
     (license license:ipa)))
 
 (define-public font-ipa-mj-mincho
--8<---------------cut here---------------end--------------->8---

mostly improving the description, and pushed as 6e0b2adf5f.

Thanks!

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 19 Jun 2022 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 311 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.