GNU bug report logs - #48642
[PATCH] Add kanatest

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48642 in the body.
You can then email your comments to 48642 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add kanatest
Date: Tue, 25 May 2021 09:22:10 +0200

[Message part 1 (text/plain, inline)]

Hi guix!

Here's a patch to add kanatest, a learning tool for japanese kana.

guix lint complains about
> URI https://git.code.sf.net/p/kanatest/code not reachable: 404 ("Not
> Found")

but cloning does work, so I don't know if I need to do something in
order to fix it.  I had to use git instead of the release tarball as
that is really old (2009), works only with gtk2 and I could not get it
to build.

Thanks!
Nicolò

[0001-gnu-Add-kanatest.patch (text/x-patch, attachment)]

Message #8 received at 48642 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 48642 <at> debbugs.gnu.org
Subject: Re: [bug#48642] [PATCH] Add kanatest
Date: Tue, 25 May 2021 10:32:21 +0200

[Message part 1 (text/plain, inline)]

On Tue, May 25 2021, Nicolò Balzarotti wrote:

> +(define-public kanatest
> +  ;; Latest release tarball is 0.4.8, which is really old and does not build
> +  ;; commit on sourceforge are not tagged, we take the latest
> +  (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff"))
> +    (package
> +      (name "kanatest")
> +      (version (string-append "0.4.10." (string-take commit 7)))

Use ‘(git-version VERSION REVISION COMMIT)’.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://git.code.sf.net/p/kanatest/code")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0dz63m9p4ggzw0yb309qmgnl664qb5q268vaa3i9v0i8qsl66d78"))))
> +      (build-system gnu-build-system)
> +      (native-inputs
> +       `(("gettext" ,gettext-minimal)     ; for msgfmt
> +         ("pkg-config" ,pkg-config)))
> +      (inputs
> +       `(("libxml2" ,libxml2)
> +         ("gtk+" ,gtk+)))
> +      (synopsis "Hiragana and Katakana simple flashcard tool")
> +      (description "Kanatest is a Japanese kana (Hiragana and Katakana) simple
> +flashcard tool.
> +
> +During test the Kanatest displays randomly selected kana char (respecting mode
> +and lesson) and waits for user answer expected as romaji equivalent.  This
> +process continues until all questions will be answered or all questions will
> +be answered correctly (depends on options).  At the end of test a short info
> +about drilling time and correctness ratio is displayed.  The results are
> +stored and user can review his performance in any time.")
> +      (home-page "https://kanatest.sourceforge.io/")

Nit: ‘home-page’ usually comes before ‘synopsis’.

Otherwise, LGTM!  Builds fine as well.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 48642 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>, 48642 <at> debbugs.gnu.org
Subject: Re: [bug#48642] [PATCH] Add kanatest
Date: Tue, 25 May 2021 10:39:10 +0200

[Message part 1 (text/plain, inline)]

Hi! Thanks for the fast review!

Xinglu Chen <public <at> yoctocell.xyz> writes:

> On Tue, May 25 2021, Nicolò Balzarotti wrote:
>
>> +(define-public kanatest
>> +  ;; Latest release tarball is 0.4.8, which is really old and does not build
>> +  ;; commit on sourceforge are not tagged, we take the latest
>> +  (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff"))
>> +    (package
>> +      (name "kanatest")
>> +      (version (string-append "0.4.10." (string-take commit 7)))
>
> Use ‘(git-version VERSION REVISION COMMIT)’.
>
I added revision "0" along with commit in the let block and used
git-version as suggested.

>> [...]
>> +      (home-page "https://kanatest.sourceforge.io/")
>
> Nit: ‘home-page’ usually comes before ‘synopsis’.
>
Moved above!

> Otherwise, LGTM!  Builds fine as well.

Thanks, here's version 2 of the patch!

Thanks again for the review,
Nicolò

[v2-0001-gnu-Add-kanatest.patch (text/x-patch, attachment)]

Message #14 received at 48642 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 48642 <at> debbugs.gnu.org
Subject: Re: [bug#48642] [PATCH] Add kanatest
Date: Tue, 25 May 2021 11:03:05 +0200

[Message part 1 (text/plain, inline)]

On Tue, May 25 2021, Nicolò Balzarotti wrote:

> Hi! Thanks for the fast review!
>
> [...]
>
> Thanks, here's version 2 of the patch!
>
> Thanks again for the review,

You are welcome!  The changes look good, I don’t have commit access,
though.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 48642-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: Xinglu Chen <public <at> yoctocell.xyz>, 48642-done <at> debbugs.gnu.org
Subject: Re: [bug#48642] [PATCH] Add kanatest
Date: Tue, 25 May 2021 12:12:13 +0200

Hello,

Nicolò Balzarotti <anothersms <at> gmail.com> writes:

> Thanks, here's version 2 of the patch!

I added a copyright line for you and applied the patch. Thank you!
>
> Thanks again for the review,

Indeed, thank you, Xinglu Chen.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.