GNU bug report logs - #48643
PATCH] gnu: fzf: Add fish shell functions to the package.

Previous Next

Package: guix-patches;

Reported by: Solene Rapenne <solene <at> perso.pw>

Date: Tue, 25 May 2021 08:18:02 UTC

Severity: normal

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48643 in the body.
You can then email your comments to 48643 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#48643; Package guix-patches. (Tue, 25 May 2021 08:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Solene Rapenne <solene <at> perso.pw>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 25 May 2021 08:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Solene Rapenne <solene <at> perso.pw>
To: guix-patches <at> gnu.org
Subject: PATCH] gnu: fzf: Add fish shell functions to the package.
Date: Tue, 25 May 2021 10:16:50 +0200
This allows to enable fzf functions for fish using the following code in
the file ~/.config/fish/config.fish 

source ~/.guix-profile/share/fish/functions/fzf
fzf_key_bindings


---
 gnu/packages/terminals.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 37636c7cdc..5273dce005 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2020 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
+;;; Copyright © 2021 Solene Rapenne <solene <at> perso.pw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -851,11 +852,15 @@ usable with any list--including files, command history, processes and more.")
             (lambda* (#:key outputs #:allow-other-keys)
               (let* ((out (assoc-ref outputs "out"))
                      (bash-completion (string-append out "/etc/bash_completion.d"))
+                     (fish-completion (string-append out "/share/fish/functions"))
                      (zsh-completion (string-append out "/share/zsh/site-functions")))
                 (with-directory-excursion "src/github.com/junegunn/fzf"
                   (mkdir-p bash-completion)
                   (copy-file "shell/completion.bash"
                              (string-append bash-completion "/fzf"))
+                  (mkdir-p fish-completion)
+                  (copy-file "shell/key-bindings.fish"
+                             (string-append fish-completion "/fzf"))
                   (mkdir-p zsh-completion)
                   (copy-file "shell/completion.zsh"
                              (string-append zsh-completion "/_fzf"))))))))))
-- 
2.31.1





Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Sun, 26 Sep 2021 12:05:01 GMT) Full text and rfc822 format available.

Notification sent to Solene Rapenne <solene <at> perso.pw>:
bug acknowledged by developer. (Sun, 26 Sep 2021 12:05:01 GMT) Full text and rfc822 format available.

Message #10 received at 48643-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Solene Rapenne <solene <at> perso.pw>
Cc: 48643-done <at> debbugs.gnu.org
Subject: Re: [bug#48643] PATCH] gnu: fzf: Add fish shell functions to the
 package.
Date: Sun, 26 Sep 2021 15:02:23 +0300
[Message part 1 (text/plain, inline)]
I adjusted the fish completion path slightly to match the other
packages. Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#48643; Package guix-patches. (Sat, 02 Oct 2021 23:10:02 GMT) Full text and rfc822 format available.

Message #13 received at 48643 <at> debbugs.gnu.org (full text, mbox):

From: wp1148917-web wp1148917-web <drwilly <at> drwilly.de>
To: "48643 <at> debbugs.gnu.org" <48643 <at> debbugs.gnu.org>
Date: Sat, 2 Oct 2021 22:43:15 +0200 (CEST)
Efraim, there seems to be a bit of confusion about the nature of the installed file: It is NOT a completion, but code that sets fzf shell-hotkeys. This should become obvious if you look at the folder from the source: https://github.com/junegunn/fzf/tree/master/shell
The file should probably be installed to vendor_functions.d/ as e.g. Arch does it: https://wiki.archlinux.org/title/Fzf#fish




Information forwarded to guix-patches <at> gnu.org:
bug#48643; Package guix-patches. (Sun, 03 Oct 2021 12:04:01 GMT) Full text and rfc822 format available.

Message #16 received at 48643-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: wp1148917-web <drwilly <at> drwilly.de>
Cc: 48643-done <at> debbugs.gnu.org
Subject: Re: [bug#48643]
Date: Sun, 3 Oct 2021 15:00:39 +0300
[Message part 1 (text/plain, inline)]
On Sat, Oct 02, 2021 at 10:43:15PM +0200, wp1148917-web wp1148917-web wrote:
> Efraim, there seems to be a bit of confusion about the nature of the installed file: It is NOT a completion, but code that sets fzf shell-hotkeys. This should become obvious if you look at the folder from the source: https://github.com/junegunn/fzf/tree/master/shell
> The file should probably be installed to vendor_functions.d/ as e.g. Arch does it: https://wiki.archlinux.org/title/Fzf#fish

First of all, thanks! I hadn't checked it too closely and relied on the
wording of 'fish completion'.

Checking the upstream documentation¹, Arch² and Debian³ the completions should
go in %output/share/fish/vendor_functions.d/fzf_key_bindings.fish, so
I've moved them there.

¹ https://fishshell.com/docs/current/completions.html?highlight=vendor#where-to-put-completions
² https://wiki.archlinux.org/title/Fzf#fish
³ https://sources.debian.org/src/fzf/0.24.3-1/debian/fzf.install/

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 01 Nov 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 148 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.