GNU bug report logs - #48707
outline not distinguishing between levels well enough

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48707 in the body.
You can then email your comments to 48707 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pauline-galea <at> gmx.com
To: bug-gnu-emacs <at> gnu.org
Cc: Philip Kaludercic <philipk <at> posteo.net>
Subject: outline not distinguishing between levels well enough
Date: Thu, 27 May 2021 21:37:26 +0200

outline is supposed to highlight the eight different heading levels in a way that
is easy to distinguish between them.  I do not see such a capability at this time.

Settings up different colours is also quite complicated and confusing.  I have originally
discussed this on "help-gnu-emacs <at> gnu.org", who encouraged me to send a bug report.

I do not get different heading colours for the three heading levels below.
Philip has mentioned the possibility that the wrong face is being applied.

--------- test.el --------

;;; * heading 1
;; comments
;;;; ** subheading 1.1
;; comments
;;;;; *** subsubheading 1.1.1
;; comments

Many Thanks
Paula


> Sent: Friday, May 28, 2021 at 7:22 AM
> From: "Philip Kaludercic" <philipk <at> posteo.net>
> To: pauline-galea <at> gmx.com
> Cc: "Help Gnu Emacs" <help-gnu-emacs <at> gnu.org>
> Subject: "emacs-28.0.50 -q" and "emacs-28.0.50 -Q" with outline-minor-mode-highlight
>
> pauline-galea <at> gmx.com writes:
>
> >> > For instance, changing the
> >> > faces would also change
> >> > those heading highlighting.  This does not seem to bother the
> >> > maintainers whilst expecting
> >> > other to be ok with it, terning down requests for improvements.
> >>
> >> I looked over it, and it does seem like a bug, as the wrong face is
> >> being applied. My guess is that outline-font-lock-face is returning the
> >> wrong face.
> >>
> >> Did you report this as a proper bug?
> >
> > You seem to understand what's wrong.
>
> Sure, just Cc me in the bug report.
>
> --
> 	Philip K.
>

Message #8 received at 48707 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: pauline-galea <at> gmx.com
Cc: Philip Kaludercic <philipk <at> posteo.net>, 48707 <at> debbugs.gnu.org
Subject: Re: bug#48707: outline not distinguishing between levels well enough
Date: Fri, 28 May 2021 01:44:36 +0300

[Message part 1 (text/plain, inline)]

> outline is supposed to highlight the eight different heading levels in a way that
> is easy to distinguish between them.  I do not see such a capability at this time.
>
> Settings up different colours is also quite complicated and confusing.  I have originally
> discussed this on "help-gnu-emacs <at> gnu.org", who encouraged me to send a bug report.
>
> I do not get different heading colours for the three heading levels below.
> Philip has mentioned the possibility that the wrong face is being applied.
>
> --------- test.el --------
>
> ;;; * heading 1
> ;; comments
> ;;;; ** subheading 1.1
> ;; comments
> ;;;;; *** subsubheading 1.1.1
> ;; comments

Thank you very much for the bug report.  This is really a bug
that should be fixed by the following patch:

[outline-font-lock-keywords.patch (text/x-diff, inline)]

diff --git a/lisp/outline.el b/lisp/outline.el
index fa7c1a27d9..3eb3e21036 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -205,7 +205,8 @@ outline-font-lock-keywords
                                  (list 'face (outline-font-lock-face)
                                        'keymap outline-mode-cycle-map)
                                (list 'face nil
-                                     'keymap outline-mode-cycle-map)))
+                                     'keymap outline-mode-cycle-map))
+                           (list 'face (outline-font-lock-face)))
                        (outline-font-lock-face))
                   (when outline-minor-mode
                     (pcase outline-minor-mode-highlight

Message #11 received at 48707 <at> debbugs.gnu.org (full text, mbox):

From: pauline-galea <at> gmx.com
To: Juri Linkov <juri <at> linkov.net>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 48707 <at> debbugs.gnu.org
Subject: bug#48707: outline not distinguishing between levels well enough
Date: Fri, 28 May 2021 01:33:50 +0200

Thank you for the patch.  I have updated outline.el and rebuilt emacs and I can see
changes.  I am unsure though how to change the heading level colours for different
subheading levels, because the headings all look like comments.

Regards



> Sent: Friday, May 28, 2021 at 10:44 AM
> From: "Juri Linkov" <juri <at> linkov.net>
> To: pauline-galea <at> gmx.com
> Cc: 48707 <at> debbugs.gnu.org, "Philip Kaludercic" <philipk <at> posteo.net>
> Subject: Re: bug#48707: outline not distinguishing between levels well enough
>
> > outline is supposed to highlight the eight different heading levels in a way that
> > is easy to distinguish between them.  I do not see such a capability at this time.
> >
> > Settings up different colours is also quite complicated and confusing.  I have originally
> > discussed this on "help-gnu-emacs <at> gnu.org", who encouraged me to send a bug report.
> >
> > I do not get different heading colours for the three heading levels below.
> > Philip has mentioned the possibility that the wrong face is being applied.
> >
> > --------- test.el --------
> >
> > ;;; * heading 1
> > ;; comments
> > ;;;; ** subheading 1.1
> > ;; comments
> > ;;;;; *** subsubheading 1.1.1
> > ;; comments
>
> Thank you very much for the bug report.  This is really a bug
> that should be fixed by the following patch:
>
>

Message #14 received at 48707 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: pauline-galea <at> gmx.com
Cc: Philip Kaludercic <philipk <at> posteo.net>, 48707 <at> debbugs.gnu.org
Subject: Re: bug#48707: outline not distinguishing between levels well enough
Date: Fri, 28 May 2021 21:59:17 +0300

tags 48707 fixed
close 48707 28.0.50
thanks

> Thank you for the patch.  I have updated outline.el and rebuilt emacs and I can see
> changes.  I am unsure though how to change the heading level colours for different
> subheading levels, because the headings all look like comments.

Thanks for confirming.  Now the fix is pushed.

Message #21 received at 48707 <at> debbugs.gnu.org (full text, mbox):

From: pauline-galea <at> gmx.com
To: Juri Linkov <juri <at> linkov.net>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 48707 <at> debbugs.gnu.org
Subject: bug#48707: outline not distinguishing between levels well enough
Date: Fri, 28 May 2021 21:23:56 +0200

> Sent: Saturday, May 29, 2021 at 6:59 AM
> From: "Juri Linkov" <juri <at> linkov.net>
> To: pauline-galea <at> gmx.com
> Cc: 48707 <at> debbugs.gnu.org, "Philip Kaludercic" <philipk <at> posteo.net>
> Subject: Re: bug#48707: outline not distinguishing between levels well enough
>
> tags 48707 fixed
> close 48707 28.0.50
> thanks
>
> > Thank you for the patch.  I have updated outline.el and rebuilt emacs and I can see
> > changes.  I am unsure though how to change the heading level colours for different
> > subheading levels, because the headings all look like comments.
>
> Thanks for confirming.  Now the fix is pushed.

I have now been able to view different colours for the different heading levels.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.