GNU bug report logs - #48717
[PATCH] Add lingot

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48717 in the body.
You can then email your comments to 48717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add lingot
Date: Fri, 28 May 2021 17:21:59 +0200

[Message part 1 (text/plain, inline)]

Added a tuner program to the package collection.

[Message part 2 (text/html, inline)]

[0001-gnu-lingot-Add-package-lingot.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Rovanion Luckey <rovanion.luckey <at> gmail.com>
Cc: 48717 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#48717] [PATCH] Add lingot
Date: Fri, 28 May 2021 19:12:07 +0200

[Message part 1 (text/plain, inline)]

Rovanion Luckey 写道：
> Added a tuner program to the package collection.

Thank you!

I should add a copyright line for you at the top of the file, once 
you confirm which name & e-mail address to use.

I made the following changes (pay close attention, they might be 
on the test):
- moved glib:bin to native-inputs, which means it can be run at 
 build time even when cross-building (and ‘guix gc --references’ 
 indicates it won't be run at run time anyway),
- the licence is ‘GPL2 or later’,
- removed the leading ‘An’ from the synopsis (in a list, it's just 
 noise),
- wrapped all text to 80 characters and added a double space after 
 full stops.

Be sure to run ‘guix lint’ on new packages, it will warn you about 
some of these and other cool mistakes.

These minor nitpicks will not be on the test but I applied them 
anyway:
- reindented the package (specifically the source form was off?),
- ordered the inputs alphabetically, and put the package somewhere 
 similar,
- removed the libasound comment because that's 99% of why packages 
 use alsa-lib.  Probably 100.  Could the same be said for 
 glib:bin, which I kept?  Perhaps!  I am whimsy.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 48717 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: 48717 <at> debbugs.gnu.org
Subject: [PATCH] Add lingot
Date: Fri, 28 May 2021 21:18:03 +0200

[Message part 1 (text/plain, inline)]

You can use the following for the copyright line:

Rovanion Luckey <rovanion.luckey <at> gmail.com>

I gleaned the license info from GitHub, but I guess it was wrong. Should
really have run guix lint on the package though. Thank you for your
patience.

[Message part 2 (text/html, inline)]

Message #17 received at 48717 <at> debbugs.gnu.org (full text, mbox):

From: Rovanion Luckey <rovanion.luckey <at> gmail.com>
To: 48717 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add lingot
Date: Fri, 30 Jul 2021 21:03:11 +0200

[Message part 1 (text/plain, inline)]

This patch has been included and this issue closed right?

Den fre 28 maj 2021 kl 21:18 skrev Rovanion Luckey <
rovanion.luckey <at> gmail.com>:

> You can use the following for the copyright line:
>
> Rovanion Luckey <rovanion.luckey <at> gmail.com>
>
> I gleaned the license info from GitHub, but I guess it was wrong. Should
> really have run guix lint on the package though. Thank you for your
> patience.
>

[Message part 2 (text/html, inline)]

Message #22 received at 48717-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Rovanion Luckey <rovanion.luckey <at> gmail.com>
Cc: 48717-done <at> debbugs.gnu.org
Subject: Re: [bug#48717] [PATCH] Add lingot
Date: Mon, 2 Aug 2021 18:40:33 +0300

[Message part 1 (text/plain, inline)]

On Fri, Jul 30, 2021 at 09:03:11PM +0200, Rovanion Luckey wrote:
> This patch has been included and this issue closed right?

Looks like it was committed on May 30th. Closing the bug.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.