GNU bug report logs - #48719
[PATCH] Fix peredicate for outline-minor-mode-highlight

Previous Next

Package: emacs;

Reported by: Utkarsh Singh <utkarsh190601 <at> gmail.com>

Date: Fri, 28 May 2021 16:27:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48719 in the body.
You can then email your comments to 48719 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#48719; Package emacs. (Fri, 28 May 2021 16:27:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Utkarsh Singh <utkarsh190601 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 28 May 2021 16:27:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix peredicate for outline-minor-mode-highlight
Date: Fri, 28 May 2021 21:56:47 +0530

Hi,

Currently `outline-minor-mode-highlight' supports nil, t, override and
append as possible values but we are using `booleanp' as predicate for
safe-local-variable which only cover first two cases.

diff --git a/lisp/outline.el b/lisp/outline.el
index fa7c1a27d9..efe3314ead 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -349,7 +349,7 @@ outline-minor-mode-highlight
                  (const :tag "Append outline faces to major mode faces" append)
                  (const :tag "Highlight separately from major mode faces" t))
   :version "28.1")
-;;;###autoload(put 'outline-minor-mode-highlight 'safe-local-variable 'booleanp)
+;;;###autoload(put 'outline-minor-mode-highlight 'safe-local-variable 'symbolp)
 
 (defun outline-minor-mode-highlight-buffer ()
   ;; Fallback to overlays when font-lock is unsupported.
 
-- 
Utkarsh Singh
http://utkarshsingh.xyz
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48719; Package emacs. (Fri, 28 May 2021 18:58:02 GMT) Full text and rfc822 format available.

Message #8 received at 48719 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Utkarsh Singh <utkarsh190601 <at> gmail.com>
Cc: 48719 <at> debbugs.gnu.org
Subject: Re: bug#48719: [PATCH] Fix peredicate for outline-minor-mode-highlight
Date: Fri, 28 May 2021 21:56:43 +0300

tags 48719 fixed
close 48719 28.0.50
thanks

> Currently `outline-minor-mode-highlight' supports nil, t, override and
> append as possible values but we are using `booleanp' as predicate for
> safe-local-variable which only cover first two cases.

Thanks for the patch, now pushed to master.
Added tag(s) fixed. Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Fri, 28 May 2021 18:58:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.0.50, send any further explanations to 48719 <at> debbugs.gnu.org and Utkarsh Singh <utkarsh190601 <at> gmail.com> Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Fri, 28 May 2021 18:58:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 26 Jun 2021 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 298 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.