GNU bug report logs - #48761
perl-mode: "$temp" colored differently.

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Mon, 31 May 2021 14:09:01 UTC

Severity: normal

Tags: fixed

Merged with 46024

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48761 in the body.
You can then email your comments to 48761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#48761; Package emacs. (Mon, 31 May 2021 14:09:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 31 May 2021 14:09:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: perl-mode: "$temp" colored differently.
Date: Mon, 31 May 2021 21:08:02 +0800
In perl-mode: $temp, @temp are colored differently. E.g., in
my (@AA, @temp, @barf, $temp, $x);

Caused by:
     ;; Fontify declarators and prefixes as types.
     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48761; Package emacs. (Tue, 01 Jun 2021 06:27:02 GMT) Full text and rfc822 format available.

Message #8 received at 48761 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 48761 <at> debbugs.gnu.org
Subject: Re: bug#48761: perl-mode: "$temp" colored differently.
Date: Tue, 01 Jun 2021 08:26:44 +0200
積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> In perl-mode: $temp, @temp are colored differently. E.g., in
> my (@AA, @temp, @barf, $temp, $x);

I can reproduce this in Emacs 27, but not in Emacs 28:



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48761; Package emacs. (Tue, 01 Jun 2021 06:28:01 GMT) Full text and rfc822 format available.

Message #11 received at 48761 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 48761 <at> debbugs.gnu.org
Subject: Re: bug#48761: perl-mode: "$temp" colored differently.
Date: Tue, 01 Jun 2021 08:27:06 +0200
[Message part 1 (text/plain, inline)]
積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> In perl-mode: $temp, @temp are colored differently. E.g., in
> my (@AA, @temp, @barf, $temp, $x);

I can reproduce this in Emacs 27, but not in Emacs 28:

[Message part 2 (image/png, inline)]
[Message part 3 (text/plain, inline)]
So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug marked as fixed in version 28.1, send any further explanations to 48761 <at> debbugs.gnu.org and 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 01 Jun 2021 06:28:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48761; Package emacs. (Tue, 01 Jun 2021 08:19:02 GMT) Full text and rfc822 format available.

Message #16 received at 48761 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: 48761 <at> debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#48761: perl-mode: "$temp" colored differently.
Date: Tue, 01 Jun 2021 08:17:41 +0000
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:
>
>> In perl-mode: $temp, @temp are colored differently. E.g., in
>> my (@AA, @temp, @barf, $temp, $x);
>
> I can reproduce this in Emacs 27, but not in Emacs 28:

I was too slow responding :/

This was patched with Bug#46024, which also has a list of other
"keywords" which have been removed from perl-mode: anon, argument,
supersede, let, and temp (sic!).
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46024

It is still the case that perl-mode treats a few variables which have
names like "legal" perl keywords as keywords and not as variables: for
example $my, @our, %sub, &package.  That would require a different
patch, but these names are much less likely to occur in the wild.

> So I'm closing this bug report.

Different symptom, but same patch: I guess this should be merged?
-- 
Cheers,
haj




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48761; Package emacs. (Tue, 01 Jun 2021 08:33:02 GMT) Full text and rfc822 format available.

Message #19 received at 48761 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 48761 <at> debbugs.gnu.org,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#48761: perl-mode: "$temp" colored differently.
Date: Tue, 01 Jun 2021 10:32:07 +0200
haj <at> posteo.de (Harald Jörg) writes:

> Different symptom, but same patch: I guess this should be merged?

Sure; go ahead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Forcibly Merged 46024 48761. Request was from haj <at> posteo.de (Harald Jörg) to control <at> debbugs.gnu.org. (Tue, 01 Jun 2021 11:01:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48761; Package emacs. (Tue, 01 Jun 2021 11:06:01 GMT) Full text and rfc822 format available.

Message #24 received at 48761 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48761 <at> debbugs.gnu.org
Subject: Re: bug#48761: perl-mode: "$temp" colored differently.
Date: Tue, 01 Jun 2021 11:05:49 +0000
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> haj <at> posteo.de (Harald Jörg) writes:
>
>> Different symptom, but same patch: I guess this should be merged?
>
> Sure; go ahead.

Done!
--
Cheers,
haj




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 29 Jun 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.