GNU bug report logs - #48781
adaptive-wrap.el (elpa): Enable lexical binding

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48781 in the body.
You can then email your comments to 48781 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jakanakaevangeli <at> chiru.no
To: bug-gnu-emacs <at> gnu.org
Subject: adaptive-wrap.el (elpa): Enable lexical binding
Date: Tue, 01 Jun 2021 18:23:46 +0200

@@ -1,4 +1,4 @@
-;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix
+;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix  -*- lexical-binding: t; -*-

For 'adaptive-wrap.el' from ELPA 
(http://elpa.gnu.org/packages/adaptive-wrap-0.5.el)

After testing for a week, I haven't observed any changes in behaviour.

Best regards.

Message #8 received at 48781 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: jakanakaevangeli <at> chiru.no
Cc: 48781 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#48781: adaptive-wrap.el (elpa): Enable lexical binding
Date: Wed, 02 Jun 2021 07:57:37 +0200

jakanakaevangeli <at> chiru.no writes:

> @@ -1,4 +1,4 @@
> -;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix
> +;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix -*-
> lexical-binding: t; -*-
>
> For 'adaptive-wrap.el' from ELPA 
> (http://elpa.gnu.org/packages/adaptive-wrap-0.5.el)
>
> After testing for a week, I haven't observed any changes in behaviour.

I'm not sure what the range of supported Emacs versions there are for
adaptive-wrap -- lexical binding can't be used in older Emacs versions
(but perhaps there are no version that has both package.el and doesn't
support lexical binding; I forget).

Stefan added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 48781 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: jakanakaevangeli <at> chiru.no
Cc: 48781 <at> debbugs.gnu.org
Subject: Re: bug#48781: adaptive-wrap.el (elpa): Enable lexical binding
Date: Wed, 02 Jun 2021 09:17:58 -0400

> -;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix
> +;;; adaptive-wrap.el --- Smart line-wrapping with wrap-prefix  -*- lexical-binding: t; -*-
>
> For 'adaptive-wrap.el' from ELPA 
> (http://elpa.gnu.org/packages/adaptive-wrap-0.5.el)
>
> After testing for a week, I haven't observed any changes in behaviour.

Thanks, installed.

Lars wrote:
> I'm not sure what the range of supported Emacs versions there are for
> adaptive-wrap -- lexical binding can't be used in older Emacs versions

To the extent that the code doesn't take advantage of lexical scoping,
it doesn't matter because it will still work just as well as before on
Emacs<24.

> (but perhaps there are no version that has both package.el and doesn't
> support lexical binding; I forget).

The first Emacs that came with `package.el` was Emacs-24, which is also
the first that came with `lexical-binding`.
There have been versions of `package.el` patched to work in Emacs<24
(not sure how far back it worked), but indeed I tend to consider
Emacs-24 as the "baseline" for ELPA packages.


        Stefan

Message #14 received at 48781 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: jakanakaevangeli <at> chiru.no
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 48781 <at> debbugs.gnu.org
Subject: Re: bug#48781: adaptive-wrap.el (elpa): Enable lexical binding
Date: Thu, 03 Jun 2021 09:54:39 +0200

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> To the extent that the code doesn't take advantage of lexical scoping,
> it doesn't matter because it will still work just as well as before on
> Emacs<24.

Sure; I was just concerned that somebody might take that as a sign to
add non-compatible code to lexical-bound files (like closures and other
nice stuff) in indeed backwards compatibility beyond Emacs 24 was an
issue (which it doesn't really seem to be).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 48781 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48781 <at> debbugs.gnu.org, jakanakaevangeli <at> chiru.no
Subject: Re: bug#48781: adaptive-wrap.el (elpa): Enable lexical binding
Date: Thu, 03 Jun 2021 09:35:05 -0400

>> To the extent that the code doesn't take advantage of lexical scoping,
>> it doesn't matter because it will still work just as well as before on
>> Emacs<24.
> Sure; I was just concerned that somebody might take that as a sign to
> add non-compatible code to lexical-bound files (like closures and other
> nice stuff) in indeed backwards compatibility beyond Emacs 24 was an
> issue (which it doesn't really seem to be).

AFAIK the desired compatibility for adaptive-wrap is not clearly known.
It hasn't been a problem so far, and if/when it turns into a problem it
should be easy to address ;-)


        Stefan

Message #20 received at 48781 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 48781 <at> debbugs.gnu.org,
 jakanakaevangeli <at> chiru.no
Subject: Re: bug#48781: adaptive-wrap.el (elpa): Enable lexical binding
Date: Sun, 19 Sep 2021 09:52:04 -0700

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> To the extent that the code doesn't take advantage of lexical scoping,
>>> it doesn't matter because it will still work just as well as before on
>>> Emacs<24.
>> Sure; I was just concerned that somebody might take that as a sign to
>> add non-compatible code to lexical-bound files (like closures and other
>> nice stuff) in indeed backwards compatibility beyond Emacs 24 was an
>> issue (which it doesn't really seem to be).
>
> AFAIK the desired compatibility for adaptive-wrap is not clearly known.
> It hasn't been a problem so far, and if/when it turns into a problem it
> should be easy to address ;-)

Should we flip it to use lexical-binding then?

Message #23 received at 48781 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, jakanakaevangeli <at> chiru.no,
 48781 <at> debbugs.gnu.org
Subject: Re: bug#48781: adaptive-wrap.el (elpa): Enable lexical binding
Date: Mon, 20 Sep 2021 07:31:07 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Should we flip it to use lexical-binding then?

Looks like this was done here:

commit 1a3cdaf967dfe1f611b15d177a3f6da7e07624fb
Author:     jakanakaevangeli <jakanakaevangeli <at> chiru.no>
AuthorDate: Wed Jun 2 09:14:46 2021 -0400

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.