GNU bug report logs - #48862
[PATCH] gnu: python-hic2cool: Update to 0.8.3.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48862 in the body.
You can then email your comments to 48862 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: rekado <at> elephly.net, Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH] gnu: python-hic2cool: Update to 0.8.3.
Date: Sun, 6 Jun 2021 07:14:07 +0200

* gnu/packages/bioinformatics.scm (python-hic2cool): Update to 0.8.3.
---
 gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index dab097381a..66e69ff2c8 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -11892,18 +11892,34 @@ pyGenomeTracks can make plots with or without Hi-C data.")
 (define-public python-hic2cool
   (package
     (name "python-hic2cool")
-    (version "0.4.2")
+    (version "0.8.3")
+    ;; pypi sources do not contain the test_data directory and no test can be
+    ;; run
     (source
      (origin
-       (method url-fetch)
-       (uri (pypi-uri "hic2cool" version))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/4dn-dcic/hic2cool")
+             (commit version)))
+       (file-name (git-file-name name version))
        (sha256
         (base32
-         "0xy6mhfns2lzib1kcr6419jjp6pmh0qx8z8na55lmiwn0ds8q9cl"))))
+         "0dlnf0qfcp4jrc1nyya32a035c13xicyq16bwfnwhbb9s47mz7gl"))))
     (build-system python-build-system)
-    (arguments '(#:tests? #f)) ; no tests included
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;;two of the test-data files need to be writable
+         (add-after 'unpack 'patch-test-data
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (chmod "test_data/hic2cool_0.4.2_single_res.cool" #o600)
+             (chmod "test_data/hic2cool_0.7.0_multi_res.mcool" #o600))))))
     (propagated-inputs
-     `(("python-cooler" ,python-cooler)))
+     `(("python-cooler" ,python-cooler)
+       ("python-h5py" ,python-h5py)
+       ("python-numpy" ,python-numpy)
+       ("python-pandas" ,python-pandas)
+       ("python-scipy" ,python-scipy)))
     (home-page "https://github.com/4dn-dcic/hic2cool")
     (synopsis "Converter for .hic and .cool files")
     (description
-- 
2.31.1

Message #8 received at 48862 <at> debbugs.gnu.org (full text, mbox):

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <48862 <at> debbugs.gnu.org>
Subject: Re: [ext] bug#48862: Acknowledgement ([PATCH] gnu: python-hic2cool:
 Update to 0.8.3.)
Date: Sun, 6 Jun 2021 09:31:18 +0200

Hey Guix,


I made some changes to the commit message, I omitted some important 
information.

I will send another patch. Sorry for this!


All the best,

     Mădălin!

On 06.06.2021 07:15, GNU bug Tracking System wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>   guix-patches <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 48862 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
-- 
System Administrator
Bioinformatics and Omics Data Science
BIMSB - MDC

Message #11 received at 48862 <at> debbugs.gnu.org (full text, mbox):

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <48862 <at> debbugs.gnu.org>
Cc: rekado <at> elephly.net, Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH v2] gnu: python-hic2cool: Update to 0.8.3.
Date: Sun, 6 Jun 2021 09:32:53 +0200

* gnu/packages/bioinformatics.scm (python-hic2cool): Update to 0.8.3.
[source]: Changed from pypi to github, pypi sources do not contain tests.
[arguments]: Add build phase "patch-test-data" and removed #:tests? #f.
[propagated-inputs]: Add python-h5py, python-numpy, python-pandas and
python-scipy.
---
 gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index dab097381a..66e69ff2c8 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -11892,18 +11892,34 @@ pyGenomeTracks can make plots with or without Hi-C data.")
 (define-public python-hic2cool
   (package
     (name "python-hic2cool")
-    (version "0.4.2")
+    (version "0.8.3")
+    ;; pypi sources do not contain the test_data directory and no test can be
+    ;; run
     (source
      (origin
-       (method url-fetch)
-       (uri (pypi-uri "hic2cool" version))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/4dn-dcic/hic2cool")
+             (commit version)))
+       (file-name (git-file-name name version))
        (sha256
         (base32
-         "0xy6mhfns2lzib1kcr6419jjp6pmh0qx8z8na55lmiwn0ds8q9cl"))))
+         "0dlnf0qfcp4jrc1nyya32a035c13xicyq16bwfnwhbb9s47mz7gl"))))
     (build-system python-build-system)
-    (arguments '(#:tests? #f)) ; no tests included
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;;two of the test-data files need to be writable
+         (add-after 'unpack 'patch-test-data
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (chmod "test_data/hic2cool_0.4.2_single_res.cool" #o600)
+             (chmod "test_data/hic2cool_0.7.0_multi_res.mcool" #o600))))))
     (propagated-inputs
-     `(("python-cooler" ,python-cooler)))
+     `(("python-cooler" ,python-cooler)
+       ("python-h5py" ,python-h5py)
+       ("python-numpy" ,python-numpy)
+       ("python-pandas" ,python-pandas)
+       ("python-scipy" ,python-scipy)))
     (home-page "https://github.com/4dn-dcic/hic2cool")
     (synopsis "Converter for .hic and .cool files")
     (description
-- 
2.31.1

Message #16 received at 48862-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: rekado <at> elephly.net, 48862-done <at> debbugs.gnu.org
Subject: Re: [bug#48862] [PATCH] gnu: python-hic2cool: Update to 0.8.3.
Date: Mon, 7 Jun 2021 10:40:08 +0300

[Message part 1 (text/plain, inline)]

I made a few changes before pushing the patch.

On Sun, Jun 06, 2021 at 07:14:07AM +0200, Mădălin Ionel Patrașcu wrote:
> * gnu/packages/bioinformatics.scm (python-hic2cool): Update to 0.8.3.

I mentioned that the download changed to use git-fetch, the added phase
and enabled tests, and the added inputs.

> ---
>  gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index dab097381a..66e69ff2c8 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -11892,18 +11892,34 @@ pyGenomeTracks can make plots with or without Hi-C data.")
>  (define-public python-hic2cool
>    (package
>      (name "python-hic2cool")
> -    (version "0.4.2")
> +    (version "0.8.3")
> +    ;; pypi sources do not contain the test_data directory and no test can be
> +    ;; run
>      (source
>       (origin
> -       (method url-fetch)
> -       (uri (pypi-uri "hic2cool" version))
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/4dn-dcic/hic2cool")
> +             (commit version)))
> +       (file-name (git-file-name name version))
>         (sha256
>          (base32
> -         "0xy6mhfns2lzib1kcr6419jjp6pmh0qx8z8na55lmiwn0ds8q9cl"))))
> +         "0dlnf0qfcp4jrc1nyya32a035c13xicyq16bwfnwhbb9s47mz7gl"))))
>      (build-system python-build-system)
> -    (arguments '(#:tests? #f)) ; no tests included
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;;two of the test-data files need to be writable
> +         (add-after 'unpack 'patch-test-data
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (chmod "test_data/hic2cool_0.4.2_single_res.cool" #o600)
> +             (chmod "test_data/hic2cool_0.7.0_multi_res.mcool" #o600))))))

I changed this one to be 'lambda _' and I changed the chmods to
make-file-writable.

>      (propagated-inputs
> -     `(("python-cooler" ,python-cooler)))
> +     `(("python-cooler" ,python-cooler)
> +       ("python-h5py" ,python-h5py)
> +       ("python-numpy" ,python-numpy)
> +       ("python-pandas" ,python-pandas)
> +       ("python-scipy" ,python-scipy)))
>      (home-page "https://github.com/4dn-dcic/hic2cool")
>      (synopsis "Converter for .hic and .cool files")
>      (description
> -- 
> 2.31.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.