GNU bug report logs - #48865
[PATCH] Allow ‘ns-hide-emacs’ to bring only the selected frame forward

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48865 in the body.
You can then email your comments to 48865 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Beshara <m <at> mfa.pw>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow ‘ns-hide-emacs’ to bring
 only the selected frame forward
Date: Sun, 06 Jun 2021 15:23:31 +1000

[Message part 1 (text/plain, inline)]

Hi there,
I have attached a patch which adds a new capability to the 
‘ns-hide-emacs’ function in the NS port.  Specifically, it causes 
the ‘ns-hide-emacs’ function to respond to being called with the 
argument 'activate-front in a similar way to how it responds when 
called with 'activate.  The difference is, instead of layering 
every Emacs frame in front of every other application’s windows, 
it only brings the selected frame forward.  I have uploaded a 
small video of the new functionality in action here: 
https://mfa.pw/activate-front.mp4

Please let me know if any modifications would need to be made to
this patch before it could be accepted.

Thanks for your time,
Matt

[activate-front.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 48865 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Matt Beshara <m <at> mfa.pw>
Cc: 48865 <at> debbugs.gnu.org
Subject: Re: bug#48865: [PATCH] Allow ‘ns-hide-emacs’ to bring only the
 selected frame forward
Date: Fri, 11 Jun 2021 18:22:53 +0100

On Sun, Jun 06, 2021 at 03:23:31PM +1000, Matt Beshara wrote:
> Hi there,
> I have attached a patch which adds a new capability to the ‘ns-hide-emacs’
> function in the NS port.  Specifically, it causes the ‘ns-hide-emacs’
> function to respond to being called with the argument 'activate-front in a
> similar way to how it responds when called with 'activate.  The difference
> is, instead of layering every Emacs frame in front of every other
> application’s windows, it only brings the selected frame forward.  I have
> uploaded a small video of the new functionality in action here:
> https://mfa.pw/activate-front.mp4

Hi, I don't see any problems with this.

> Please let me know if any modifications would need to be made to
> this patch before it could be accepted.

If you could fill out the commit message in line with CONTRIBUTE, that
would be great.

Thanks!
-- 
Alan Third

Message #13 received at 48865 <at> debbugs.gnu.org (full text, mbox):

From: Matt Beshara <m <at> mfa.pw>
To: Alan Third <alan <at> idiocy.org>
Cc: 48865 <at> debbugs.gnu.org
Subject: Re: bug#48865: [PATCH] Allow ‘ns-hide-emacs’ to bring only the selected frame forward
Date: Sat, 12 Jun 2021 09:39:13 +1000

[Message part 1 (text/plain, inline)]

Alan Third <alan <at> idiocy.org> writes:

Hi Alan,
I’ve attached an updated patch.
Is the commit message OK?

Matt

> On Sun, Jun 06, 2021 at 03:23:31PM +1000, Matt Beshara wrote:
>> Hi there,
>> I have attached a patch which adds a new capability to the 
>> ‘ns-hide-emacs’
>> function in the NS port.  Specifically, it causes the 
>> ‘ns-hide-emacs’
>> function to respond to being called with the argument 
>> 'activate-front in a
>> similar way to how it responds when called with 'activate.  The 
>> difference
>> is, instead of layering every Emacs frame in front of every 
>> other
>> application’s windows, it only brings the selected frame 
>> forward.  I have
>> uploaded a small video of the new functionality in action here:
>> https://mfa.pw/activate-front.mp4
>
> Hi, I don't see any problems with this.
>
>> Please let me know if any modifications would need to be made 
>> to
>> this patch before it could be accepted.
>
> If you could fill out the commit message in line with 
> CONTRIBUTE, that
> would be great.
>
> Thanks!

[activate-front-2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 48865 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Matt Beshara <m <at> mfa.pw>
Cc: 48865 <at> debbugs.gnu.org
Subject: Re: bug#48865: [PATCH] Allow ‘ns-hide-emacs’ to bring only the
 selected frame forward
Date: Sat, 12 Jun 2021 10:15:58 +0100

On Sat, Jun 12, 2021 at 09:39:13AM +1000, Matt Beshara wrote:
> 
> Alan Third <alan <at> idiocy.org> writes:
> 
> Hi Alan,
> I’ve attached an updated patch.
> Is the commit message OK?

Near enough. I've made a few small changes and will push it. I take it
you've done the copyright paperwork?

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.