GNU bug report logs - #48867
[PATCH] gnu: Add guile-define.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48867 in the body.
You can then email your comments to 48867 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add guile-define.
Date: Sun, 06 Jun 2021 11:55:45 +0200

* gnu/packages/guile-xyz.scm (guile-define): New variable.
---
 gnu/packages/guile-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 6db5134344..6a84e5e052 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1230,6 +1230,32 @@ using S-expressions.")
 tracker's SOAP service, such as @url{https://bugs.gnu.org}.")
     (license license:gpl3+)))
 
+(define-public guile-define
+  (let ((changeset "76881ea2bb68")
+        (revision "0"))
+    (package
+      (name "guile-define")
+      (version (hg-version "0.0.0" revision changeset))
+      (source
+       (origin
+         (method hg-fetch)
+         (uri (hg-reference
+               (url "https://hg.sr.ht/~bjoli/guile-define")
+               (changeset changeset)))
+         (file-name (hg-file-name name version))
+         (sha256
+          (base32 "1ns8p1j88x0ms8xalagz3qxjkzzvcg3dppz4balfcnr5pzy8zm4p"))))
+      (build-system guile-build-system)
+      (arguments
+       `(#:scheme-file-regexp "define\\.scm$"))
+      (native-inputs
+       `(("guile" ,guile-3.0)))
+      (home-page "https://hg.sr.ht/~bjoli/guile-define")
+      (synopsis "Definitions in expression contexts for Guile")
+      (description "This package provides a utility macro to allow
+@code{define}s in expression contexts of function bodies.")
+      (license license:isc))))
+
 (define-public guile-email
   (package
     (name "guile-email")

base-commit: 9caf7112ee50af26fbc4c1bd3c337f1f86b710af
-- 
2.31.1

Message #8 received at 48867 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48867 <at> debbugs.gnu.org
Subject: Re: bug#48867: [PATCH] gnu: Add guile-define.
Date: Tue, 08 Jun 2021 23:26:36 +0200

Hi,

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> * gnu/packages/guile-xyz.scm (guile-define): New variable.

[...]

> +      (native-inputs
> +       `(("guile" ,guile-3.0)))
> +      (home-page "https://hg.sr.ht/~bjoli/guile-define")
> +      (synopsis "Definitions in expression contexts for Guile")
> +      (description "This package provides a utility macro to allow
> +@code{define}s in expression contexts of function bodies.")

This may have been useful with Guile 2.x but it’s useless with 3.0,
which already allows that:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (version)
$9 = "3.0.7"
scheme@(guile-user)> (define (divide-minus-one a b)
		       (when (= b 1) (error "We don't allow that here"))
		       (define b* (- b 1))
		       (/ a b*))
scheme@(guile-user)>
--8<---------------cut here---------------end--------------->8---

So either we make the package depend on 2.x, or we drop it.  Dropping it
is probably the best option if there are no dependents.

Thoughts?

Ludo’.

Message #11 received at 48867 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48867 <at> debbugs.gnu.org
Subject: Re: [bug#48867] [PATCH] gnu: Add guile-define.
Date: Wed, 09 Jun 2021 13:15:42 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jun 08 2021, Ludovic Courtès wrote:

> Hi,
>
> Xinglu Chen <public <at> yoctocell.xyz> skribis:
>
>> * gnu/packages/guile-xyz.scm (guile-define): New variable.
>
> [...]
>
>> +      (native-inputs
>> +       `(("guile" ,guile-3.0)))
>> +      (home-page "https://hg.sr.ht/~bjoli/guile-define")
>> +      (synopsis "Definitions in expression contexts for Guile")
>> +      (description "This package provides a utility macro to allow
>> +@code{define}s in expression contexts of function bodies.")
>
> This may have been useful with Guile 2.x but it’s useless with 3.0,
> which already allows that:
>
> --8<---------------cut here---------------start------------->8---
> scheme@(guile-user)> (version)
> $9 = "3.0.7"
> scheme@(guile-user)> (define (divide-minus-one a b)
> 		       (when (= b 1) (error "We don't allow that here"))
> 		       (define b* (- b 1))
> 		       (/ a b*))
> scheme@(guile-user)>
> --8<---------------cut here---------------end--------------->8---
>
> So either we make the package depend on 2.x, or we drop it.  Dropping it
> is probably the best option if there are no dependents.
>
> Thoughts?

Oh, I didn’t know that, then I think it’s fine to drop the package.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.