GNU bug report logs - #48893
[PATCH] New package: ack

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48893 in the body.
You can then email your comments to 48893 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] New package: ack
Date: Sun,  6 Jun 2021 16:51:49 -0700

ack is a grep-like source code search tool.

Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
---
 gnu/packages/search.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 362eb0d95e..a131678936 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018 Adam Massmann <massmannak <at> gmail.com>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
+;;; Copyright © 2021 Ryan Sundberg <ryan <at> arctype.co>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,11 +25,12 @@
 
 (define-module (gnu packages search)
   #:use-module ((guix licenses)
-                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
+                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
@@ -50,6 +52,32 @@
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml))
 
+
+(define-public ack
+  (package
+    (name "ack")
+    (version "3.5.0")
+    (source 
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://beyondgrep.com/ack-v" version))
+        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
+    (inputs `(("perl" ,perl)))
+    (build-system copy-build-system)
+    (arguments 
+      `(#:install-plan '(("ack" "bin/ack"))
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'unpack 
+                   (lambda* (#:key source #:allow-other-keys)
+                     (copy-file source "ack")
+                     (chmod "ack" #o0755)
+                     #t)))))
+    (home-page "https://github.com/protojure/protoc-plugin")
+    (synopsis "ack is a grep-like source code search tool.")
+    (description "Designed for programmers with large heterogeneous trees of source code, ack is written in portable Perl 5 and takes advantage of the power of Perl's regular expressions. ack is designed as an alternative to grep for programmers.")
+    (license artistic2.0)))
+
 (define-public xapian
   (package
     (name "xapian")
-- 
2.31.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] New package: ack
Date: Sun,  6 Jun 2021 16:58:53 -0700

ack is a grep-like source code search tool.

(The previous patch had the wrong home-page set.)

Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
---
 gnu/packages/search.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 362eb0d95e..e4f48d5906 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2018 Adam Massmann <massmannak <at> gmail.com>
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
+;;; Copyright © 2021 Ryan Sundberg <ryan <at> arctype.co>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,11 +25,12 @@
 
 (define-module (gnu packages search)
   #:use-module ((guix licenses)
-                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
+                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix utils)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
@@ -50,6 +52,31 @@
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml))
 
+(define-public ack
+  (package
+    (name "ack")
+    (version "3.5.0")
+    (source 
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://beyondgrep.com/ack-v" version))
+        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
+    (inputs `(("perl" ,perl)))
+    (build-system copy-build-system)
+    (arguments 
+      `(#:install-plan '(("ack" "bin/ack"))
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'unpack 
+                   (lambda* (#:key source #:allow-other-keys)
+                     (copy-file source "ack")
+                     (chmod "ack" #o0755)
+                     #t)))))
+    (home-page "https://beyondgrep.com/")
+    (synopsis "ack is a grep-like source code search tool.")
+    (description "Designed for programmers with large heterogeneous trees of source code, ack is written in portable Perl 5 and takes advantage of the power of Perl's regular expressions. ack is designed as an alternative to grep for programmers.")
+    (license artistic2.0)))
+
 (define-public xapian
   (package
     (name "xapian")
-- 
2.31.1

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] New package: ack
Date: Wed, 9 Jun 2021 00:12:30 -0700

[Message part 1 (text/plain, inline)]

Revised ack patch per coding standards.

--
Sincerely,
Ryan Sundberg

On 6/6/21 4:58 PM, Ryan Sundberg wrote:
> ack is a grep-like source code search tool.
> 
> (The previous patch had the wrong home-page set.)
> 
> Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
> ---
>  gnu/packages/search.scm | 29 ++++++++++++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
> index 362eb0d95e..e4f48d5906 100644
> --- a/gnu/packages/search.scm
> +++ b/gnu/packages/search.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright © 2018, 2020, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
>  ;;; Copyright © 2018 Adam Massmann <massmannak <at> gmail.com>
>  ;;; Copyright © 2020 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
> +;;; Copyright © 2021 Ryan Sundberg <ryan <at> arctype.co>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -24,11 +25,12 @@
>  
>  (define-module (gnu packages search)
>    #:use-module ((guix licenses)
> -                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license))
> +                #:select (gpl2 gpl2+ gpl3+ lgpl2.1+ bsd-3 x11 perl-license artistic2.0))
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
>    #:use-module (guix utils)
> +  #:use-module (guix build-system copy)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system perl)
>    #:use-module (guix build-system python)
> @@ -50,6 +52,31 @@
>    #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages xml))
>  
> +(define-public ack
> +  (package
> +    (name "ack")
> +    (version "3.5.0")
> +    (source 
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://beyondgrep.com/ack-v" version))
> +        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
> +    (inputs `(("perl" ,perl)))
> +    (build-system copy-build-system)
> +    (arguments 
> +      `(#:install-plan '(("ack" "bin/ack"))
> +        #:phases
> +        (modify-phases %standard-phases
> +          (replace 'unpack 
> +                   (lambda* (#:key source #:allow-other-keys)
> +                     (copy-file source "ack")
> +                     (chmod "ack" #o0755)
> +                     #t)))))
> +    (home-page "https://beyondgrep.com/")
> +    (synopsis "ack is a grep-like source code search tool.")
> +    (description "Designed for programmers with large heterogeneous trees of source code, ack is written in portable Perl 5 and takes advantage 
of the power of Perl's regular expressions. ack is designed as an alternative to grep for programmers.")
> +    (license artistic2.0)))
> +
>  (define-public xapian
>    (package
>      (name "xapian")
> 

[0001-gnu-Add-ack-version-3.5.0.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #14 received at 48893 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ryan Sundberg <ryan <at> arctype.co>
Cc: 48893 <at> debbugs.gnu.org
Subject: Re: bug#48893: [PATCH] New package: ack
Date: Sun, 13 Jun 2021 22:46:49 +0200

Hi,

Ryan Sundberg <ryan <at> arctype.co> skribis:

> From fea54a57b5b4e1cdc6bd642ae499fbaafad5cb62 Mon Sep 17 00:00:00 2001
> From: Ryan Sundberg <ryan <at> arctype.co>
> Date: Sun, 31 Jan 2021 10:29:47 -0800
> Subject: [PATCH] gnu: Add ack version 3.5.0
>
> * gnu/packages/search.scm (ack): New variable.
>
> Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>

Overall this LGTM.  However…

> +(define-public ack
> +  (package
> +    (name "ack")
> +    (version "3.5.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://beyondgrep.com/ack-v" version))
> +        (sha256 (base32 "17wq9c1pwisbg4mcmvmdaym8hlawx209iriaxjlw9hwi0v4x6w38"))))
> +    (inputs `(("perl" ,perl)))
> +    (build-system copy-build-system)

… I noticed this:

--8<---------------cut here---------------start------------->8---
$ head -4 $(./pre-inst-env guix build ack)/bin/ack
#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl
#
# This file, ack, is generated code.
# Please DO NOT EDIT or send patches for it.
--8<---------------cut here---------------end--------------->8---

Could you arrange so that the ‘ack’ file is “built from source”?
We usually try hard to build everything from source.

Thanks in advance,
Ludo’.

Message #19 received at 48893-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ryan Sundberg <ryan <at> arctype.co>
Cc: 48893-done <at> debbugs.gnu.org
Subject: Re: bug#48893: [PATCH] New package: ack
Date: Mon, 29 May 2023 13:35:19 +0200

The package ack was made available in commit
1051db25267a9bbc0ad38be2f3ec92af40f18e18, so closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.