GNU bug report logs - #48918
[PATCH 1/2] gnu: python-pyzmq: Enable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48918 in the body.
You can then email your comments to 48918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 1/2] gnu: python-pyzmq: Enable tests.
Date: Tue,  8 Jun 2021 13:20:29 +0000

* gnu/packages/python-xyz.scm (python-pyzmq)[arguments]: Remove #:tests?. Add
phase to build Cython extensions before tests.
[native-inputs]: Remove python-nose. Add python-cython, python-pytest.
---
 gnu/packages/python-xyz.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9f961756b1..367c75f0f7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9162,14 +9162,18 @@ applications.")
     (arguments
      `(#:configure-flags
        (list (string-append "--zmq=" (assoc-ref %build-inputs "zeromq")))
-       ;; FIXME: You must build pyzmq with 'python setup.py build_ext
-       ;; --inplace' for 'python setup.py test' to work.
-       #:tests? #f))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'build-ext
+           (lambda _
+             ;; Cython extensions have to be built before running the tests.
+             (invoke "python" "setup.py" "build_ext" "--inplace"))))))
     (inputs
      `(("zeromq" ,zeromq)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
-       ("python-nose" ,python-nose)))
+       ("python-cython" ,python-cython)
+       ("python-pytest" ,python-pytest)))
     (home-page "https://github.com/zeromq/pyzmq")
     (synopsis "Python bindings for 0MQ")
     (description
-- 
2.31.1

Message #8 received at 48918 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 48918 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 2/2] gnu: python-pyzmq: Update to 22.1.0.
Date: Tue,  8 Jun 2021 13:21:53 +0000

* gnu/packages/python-xyz.scm (python-pyzmq): Update to 22.1.0.
---
 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 367c75f0f7..89a4d44386 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9151,13 +9151,13 @@ applications.")
 (define-public python-pyzmq
   (package
     (name "python-pyzmq")
-    (version "22.0.3")
+    (version "22.1.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "pyzmq" version))
        (sha256
-        (base32 "0bgrn65cxfz1c1sjrgyq5dy1mkhppxxbizd5wvrl03cq4zhkrxpp"))))
+        (base32 "0pa1y97z75xqyca9xfp9zrzksydbgzsxf8yh0hwp0rgahpfxch3h"))))
     (build-system python-build-system)
     (arguments
      `(#:configure-flags
-- 
2.31.1

Message #13 received at 48918-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 48918-done <at> debbugs.gnu.org
Subject: Re: [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests.
Date: Tue, 8 Jun 2021 13:46:53 -0400

On Tue, Jun 08, 2021 at 01:20:29PM +0000, Vinicius Monego wrote:
> * gnu/packages/python-xyz.scm (python-pyzmq)[arguments]: Remove #:tests?. Add
> phase to build Cython extensions before tests.
> [native-inputs]: Remove python-nose. Add python-cython, python-pytest.

Thanks!

I renamed the new phase to 'build-extensions', because we typically try
to avoid abbreviations. They can be confusing to those who are not
fluent in English.

Pushed as 172a0794bb9fe3af77ea459145bf7364b82c5cf2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.