Received: (at 48925) by debbugs.gnu.org; 14 Nov 2021 06:57:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 14 01:57:44 2021 Received: from localhost ([127.0.0.1]:48958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mm9SS-00034o-0c for submit <at> debbugs.gnu.org; Sun, 14 Nov 2021 01:57:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1mm9SQ-00034X-MZ for 48925 <at> debbugs.gnu.org; Sun, 14 Nov 2021 01:57:43 -0500 Received: from [2001:470:142:3::e] (port=44816 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1mm9SL-0001hS-1H; Sun, 14 Nov 2021 01:57:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rcic6YZczvnMDAbuIaiovp6b5JxBxA04rCVmo4cfkzM=; b=Ka6mrtzV0tny Jpxh3neXSo0ce+vp1CNtlo3ZbIXIi9B0dFc3JaGclMZgGpmqGB8g6jadQmMJLlYWShsX0md/9OUYO p9dAPn43NCPMNsqLkcgCNPV5GXhVrIpHlyzBmo/0NDI2idObpeZzX3S7xv/DXJi9t0TftvJShuD+o Ef+eUC/Ek2CAIpVg+k2mp/t6foPcO0DIecycscEE6P9DGtmYPBftEpoQ8QXX/ZKQXSDjen7hO1opd d8WNKRMmt7hG4lTiQA30UcYq4ZA8Ru8IcHQVfjYNcrK1Sn8jj121Q3jJEGL/h/p+JRkB+ofCofVeJ +N0wJkJIL2MNoBRgIf869A==; Received: from [87.69.77.57] (port=3473 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1mm9SK-0005oB-Kz; Sun, 14 Nov 2021 01:57:36 -0500 Date: Sun, 14 Nov 2021 08:57:23 +0200 Message-Id: <83ee7jw7fw.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> In-Reply-To: <87ee7jh87y.fsf@HIDDEN> (message from Lars Ingebrigtsen on Sun, 14 Nov 2021 01:49:37 +0100) Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> <871r3m7uzl.fsf@HIDDEN> <83h7ci22ve.fsf@HIDDEN> <87lf1u3x9h.fsf@HIDDEN> <83fss1zr89.fsf@HIDDEN> <87ee7jh87y.fsf@HIDDEN> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 48925 Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) > From: Lars Ingebrigtsen <larsi@HIDDEN> > Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org > Date: Sun, 14 Nov 2021 01:49:37 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Given what Miha wrote, maybe we don't need to make any changes at all > > here? > > In which message? https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48925#34
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 14 Nov 2021 00:49:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 13 19:49:50 2021 Received: from localhost ([127.0.0.1]:48514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mm3iP-0004rO-RV for submit <at> debbugs.gnu.org; Sat, 13 Nov 2021 19:49:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mm3iN-0004rA-BN for 48925 <at> debbugs.gnu.org; Sat, 13 Nov 2021 19:49:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kj5nOZ3T18SQzuQigkGKpGVDWNpEy4ljinpINc4FvJ8=; b=bnItAYlR44bcEaIjhBzKTzhiEi mUMVRzs+alRGvY6cb1HsSAkXw9vooZNQSW52ZeO3Y6m+BJ3nI7iW71gVP8OLeuX12RWAqR3aFbBqJ yXvltvdvpCccxnTmj5bf0R8m3MGu+2KNYwK2RaOXyDKshhbAiPrWr1DYi5KV6Kt7J61o=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mm3iD-0005eo-TR; Sun, 14 Nov 2021 01:49:40 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> <871r3m7uzl.fsf@HIDDEN> <83h7ci22ve.fsf@HIDDEN> <87lf1u3x9h.fsf@HIDDEN> <83fss1zr89.fsf@HIDDEN> X-Now-Playing: David Allred's _Smells Like Everyone's Watching_: "Film" Date: Sun, 14 Nov 2021 01:49:37 +0100 In-Reply-To: <83fss1zr89.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 12 Nov 2021 10:57:10 +0200") Message-ID: <87ee7jh87y.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > The probability is low, indeed, but it isn't zero. Given such a low probability, it's worth a shot. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48925 Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: > The probability is low, indeed, but it isn't zero. Given such a low probability, it's worth a shot. > Given what Miha wrote, maybe we don't need to make any changes at all > here? In which message? I re-skimmed the thread, but didn't see Miha saying that it's not needed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 12 Nov 2021 08:57:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 12 03:57:38 2021 Received: from localhost ([127.0.0.1]:43420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mlSNO-00030u-67 for submit <at> debbugs.gnu.org; Fri, 12 Nov 2021 03:57:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1mlSNL-00030i-JL for 48925 <at> debbugs.gnu.org; Fri, 12 Nov 2021 03:57:36 -0500 Received: from [2001:470:142:3::e] (port=36804 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1mlSNF-00077H-RC; Fri, 12 Nov 2021 03:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D6Ba1Jeo9ebCAih3ialUgcImccq5eXyCenHuFVwAyTQ=; b=giPDn0kcap9t UZ8aryYCa2u4mKNEEuFQg7NV/xyL2NtI1QiK+o97KiXfCJXmkF9epKiNPuWlnVDPF+nrmq3HN48bl bMXhlBCX0gwN8JvciGCaAylUSsQNhS82OJKEI3jC+Z7BKLTKfkaH3fwBM65PyLbDoTRKjJhfJM2ii 09+mrSA0bUBjpFYBsOvk4FIT0UI9pbuAtWQG5pWUCwZT4SaPiva1m7fitbp1W4ZMgk7nlWJ4MwuGI LDHfZOwSQ8YLJ0MAXED66Gr+G+kqytM23TVprQBLI3Cb8u04lMJMxT+gXkSC65p0sayGQyYceq/G2 XWUa0SOJoDhcLUDB5wwJug==; Received: from [87.69.77.57] (port=4151 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1mlSNF-0003Hm-97; Fri, 12 Nov 2021 03:57:29 -0500 Date: Fri, 12 Nov 2021 10:57:10 +0200 Message-Id: <83fss1zr89.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> In-Reply-To: <87lf1u3x9h.fsf@HIDDEN> (message from Lars Ingebrigtsen on Fri, 12 Nov 2021 03:47:54 +0100) Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> <871r3m7uzl.fsf@HIDDEN> <83h7ci22ve.fsf@HIDDEN> <87lf1u3x9h.fsf@HIDDEN> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 48925 Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) > From: Lars Ingebrigtsen <larsi@HIDDEN> > Cc: miha@HIDDEN, monnier@HIDDEN, 48925 <at> debbugs.gnu.org > Date: Fri, 12 Nov 2021 03:47:54 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > I didn't say it will be a problem now. But it's a time bomb waiting > > to go off. So I'd like to see if we could still do this in C. > > It's possible, of course, but it does seem unlikely that we'd start > using `read-string' during the early build. (Especially since we're > apparently not doing that now.) I'm having a hard time imagining when > there'd be a call to that function at that point. The probability is low, indeed, but it isn't zero. Given what Miha wrote, maybe we don't need to make any changes at all here?
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 12 Nov 2021 02:48:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 21:48:10 2021 Received: from localhost ([127.0.0.1]:42737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mlMbq-0006kd-0a for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 21:48:10 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1mlMbn-0006kD-Fd for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 21:48:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=h8TilE19tgAeBdf6xaAQQaZVRYk5sZEnmnH2mxdhcVo=; b=KdU/xJKI3MT6VoNKYTdN4CqACA E8vogG96fCwHi3lc+f8Nb5A36zZYjSE3MMBNKUBRJ8USc+yUZrBXpBtqXOTfH3rT1mJabuxIkvRLP jv/3OUYqu5+qTyiFRiKggFBLEaZqUXlGvYwTIFHSsBL8SNZ3zOr8WVrKJFGjQ48Dfu3w=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1mlMbc-0003Iq-JW; Fri, 12 Nov 2021 03:47:59 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> <871r3m7uzl.fsf@HIDDEN> <83h7ci22ve.fsf@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUODAY1MxhAPiBT USw2NR9kZFGZkW1eXDVoa0usqKKHeUzEpWT///+wUHC2AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UL DAIpJ1WTUNYAAAF+SURBVDjLrdTPTsIwHAdwUB7A4XwAuvoCq7DFG6P4BoXxACObnkhDftM7dBwN Abl7Mt6NkZezWwfZn+5g4u+yrZ98f7+2h7Vasoy0kG0jhCimNPtsnapNh4ZJqYmNAvTHt2ywSNaT dRh0i4nJbLabLeZRFIYHCcMzjG6uyXgBLy4H4VEvk/MMY9Tt9WQbbGKcilpsy7mEk7wsksPV5GHA gsPbIXqNnjf7j2grI/lw1t/tD3sJm/k6irZeDtQ0TA+mANwBcFzCES4cULZWdUcsuwTFQsMGsHt1 ABWpw2MFOieYN8FRDam3OvIGeOKVVulu0rXPSqID+e3G6nmGC3lTIFPu8b0MHVB1/1VPKPhpAPeb lOGyAFCCREEcEp5usAwiA/nCiyAgFiJWACUQcaIFVf8P/G8gdJBISBogTntpwEkS3a58BbpWDpPX xnUJ5ieiCv7KD4kGVj5LgckplQTLQVRgJSGwNIkpLJeBBacDZj8Vw8YIIw+PAkw9+Xv6BSN2BWHG DGGXAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTExLTEyVDAyOjQxOjM5KzAwOjAwjWe4ywAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMS0xMlQwMjo0MTozOSswMDowMPw6AHcAAAAASUVORK5CYII= X-Now-Playing: Sonic Youth's _Daydream Nation (1)_: "Eric's Trip (Home Demo)" Date: Fri, 12 Nov 2021 03:47:54 +0100 In-Reply-To: <83h7ci22ve.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 11 Nov 2021 16:17:25 +0200") Message-ID: <87lf1u3x9h.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > I didn't say it will be a problem now. But it's a time bomb waiting > to go off. So I'd like to see if we could still do this in C. It's possible, of course, but it does seem unlikely that we'd start using `read-string' during the early build. (Especially since we're apparently not doing that now.) I'm having a hard time imagining [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48925 Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: > I didn't say it will be a problem now. But it's a time bomb waiting > to go off. So I'd like to see if we could still do this in C. It's possible, of course, but it does seem unlikely that we'd start using `read-string' during the early build. (Especially since we're apparently not doing that now.) I'm having a hard time imagining when there'd be a call to that function at that point. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 12 Nov 2021 00:23:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 19:23:01 2021 Received: from localhost ([127.0.0.1]:42590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mlKLN-0000nn-36 for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 19:23:01 -0500 Received: from heytings.org ([95.142.160.155]:59418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gregory@HIDDEN>) id 1mlKLL-0000ne-RG for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 19:23:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1636676578; bh=KOWZWKHEW6d8kJWLx6c3yR1iOKOZaKgjT6dV56q3j64=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=mHtlS6Xz7gyGj7XPxSYmQOSAloBIfEXWTq9C7vzgOM+CXpibaM5va54PDbnzwv5W3 QRBTRdlFmvLTcUYVRigyT4tUg721uVKpx8joc7qbWGScf4VMbXou84IxI9miHXKLXr KqAz+CG8Db7H9lscpe/ej4EiE82xe9N3xOlVtYS7p1OoT9uAzGcumGMlqi7MlWY4qm SnUnE9gff+2ckiUq2/cuPKCfrfEXvK8XTd0F19ZTjGvZ1MK7ph5dRT18yQpGdkIjrT bd2WkgcV8rl7sIGaWsYWb/tc2yEyB/Hbe+tm6JiFRlHEJ28XLgBjymv6dXGiN6k364 kTQMcknH2pWvg== Date: Fri, 12 Nov 2021 00:22:58 +0000 From: Gregory Heytings <gregory@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places In-Reply-To: <jwvy25uqmcm.fsf-monnier+emacs@HIDDEN> Message-ID: <993162c2a1e7b3de58bd@HIDDEN> References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> <jwvy25uqmcm.fsf-monnier+emacs@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48925 Cc: Eli Zaretskii <eliz@HIDDEN>, larsi@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) >> What is awkward to do in C? > > We don't have anby facility to create closures from C, so we'd basically > have to call an ELisp function to create the closure. > BTW, these patches would be much simpler and this discussion would not exist with the approach I defended in bug#45474.
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 23:58:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 18:58:58 2021
Received: from localhost ([127.0.0.1]:42552 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mlJy6-0000BA-NU
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 18:58:58 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37803)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1mlJy5-0000At-VH
for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 18:58:58 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D6334440B69;
Thu, 11 Nov 2021 18:58:51 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 10108440B45;
Thu, 11 Nov 2021 18:58:50 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1636675130;
bh=tT0+bjkhoVPzFksJ1HiibhaXJoxQytYoTcA51ve5NQo=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=LnPknv+ysPnXA8kDIlbvI+OeYi9KnsOF7F41xaq+2zArYfIf7vQa7r38OpMu5EM9i
lvorvvyjo8WdWA+8ZjRZ7fALIM2dJ5F682a+Bfl3zouSPI4EGlDiS6E14geNjR3eW2
4l7s4BWdllMdgKoz+KU/qiQjO5a2k/NXlywujNjtNHr33N0KJ//+h4aUAURCZ6eiZo
hpKmZEos4Vo5k67IjzksOksrFQJkbj5/b69tOndbQhYim7QzG1gaC0mQaeVldBB+wv
/PlGPPtQMIo89vd5sctkNuDUUqiRS3b/6mI5DadpUqS00VGJhl1ealVXIkV9Nhpqwr
hfhWbXB+k2LCQ==
Received: from milanesa (unknown [45.72.241.23])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B8B641209AF;
Thu, 11 Nov 2021 18:58:49 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables
buffer-locally in a few more places
Message-ID: <jwvy25uqmcm.fsf-monnier+emacs@HIDDEN>
References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN>
<87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc>
<83lf1v0w6y.fsf@HIDDEN>
Date: Thu, 11 Nov 2021 18:58:51 -0500
In-Reply-To: <83lf1v0w6y.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 11 Nov
2021 13:27:01 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.064 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48925
Cc: larsi@HIDDEN, 48925 <at> debbugs.gnu.org, miha@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Moving read-string to subr.el means the function will be unavailable
> during loadup until subr.elc is loaded.
I believe this should not be a problem: `read-string` is only used for
interaction with the user so it's never used until much later than the
load of `subr.el` (it's not used during bootstrap).
> What is awkward to do in C?
We don't have anby facility to create closures from C, so we'd basically
have to call an ELisp function to create the closure.
Stefan
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 16:46:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 11:46:25 2021
Received: from localhost ([127.0.0.1]:42103 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mlDDV-0001O6-0m
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 11:46:25 -0500
Received: from kamnitnik.top ([209.250.245.214]:46192)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <miha@HIDDEN>) id 1mlDDH-0001Nj-2o
for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 11:46:23 -0500
Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43])
by kamnitnik.top (Postfix) with ESMTPSA id 9A5E99CFAE;
Thu, 11 Nov 2021 16:46:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top;
s=mail; t=1636649169;
bh=RhxsdcRoHoVfNcPZIjyWcGQRqqPnu16U6w5M43WEpVI=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=lMguU6u7/RtEcJmhoEzGztCpvjc5JFBM1+sMwACrfEb1OR78hfXbhq3t47Q9j32uU
CI4lYKmxPCcWclh9hSaWcxFkb8xYnhyJ2vHD6jj022GoZykhHKYBmkrYHSw0D77tNV
dRhfUJrQzhD+giOiff8bXxeg27yKUqmIF7wrNHNopi09Nmjk7MBvrtrmkmYtSqzNfO
CiRy6SHif4OFHlUddgx5RwlR/lamWi2SfXE8+2ytN167dmqf8tGqRQYxsgTU57LuVr
hjGD7ILu07a4XZ033q7hak4UEbVrGCspRf8HN4wh+3jzs/n0R+hyEK6gCnBR1lUErM
hOWWWxLaJE+bA==
From: <miha@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables
buffer-locally in a few more places
In-Reply-To: <83h7ci22ve.fsf@HIDDEN>
References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN>
<87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc>
<83lf1v0w6y.fsf@HIDDEN> <871r3m7uzl.fsf@HIDDEN>
<83h7ci22ve.fsf@HIDDEN>
Date: Thu, 11 Nov 2021 17:50:33 +0100
Message-ID: <87fss2hc12.fsf@miha-pc>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Lars
Ingebrigtsen
<larsi@HIDDEN> >> Cc: <miha@HIDDEN>, monnier@HIDDEN,
48925 <at> debbugs.gnu.org
>> Date: Thu, 11 Nov 2021 13:11:10 +0100 >> >> Eli Zaretskii <eliz@HIDDEN>
wri [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
X-Debbugs-Envelope-To: 48925
Cc: monnier@HIDDEN, 48925 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Lars Ingebrigtsen
<larsi@HIDDEN> >> Cc: <miha@HIDDEN>, monnier@HIDDEN, 48925 <at> debbugs.gnu.org
>> Date: Thu, 11 Nov 2021 13:11:10 +0100 >> >> Eli Zaretskii <eliz@HIDDEN>
wri [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Lars Ingebrigtsen <larsi@HIDDEN>
>> Cc: <miha@HIDDEN>, monnier@HIDDEN, 48925@HIDDEN=
org
>> Date: Thu, 11 Nov 2021 13:11:10 +0100
>>=20
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>=20
>> > Moving read-string to subr.el means the function will be unavailable
>> > during loadup until subr.elc is loaded.
>>=20
>> That's a worry, so I tried Miha's patch now and did both a "make" and a
>> "make bootstrap", and both completed without any problems.
>
> I didn't say it will be a problem now. But it's a time bomb waiting
> to go off. So I'd like to see if we could still do this in C.
In that case, my personal opinion is that it's okay to leave it as is
and close this bug.
The specbinding in `read-string' isn't a very big problem. The only
problematic case I can think of is quite specific: the user runs a
function that let-binds `minibuffer-completion-table' around a call to
`read-from-minibuffer' (this is the old convention, the new convection
is to set the completion table buffer locally), and then recursively
uses `read-string' during this minibuffer session on a separate frame
with `minibuffer-follows-selected-frame' customized to nil. Completion
commands will now not work in the outer minibuffer.
IMO, it's not really worth trying too hard to figure out a way to fix
this very specific issue in C. One simple solution would be to introduce
a new optional argument to `read-from-minibuffer', a function that would
be run in the minibuffer as an alternative to
minibuffer-with-setup-hook. I believe Stefan M. proposed something like
this, but this should probably be discussed more thoroughly.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmGNSdkTHG1paGFAa2Ft
bml0bmlrLnRvcAAKCRCzCRoakhWZP93EEACZGd+bjGXbX8d9NLo41Y5Ew7KuaCPi
n8C+2YpM0tSisOcytaxp7GP7xxz7t0OKREGm/ifBuaBIM0naZ/8YWScfQahMLTRv
u8ATDa9LOfmDk2iufnYA/OgNMJ8L+BCWCmUB6WHNR/dSQgwKbE97jhfEQL5LlOwW
waOXP4WLEYwvChQK6j0tWygByJu5BY3ScIa2/ydlfD6c6YteF1ge6KkZlqDvv0Hi
Bt7/P2xKVdip8M0/TxYzS4FifuP3nLCA4nfp9ZGxgF1LkOUOU45k4va12ECYxwML
l2cPRf652KyNXYQBtzCdomBpVl0wzJxxcBe22745Y+n/sA3tVv0BBwBP9buYd/2n
QrYJbJ1om5DjRozvvdrXI50U9HrobvqU4lileSVo8VvmwkZJhqEnoFQgCQ4OPQeq
b5tf2vmcYo+pyuwrBNoPrtBNw5Q2U9CNQLOpfQEO0JcxwB73LxiwXt9OWcwswUFC
5fKoodemNJKdCpAxWYeNXg698lZJl2wLV+RTWaTkNJ2mdNdkd5Ch0xdAmFCe7oZr
Ou2TvVVTFf0ruHgbeOTfNv2MrWty1MMnLZrh7tfog5gozlK97cp/TAkfqTMMEjHb
BER2fuijLMAPJH9JnA4HDCKeZRAh0/HqV74vMAykqG/Rp2jNkMdC7QDknYzam6mw
8dt4LAzyyzuK8w==
=XIbd
-----END PGP SIGNATURE-----
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 14:17:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 09:17:41 2021 Received: from localhost ([127.0.0.1]:40449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mlAtY-0004xL-Ok for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 09:17:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1mlAtT-0004x3-8Q for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 09:17:39 -0500 Received: from [2001:470:142:3::e] (port=54480 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1mlAtM-0006sW-KE; Thu, 11 Nov 2021 09:17:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3cD2zasS22VhsnzNRWHQZ2d+KzW7TBk513dUIKMwMLI=; b=aTBNg2rIzwXG Y/QEZG3ZoFQ0cl8RQh8m0jTOCB/3+8HTvPXAePVypYzSdAzgfKlOGgtxH5tsgXdrQB6YlQEoe6L1y cyjRN0kVdlmNaexbqMhEfTMOSfGA1/cTb8WgdpIhQAtJnek2OMrXb6AqeglP4DmMB9p4ing7/3H6I kDV3D+Hjyxcb3rCs5V/VIElLmZIY7tHl0cfPqHWAU1uKfVTjLlQak1nU1AEeqkBU0HBYfWJ/B30AV dzGtnPnz3Gkbv37+4i381fw0puCZ63Ztu7ENhGQIn9UnKiLOPmiWngTTcTZpXErmiZlhRAGKPko59 nk9wiEWgUkBjc21i82V9LQ==; Received: from [87.69.77.57] (port=2912 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1mlAtM-0004gd-4x; Thu, 11 Nov 2021 09:17:28 -0500 Date: Thu, 11 Nov 2021 16:17:25 +0200 Message-Id: <83h7ci22ve.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lars Ingebrigtsen <larsi@HIDDEN> In-Reply-To: <871r3m7uzl.fsf@HIDDEN> (message from Lars Ingebrigtsen on Thu, 11 Nov 2021 13:11:10 +0100) Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> <871r3m7uzl.fsf@HIDDEN> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 48925 Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) > From: Lars Ingebrigtsen <larsi@HIDDEN> > Cc: <miha@HIDDEN>, monnier@HIDDEN, 48925 <at> debbugs.gnu.org > Date: Thu, 11 Nov 2021 13:11:10 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Moving read-string to subr.el means the function will be unavailable > > during loadup until subr.elc is loaded. > > That's a worry, so I tried Miha's patch now and did both a "make" and a > "make bootstrap", and both completed without any problems. I didn't say it will be a problem now. But it's a time bomb waiting to go off. So I'd like to see if we could still do this in C.
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 12:59:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 07:59:56 2021
Received: from localhost ([127.0.0.1]:40382 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ml9gK-0002j6-8E
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 07:59:56 -0500
Received: from kamnitnik.top ([209.250.245.214]:44932)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <miha@HIDDEN>) id 1ml9gI-0002iy-Mz
for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 07:59:55 -0500
Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43])
by kamnitnik.top (Postfix) with ESMTPSA id 764CD9CFA8;
Thu, 11 Nov 2021 12:59:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top;
s=mail; t=1636635593;
bh=JnCp4XYbdQqejDLgzDGYuyGtLbVpSRPUBtywm0++CeU=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=mpTdyf3QX+YdxHVrv3r/hMjYIuBUYuM5VGP7N/OWtlpd14FI81npsOYL4hsKbPqdt
YQbeipoCV4e8USes8hN7QKcYmyhLCby9SCXA7KYky+Qne0aE1+4zdF/qMATF9qROLc
joIEkjTHb7hMPDKKB3YTWMaG8btfXKkC/q8vNxplFWQ0+EXKQ6BuHLDN1PFBnL0gjD
SenzOKgZcaVRLJqEYnQLABMivK8EbplZE8hQWMptL9ReKX+9Fb0kCgomkk5hFWX+51
KWioPt/+tH57XCwxuK/nrCYoWm1r5eIkdxL1hM0jWOKR1xamhzgL7BCCeqBGiik8GQ
9ttPjEYHlcQ2w==
From: <miha@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables
buffer-locally in a few more places
In-Reply-To: <83lf1v0w6y.fsf@HIDDEN>
References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN>
<87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc>
<83lf1v0w6y.fsf@HIDDEN>
Date: Thu, 11 Nov 2021 14:04:17 +0100
Message-ID: <87k0hehmi6.fsf@miha-pc>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Cc:
48925 <at> debbugs.gnu.org
>> Date: Thu, 11 Nov 2021 11:42:34 +0100 >> From: miha--- via "Bug reports
for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> >> >> To be o [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
X-Debbugs-Envelope-To: 48925
Cc: larsi@HIDDEN, monnier@HIDDEN, 48925 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: 48925 <at> debbugs.gnu.org
>> Date: Thu, 11 Nov 2021 11:42:34 +0100 >> From: miha--- via "Bug reports
for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> >> >> To be o [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: 48925 <at> debbugs.gnu.org
>> Date: Thu, 11 Nov 2021 11:42:34 +0100
>> From: miha--- via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>=20
>> >> To be on the safer side, I guess we could replace the
>> >>
>> >> specbind (Qminibuffer_completion_table, Qnil);
>> >>
>> >> with a use of `minibuffer-with-setup-hook` that sets the var to nil in
>> >> the new minibuffer. But doing it in C is awkward so it would best be
>> >> done by moving the function to subr.el.
>> >
>> > Sounds like a good idea to me. Miha, could you do that?
>>=20
>> Okay, patch attached.
>
> Moving read-string to subr.el means the function will be unavailable
> during loadup until subr.elc is loaded.
Sorry, I forgot to include a disclaimer that I don't really know that
much about loadup and bootstrapping, I kind of just blindly moved the
function to lisp saw that "make" worked. I did check loadup.el and saw
that `read-string' or `call-interactively' aren't used directly before
subr.el, but I'm not sure that this is sufficient.
It may be used indirectly through `command-execute', which is defined in
simple.el, so I think it should be okay.
> What is awkward to do in C? Maybe I could help with that, so that we
> wouldn't need to move this to Lisp.
We want to do what `minibuffer-with-setup-hook' does: add a function to
a hook that will remove itself from this hook. If I understand
correctly, we'd have to do this without `add-hook' and `remove-hook'
since they are defined in subr.el.
> Thanks.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmGNFNETHG1paGFAa2Ft
bml0bmlrLnRvcAAKCRCzCRoakhWZPyl0EACepBvDxuoihMh0204jCtDHwxXNc2qB
/+VGM6XQe93uy6+AAS/xIFCHus/FN4eyNwcI7f9xKuOhrvmpAz9A1lI2D7mzrEow
q1F5LhRzu2/vNLqZaYk1z6HjSOn5SCUKR8SPeaAYkMRczral7X/zau+/vUi6uk4z
koOKmSHfn/4EnNtON56AlkkNIKYgL6gympqnbnMq21NJPeZPtOIloVukW7z8Qf2J
MzM/AszRS/6z/PfSOkmtSv5/9pVgSdPHREQDMfrT+re0/tV2kC+DTMo9LnMGqBQ0
Pq7E8b4h70QzcVd7WjR7DeBApbdwxYZxp+coGC9xAMsw8rKwKOxkgu4eHU2Q3ejt
U32ZjJBSO9SbmqbvL20oXNHyzCwfmiKHtVdzlUR++jiY0mibWVSQ+Fo5APf/4mAm
6nVPLpNbEne6VaTih3i7matNEdgqWEFoMp9lJVi9ZB/L4pZYznKFFf2bFqPc5Dk5
DBOSwvuSgWZyQojQnZhYvegk3IFiDTPk0iKX/2VRo//Rnm1PIwrk7Up3JD3P5d7R
aNBU/v+pLCgovknLD2RuqsZkfeE0ZCD65/sH1J0FNmEQ+f6pre2aIsRONYyqXTXs
Z8Uxahs8j7fXg/ZISAF8NeM0960NElLSCri6YA++4iRC32prma3mGqhysYBdfoUd
Jdj1tl1CrNGbag==
=jdSk
-----END PGP SIGNATURE-----
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 12:11:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 07:11:22 2021 Received: from localhost ([127.0.0.1]:40338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ml8vK-0007dE-MO for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 07:11:22 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1ml8vI-0007d0-Pc for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 07:11:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wgue3lx3nt7Tm5BcVNCUTNd5CVrv9H3/eeOzWk+lHnc=; b=bKJDskS/nDS6wpdzMdwfcQhcVk UIHtatQNcpbIXPQuIpVa68UyeLd4cr7pcgPqt804oUBxRXAjyyu+ryDdXnQ1OeFOVPFCLOUiyrkrv 1O0vQPuaB52xcyr3inSRqel9q3q5LtSrRUh4n8ePGtpCa8EbpMnkZJOL7RBR0PEx+nSM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1ml8v9-0005Ws-AZ; Thu, 11 Nov 2021 13:11:13 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@HIDDEN> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWDe3BYU0yll4K9 oXnauo3gvo7gwZT///+NHmO0AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+ULCwwJAYVT5DoAAAG3SURB VDjLdZNNbqQwEIXd0WQPMxdApJV1NEazjgabA6SrvI4S7PsfYV65yuBoOg+1G/zh+sddxsFBF9fr Mo5uVGB6mEWTvDiOPqjWZfWLX+yhA00ciO+CWErJ94Cw9A2476MHEe6aFZKVBCDAyBCWgr/EEXc3 M4VbpRCecjbAQZ4D4YrIAuF+GrBXQyo7fqVwc67msZoOH0DRDpYsPzG16o6uhRE5fMgJDYoJoKSS iaRYCmJAEsFegDY1JTY0XckR9uVSEGEYLMIt58Qpa1TNBJmrCD+1iCfQm5Bh9DwRa+aBu7LX5xps /toP2U+v0+Oru/4HYlj9n7/TY64Z9uDlYXIf8/S87j5sEsZqCYbg5zeAp3fnniP62wDvbnqar9f9 uiy18c0U0W/v/fzjw/38tZuPoYKIRqF1exfVoPWz9qacKZ6AD2G37ImogRhqYdE6VJq2OtTD2SCZ AjFHp3O1XyzxA+h+THXumPpwq9c21tJPBTUcOioLk3Q7ANcia7Ig5wk5j0+A61TVuRq00dBWTu0C zFAd86ZbAzYEGKkOBJsdU52LdqLbly+Vws3K/kUba8/vaBjHf0usLVcfdy2oAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIxLTExLTExVDEyOjA5OjAwKzAwOjAwgbmcCQAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMS0xMS0xMVQxMjowOTowMCswMDowMPDkJLUAAAAASUVORK5CYII= X-Now-Playing: Hype Williams's _Junt-Deez Ruins You See_: "Infinity" Date: Thu, 11 Nov 2021 13:11:10 +0100 In-Reply-To: <83lf1v0w6y.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 11 Nov 2021 13:27:01 +0200") Message-ID: <871r3m7uzl.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > Moving read-string to subr.el means the function will be unavailable > during loadup until subr.elc is loaded. That's a worry, so I tried Miha's patch now and did both a "make" and a "make bootstrap", and both completed without any problems. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48925 Cc: monnier@HIDDEN, miha@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: > Moving read-string to subr.el means the function will be unavailable > during loadup until subr.elc is loaded. That's a worry, so I tried Miha's patch now and did both a "make" and a "make bootstrap", and both completed without any problems. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 11:27:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 06:27:27 2021 Received: from localhost ([127.0.0.1]:40292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ml8Eo-0006Jp-Ew for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 06:27:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ml8EY-0006J9-Qc for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 06:27:25 -0500 Received: from [2001:470:142:3::e] (port=49738 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ml8ES-0005EX-WF; Thu, 11 Nov 2021 06:27:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6oH1lZbJ1zdPky2DRPKqeyPwVVd5/TmbufZMlkhe/2Q=; b=TVWytRmGQE7X A0fO5RtZLgovTEKtYE95L8Q9Wsa7XYlGrYrUBOxgdm99qhDQ9j9s7rSZWxCgixlDsZhepgt/9T1nK phzQnlOXDZvPhBQSwdFDeuNL84tvBiKBi/nq0j3yBoNHjVE8cy3B99ASx5SHiQM3+vCBsJpBPrOCO qGV22S9tzzXJoDk6WYdChrotK7A6nyCEgs5DT9t+gZ+ohFkrkBYsB0SPIVsTkB+790jttaXMI7pFM r0ln4HkKFRNWmTyMYvmqRR9rW0N0VNAmlPTwe9NXWhJsjSgbqd/fkRvUGZUl3Yml6v6T2CjpD32ef U3t3p1BalqcfnUUB1tUdYg==; Received: from [87.69.77.57] (port=4456 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ml8ES-0007pa-JW; Thu, 11 Nov 2021 06:27:04 -0500 Date: Thu, 11 Nov 2021 13:27:01 +0200 Message-Id: <83lf1v0w6y.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: <miha@HIDDEN> In-Reply-To: <87mtmbgehx.fsf@miha-pc> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> <87czn79smi.fsf@HIDDEN> <87mtmbgehx.fsf@miha-pc> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48925 Cc: larsi@HIDDEN, monnier@HIDDEN, 48925 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 48925 <at> debbugs.gnu.org > Date: Thu, 11 Nov 2021 11:42:34 +0100 > From: miha--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > >> To be on the safer side, I guess we could replace the > >> > >> specbind (Qminibuffer_completion_table, Qnil); > >> > >> with a use of `minibuffer-with-setup-hook` that sets the var to nil in > >> the new minibuffer. But doing it in C is awkward so it would best be > >> done by moving the function to subr.el. > > > > Sounds like a good idea to me. Miha, could you do that? > > Okay, patch attached. Moving read-string to subr.el means the function will be unavailable during loadup until subr.elc is loaded. What is awkward to do in C? Maybe I could help with that, so that we wouldn't need to move this to Lisp. Thanks.
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 10:38:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 05:38:14 2021
Received: from localhost ([127.0.0.1]:40242 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ml7TB-0004rE-P1
for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 05:38:14 -0500
Received: from kamnitnik.top ([209.250.245.214]:44170)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <miha@HIDDEN>) id 1ml7T9-0004r5-DT
for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 05:38:12 -0500
Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43])
by kamnitnik.top (Postfix) with ESMTPSA id 304D79CFA8;
Thu, 11 Nov 2021 10:38:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top;
s=mail; t=1636627090;
bh=J0RHQxSWuMwgHEcuZ8v4VmqJx9B/cWlvLlaliiP3l1s=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=RvFWunlSsEHvklbyTzKPpj7laXZ/1ZnV7XGgJcuontldyE836zy027ZeFnJO/EOKb
NSYqvAOWOKLAlRDVXdRmzOGlJi50pmwkkqDLFlyPCGmqvloOKQ4vf9Bkt/RnGXlppI
GTTkHiSwJboe7dVvkKwu7sEx0wKmMzV5W6GLQ0RJa8rWmb11tWn+b3qoeI8DLWSOj7
VuiJZkqokv8ZR1YFs+uj3G3/u3C+K0xkxiJwOTBBsbYLjgKahGTh5wwb6mu/AQliY1
gtQwNgInlvtlXnriSFmfSM5GOX2IV4/b1IHoIz0zVLxQVdoNvhrKf0ojuqru1ZBWCB
exz3uxbfmKOTQ==
From: <miha@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>, Stefan Monnier
<monnier@HIDDEN>
Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables
buffer-locally in a few more places
In-Reply-To: <87czn79smi.fsf@HIDDEN>
References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN>
<87czn79smi.fsf@HIDDEN>
Date: Thu, 11 Nov 2021 11:42:34 +0100
Message-ID: <87mtmbgehx.fsf@miha-pc>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Lars Ingebrigtsen <larsi@HIDDEN> writes: > Stefan Monnier
<monnier@HIDDEN> writes: > >>> This follows up on changes proposed
in bug#45474. >> >> Thanks, the first patch looks good to me (assuming it
works ;-). > > So I've now appli [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
X-Debbugs-Envelope-To: 48925
Cc: 48925 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Lars Ingebrigtsen <larsi@HIDDEN> writes: > Stefan Monnier
<monnier@HIDDEN> writes: > >>> This follows up on changes proposed
in bug#45474. >> >> Thanks, the first patch looks good to me (assuming it
works ;-). > > So I've now appli [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain
Lars Ingebrigtsen <larsi@HIDDEN> writes:
> Stefan Monnier <monnier@HIDDEN> writes:
>
>>> This follows up on changes proposed in bug#45474.
>>
>> Thanks, the first patch looks good to me (assuming it works ;-).
>
> So I've now applied it to Emacs 29. It didn't lead to any obvious
> regressions (or test suite failures) that I can see, which is a good
> sign.
>
>>> The second patch is a bit more controversial, but is probably required
>>> if we want more reliable usage of completion commands in non-innermost
>>> minibuffers (that is, with minibuffer-follows-selected-frame set
>>> to nil.)
>>
>> The patch is fundamentally right, but as you say it's a bit more
>> controversial because it risks exposing bugs. Hmm...
>>
>> To be on the safer side, I guess we could replace the
>>
>> specbind (Qminibuffer_completion_table, Qnil);
>>
>> with a use of `minibuffer-with-setup-hook` that sets the var to nil in
>> the new minibuffer. But doing it in C is awkward so it would best be
>> done by moving the function to subr.el.
>
> Sounds like a good idea to me. Miha, could you do that?
Okay, patch attached.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Set-minibuffer-completion-table-buffer-locally-in-re.patch
Content-Transfer-Encoding: quoted-printable
From=2070fb493398d4961be0fa997684261554822e66b2 Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D <miha@kamnitnik.=
top>
Date: Thu, 11 Nov 2021 11:38:03 +0100
Subject: [PATCH] Set minibuffer-completion-table buffer-locally in read-str=
ing
* src/callint.c (Fcall_interactively):
* src/minibuf.c (Fread_string): Move function subr.el and use
minibuffer-with-setup-hook to set minibuffer-completion-table
buffer-locally.
=2D--
lisp/subr.el | 26 ++++++++++++++++++++++++++
src/callint.c | 10 ++++------
src/minibuf.c | 35 -----------------------------------
3 files changed, 30 insertions(+), 41 deletions(-)
diff --git a/lisp/subr.el b/lisp/subr.el
index 5a5842d428..75f00f33d4 100644
=2D-- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3507,6 +3507,32 @@ y-or-n-p
(message "%s%c" prompt (if ret ?y ?n)))
ret)))
=20
+(defun read-string ( prompt &optional initial-input history
+ default-value inherit-input-method)
+ "Read a string from the minibuffer, prompting with string PROMPT.
+If non-nil, second arg INITIAL-INPUT is a string to insert before reading.
+ This argument has been superseded by DEFAULT-VALUE and should normally b=
e nil
+ in new code. It behaves as INITIAL-CONTENTS in `read-from-minibuffer' (=
which
+ see).
+The third arg HISTORY, if non-nil, specifies a history list
+ and optionally the initial position in the list.
+See `read-from-minibuffer' for details of HISTORY argument.
+Fourth arg DEFAULT-VALUE is the default value or the list of default value=
s.
+ If non-nil, it is used for history commands, and as the value (or the fir=
st
+ element of the list of default values) to return if the user enters the
+ empty string.
+Fifth arg INHERIT-INPUT-METHOD, if non-nil, means the minibuffer inherits
+ the current input method and the setting of `enable-multibyte-characters'=
."
+ (minibuffer-with-setup-hook
+ (lambda ()
+ (setq-local minibuffer-completion-table nil))
+ (let ((ret (read-from-minibuffer prompt initial-input nil nil
+ history default-value
+ inherit-input-method)))
+ (if (and default-value (equal "" ret))
+ (if (consp default-value) (car default-value) default-value)
+ ret))))
+
;;; Atomic change groups.
=20
diff --git a/src/callint.c b/src/callint.c
index 44dae361c1..4e80d510ce 100644
=2D-- a/src/callint.c
+++ b/src/callint.c
@@ -631,8 +631,8 @@ DEFUN ("call-interactively", Fcall_interactively, Scall=
_interactively, 1, 3, 0,
=20
case 'M': /* String read via minibuffer with
inheriting the current input method. */
=2D args[i] =3D Fread_string (callint_message,
=2D Qnil, Qnil, Qnil, Qt);
+ args[i] =3D call5 (intern ("read-string"),
+ callint_message, Qnil, Qnil, Qnil, Qt);
break;
=20
case 'N': /* Prefix arg as number, else number from minibuffer. */
@@ -672,13 +672,11 @@ DEFUN ("call-interactively", Fcall_interactively, Sca=
ll_interactively, 1, 3, 0,
=20
case 's': /* String read via minibuffer without
inheriting the current input method. */
=2D args[i] =3D Fread_string (callint_message,
=2D Qnil, Qnil, Qnil, Qnil);
+ args[i] =3D call1 (intern ("read-string"), callint_message);
break;
=20
case 'S': /* Any symbol. */
=2D visargs[i] =3D Fread_string (callint_message,
=2D Qnil, Qnil, Qnil, Qnil);
+ visargs[i] =3D call1 (intern ("read-string"), callint_message);
args[i] =3D Fintern (visargs[i], Qnil);
break;
=20
diff --git a/src/minibuf.c b/src/minibuf.c
index 6c0cd358c5..f0f08d97c0 100644
=2D-- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -1366,40 +1366,6 @@ DEFUN ("read-from-minibuffer", Fread_from_minibuffer,
=20
/* Functions that use the minibuffer to read various things. */
=20
=2DDEFUN ("read-string", Fread_string, Sread_string, 1, 5, 0,
=2D doc: /* Read a string from the minibuffer, prompting with string =
PROMPT.
=2DIf non-nil, second arg INITIAL-INPUT is a string to insert before readin=
g.
=2D This argument has been superseded by DEFAULT-VALUE and should normally=
be nil
=2D in new code. It behaves as INITIAL-CONTENTS in `read-from-minibuffer'=
(which
=2D see).
=2DThe third arg HISTORY, if non-nil, specifies a history list
=2D and optionally the initial position in the list.
=2DSee `read-from-minibuffer' for details of HISTORY argument.
=2DFourth arg DEFAULT-VALUE is the default value or the list of default val=
ues.
=2D If non-nil, it is used for history commands, and as the value (or the f=
irst
=2D element of the list of default values) to return if the user enters the
=2D empty string.
=2DFifth arg INHERIT-INPUT-METHOD, if non-nil, means the minibuffer inherits
=2D the current input method and the setting of `enable-multibyte-character=
s'. */)
=2D (Lisp_Object prompt, Lisp_Object initial_input, Lisp_Object history, L=
isp_Object default_value, Lisp_Object inherit_input_method)
=2D{
=2D Lisp_Object val;
=2D ptrdiff_t count =3D SPECPDL_INDEX ();
=2D
=2D /* Just in case we're in a recursive minibuffer, make it clear that the
=2D previous minibuffer's completion table does not apply to the new
=2D minibuffer.
=2D FIXME: `minibuffer-completion-table' should be buffer-local instead=
. */
=2D specbind (Qminibuffer_completion_table, Qnil);
=2D
=2D val =3D Fread_from_minibuffer (prompt, initial_input, Qnil,
=2D Qnil, history, default_value,
=2D inherit_input_method);
=2D if (STRINGP (val) && SCHARS (val) =3D=3D 0 && ! NILP (default_value))
=2D val =3D CONSP (default_value) ? XCAR (default_value) : default_value;
=2D return unbind_to (count, val);
=2D}
=2D
DEFUN ("read-command", Fread_command, Sread_command, 1, 2, 0,
doc: /* Read the name of a command and return as a symbol.
Prompt with PROMPT. By default, return DEFAULT-VALUE or its first element
@@ -2513,7 +2479,6 @@ syms_of_minibuf (void)
defsubr (&Sactive_minibuffer_window);
defsubr (&Sset_minibuffer_window);
defsubr (&Sread_from_minibuffer);
=2D defsubr (&Sread_string);
defsubr (&Sread_command);
defsubr (&Sread_variable);
defsubr (&Sinternal_complete_buffer);
=2D-=20
2.33.1
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmGM85oTHG1paGFAa2Ft
bml0bmlrLnRvcAAKCRCzCRoakhWZP7o5EAC1C51hML5q2TRiH5+8WQgbR7Lh1s4A
gXeEdodpXbh1XpIHls2llS0sEnrL1O2Vb5DaiAvjmKdheSxuZnVzlObiqXR1lpC4
CTtgz2Ba9GloeTqTYlUfsS+an6HDNB9My3pRjMFrkN36AwyFxGvHOmLruZSf931a
gmnV/8VdPN2ZWoXT3fawUUSmKFkhpgT9CsDLoZuUGNf6hkCZqRwkjUozrew2Rjv1
lnpyGGysVtFP2Z8Ilm+K32NCRoj3z0vFCV8vIxKMJOydyauA7p3LMgEuS+gCZ/z1
K2ApzEr/4JlBnsiSIUxerpOyc5xwCZzBoVOACRLfHKujmFJmmv41R0mG4SbqkJ/X
C10xYNf5338ia8Ho4SDAl59F4x/1G9gq4oqsNbfwqnek9LwQoXhACR3IkEseSq4o
yr/II0X/qURfnlXcCEScX1EWb4UdlY7T1gGw+8Sd7aKliMRQaScoZJD7brcjANu4
oRK1/2Lp0JItnHce+Jilu0/2wisTAaw2CxyiCRfX4VbnNWJzMdwWEzogoGUFgIUJ
7eU0OxIQ7Z/UJldQ5NU+nUOEMoBvo9/776OPCfqCQ7HpzJohOiSJfXmGxD4PzN5a
Y9Ivizw/rlLwNzbZlI+2DryNSXelem5gQv9z3aPR4jnfLxN14XYSopz5br0SAhWF
noRV6HvzNz+ZBA==
=qUe7
-----END PGP SIGNATURE-----
--==-=-=--
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 05:19:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 11 00:19:49 2021 Received: from localhost ([127.0.0.1]:39852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ml2V1-0001js-TQ for submit <at> debbugs.gnu.org; Thu, 11 Nov 2021 00:19:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1ml2Uk-0001j5-RT for 48925 <at> debbugs.gnu.org; Thu, 11 Nov 2021 00:19:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oeXpibJwWloyD3CFOzIGcdRmCDVX5/X54AKCzNaHEkY=; b=STjjX514H35pcob/cdVl3JMweL 9kVgE44be5bOvbhr9NOK2daW72a6hNFg0YFG4bqEebyXIiQb2PvnDmG0GjImj1uv2c2RHxIMPf6Yx aWuQT6CboLCNwr3+5AXjtrDv8ySSQum0rDpcBQglPcGl+2/oniqRfEooLkd1KOaDNVhk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1ml2Ua-0002a0-J8; Thu, 11 Nov 2021 06:19:23 +0100 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> X-Now-Playing: King Crimson's _The Complete 1969 Recordings (26): BBC Sessions_: "The Court Of The Crimson King" Date: Thu, 11 Nov 2021 06:19:17 +0100 In-Reply-To: <jwvk0ll5air.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Tue, 20 Jul 2021 10:29:40 -0400") Message-ID: <87czn79smi.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier <monnier@HIDDEN> writes: >> This follows up on changes proposed in bug#45474. > > Thanks, the first patch looks good to me (assuming it works ;-). So I've now applied it to Emacs 29. It didn't lead to any obvious regressions (or test suite failures) that I can see, which is a good sign. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48925 Cc: 48925 <at> debbugs.gnu.org, miha@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Stefan Monnier <monnier@HIDDEN> writes: >> This follows up on changes proposed in bug#45474. > > Thanks, the first patch looks good to me (assuming it works ;-). So I've now applied it to Emacs 29. It didn't lead to any obvious regressions (or test suite failures) that I can see, which is a good sign. >> The second patch is a bit more controversial, but is probably required >> if we want more reliable usage of completion commands in non-innermost >> minibuffers (that is, with minibuffer-follows-selected-frame set >> to nil.) > > The patch is fundamentally right, but as you say it's a bit more > controversial because it risks exposing bugs. Hmm... > > To be on the safer side, I guess we could replace the > > specbind (Qminibuffer_completion_table, Qnil); > > with a use of `minibuffer-with-setup-hook` that sets the var to nil in > the new minibuffer. But doing it in C is awkward so it would best be > done by moving the function to subr.el. Sounds like a good idea to me. Miha, could you do that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
Received: (at 48925) by debbugs.gnu.org; 20 Jul 2021 14:29:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 20 10:29:51 2021
Received: from localhost ([127.0.0.1]:35009 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1m5qkp-00032y-2p
for submit <at> debbugs.gnu.org; Tue, 20 Jul 2021 10:29:51 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56196)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1m5qkn-00032i-9E
for 48925 <at> debbugs.gnu.org; Tue, 20 Jul 2021 10:29:50 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D885E440B4E;
Tue, 20 Jul 2021 10:29:42 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B6D88440AA8;
Tue, 20 Jul 2021 10:29:41 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1626791381;
bh=01dKd1f23y8nDHP5nlDjXhZEn5vOfk43J0HeO6eExV4=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=oPozPEqXikUgsOUIkb0gxl4j8PCezTxMsCVXJTKFfMPUYJPcYfDNKOyAlVr10v8PI
+hoS9z9uxIXK0XsXfgvIWNRH4jiNUUUUWS/S0jyAXCdplFlFrk8N2dlA2JPQhYiRGC
cpZ3WgQBEry3apXUPEYZVggID1FYVXDicbRSATt382AYozrZ4dMidbkGH60F9t2Y7A
MP0Zxrd2A8mJA6IVecqBrrheHZdp8djIzDQh2fMbfkTE8df8fQnUbnqcRo424xF2i8
bf6A9a3qa5yqZoxtaAIAjJdRxFWkM4mHMtjYdMZnibvhWo2uvQleBizFM3UvHyQR+F
w16Xwj8JJ2vYQ==
Received: from alfajor (unknown [216.154.29.138])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 58AE91200E2;
Tue, 20 Jul 2021 10:29:41 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: miha@HIDDEN
Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables
buffer-locally in a few more places
Message-ID: <jwvk0ll5air.fsf-monnier+emacs@HIDDEN>
References: <87fsxstdiy.fsf@miha-pc>
Date: Tue, 20 Jul 2021 10:29:40 -0400
In-Reply-To: <87fsxstdiy.fsf@miha-pc> (miha@HIDDEN's message of "Tue,
08 Jun 2021 20:30:29 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.096 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 48925
Cc: 48925 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> This follows up on changes proposed in bug#45474.
Thanks, the first patch looks good to me (assuming it works ;-).
> The second patch is a bit more controversial, but is probably required
> if we want more reliable usage of completion commands in non-innermost
> minibuffers (that is, with minibuffer-follows-selected-frame set
> to nil.)
The patch is fundamentally right, but as you say it's a bit more
controversial because it risks exposing bugs. Hmm...
To be on the safer side, I guess we could replace the
specbind (Qminibuffer_completion_table, Qnil);
with a use of `minibuffer-with-setup-hook` that sets the var to nil in
the new minibuffer. But doing it in C is awkward so it would best be
done by moving the function to subr.el.
Stefan
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.Received: (at 48925) by debbugs.gnu.org; 20 Jul 2021 12:30:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 20 08:30:23 2021 Received: from localhost ([127.0.0.1]:33142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1m5otC-00082t-V5 for submit <at> debbugs.gnu.org; Tue, 20 Jul 2021 08:30:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1m5otB-0007vy-CX for 48925 <at> debbugs.gnu.org; Tue, 20 Jul 2021 08:30:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LlMn9F5oWZ7elwf0u6IciNX76SS3HUOe+DjA5RXMA5U=; b=dbOcLu3z329M4p2tFx7ERscRvq oDM4ewHuzaBgAlx/nYfTWSNyMMiAwa8J2ORCgpwOiz/sUE7zDcRsLFUDUhRtpz6fg/MPe06lcViFT a9RLSO1BDVTxkbrockmnSs0NahGo0VdBvNegGoP97pA8X0qQ7UvxuOMuNgzP5HB3Pp30=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1m5ot1-000380-J2; Tue, 20 Jul 2021 14:30:14 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: miha@HIDDEN Subject: Re: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places References: <87fsxstdiy.fsf@miha-pc> X-Now-Playing: Pet Shop Boys's _Hotspot_: "Will-o-the-Wisp" Date: Tue, 20 Jul 2021 14:30:11 +0200 In-Reply-To: <87fsxstdiy.fsf@miha-pc> (miha@HIDDEN's message of "Tue, 08 Jun 2021 20:30:29 +0200") Message-ID: <87bl6xf9rg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: miha@HIDDEN writes: > This follows up on changes proposed in bug#45474. The second patch is a > bit more controversial, but is probably required if we want more > reliable usage of completion commands in non-innermost mi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 48925 Cc: 48925 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) miha@HIDDEN writes: > This follows up on changes proposed in bug#45474. The second patch is a > bit more controversial, but is probably required if we want more > reliable usage of completion commands in non-innermost minibuffers (that > is, with minibuffer-follows-selected-frame set to nil.) Stefan, do have any comments about these two patches? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 8 Jun 2021 18:30:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 08 14:30:09 2021
Received: from localhost ([127.0.0.1]:59777 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lqgUL-0002qH-5s
for submit <at> debbugs.gnu.org; Tue, 08 Jun 2021 14:30:09 -0400
Received: from lists.gnu.org ([209.51.188.17]:51838)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <miha@HIDDEN>) id 1lqgUG-0002p6-1Z
for submit <at> debbugs.gnu.org; Tue, 08 Jun 2021 14:30:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60244)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <miha@HIDDEN>)
id 1lqgUF-0002LE-OT
for bug-gnu-emacs@HIDDEN; Tue, 08 Jun 2021 14:30:03 -0400
Received: from kamnitnik.top ([2001:19f0:5001:bf2:5400:2ff:fee0:2626]:53452
helo=mail.kamnitnik.top)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <miha@HIDDEN>)
id 1lqgUD-0002LQ-6A
for bug-gnu-emacs@HIDDEN; Tue, 08 Jun 2021 14:30:03 -0400
Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43])
by mail.kamnitnik.top (Postfix) with ESMTPSA id 9DA0DBB843
for <bug-gnu-emacs@HIDDEN>; Tue, 8 Jun 2021 18:29:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top;
s=mail; t=1623176996;
bh=Vf3ZDCrS+UtI7M7lfMHhMFbRhPVPthyE/dTmCJcNmMQ=;
h=From:To:Subject:Date:From;
b=fbyZJPoPdaPayhqhULhQBHP6mm7ccgtBBLtmqrockmfLx/xgL260eJ/U6ee59chnE
5TEp8rhaCHuU8l03GbCEsTG8hoNK5+zZjBzJylnIdV4y2B4cXn6ra1s7H0b47aDHp4
9VHPpGpl87HN+P6hZu+xtN8d1pBDCRZs+OaQqyYrf2PaqjNKve2sr90Imuv9Kkrhx1
vnn0UlInl/cGVbPigIWrRkCAAfLpRWBtXhe1rMu+1jR7qn1x8ic8eh7PB3hUwrNGfg
QIH3qu89YZJr7fZOjLP037M7jCfyo6Y0D81LcHyRJbwpGpZnbdaBP7JSKwaaCKRJvW
qLxBq1roxKOKg==
From: miha@HIDDEN
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a
few more places
Date: Tue, 08 Jun 2021 20:30:29 +0200
Message-ID: <87fsxstdiy.fsf@miha-pc>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha256; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2001:19f0:5001:bf2:5400:2ff:fee0:2626;
envelope-from=miha@HIDDEN; helo=mail.kamnitnik.top
X-Spam_score_int: 20
X-Spam_score: 2.0
X-Spam_bar: ++
X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498,
FROM_SUSPICIOUS_NTLD_FP=1.563, PDS_OTHER_BAD_TLD=1.997, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 2.7 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: This follows up on changes proposed in bug#45474. The second
patch is a bit more controversial, but is probably required if we want more
reliable usage of completion commands in non-innermost minibuff [...]
Content analysis details: (2.7 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: kamnitnik.top (top)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.9 SPF_FAIL SPF: sender does not match SPF record (fail)
[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
id=miha%40kamnitnik.top; ip=209.51.188.17; r=debbugs.gnu.org]
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
medium trust [209.51.188.17 listed in list.dnswl.org]
0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4)
[209.51.188.17 listed in wl.mailspike.net]
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
1.6 FROM_SUSPICIOUS_NTLD_FP From abused NTLD
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.1 (/)
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain
This follows up on changes proposed in bug#45474. The second patch is a
bit more controversial, but is probably required if we want more
reliable usage of completion commands in non-innermost minibuffers (that
is, with minibuffer-follows-selected-frame set to nil.)
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Set-minibuffer-completion-variables-locally-in-more-.patch
Content-Transfer-Encoding: quoted-printable
From=20049d57e6d10edca1d6a0af119f557e364d8ea93f Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D <miha@kamnitnik.=
top>
Date: Tue, 8 Jun 2021 20:17:59 +0200
Subject: [PATCH 1/2] Set `minibuffer-completion-*` variables locally in more
places
Follow-up to commit
2021-05-01 "* lisp/minibuffer.el (completing-read-default): Fix bug#45474"
* lisp/calc/calc-store.el (calc-read-var-name):
* lisp/emacs-lisp/crm.el (completing-read-multiple):
* lisp/progmodes/cc-styles.el (c-read-offset):
* lisp/window.el (read-buffer-to-switch):
Set `minibuffer-completion-*` variables buffer-locally instead of
using a global let-binding.
=2D--
lisp/calc/calc-store.el | 15 +++++++-----
lisp/emacs-lisp/crm.el | 47 ++++++++++++++++++-------------------
lisp/progmodes/cc-styles.el | 12 ++++++----
lisp/window.el | 2 +-
4 files changed, 40 insertions(+), 36 deletions(-)
diff --git a/lisp/calc/calc-store.el b/lisp/calc/calc-store.el
index ee29c440fe..d96b40156d 100644
=2D-- a/lisp/calc/calc-store.el
+++ b/lisp/calc/calc-store.el
@@ -188,12 +188,15 @@ calc-read-var-name
(let* ((calc-store-opers store-opers)
(var (concat
"var-"
=2D (let ((minibuffer-completion-table
=2D (mapcar (lambda (x) (substring x 4))
=2D (all-completions "var-" obarray)))
=2D (minibuffer-completion-predicate
=2D (lambda (x) (boundp (intern (concat "var-" x)))))
=2D (minibuffer-completion-confirm t))
+ (minibuffer-with-setup-hook
+ (lambda ()
+ (setq-local minibuffer-completion-table
+ (mapcar (lambda (x) (substring x 4))
+ (all-completions "var-" obarray)))
+ (setq-local minibuffer-completion-predicate
+ (lambda (x)
+ (boundp (intern (concat "var-" x)))))
+ (setq-local minibuffer-completion-confirm t))
(read-from-minibuffer
prompt nil calc-var-name-map nil
'calc-read-var-name-history)))))
diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el
index e106815817..67464bc6db 100644
=2D-- a/lisp/emacs-lisp/crm.el
+++ b/lisp/emacs-lisp/crm.el
@@ -245,30 +245,29 @@ completing-read-multiple
=20
This function returns a list of the strings that were read,
with empty strings removed."
=2D (unwind-protect
=2D (progn
=2D (add-hook 'choose-completion-string-functions
=2D 'crm--choose-completion-string)
=2D (let* ((minibuffer-completion-table #'crm--collection-fn)
=2D (minibuffer-completion-predicate predicate)
=2D ;; see completing_read in src/minibuf.c
=2D (minibuffer-completion-confirm
=2D (unless (eq require-match t) require-match))
=2D (crm-completion-table table)
=2D (map (if require-match
=2D crm-local-must-match-map
=2D crm-local-completion-map))
=2D ;; If the user enters empty input, `read-from-minibuffer'
=2D ;; returns the empty string, not DEF.
=2D (input (read-from-minibuffer
=2D prompt initial-input map
=2D nil hist def inherit-input-method)))
=2D (when (and def (string-equal input ""))
=2D (setq input (if (consp def) (car def) def)))
=2D ;; Remove empty strings in the list of read strings.
=2D (split-string input crm-separator t)))
=2D (remove-hook 'choose-completion-string-functions
=2D 'crm--choose-completion-string)))
+ (let* ((map (if require-match
+ crm-local-must-match-map
+ crm-local-completion-map))
+ input)
+ (minibuffer-with-setup-hook
+ (lambda ()
+ (add-hook 'choose-completion-string-functions
+ 'crm--choose-completion-string nil 'local)
+ (setq-local minibuffer-completion-table #'crm--collection-fn)
+ (setq-local minibuffer-completion-predicate predicate)
+ ;; see completing_read in src/minibuf.c
+ (setq-local minibuffer-completion-confirm
+ (unless (eq require-match t) require-match))
+ (setq-local crm-completion-table table))
+ (setq input (read-from-minibuffer
+ prompt initial-input map
+ nil hist def inherit-input-method)))
+ ;; If the user enters empty input, `read-from-minibuffer'
+ ;; returns the empty string, not DEF.
+ (when (and def (string-equal input ""))
+ (setq input (if (consp def) (car def) def)))
+ ;; Remove empty strings in the list of read strings.
+ (split-string input crm-separator t)))
=20
;; testing and debugging
;; (defun crm-init-test-environ ()
diff --git a/lisp/progmodes/cc-styles.el b/lisp/progmodes/cc-styles.el
index 8514434e9a..873682043c 100644
=2D-- a/lisp/progmodes/cc-styles.el
+++ b/lisp/progmodes/cc-styles.el
@@ -444,17 +444,19 @@ c-read-offset
defstr))
(prompt (concat symname " offset " defstr))
(keymap (make-sparse-keymap))
=2D (minibuffer-completion-table obarray)
=2D (minibuffer-completion-predicate 'fboundp)
offset input)
;; In principle completing-read is used here, but SPC is unbound
;; to make it less annoying to enter lists.
(set-keymap-parent keymap minibuffer-local-completion-map)
(define-key keymap " " 'self-insert-command)
(while (not offset)
=2D (setq input (read-from-minibuffer prompt nil keymap t
=2D 'c-read-offset-history
=2D (format "%s" oldoff)))
+ (minibuffer-with-setup-hook
+ (lambda ()
+ (setq-local minibuffer-completion-table obarray)
+ (setq-local minibuffer-completion-predicate 'fboundp))
+ (setq input (read-from-minibuffer prompt nil keymap t
+ 'c-read-offset-history
+ (format "%s" oldoff))))
(if (c-valid-offset input)
(setq offset input)
;; error, but don't signal one, keep trying
diff --git a/lisp/window.el b/lisp/window.el
index fd1c617d6b..029202e350 100644
=2D-- a/lisp/window.el
+++ b/lisp/window.el
@@ -8376,7 +8376,7 @@ read-buffer-to-switch
(let ((rbts-completion-table (internal-complete-buffer-except)))
(minibuffer-with-setup-hook
(lambda ()
=2D (setq minibuffer-completion-table rbts-completion-table)
+ (setq-local minibuffer-completion-table rbts-completion-table)
;; Since rbts-completion-table is built dynamically, we
;; can't just add it to the default value of
;; icomplete-with-completion-tables, so we add it
=2D-=20
2.31.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0002-Don-t-bind-minibuffer-completion-table-to-nil-in-rea.patch
Content-Transfer-Encoding: quoted-printable
From=20466169b9f679a78aec00f9735335d90718c0d898 Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?Miha=3D20Rihtar=3DC5=3DA1i=3DC4=3D8D?=3D <miha@kamnitnik.=
top>
Date: Tue, 8 Jun 2021 20:19:44 +0200
Subject: [PATCH 2/2] Don't bind minibuffer-completion-table to nil in
read-string
This reverts
2012-06-19 "* src/minibuf.c (Fread_string): Bind minibuffer-completion-tabl=
e."
* src/minibuf.c (Fread_string): Don't bind minibuffer-completion-table
to nil.
=2D--
src/minibuf.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/minibuf.c b/src/minibuf.c
index 00069eabbe..adee471887 100644
=2D-- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -1376,20 +1376,13 @@ DEFUN ("read-string", Fread_string, Sread_string, 1=
, 5, 0,
(Lisp_Object prompt, Lisp_Object initial_input, Lisp_Object history, Lis=
p_Object default_value, Lisp_Object inherit_input_method)
{
Lisp_Object val;
=2D ptrdiff_t count =3D SPECPDL_INDEX ();
=2D
=2D /* Just in case we're in a recursive minibuffer, make it clear that the
=2D previous minibuffer's completion table does not apply to the new
=2D minibuffer.
=2D FIXME: `minibuffer-completion-table' should be buffer-local instead=
. */
=2D specbind (Qminibuffer_completion_table, Qnil);
=20
val =3D Fread_from_minibuffer (prompt, initial_input, Qnil,
Qnil, history, default_value,
inherit_input_method);
if (STRINGP (val) && SCHARS (val) =3D=3D 0 && ! NILP (default_value))
val =3D CONSP (default_value) ? XCAR (default_value) : default_value;
=2D return unbind_to (count, val);
+ return val;
}
=20
DEFUN ("read-command", Fread_command, Sread_command, 1, 2, 0,
=2D-=20
2.31.1
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmC/t0UTHG1paGFAa2Ft
bml0bmlrLnRvcAAKCRCzCRoakhWZP51vD/0T1qggVwg0fwCH2LRvjsB7G8UPwHmk
LQQdscOkfSeJOFz0RI/0VI/rXXN2sV14/vB53EDwXSNKxlSzUY4DLyTcRVDTVVJt
8NhIGMeaXrCw75X5+Y+cSmlUaIIk7kOR+17d9bB8Z5Avoo43bpwzovkrbk3OHLj/
8n+uH/KcLY+HDTef/ZUNoKi1tLofX3grB5OLkdWXw/1209Vx4l8fAhTbv2Ha6XA5
p7tayadbowQi9Gj+xl2EJ0t/OzqP57tGSvBzuB3/T9v6npdfT5gHC3jceAigoH0G
CYalxm//DdTN+mIaXgu+pKrruGhAfX3AB1iaAHbRmaxn6mdHDjgObyFaAtR2dsK0
OXP74PNdkndOthKwAL94qUKiHJ/vr0hNNuc70unuwCumrtXnvUShNSvRoKBrxCTV
lwbYh3VyApKXo24z1SJbfL/m71F1cdokJPNoihyQn2YqDpUzfnPub1eINv/kboac
NjxYB1XQ0hrxsVUjEyhw4/823oh1nizyeVDAKrL1Good/qtiX0lhN2D94VM150+k
9bcHp8klHu70WJBiWqPCuHvsyPjb32ns69sgx6nr0aGOCjP88d5+P5wxoRV5mI1N
JBgiw6N9BRJErjZIFatmULPcAW++/mk37udjur8UzJ2SU9LfhxObB6/hDKGw/hr/
Ol5oD+K2ZJ5GWQ==
=UhWH
-----END PGP SIGNATURE-----
--==-=-=--
miha@HIDDEN:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#48925; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.