GNU bug report logs - #49004
Update IRC-related references to point to Libera.Chat

Previous Next

Package: emacs;

Reported by: Amin Bandali <bandali <at> gnu.org>

Date: Sun, 13 Jun 2021 15:02:02 UTC

Severity: normal

Tags: patch

Done: Amin Bandali <bandali <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49004 in the body.
You can then email your comments to 49004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 15:02:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Amin Bandali <bandali <at> gnu.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 13 Jun 2021 15:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <bandali <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Cc: eliz <at> gnu.org, larsi <at> gnus.org
Subject: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 11:01:35 -0400
[Message part 1 (text/plain, inline)]
Tags: patch

Hello,

I've prepared the following first revision against emacs-27.
All comments/feedback welcome.

Eli, Lars, are you comfortable with the scope of the changes?

[0001-Update-IRC-related-references-to-point-to-Libera.Cha.patch (text/patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 15:08:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Amin Bandali <bandali <at> gnu.org>
Cc: bug-gnu-emacs <at> gnu.org, larsi <at> gnus.org
Subject: Re: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 18:07:34 +0300
> From: Amin Bandali <bandali <at> gnu.org>
> Cc: eliz <at> gnu.org, larsi <at> gnus.org
> Date: Sun, 13 Jun 2021 11:01:35 -0400
> 
> I've prepared the following first revision against emacs-27.
> All comments/feedback welcome.
> 
> Eli, Lars, are you comfortable with the scope of the changes?

It's a large patch: is there anything here besides mechanical change
of the server address?

Btw, shouldn't we have some FAQ about the switch and its reasons?

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 16:08:01 GMT) Full text and rfc822 format available.

Message #11 received at 49004 <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <bandali <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: larsi <at> gnus.org, Tassilo Horn <tsdh <at> gnu.org>, 49004 <at> debbugs.gnu.org,
 Philip Kaludercic <philipk <at> posteo.net>, "J.P." <jp <at> neverwas.me>
Subject: Re: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 12:07:13 -0400
Eli Zaretskii writes:

>> From: Amin Bandali <bandali <at> gnu.org>
>> Cc: eliz <at> gnu.org, larsi <at> gnus.org
>> Date: Sun, 13 Jun 2021 11:01:35 -0400
>> 
>> I've prepared the following first revision against emacs-27.
>> All comments/feedback welcome.
>> 
>> Eli, Lars, are you comfortable with the scope of the changes?
>
> It's a large patch: is there anything here besides mechanical change
> of the server address?

It's a bit large, but it is indeed mostly mechanical replacements.
I also took the liberty to backport the following tiny and relevant
changes from the 'master' branch:

- https://git.savannah.gnu.org/cgit/emacs.git/commit?id=a70a344941713baf08dc0c093bdf25cf36b09858
- https://git.savannah.gnu.org/cgit/emacs.git/commit?id=86e4d770a833538f3cb711eb42d8fd8d764a4635
- https://git.savannah.gnu.org/cgit/emacs.git/commit?id=19ef864084c9765b7736851b46dcbcbe3dbfcf27

I'm Cc'ing active ERC contributor J.P. to help with the reviewing,
as well as Philip and Tassilo whom I saw discuss rcirc changes on
emacs-devel recently.  I'd appreciate it if you would kindly help
look over and review the proposed changes.

> Btw, shouldn't we have some FAQ about the switch and its reasons?
>
> Thanks.
>

That's a good idea, thanks.  I will add a NEWS entry in the next
revision, and perhaps add to the erc and rcirc texinfo manuals too.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 16:22:02 GMT) Full text and rfc822 format available.

Message #14 received at 49004 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Amin Bandali <bandali <at> gnu.org>
Cc: larsi <at> gnus.org, tsdh <at> gnu.org, 49004 <at> debbugs.gnu.org, philipk <at> posteo.net,
 jp <at> neverwas.me
Subject: Re: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 19:21:24 +0300
> From: Amin Bandali <bandali <at> gnu.org>
> Cc: 49004 <at> debbugs.gnu.org,  larsi <at> gnus.org, "J.P." <jp <at> neverwas.me>, Philip
>  Kaludercic <philipk <at> posteo.net>, Tassilo Horn <tsdh <at> gnu.org>
> Date: Sun, 13 Jun 2021 12:07:13 -0400
> 
> > It's a large patch: is there anything here besides mechanical change
> > of the server address?
> 
> It's a bit large, but it is indeed mostly mechanical replacements.
> I also took the liberty to backport the following tiny and relevant
> changes from the 'master' branch:
> 
> - https://git.savannah.gnu.org/cgit/emacs.git/commit?id=a70a344941713baf08dc0c093bdf25cf36b09858
> - https://git.savannah.gnu.org/cgit/emacs.git/commit?id=86e4d770a833538f3cb711eb42d8fd8d764a4635
> - https://git.savannah.gnu.org/cgit/emacs.git/commit?id=19ef864084c9765b7736851b46dcbcbe3dbfcf27

Then the change is fine by me, of course.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 17:14:01 GMT) Full text and rfc822 format available.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Amin Bandali <bandali <at> gnu.org>
Cc: bug-gnu-emacs <at> gnu.org, eliz <at> gnu.org
Subject: Re: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 19:12:58 +0200
Amin Bandali <bandali <at> gnu.org> writes:

> I've prepared the following first revision against emacs-27.
> All comments/feedback welcome.
>
> Eli, Lars, are you comfortable with the scope of the changes?

It's OK by me, but it's unlikely that there'll be another emacs-27
release, I think?  So shouldn't this go straight to Emacs 28?






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 17:23:01 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: bug-gnu-emacs <at> gnu.org, bandali <at> gnu.org
Subject: Re: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 20:22:26 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: bug-gnu-emacs <at> gnu.org,  eliz <at> gnu.org
> Date: Sun, 13 Jun 2021 19:12:58 +0200
> 
> Amin Bandali <bandali <at> gnu.org> writes:
> 
> > I've prepared the following first revision against emacs-27.
> > All comments/feedback welcome.
> >
> > Eli, Lars, are you comfortable with the scope of the changes?
> 
> It's OK by me, but it's unlikely that there'll be another emacs-27
> release, I think?  So shouldn't this go straight to Emacs 28?

Probably.  It doesn't really matter much.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 19:35:01 GMT) Full text and rfc822 format available.

Message #23 received at 49004 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Amin Bandali <bandali <at> gnu.org>
Cc: 49004 <at> debbugs.gnu.org
Subject: Re: bug#49004: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 21:34:38 +0200
Amin Bandali <bandali <at> gnu.org> writes:

Hey Amin,

> I'm Cc'ing active ERC contributor J.P. to help with the reviewing,
> as well as Philip and Tassilo whom I saw discuss rcirc changes on
> emacs-devel recently.  I'd appreciate it if you would kindly help
> look over and review the proposed changes.

The rcirc-related changes are fine.  Thanks for your effort!

Bye,
Tassilo




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 20:55:02 GMT) Full text and rfc822 format available.

Message #26 received at 49004 <at> debbugs.gnu.org (full text, mbox):

From: "Ryan Yeske" <ryan <at> ryanyeske.com>
To: 49004 <at> debbugs.gnu.org
Subject: rcirc-server-alist update to libera.chat
Date: Sun, 13 Jun 2021 13:18:40 -0700
[Message part 1 (text/plain, inline)]
Hey all!  I'm the original author of rcirc.el.  

I was contacted via irc by Amin and installed this patch (0001-) on the latest emacs-27 to verify the rcirc side of these changes.

The defcustom change looks good, as does the doc changes. 

Thanks for everyone's work on this!

Ryan
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Sun, 13 Jun 2021 23:04:02 GMT) Full text and rfc822 format available.

Message #29 received at 49004 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Amin Bandali <bandali <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>, Eli Zaretskii <eliz <at> gnu.org>,
 49004 <at> debbugs.gnu.org, larsi <at> gnus.org, Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#49004: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 16:03:20 -0700
The changes to `erc-networks-alist' may warrant further discussion at
some point (see below if you're really interested). Otherwise, I'd say
everything looks fine. Let me know if you need someone to actually fire
it up. I think you've already field tested the changes to erc-services
though, right? Thanks.


Below
~~~~~

`erc-networks-alist' isn't consulted for libera at the moment because
the RPL_ISUPPORT NETWORK token takes precedence.

Trusted opinions vary on whether clients should be using this param for
anything other than display purposes. But there's currently no viable
alternative offered by naysayers for canonical/authoritative,
server-reported network identifiers.

We don't currently have a policy in place for handing some hypothetical
encounter with an undesirable NETWORK name, such as NETWORK=My\x20Net,
that we'd rather not use as an identifying lisp symbol (unless we're
cool with passing around 'My\ Net).

Again, this doesn't matter at this exact second, but I'm hoping to
cross that bridge relatively shortly.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#49004; Package emacs. (Mon, 14 Jun 2021 00:55:01 GMT) Full text and rfc822 format available.

Message #32 received at 49004 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Amin Bandali <bandali <at> gnu.org>
Cc: larsi <at> gnus.org, Philip Kaludercic <philipk <at> posteo.net>,
 49004 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Tassilo Horn <tsdh <at> gnu.org>
Subject: Re: bug#49004: Update IRC-related references to point to Libera.Chat
Date: Sun, 13 Jun 2021 17:54:40 -0700
"J.P." <jp <at> neverwas.me> writes:

> Let me know if you need someone to actually fire it up. I think you've
> already field tested the changes to erc-services though, right?

I just tried this on 27:

  https://bpa.st/raw/XK6A

The first session doesn't have the services module loaded (so it fails,
which is good). The second shows it successfully logging in. Nice work!




Reply sent to Amin Bandali <bandali <at> gnu.org>:
You have taken responsibility. (Sun, 04 Jul 2021 05:26:02 GMT) Full text and rfc822 format available.

Notification sent to Amin Bandali <bandali <at> gnu.org>:
bug acknowledged by developer. (Sun, 04 Jul 2021 05:26:02 GMT) Full text and rfc822 format available.

Message #37 received at 49004-done <at> debbugs.gnu.org (full text, mbox):

From: Amin Bandali <bandali <at> gnu.org>
To: 49004-done <at> debbugs.gnu.org
Cc: larsi <at> gnus.org, Philip Kaludercic <philipk <at> posteo.net>,
 Tassilo Horn <tsdh <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>,
 "J.P." <jp <at> neverwas.me>
Subject: Re: bug#49004: Update IRC-related references to point to Libera.Chat
Date: Sun, 04 Jul 2021 01:24:52 -0400
Thank you all for looking and testing this, and sorry for the delay.
I went ahead and pushed the change to 'emacs-27' along with a NEWS
entry and small explanatory blurbs in the erc.texi and rcirc.texi
manuals, and then merged it into 'master' as well.

Best,
amin




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Aug 2021 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 240 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.