GNU bug report logs - #49077
26.3; conf-mode for Java properties files uses incorrect comment syntax

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49077 in the body.
You can then email your comments to 49077 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Spencer Nelson <swnelson <at> uw.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3;
 conf-mode for Java properties files uses incorrect comment syntax
Date: Thu, 17 Jun 2021 10:10:19 -0700

I noticed today that conf-mode.el's derived mode, conf-javaprop-mode,
isn't configured correctly for Java properties files.

The documenting comment for conf-javaprop-mode says this:

"Conf Mode starter for Java properties files.
Comments start with `#' but are also recognized with `//' or
between `/*' and `*/'.
For details see `conf-mode'.  Example:

# Conf mode font-locks this right with \\[conf-javaprop-mode] (Java properties)
// another kind of comment
/* yet another */

But // and /* don't start comments in Java properties files. Java
properties files just have single-line comments starting with #.
Somewhat obscurely, comments can also start with !.

I'm up for submitting a patch to fix this, but it would be my first
contribution to emacs, and I'm a bit intimidated, so I want to check
whether it's reasonable to fix first.

Message #8 received at 49077 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Spencer Nelson <swnelson <at> uw.edu>
Cc: 49077 <at> debbugs.gnu.org
Subject: Re: bug#49077: 26.3; conf-mode for Java properties files uses
 incorrect comment syntax
Date: Sat, 19 Jun 2021 15:33:16 +0200

Spencer Nelson <swnelson <at> uw.edu> writes:

> I'm up for submitting a patch to fix this, but it would be my first
> contribution to emacs, and I'm a bit intimidated, so I want to check
> whether it's reasonable to fix first.

Sure, fixing this would be very welcome.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 49077 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Spencer Nelson <swnelson <at> uw.edu>
Cc: 49077 <at> debbugs.gnu.org
Subject: Re: bug#49077: 26.3; conf-mode for Java properties files uses
 incorrect comment syntax
Date: Sat, 16 Jul 2022 14:15:21 +0200

Spencer Nelson <swnelson <at> uw.edu> writes:

> The documenting comment for conf-javaprop-mode says this:
>
> "Conf Mode starter for Java properties files.
> Comments start with `#' but are also recognized with `//' or
> between `/*' and `*/'.
> For details see `conf-mode'.  Example:
>
> # Conf mode font-locks this right with \\[conf-javaprop-mode] (Java properties)
> // another kind of comment
> /* yet another */
>
> But // and /* don't start comments in Java properties files. Java
> properties files just have single-line comments starting with #.
> Somewhat obscurely, comments can also start with !.

I thought this should be easy to fix, but I'm not at all sure where the
font-locking of // and /* */ is coming from.  I feel like I've looked at
all the font-lock-* variables, but I can't find anything.

Anybody?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 49077 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Spencer Nelson <swnelson <at> uw.edu>
Cc: 49077 <at> debbugs.gnu.org
Subject: Re: bug#49077: 26.3; conf-mode for Java properties files uses
 incorrect comment syntax
Date: Sat, 20 Aug 2022 11:54:53 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I thought this should be easy to fix, but I'm not at all sure where the
> font-locking of // and /* */ is coming from.  I feel like I've looked at
> all the font-lock-* variables, but I can't find anything.

It was in the syntax property stuff.  Now fixed in Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.