GNU bug report logs - #49094
[PATCH] gnu: Add video-contact-sheet

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Pradana Adrinusa AUMARS <paumars@HIDDEN>; Keywords: patch; merged with #49093; dated Fri, 18 Jun 2021 15:18:03 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Merged 49093 49094. Request was from Sarah Morgensen <iskarian@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 49094 <at> debbugs.gnu.org:


Received: (at 49094) by debbugs.gnu.org; 23 Jul 2021 22:40:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 23 18:40:13 2021
Received: from localhost ([127.0.0.1]:44865 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1m73q0-0004U5-Cv
	for submit <at> debbugs.gnu.org; Fri, 23 Jul 2021 18:40:13 -0400
Received: from out0.migadu.com ([94.23.1.103]:23809)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <iskarian@HIDDEN>) id 1m73pu-0004Tj-4D
 for 49094 <at> debbugs.gnu.org; Fri, 23 Jul 2021 18:40:11 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
 t=1627080004;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=FVTGS5Sfrhpqi/cBmti+jmK4sCuKaSJw/wgC5wmxYoA=;
 b=gameZF6VNfW49Qk53yEBa2NQ7bvE8ccKi3Brh/x7ufbAFAwQ19lXhVTMmKRBd/YSR3J0JJ
 FtLJU9LBkPyC5RhPpyKzc7u4t/gKkNf7gr94mjW1A2JchsBq424gbYE4lNFg7lxLHq0qAU
 dF9okBUdhaYkLRL9/NDp3Ov8U3iLbPs=
From: Sarah Morgensen <iskarian@HIDDEN>
To: Pradana Adrinusa AUMARS <paumars@HIDDEN>
Subject: Re: bug#49094: [PATCH] gnu: Add video-contact-sheet
References: <3627c385f0509614621b154cd26dc9ed4f503a51.camel@HIDDEN>
Date: Fri, 23 Jul 2021 15:40:02 -0700
In-Reply-To: <3627c385f0509614621b154cd26dc9ed4f503a51.camel@HIDDEN>
 (Pradana Adrinusa AUMARS's message of "Fri, 18 Jun 2021 16:27:02 +0200")
Message-ID: <861r7or6wt.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 49094
Cc: 49094 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

Thank you for the patch.  Unfortunately, I cannot apply it because your
mail client has wrapped some lines, corrupting the patch.  (Also, adding
to the end of the file rather than the middle tends to cause patches not
to apply, so probably avoid this as well.)

I do still have a few suggestions, annotated below:

Pradana Adrinusa AUMARS <paumars@HIDDEN> writes:

>>From 9851db2b3036ee3d5e8ef85ed8bae2f6398702e0 Mon Sep 17 00:00:00 2001
> From: Pradana AUMARS <paumars@HIDDEN>
> Date: Fri, 18 Jun 2021 16:13:07 +0200
> Subject: [PATCH] gnu: Add video-contact-sheet
>
> ---
>  gnu/packages/video.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index e3f4f59b4c..ba3035cf45 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -51,6 +51,7 @@
>  ;;; Copyright =C2=A9 2021 Andrew Tropin <andrew@HIDDEN>
>  ;;; Copyright =C2=A9 2021 David Wilson <david@HIDDEN>
>  ;;; Copyright =C2=A9 2021 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
> +;;; Copyright =C2=A9 2021 Pradana Aumars <paumars@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -96,6 +97,7 @@
>    #:use-module (gnu packages avahi)
>    #:use-module (gnu packages backup)
>    #:use-module (gnu packages base)
> +  #:use-module (gnu packages bash)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages cdrom)
> @@ -5180,3 +5182,32 @@ information) NALUs (Network Abstraction Layer
> Unit) for inclusion into an h.264
>  elementary stream are provided.")
>      (home-page "https://github.com/szatmary/libcaption")
>      (license license:expat)))
> +
> +(define-public video-contact-sheet
> +  (package
> +   (name "video-contact-sheet")
> +   (version "1.13.4")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "http://p.outlyer.net/vcs/files/vcs-"
> version
> +				".tar.gz"))

Lines should be wrapped at 80 characters when possible.  Indentation
should be with spaces instead of tabs.

Also, it looks like 'http://p.outlyer.net/vcs/files/' has a permanent
redirect to 'http://p.outlyer.net/files/vcs/' so that should be updated.

> +            (sha256
> +             (base32
> +              "0jsl93r0rnybjcipqbww5hwsr9ln6kz1qnf32qfxdvhfw52n27fw"))
> ))
> +   (build-system gnu-build-system)
> +   (arguments
> +    `(#:phases (modify-phases %standard-phases
> +                              (delete 'configure)
> +                              (delete 'build)
> +                              (delete 'check))
> +      #:make-flags (list (string-append "prefix=3D" (assoc-ref %outputs
> "out")))))
> +   (inputs
> +    `(("bash" ,bash)
> +      ("ffmpeg" ,ffmpeg)
> +      ("imagemagick" ,imagemagick)))
> +   (synopsis "Bash script to create contact sheets (preview images)
> from videos")
> +   (description "This is a bash script meant to create video contact
> sheets (previews) of videos. Any video supported by mplayer and ffmpeg
> can be used. A note of warning: Unlike most similar tools it, by
> default, makes screenshots the same size as the video, see below for
                                                             ^ the manual
> details on how to change this.
> +
> +Take a look at the documentation and/or use the =E2=80=93help and =E2=80=
=93fullhelp
> options to learn how to use it.")
This last sentence should probably not be in the description.

Please also wrap these lines at 80 characters as well (see other
packages for examples), and use two spaces between sentences.

> +   (home-page "http://p.outlyer.net/vcs/")
> +   (license license:lgpl3)))

--
Sarah




Information forwarded to guix-patches@HIDDEN:
bug#49094; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 18 Jun 2021 15:17:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 18 11:17:39 2021
Received: from localhost ([127.0.0.1]:57612 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1luGFX-0001TH-E1
	for submit <at> debbugs.gnu.org; Fri, 18 Jun 2021 11:17:39 -0400
Received: from lists.gnu.org ([209.51.188.17]:36830)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <SRS0=nKz1=LM=courrier.dev=paumars@HIDDEN>)
 id 1luFSi-0000Ce-DR
 for submit <at> debbugs.gnu.org; Fri, 18 Jun 2021 10:27:12 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53690)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1)
 (envelope-from <SRS0=nKz1=LM=courrier.dev=paumars@HIDDEN>)
 id 1luFSi-00087o-6m
 for guix-patches@HIDDEN; Fri, 18 Jun 2021 10:27:12 -0400
Received: from mail.42l.fr ([185.216.27.142]:36776)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1)
 (envelope-from <SRS0=nKz1=LM=courrier.dev=paumars@HIDDEN>)
 id 1luFSf-0003iQ-KZ
 for guix-patches@HIDDEN; Fri, 18 Jun 2021 10:27:11 -0400
Message-ID: <3627c385f0509614621b154cd26dc9ed4f503a51.camel@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=courrier.dev; s=mail;
 t=1624026422; bh=njBSI2SAgAtcy8VI+B6TOLzyVdEJKeGe+04lEEwrHdY=;
 h=Subject:From:To;
 b=DsBYjn7Hjn1IRotlOHyljh0OuVLJKr03YWdxnTHZYfAP3QuTLqxWqoEyXYH8slcPo
 0kBVStn1jHfzqXfQvZ4OboJpSYZet+FO2e6GqtWN31Zwcpiyljpvx5dn77r5pN4Fqm
 FrOyTaImChorpdsTdcMzeeGZ7rz5XuEleM7OnuooJaCraVzNnEPW0hN5gAT0X72wZD
 yxrBE+OgD2POte5/Uh2BcToY+nA8QYiVlBU+MIJbNHdjjS9+iS7w9W+JZAJ3Uaf+DF
 zwJW0viUdMyQXJKsy54Eu74lQ/EGtctUMLeGPhgIRoSSDaKEFNj80pBz7bZmKW9hxi
 QZBxl1VnpgNXQ==
Subject: [PATCH] gnu: Add video-contact-sheet
From: Pradana Adrinusa AUMARS <paumars@HIDDEN>
To: guix-patches@HIDDEN
Date: Fri, 18 Jun 2021 16:27:02 +0200
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=185.216.27.142;
 envelope-from=SRS0=nKz1=LM=courrier.dev=paumars@HIDDEN; helo=mail.42l.fr
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Fri, 18 Jun 2021 11:17:37 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

From 9851db2b3036ee3d5e8ef85ed8bae2f6398702e0 Mon Sep 17 00:00:00 2001
From: Pradana AUMARS <paumars@HIDDEN>
Date: Fri, 18 Jun 2021 16:13:07 +0200
Subject: [PATCH] gnu: Add video-contact-sheet

---
 gnu/packages/video.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e3f4f59b4c..ba3035cf45 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2021 Andrew Tropin <andrew@HIDDEN>
 ;;; Copyright © 2021 David Wilson <david@HIDDEN>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2021 Pradana Aumars <paumars@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -96,6 +97,7 @@
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages cdrom)
@@ -5180,3 +5182,32 @@ information) NALUs (Network Abstraction Layer
Unit) for inclusion into an h.264
 elementary stream are provided.")
     (home-page "https://github.com/szatmary/libcaption")
     (license license:expat)))
+
+(define-public video-contact-sheet
+  (package
+   (name "video-contact-sheet")
+   (version "1.13.4")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "http://p.outlyer.net/vcs/files/vcs-"
version
+				".tar.gz"))
+            (sha256
+             (base32
+              "0jsl93r0rnybjcipqbww5hwsr9ln6kz1qnf32qfxdvhfw52n27fw"))
))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:phases (modify-phases %standard-phases
+                              (delete 'configure)
+                              (delete 'build)
+                              (delete 'check))
+      #:make-flags (list (string-append "prefix=" (assoc-ref %outputs
"out")))))
+   (inputs
+    `(("bash" ,bash)
+      ("ffmpeg" ,ffmpeg)
+      ("imagemagick" ,imagemagick)))
+   (synopsis "Bash script to create contact sheets (preview images)
from videos")
+   (description "This is a bash script meant to create video contact
sheets (previews) of videos. Any video supported by mplayer and ffmpeg
can be used. A note of warning: Unlike most similar tools it, by
default, makes screenshots the same size as the video, see below for
details on how to change this.
+
+Take a look at the documentation and/or use the –help and –fullhelp
options to learn how to use it.")
+   (home-page "http://p.outlyer.net/vcs/")
+   (license license:lgpl3)))
-- 
2.32.0






Acknowledgement sent to Pradana Adrinusa AUMARS <paumars@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#49094; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 23 Jul 2021 23:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.