GNU bug report logs -
#49100
make check fails: %derivation-cache
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49100 in the body.
You can then email your comments to 49100 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
ludo <at> gnu.org, bug-guix <at> gnu.org
:
bug#49100
; Package
guix
.
(Fri, 18 Jun 2021 17:56:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Chris Marusich <cmmarusich <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
ludo <at> gnu.org, bug-guix <at> gnu.org
.
(Fri, 18 Jun 2021 17:56:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check"
errors out in tests/builders.scm:
--8<---------------cut here---------------start------------->8---
Backtrace:
1 (primitive-load-path "tests/builders.scm")
In guix/tests.scm:
146:8 0 (call-with-external-store #<procedure 7f92ff4f7d60 at i…>)
guix/tests.scm:146:8: In procedure call-with-external-store:
error: %derivation-cache: unbound variable
--8<---------------cut here---------------end--------------->8---
The problem appears to have been caused by
7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using
gexps.").
The attached patch fixes the issue for me. However, since I'm not sure
how %derivation-cache is or was supposed to be used, I would appreciate
a second opinion.
Note that %derivation-cache has been used to refer to two different
things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c).
Note also that even after applying this fix, some tests relying on
call-with-external-store still fail when run (see: bug 47018).
--
Chris
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org
:
bug#49100
; Package
guix
.
(Sun, 20 Jun 2021 21:18:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 49100 <at> debbugs.gnu.org (full text, mbox):
Hi Chris,
Chris Marusich <cmmarusich <at> gmail.com> skribis:
> On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check"
> errors out in tests/builders.scm:
>
> Backtrace:
> 1 (primitive-load-path "tests/builders.scm")
> In guix/tests.scm:
> 146:8 0 (call-with-external-store #<procedure 7f92ff4f7d60 at i…>)
>
> guix/tests.scm:146:8: In procedure call-with-external-store:
> error: %derivation-cache: unbound variable
>
> The problem appears to have been caused by
> 7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using
> gexps.").
Oops, my bad.
> The attached patch fixes the issue for me. However, since I'm not sure
> how %derivation-cache is or was supposed to be used, I would appreciate
> a second opinion.
You forgot to attach the patch, but I think it’s enough to remove the
‘hash-clear!’ call from ‘call-with-external-store’.
I haven’t checked but if the tests that rely on
‘call-with-external-store’ work for you, feel free to push!
> Note that %derivation-cache has been used to refer to two different
> things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c).
(@@ (guix packages) %derivation-cache) on ‘master’ maps <package>
records to the corresponding derivation. In ‘core-updates’, this cache
no longer exists; it’s superseded by the “object cache”, which is
per-session (part of <store-connection>.)
> Note also that even after applying this fix, some tests relying on
> call-with-external-store still fail when run (see: bug 47018).
Oh right.
HTH,
Ludo’.
Reply sent
to
Chris Marusich <cmmarusich <at> gmail.com>
:
You have taken responsibility.
(Wed, 23 Jun 2021 01:35:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Chris Marusich <cmmarusich <at> gmail.com>
:
bug acknowledged by developer.
(Wed, 23 Jun 2021 01:35:02 GMT)
Full text and
rfc822 format available.
Message #13 received at 49100-close <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:
>> The attached patch fixes the issue for me. However, since I'm not sure
>> how %derivation-cache is or was supposed to be used, I would appreciate
>> a second opinion.
>
> You forgot to attach the patch, but I think it’s enough to remove the
> ‘hash-clear!’ call from ‘call-with-external-store’.
Sorry - but yes, that's all it did. I removed the hash-clear! call.
I've gone ahead and committed this as
7f0af119a1e3ea9d0ae53811b619437b3e942702 on core-updates.
--
Chris
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 21 Jul 2021 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 272 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.