GNU bug report logs - #49141
[PATCH] etc: snippets: Use ‘hg-file-name’ when origin uses ‘hg-fetch’.

Previous Next

Package: guix-patches;

Reported by: Xinglu Chen <public <at> yoctocell.xyz>

Date: Sun, 20 Jun 2021 16:31:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49141 in the body.
You can then email your comments to 49141 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#49141; Package guix-patches. (Sun, 20 Jun 2021 16:31:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Xinglu Chen <public <at> yoctocell.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 20 Jun 2021 16:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] etc: snippets: Use ‘hg-file-name’ when origin uses ‘hg-fetch’.
Date: Sun, 20 Jun 2021 18:30:14 +0200
Adjust to changes in commit aaafd19bd1e37265de07e246286a6819792c25b4.

* etc/snippets/scheme-mode/guix-origin: Use ‘hg-file-name’ instead of
‘string-append’ when ‘method’ for origin is ‘hg-fetch’.
---
 etc/snippets/scheme-mode/guix-origin | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/etc/snippets/scheme-mode/guix-origin b/etc/snippets/scheme-mode/guix-origin
index 2820a369f3..b763a32926 100644
--- a/etc/snippets/scheme-mode/guix-origin
+++ b/etc/snippets/scheme-mode/guix-origin
@@ -19,6 +19,8 @@
                  (t "(string-append \\"https://\\" version \\".tar.gz\\")"))}$0)
  ${1:$(cond ((equal yas-text "git-fetch")
              "(file-name (git-file-name name version))")
+            ((equal yas-text "hg-fetch")
+             "(file-name (hg-file-name name version))")
             ((member yas-text '("svn-fetch" "hg-fetch" "cvs-fetch" "bzr-fetch"))
              "(file-name (string-append name \\"-\\" version \\"-checkout\\"))")
             (t ""))}

base-commit: a211078f992bc5a26eaf787c6b01caa41de67597
-- 
2.32.0






Information forwarded to guix-patches <at> gnu.org:
bug#49141; Package guix-patches. (Sun, 20 Jun 2021 18:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 49141 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 49141 <at> debbugs.gnu.org
Subject: [PATCH v2] etc: snippets: Use ‘hg-file-name’ when origin uses ‘hg-fetch’
Date: Sun, 20 Jun 2021 20:44:44 +0200
Adjust to changes in commit aaafd19bd1e37265de07e246286a6819792c25b4.

* etc/snippets/scheme-mode/guix-origin: Use ‘hg-file-name’ instead of
‘string-append’ when ‘method’ for origin is ‘hg-fetch’.
---
Changes since v1:

* Remove ‘hg-fetch’ from the line below

 etc/snippets/scheme-mode/guix-origin | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/etc/snippets/scheme-mode/guix-origin b/etc/snippets/scheme-mode/guix-origin
index 2820a369f3..eb0cdc8242 100644
--- a/etc/snippets/scheme-mode/guix-origin
+++ b/etc/snippets/scheme-mode/guix-origin
@@ -19,7 +19,9 @@
                  (t "(string-append \\"https://\\" version \\".tar.gz\\")"))}$0)
  ${1:$(cond ((equal yas-text "git-fetch")
              "(file-name (git-file-name name version))")
-            ((member yas-text '("svn-fetch" "hg-fetch" "cvs-fetch" "bzr-fetch"))
+            ((equal yas-text "hg-fetch")
+             "(file-name (hg-file-name name version))")
+            ((member yas-text '("svn-fetch" "cvs-fetch" "bzr-fetch"))
              "(file-name (string-append name \\"-\\" version \\"-checkout\\"))")
             (t ""))}
  (sha256

base-commit: a211078f992bc5a26eaf787c6b01caa41de67597
-- 
2.32.0






Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 26 Jun 2021 20:46:01 GMT) Full text and rfc822 format available.

Notification sent to Xinglu Chen <public <at> yoctocell.xyz>:
bug acknowledged by developer. (Sat, 26 Jun 2021 20:46:02 GMT) Full text and rfc822 format available.

Message #13 received at 49141-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 49141-done <at> debbugs.gnu.org
Subject: Re: bug#49141: [PATCH] etc: snippets: Use ‘hg-file-name’ when
 origin uses ‘hg-fetch’.
Date: Sat, 26 Jun 2021 22:45:39 +0200
Hi,

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> Adjust to changes in commit aaafd19bd1e37265de07e246286a6819792c25b4.
>
> * etc/snippets/scheme-mode/guix-origin: Use ‘hg-file-name’ instead of
> ‘string-append’ when ‘method’ for origin is ‘hg-fetch’.

Applied, thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 25 Jul 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.