GNU bug report logs - #49143
28.0.50; find-file-literally doesn't ignore `mode:`

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49143 in the body.
You can then email your comments to 49143 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; find-file-literally doesn't ignore `mode:`
Date: Sun, 20 Jun 2021 13:54:32 -0400

Package: Emacs
Version: 28.0.50


Contrary to its documentation, it seems that `find-file-literally`
doesn't ignore file-local `mode:` settings any more, as evidenced by the
following backtrace:

    dismal-mode()
    hack-one-local-variable(mode dismal)
    hack-local-variables-apply()
    hack-local-variables(no-mode)
    run-mode-hooks()
    fundamental-mode()
    set-buffer-major-mode(#<buffer normalization.dis>)
    set-auto-mode()
    normal-mode(t)
    after-find-file(nil t)
    find-file-noselect-1(#<buffer normalization.dis> "~/tmp/normalization.dis" nil nil "~/tmp/normalization.dis" (1347023 65026))
    find-file-noselect("~/tmp/normalization.dis")

I suspect the culprit is

    commit 5bedbe6b1d5f4b801abf91b4d023d5c4e66418f0
    Author: Lars Ingebrigtsen <larsi <at> gnus.org>
    Date:   Mon May 10 12:40:11 2021 +0200
    
        Always heed the `lexical-binding' local variable
        
        * doc/lispref/variables.texi (File Local Variables): Document
        `permanently-enabled-local-variables'.
        
        * lisp/files.el (enable-local-variables): Mention the new variable.
        (set-auto-mode): Always call `hack-local-variables'.
        (hack-local-variables): Factor out the variable gathering into its
        own function, and respect the new variable (bug#47843).
        (hack-local-variables--find-variables): Factored out from
        `hack-local-variables'.
        (permanently-enabled-local-variables): New variable.


-- Stefan

Message #8 received at 49143 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 49143 <at> debbugs.gnu.org
Subject: Re: bug#49143: 28.0.50; find-file-literally doesn't ignore `mode:`
Date: Mon, 21 Jun 2021 14:54:27 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> Contrary to its documentation, it seems that `find-file-literally`
> doesn't ignore file-local `mode:` settings any more, as evidenced by the
> following backtrace:
>
>     dismal-mode()
>     hack-one-local-variable(mode dismal)

Oops.

> I suspect the culprit is
>
>     commit 5bedbe6b1d5f4b801abf91b4d023d5c4e66418f0
>     Author: Lars Ingebrigtsen <larsi <at> gnus.org>
>     Date:   Mon May 10 12:40:11 2021 +0200

Yes, indeed.  I think I've now found the right fix -- I'm not totally
confident that it's the correct level to fix this on, though...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.