GNU bug report logs -
#49162
28.0.50; [PATCH] Use named face for apropos-face-button
Previous Next
Reported by: Protesilaos Stavrou <info <at> protesilaos.com>
Date: Mon, 21 Jun 2021 20:18:01 UTC
Severity: normal
Tags: patch
Found in version 28.0.50
Fixed in version 28.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49162 in the body.
You can then email your comments to 49162 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Mon, 21 Jun 2021 20:18:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Protesilaos Stavrou <info <at> protesilaos.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Mon, 21 Jun 2021 20:18:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Dear maintainers,
The attached patch defines a new face for the Apropos buffer which
applies to buttons that indicate faces.
Before the attributes were hardcoded and could thus not be edited by the
user/theme.
All the best,
Protesilaos
--
Protesilaos Stavrou
https://protesilaos.com
[0001-Use-named-face-for-apropos-face-button.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 11:44:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 49162 <at> debbugs.gnu.org (full text, mbox):
> From: Protesilaos Stavrou <info <at> protesilaos.com>
> Date: Mon, 21 Jun 2021 23:17:32 +0300
>
> +*** New face 'apropos-face-button'.
The name should be apropos-button-face, IMO.
Thanks.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 12:03:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 49162 <at> debbugs.gnu.org (full text, mbox):
>> +*** New face 'apropos-face-button'.
>
> The name should be apropos-button-face, IMO.
`apropos-button' IMO.
martin
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 12:12:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 49162 <at> debbugs.gnu.org (full text, mbox):
On 2021-06-22, 14:02 +0200, martin rudalics <rudalics <at> gmx.at> wrote:
> >> +*** New face 'apropos-face-button'.
> >
> > The name should be apropos-button-face, IMO.
>
> `apropos-button' IMO.
Thank you Martin and Eli! I picked that symbol because it was already
given by the implicit face.
You can try it with emacs -Q:
- M-x apropos RET font-lock-variable RET
- Place point over the underlined "Face" text and M-x describe-char
- In the resulting Help buffer, you will find the reference to
'apropos-face-button', whose specification is defined thus:
Category apropos-face-button:
action [Show]
apropos-label "Face"
apropos-short-label "F"
evaporate t
face (font-lock-variable-name-face button)
follow-link t
help-echo "mouse-2, RET: Display more help on this face"
keymap [Show]
mouse-face highlight
rear-nonsticky t
supertype button
type apropos-face
What do you think?
--
Protesilaos Stavrou
https://protesilaos.com
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 12:22:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 49162 <at> debbugs.gnu.org (full text, mbox):
On Jun 22 2021, Protesilaos Stavrou wrote:
> On 2021-06-22, 14:02 +0200, martin rudalics <rudalics <at> gmx.at> wrote:
>
>> >> +*** New face 'apropos-face-button'.
>> >
>> > The name should be apropos-button-face, IMO.
>>
>> `apropos-button' IMO.
>
> Thank you Martin and Eli! I picked that symbol because it was already
> given by the implicit face.
>
> You can try it with emacs -Q:
>
> - M-x apropos RET font-lock-variable RET
> - Place point over the underlined "Face" text and M-x describe-char
> - In the resulting Help buffer, you will find the reference to
> 'apropos-face-button', whose specification is defined thus:
>
> Category apropos-face-button:
>
> action [Show]
> apropos-label "Face"
> apropos-short-label "F"
> evaporate t
> face (font-lock-variable-name-face button)
> follow-link t
> help-echo "mouse-2, RET: Display more help on this face"
> keymap [Show]
> mouse-face highlight
> rear-nonsticky t
> supertype button
> type apropos-face
>
>
> What do you think?
It's the face for the apropos-face-button, so the name looks right.
Andreas.
--
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 12:38:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 49162 <at> debbugs.gnu.org (full text, mbox):
> From: Protesilaos Stavrou <info <at> protesilaos.com>
> Cc: 49162 <at> debbugs.gnu.org
> Date: Tue, 22 Jun 2021 15:11:33 +0300
>
> Thank you Martin and Eli! I picked that symbol because it was already
> given by the implicit face.
>
> You can try it with emacs -Q:
>
> - M-x apropos RET font-lock-variable RET
> - Place point over the underlined "Face" text and M-x describe-char
> - In the resulting Help buffer, you will find the reference to
> 'apropos-face-button', whose specification is defined thus:
>
> Category apropos-face-button:
That's the _button_, not its _face_. It is cumbersome to call a face
by a name that ends with "-button", IMO.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 13:10:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 49162 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 2021-06-22, 15:37 +0300, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Protesilaos Stavrou <info <at> protesilaos.com>
>> Cc: 49162 <at> debbugs.gnu.org
>> Date: Tue, 22 Jun 2021 15:11:33 +0300
>>
>> Thank you Martin and Eli! I picked that symbol because it was already
>> given by the implicit face.
>>
>> You can try it with emacs -Q:
>>
>> - M-x apropos RET font-lock-variable RET
>> - Place point over the underlined "Face" text and M-x describe-char
>> - In the resulting Help buffer, you will find the reference to
>> 'apropos-face-button', whose specification is defined thus:
>>
>> Category apropos-face-button:
>
> That's the _button_, not its _face_. It is cumbersome to call a face
> by a name that ends with "-button", IMO.
I see. Thank you! Please find attached the revised patch for
'apropos-button-face'
--
Protesilaos Stavrou
https://protesilaos.com
[0001-Use-named-face-for-apropos-button-face.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 13:35:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 49162 <at> debbugs.gnu.org (full text, mbox):
Protesilaos Stavrou <info <at> protesilaos.com> writes:
> I see. Thank you! Please find attached the revised patch for
> 'apropos-button-face'
Thanks; applied to Emacs 28 (but I changed the name of the face to
`apropos-button' -- we don't call new faces `-face' these days).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 28.1, send any further explanations to
49162 <at> debbugs.gnu.org and Protesilaos Stavrou <info <at> protesilaos.com>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Tue, 22 Jun 2021 13:35:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 14:01:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 49162 <at> debbugs.gnu.org (full text, mbox):
On Jun 22 2021, Eli Zaretskii wrote:
>> From: Protesilaos Stavrou <info <at> protesilaos.com>
>> Cc: 49162 <at> debbugs.gnu.org
>> Date: Tue, 22 Jun 2021 15:11:33 +0300
>>
>> Thank you Martin and Eli! I picked that symbol because it was already
>> given by the implicit face.
>>
>> You can try it with emacs -Q:
>>
>> - M-x apropos RET font-lock-variable RET
>> - Place point over the underlined "Face" text and M-x describe-char
>> - In the resulting Help buffer, you will find the reference to
>> 'apropos-face-button', whose specification is defined thus:
>>
>> Category apropos-face-button:
>
> That's the _button_, not its _face_.
But the new face is the face for the button.
Andreas.
--
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 15:34:01 GMT)
Full text and
rfc822 format available.
Message #34 received at 49162 <at> debbugs.gnu.org (full text, mbox):
> From: Andreas Schwab <schwab <at> linux-m68k.org>
> Cc: Protesilaos Stavrou <info <at> protesilaos.com>, 49162 <at> debbugs.gnu.org
> Date: Tue, 22 Jun 2021 16:00:06 +0200
>
> >> Category apropos-face-button:
> >
> > That's the _button_, not its _face_.
>
> But the new face is the face for the button.
I don't have anything about naming the face apropos-button. It's
apropos-face-button that I don't like: it implies that it's a button
of a face, or something that is apropos button-face; both are wrong.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 15:45:02 GMT)
Full text and
rfc822 format available.
Message #37 received at 49162 <at> debbugs.gnu.org (full text, mbox):
On Jun 22 2021, Eli Zaretskii wrote:
>> From: Andreas Schwab <schwab <at> linux-m68k.org>
>> Cc: Protesilaos Stavrou <info <at> protesilaos.com>, 49162 <at> debbugs.gnu.org
>> Date: Tue, 22 Jun 2021 16:00:06 +0200
>>
>> >> Category apropos-face-button:
>> >
>> > That's the _button_, not its _face_.
>>
>> But the new face is the face for the button.
>
> I don't have anything about naming the face apropos-button. It's
> apropos-face-button that I don't like: it implies that it's a button
> of a face, or something that is apropos button-face; both are wrong.
But that happens to be the name of the button that the face is for, just
like the apropos-variable-button face is the face for the
apropos-variable-button button. Since face names have no qualifiers,
such duplication is unavoidable.
Andreas.
--
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#49162; Package
emacs.
(Tue, 22 Jun 2021 15:55:01 GMT)
Full text and
rfc822 format available.
Message #40 received at 49162 <at> debbugs.gnu.org (full text, mbox):
> From: Andreas Schwab <schwab <at> linux-m68k.org>
> Cc: info <at> protesilaos.com, 49162 <at> debbugs.gnu.org
> Date: Tue, 22 Jun 2021 17:44:25 +0200
>
> > I don't have anything about naming the face apropos-button. It's
> > apropos-face-button that I don't like: it implies that it's a button
> > of a face, or something that is apropos button-face; both are wrong.
>
> But that happens to be the name of the button that the face is for, just
> like the apropos-variable-button face is the face for the
> apropos-variable-button button.
And they are all unfortunate, IMO. We don't need to keep some kind of
consistency here, I think.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Wed, 21 Jul 2021 11:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 277 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.