GNU bug report logs - #49188
[PATCH 0/1] Fixing passmenu (password-store) command substitutions

Previous Next

Package: guix-patches;

Reported by: David Dashyan <mail <at> davie.li>

Date: Wed, 23 Jun 2021 15:28:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49188 in the body.
You can then email your comments to 49188 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#49188; Package guix-patches. (Wed, 23 Jun 2021 15:28:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to David Dashyan <mail <at> davie.li>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 23 Jun 2021 15:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Dashyan <mail <at> davie.li>
To: guix-patches <at> gnu.org
Cc: David Dashyan <mail <at> davie.li>
Subject: [PATCH 0/1] Fixing passmenu (password-store) command substitutions
Date: Wed, 23 Jun 2021 18:26:44 +0300
Hello!  There was an update to password-stre contrib scripts adding Wayland
support.  This left some of substite* invocations producing incorrect scripts.

Breackage introduced in upstream commit 
3d36829ce7a203f97e84723e1dc02fef1e0d06cc
link -> https://git.zx2c4.com/password-store/commit/?id=3d36829ce7a203f97e84723e1dc02fef1e0d06cc

But!  I ignored the wailand support -- it requires dmenu-wl and ydotool
packages, I only made the passmenu command work with xorg again.

What do guix do in such case make new output for wayland?

Peace and love

David Dashyan (1):
  gnu: password-store: Fix passmenu paths substitution

 gnu/packages/password-utils.scm | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)


base-commit: d027858e70c4a37aca90b1d4ecb2f0421a95d987
-- 
2.32.0





Information forwarded to guix-patches <at> gnu.org:
bug#49188; Package guix-patches. (Wed, 23 Jun 2021 15:31:01 GMT) Full text and rfc822 format available.

Message #8 received at 49188 <at> debbugs.gnu.org (full text, mbox):

From: David Dashyan <mail <at> davie.li>
To: 49188 <at> debbugs.gnu.org
Cc: David Dashyan <mail <at> davie.li>
Subject: [PATCH 1/1] gnu: password-store: Fix passmenu paths substitution
Date: Wed, 23 Jun 2021 18:29:59 +0300
* gnu/packages/password-utils.scm (password-store)
[arguments]: Fix dmenu and xdotool path substitution in patch-passmenu-path
phase.
---
 gnu/packages/password-utils.scm | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 9c8912c5e8..460193c72d 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -31,6 +31,7 @@
 ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
+;;; Copyright © 2021 David Dashyan <mail <at> davie.li>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -517,12 +518,18 @@ any X11 window.")
                                  "}\"\n"))))
              #t))
          (add-before 'install 'patch-passmenu-path
+           ;; FIXME Wayland support requires ydotool and dmenu-wl packages
+           ;; We are ignoring part of the script that gets executed if
+           ;; WAYLAND_DISPLAY env variable is set, leaving dmenu-wl and ydotool
+           ;; commands as is.
            (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "contrib/dmenu/passmenu"
-               (("dmenu") (string-append (assoc-ref inputs "dmenu")
-                                         "/bin/dmenu"))
-               (("xdotool") (string-append (assoc-ref inputs "xdotool")
-                                           "/bin/xdotool")))
+               (("dmenu=dmenu\n") (string-append "dmenu="
+                                                 (assoc-ref inputs "dmenu")
+                                                 "/bin/dmenu\n"))
+               (("xdotool=\"xdotool") (string-append "xdotool=\""
+                                                     (assoc-ref inputs "xdotool")
+                                                     "/bin/xdotool")))
              #t))
          (add-after 'install 'install-passmenu
            (lambda* (#:key outputs #:allow-other-keys)
-- 
2.32.0





Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Tue, 13 Jul 2021 13:10:02 GMT) Full text and rfc822 format available.

Notification sent to David Dashyan <mail <at> davie.li>:
bug acknowledged by developer. (Tue, 13 Jul 2021 13:10:02 GMT) Full text and rfc822 format available.

Message #13 received at 49188-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: David Dashyan <mail <at> davie.li>
Cc: 49188-done <at> debbugs.gnu.org
Subject: Re: [bug#49188] [PATCH 1/1] gnu: password-store: Fix passmenu paths
 substitution
Date: Tue, 13 Jul 2021 16:08:05 +0300
[Message part 1 (text/plain, inline)]
Thanks. Patch pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 11 Aug 2021 11:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 231 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.