GNU bug report logs - #49199
[PATCH core-updates] add package-db to runhaskell (haskell-build-system)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49199 in the body.
You can then email your comments to 49199 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH core-updates] add package-db to runhaskell
 (haskell-build-system)
Date: Wed, 23 Jun 2021 22:09:05 +0000

[Message part 1 (text/plain, inline)]

Hello,

This is a patch to fix issue #48944 as well as more broadly an issue of Haskell packages that need modules at the configure step. Currently the package database is not passed to runhaskell directly, which means runhaskell Setup.hs configure does not have outside modules available. This blocks packages that need things like cabal-doctest or gtk2hs-buildtools like ghc-cairo (which has a custom build process in the package currently, for this reason). Comments in ghc-cairo and for other packages with this need, suggest the change made in this patch.

The simplest change I saw was to make the package database passed to runhaskell on any command; not sure if this would be better for just configure. It may be possible to do this just passing the actual needed packages with -package-id, as suggested in https://github.com/tweag/rules_haskell/issues/1314 However, I have not tried that and seemed more complicated than needed. Also, I did not modify the message printed as it already has the package-db in params, but perhaps better to be clear the exact command being run?

I have built many Haskell packages with this change and it works well for me, fixing the reported issue and packages I'm building not yet in guix. Given this changes the build command for all Haskell packages, would be happy for other tests to be run.

John

[runhaskell-add-pkgdb.patch (text/x-patch, attachment)]

Message #8 received at 49199 <at> debbugs.gnu.org (full text, mbox):

From: "Philip Munksgaard" <philip <at> munksgaard.me>
To: 49199 <at> debbugs.gnu.org
Date: Fri, 02 Jul 2021 09:38:32 +0200

This works for me. How can we get it merged?

Message #11 received at 49199 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "49199 <at> debbugs.gnu.org" <49199 <at> debbugs.gnu.org>
Subject: [PATCH core-updates] add package-db to runhaskell
 (haskell-build-system)
Date: Sun, 04 Jul 2021 00:47:21 +0000

I don't know, I'm rather new here :-) We'll need one of the main devs I guess to do it? The patch I submitted was actually from the master branch, but haskell-build-system is identical in core-updates if I'm reading the git log correctly. But I'm happy to do more testing on the core-updates branch.

Message #14 received at 49199 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "49199 <at> debbugs.gnu.org" <49199 <at> debbugs.gnu.org>
Subject: [PATCH core-updates] add package-db to runhaskell
 (haskell-build-system)
Date: Mon, 05 Jul 2021 16:17:38 +0000

Looks like you (and me) have run into several of these problems that could be revised with some fixes to haskell-build-system and the hackage importer. On #guix it was discussed having a branch to try out these changes and leverage the CI to see what breaks on making changes to the build system, ghc version, etc.

We'll need someone to create and let us push there, not sure who to ask or how to get started on that...

Message #19 received at 49199-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 49199-done <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>
Subject: [PATCH core-updates] add package-db to runhaskell
 (haskell-build-system)
Date: Wed, 21 Jul 2021 00:22:45 +0200

Hi,

I made a commit out of the diff and pushed it to wip-haskell, 
which is based on core-updates.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.