GNU bug report logs - #49243
27.2; [PATCH] Merge auth-source-pass changes from upstream

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49243 in the body.
You can then email your comments to 49243 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.2; [PATCH] Merge auth-source-pass changes from upstream
Date: Sun, 27 Jun 2021 18:02:01 +0200

[Message part 1 (text/plain, inline)]

Hi,

please find attached a few patches for auth-source-pass that were merged
upstream.

Damien Cassou (2):
  ; * lisp/auth-source-pass.el: Improve docstrings
  ; * lisp/auth-source-pass.el: Remove useless metadata

Iku Iwasa (1):
  lisp/auth-source-pass.el: Support multiple hosts in search spec

Tino Calancha (1):
  lisp/auth-source-pass.el: Keep legitimate spaces inside data

 lisp/auth-source-pass.el            | 61 ++++++++++++++++-------------
 test/lisp/auth-source-pass-tests.el | 24 +++++++++++-
 2 files changed, 57 insertions(+), 28 deletions(-)


-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-lisp-auth-source-pass.el-Support-multiple-hosts-in-s.patch (text/x-patch, attachment)]

[0002-lisp-auth-source-pass.el-Improve-docstrings.patch (text/x-patch, attachment)]

[0003-lisp-auth-source-pass.el-Remove-useless-metadata.patch (text/x-patch, attachment)]

[0004-lisp-auth-source-pass.el-Keep-legitimate-spaces-insi.patch (text/x-patch, attachment)]

Message #8 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>
Cc: 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Mon, 28 Jun 2021 15:08:34 +0200

>>>>> On Sun, 27 Jun 2021 18:02:01 +0200, Damien Cassou <damien <at> cassou.me> said:

    Damien> Hi,
    Damien> please find attached a few patches for auth-source-pass that were merged
    Damien> upstream.

    Damien> Damien Cassou (2):
    Damien>   ; * lisp/auth-source-pass.el: Improve docstrings
    Damien>   ; * lisp/auth-source-pass.el: Remove useless metadata

    Damien> Iku Iwasa (1):
    Damien>   lisp/auth-source-pass.el: Support multiple hosts in search spec

Hmm, if auth-source-search supports multiple hosts, it would be good
if that were documented in the info manual.

Robert
-- 

Message #11 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Wed, 30 Jun 2021 15:09:11 +0200

Damien Cassou <damien <at> cassou.me> writes:

> please find attached a few patches for auth-source-pass that were merged
> upstream.

Thanks; looks good to me.  You can still push directly to Emacs, I
think?  Or do you want me to apply the patches?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Wed, 30 Jun 2021 18:09:32 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Thanks; looks good to me.  You can still push directly to Emacs, I
> think?  Or do you want me to apply the patches?

I would feel safer if you do it for me :-).

> Hmm, if auth-source-search supports multiple hosts, it would be good
> if that were documented in the info manual.

not sure because supporting only one host was a bug: auth-source-pass
wasn't implementing the auth-source protocol correctly.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #17 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Wed, 30 Jun 2021 19:56:23 +0200

>>>>> On Wed, 30 Jun 2021 18:09:32 +0200, Damien Cassou <damien <at> cassou.me> said:

    Damien> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
    >> Thanks; looks good to me.  You can still push directly to Emacs, I
    >> think?  Or do you want me to apply the patches?

    Damien> I would feel safer if you do it for me :-).

    >> Hmm, if auth-source-search supports multiple hosts, it would be good
    >> if that were documented in the info manual.

    Damien> not sure because supporting only one host was a bug: auth-source-pass
    Damien> wasn't implementing the auth-source protocol correctly.

That last bit was me, not Lars. I was trying to nudge you to go look
at the 'developers' section of the auth-source info manual and bring
its documentation in line with the implementation, since it currently
doesnʼt say anything about multiple hosts.

Robert
-- 

Message #20 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Fri, 02 Jul 2021 12:54:13 +0200

Damien Cassou <damien <at> cassou.me> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>> Thanks; looks good to me.  You can still push directly to Emacs, I
>> think?  Or do you want me to apply the patches?
>
> I would feel safer if you do it for me :-).

Sure; no prob.  :-)  Pushed now to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Fri, 02 Jul 2021 15:33:36 +0200

Robert Pluim <rpluim <at> gmail.com> writes:
> That last bit was me, not Lars. I was trying to nudge you to go look
> at the 'developers' section of the auth-source info manual and bring
> its documentation in line with the implementation, since it currently
> doesnʼt say anything about multiple hosts.

I've just checked. The info manual says:

   -- Function: auth-source-search &rest spec &key type max host user port
            secret require create delete &allow-other-keys
  
      This function searches (or modifies) authentication backends
       according to SPEC.  See the function’s doc-string for details.

And the docstring says:

  A string value is always matched literally.  A symbol is matched as
  its string value, literally.  All the SPEC values can be single values
  (symbol or string) or lists thereof (in which case any of the search
  terms matches).

I think this is good enough.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #28 received at 49243 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>
Cc: 49243 <at> debbugs.gnu.org
Subject: Re: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from
 upstream
Date: Fri, 02 Jul 2021 15:48:12 +0200

>>>>> On Fri, 02 Jul 2021 15:33:36 +0200, Damien Cassou <damien <at> cassou.me> said:

    Damien> Robert Pluim <rpluim <at> gmail.com> writes:
    >> That last bit was me, not Lars. I was trying to nudge you to go look
    >> at the 'developers' section of the auth-source info manual and bring
    >> its documentation in line with the implementation, since it currently
    >> doesnʼt say anything about multiple hosts.

    Damien> I've just checked. The info manual says:

    Damien>    -- Function: auth-source-search &rest spec &key type max host user port
    Damien>             secret require create delete &allow-other-keys
  
    Damien>       This function searches (or modifies) authentication backends
    Damien>        according to SPEC.  See the function’s doc-string for details.

    Damien> And the docstring says:

    Damien>   A string value is always matched literally.  A symbol is matched as
    Damien>   its string value, literally.  All the SPEC values can be single values
    Damien>   (symbol or string) or lists thereof (in which case any of the search
    Damien>   terms matches).

Ah, I didnʼt go back to the docstring

    Damien> I think this is good enough.

Yes

    Damien> "Success is the ability to go from one failure to another without
    Damien> losing enthusiasm." --Winston Churchill

:-)

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.