GNU bug report logs - #49293
[PATCH] isc-dhcp: Fix dhclient-script wrapper when cross-compiling.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49293 in the body.
You can then email your comments to 49293 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH] isc-dhcp: Fix dhclient-script wrapper when cross-compiling.
Date: Wed, 30 Jun 2021 16:13:46 +0200

[Message part 1 (text/plain, inline)]

This causes many rebuilds, but only when cross-compiling.
This should unbreak Internet access on cross-compiled pinebook
images.

Reported-By: Guest4977 (on IRC)

[0001-isc-dhcp-Fix-dhclient-script-wrapper-when-cross-comp.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 49293 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49293 <at> debbugs.gnu.org
Subject: Re: bug#49293: [PATCH] isc-dhcp: Fix dhclient-script wrapper when
 cross-compiling.
Date: Wed, 07 Jul 2021 16:28:51 +0200

Hello Maxime,

> * gnu/gnunet/packages/admin.scm
>   (isc-dhcp)[arguments]<#:phases>{post-install}: Use the
>   cross-compiled bash when cross-compiling. Work-around
>   <https://issues.guix.gnu.org/49290>.

When running:

--8<---------------cut here---------------start------------->8---
mathieu <at> meije ~/guix [env]$ grep -nr bash /gnu/store/wgrh2kzgj1h6bnhxi8vv42qvriarmhsy-isc-dhcp-4.4.2-P1
/gnu/store/wgrh2kzgj1h6bnhxi8vv42qvriarmhsy-isc-dhcp-4.4.2-P1/libexec/dhclient-script:1:#!/gnu/store/xrvzr2xxf9azy9frn1a4ggfyws0jzg4a-bash-minimal-5.0.16/bin/bash
/gnu/store/wgrh2kzgj1h6bnhxi8vv42qvriarmhsy-isc-dhcp-4.4.2-P1/libexec/.dhclient-script-real:1:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash
--8<---------------cut here---------------end--------------->8---

the first bash shebang reports:

--8<---------------cut here---------------start------------->8---
mathieu <at> meije ~/guix [env]$ file /gnu/store/xrvzr2xxf9azy9frn1a4ggfyws0jzg4a-bash-minimal-5.0.16/bin/bash
/gnu/store/xrvzr2xxf9azy9frn1a4ggfyws0jzg4a-bash-minimal-5.0.16/bin/bash: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /gnu/store/qxbv3y3992whk7hrbbcl391mgnqnyxch-glibc-cross-aarch64-linux-gnu-2.31/lib/ld-linux-aarch64.so.1, for GNU/Linux 2.6.32, not stripped
--8<---------------cut here---------------end--------------->8---

which seems fine, but for the second one:

--8<---------------cut here---------------start------------->8---
mathieu <at> meije ~/guix [env]$ file /gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash
/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/lib/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, not stripped
--8<---------------cut here---------------end--------------->8---

As the first script is exec-ing the second one, it could be problematic,
right?

Thanks,

Mathieu

Message #11 received at 49293 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 49293 <at> debbugs.gnu.org
Subject: Re: bug#49293: [PATCH] isc-dhcp: Fix dhclient-script wrapper when
 cross-compiling.
Date: Thu, 08 Jul 2021 22:44:01 +0200

[Message part 1 (text/plain, inline)]

Mathieu Othacehe schreef op wo 07-07-2021 om 16:28 [+0200]:
> Hello Maxime,
> 
> > * gnu/gnunet/packages/admin.scm
> >   (isc-dhcp)[arguments]<#:phases>{post-install}: Use the
> >   cross-compiled bash when cross-compiling. Work-around
> >   <https://issues.guix.gnu.org/49290>;.
> 
> When running:
> 
> --8<---------------cut here---------------start------------->8---
> mathieu <at> meije ~/guix [env]$ grep -nr bash /gnu/store/wgrh2kzgj1h6bnhxi8vv42qvriarmhsy-isc-dhcp-4.4.2-P1
> /gnu/store/wgrh2kzgj1h6bnhxi8vv42qvriarmhsy-isc-dhcp-4.4.2-P1/libexec/dhclient-script:1:#!/gnu/store/xrvzr2xxf9azy9frn1a4ggfyws0jzg4a-bash-minimal-5.0.16/bin/bash
> /gnu/store/wgrh2kzgj1h6bnhxi8vv42qvriarmhsy-isc-dhcp-4.4.2-P1/libexec/.dhclient-script-real:1:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash
> --8<---------------cut here---------------end--------------->8---
> 
> the first bash shebang reports:
> 
> --8<---------------cut here---------------start------------->8---
> mathieu <at> meije ~/guix [env]$ file /gnu/store/xrvzr2xxf9azy9frn1a4ggfyws0jzg4a-bash-minimal-5.0.16/bin/bash
> /gnu/store/xrvzr2xxf9azy9frn1a4ggfyws0jzg4a-bash-minimal-5.0.16/bin/bash: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /gnu/store/qxbv3y3992whk7hrbbcl391mgnqnyxch-glibc-cross-aarch64-linux-gnu-2.31/lib/ld-linux-aarch64.so.1, for GNU/Linux 2.6.32, not stripped
> --8<---------------cut here---------------end--------------->8---
> 
> which seems fine, but for the second one:
> 
> --8<---------------cut here---------------start------------->8---
> mathieu <at> meije ~/guix [env]$ file /gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash
> /gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/lib/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, not stripped
> --8<---------------cut here---------------end--------------->8---
> 
> As the first script is exec-ing the second one, it could be problematic,
> right?

Yes, indeed.  It seems like the same thing needs to be done for libexec/.dhclient-script.
Also, I'm not sure if using 'canonical-package' is the right thing.
I wonder when 'canonical-package' is supposed to be used.

(Somewhat unrelated) I'll rebase the meson patch on core-updates and try to
cross-compile some qt application and run it under qemu.  

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 49293 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49293 <at> debbugs.gnu.org
Subject: Re: bug#49293: [PATCH] isc-dhcp: Fix dhclient-script wrapper when
 cross-compiling.
Date: Thu, 08 Jul 2021 23:00:14 +0200

Hey Maxime,

> Yes, indeed.  It seems like the same thing needs to be done for libexec/.dhclient-script.
> Also, I'm not sure if using 'canonical-package' is the right thing.
> I wonder when 'canonical-package' is supposed to be used.

There's at least one issue with canonical-package that is discussed
here:
https://lists.gnu.org/archive/html/guix-devel/2020-06/msg00123.html.

The problem is that having for instance the canonical and non-canonical
package "coreutils" in a package or system closure, will significantly
increase its size.

> (Somewhat unrelated) I'll rebase the meson patch on core-updates and try to
> cross-compile some qt application and run it under qemu.  

I put the cross-compilation effort aside lately, it's really great to
see you bringing real progress on that front.

Thanks,

Mathieu

Message #19 received at 49293-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49293-done <at> debbugs.gnu.org
Subject: Re: bug#49293: [PATCH] isc-dhcp: Fix dhclient-script wrapper when
 cross-compiling.
Date: Sun, 29 Aug 2021 11:58:47 +0200

Hello,

> Yes, indeed.  It seems like the same thing needs to be done for libexec/.dhclient-script.
> Also, I'm not sure if using 'canonical-package' is the right thing.
> I wonder when 'canonical-package' is supposed to be used.

I fixed this issue and pushed it as
7256d9d2049352e9a63594eb558dc44978bd6687.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.