GNU bug report logs - #49321
28.0.50; [PATCH] Add option icomplete-matches-format

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49321 in the body.
You can then email your comments to 49321 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [PATCH] Add option icomplete-matches-format
Date: Thu, 01 Jul 2021 16:39:45 -0300

[Message part 1 (text/plain, inline)]

This patch adds a new user option to lisp/icomplete.el called
'icomplete-matches-format', similar to 'lazy-count-prefix-format'.

[0001-Add-option-icomplete-matches-format.patch (text/x-patch, attachment)]

Message #8 received at 49321 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 49321 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#49321: 28.0.50; [PATCH] Add option icomplete-matches-format
Date: Sun, 04 Jul 2021 16:05:09 +0200

Gabriel <gabriel376 <at> hotmail.com> writes:

> This patch adds a new user option to lisp/icomplete.el called
> 'icomplete-matches-format', similar to 'lazy-count-prefix-format'.

I guess that sounds reasonable, but I really have no opinion here.  So
I've added Dmitry and João to the CCs -- perhaps they have?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 49321 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Gabriel <gabriel376 <at> hotmail.com>, 49321 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#49321: 28.0.50; [PATCH] Add option icomplete-matches-format
Date: Sun, 4 Jul 2021 16:00:10 +0100

Thanks Lars,

I think it'd be great to skip the `safe-length` and similar potentially
costly calls if the user decides he doesn't want this info (which
I suppose is icomplete-matches-format = nil)

João

On Sun, Jul 4, 2021 at 3:05 PM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>
> Gabriel <gabriel376 <at> hotmail.com> writes:
>
> > This patch adds a new user option to lisp/icomplete.el called
> > 'icomplete-matches-format', similar to 'lazy-count-prefix-format'.
>
> I guess that sounds reasonable, but I really have no opinion here.  So
> I've added Dmitry and João to the CCs -- perhaps they have?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no



-- 
João Távora

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#49321: 28.0.50; [PATCH] Add option icomplete-matches-format
Date: Sun, 04 Jul 2021 12:33:26 -0300

[Message part 1 (text/plain, inline)]

João Távora <joaotavora <at> gmail.com> writes:

> Thanks Lars,
>
> I think it'd be great to skip the `safe-length` and similar potentially
> costly calls if the user decides he doesn't want this info (which
> I suppose is icomplete-matches-format = nil)
>
> João
>

Hi Joao,

Thanks for your inputs, makes a lot of sense to shortcut this piece of
code in case the user option is nil. Here is an updated version of the
patch:

[0001-Add-option-icomplete-matches-format.patch (text/x-patch, attachment)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#49321: 28.0.50; [PATCH] Add option icomplete-matches-format
Date: Sun, 04 Jul 2021 12:49:05 -0300

By the way, there is an open thread in #emacs-devel [1] about making
'icomplete-scroll' into a defcustom, which makes sense to me. In this
case, I am not sure if/how the matches prefix should work. The 'current
value' may not make sense, since it's a rotating list, but the 'total
value' continues to be an important info for the user. I will be glad to
send new patches, if necessary.

[1] https://lists.gnu.org/archive/html/emacs-devel/2021-06/msg00827.html

Regards,
Gabriel

Message #20 received at 49321 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 49321 <at> debbugs.gnu.org
Subject: Re: bug#49321: 28.0.50; [PATCH] Add option icomplete-matches-format
Date: Mon, 19 Jul 2021 18:04:42 +0200

Gabriel <gabriel376 <at> hotmail.com> writes:

> Thanks for your inputs, makes a lot of sense to shortcut this piece of
> code in case the user option is nil. Here is an updated version of the
> patch:

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.