GNU bug report logs - #49336
[PATCH] gnu: shellcheck: Generate and install manpage

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49336 in the body.
You can then email your comments to 49336 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: shellcheck: Generate and install manpage
Date: Fri,  2 Jul 2021 14:10:02 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/haskell-apps.scm (shellcheck)
[arguments]<#:phases>: Add build-manpage and install-manpage phases
[native-inputs]: Add pandoc
---
 gnu/packages/haskell-apps.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/haskell-apps.scm b/gnu/packages/haskell-apps.scm
index af777d1e3a..59e044b424 100644
--- a/gnu/packages/haskell-apps.scm
+++ b/gnu/packages/haskell-apps.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2020 Brian Leung <bkleung89 <at> gmail.com>
 ;;; Copyright © 2021 EuAndreh <eu <at> euandre.org>
 ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
+;;; Copyright © 2021 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -857,11 +858,27 @@ too slow and you'll get wound up in the scroll and crushed.")
         (base32 "06m4wh891nah3y0br4wh3adpsb16zawkb2ijgf1vcz61fznj6ps1"))
        (file-name (string-append name "-" version ".tar.gz"))))
     (build-system haskell-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'build 'build-manpage
+           (lambda _
+             ;; Run script to generate manpage
+             (invoke "sh" "manpage")
+             #t))
+         (add-after 'install 'install-manpage
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "shellcheck.1"
+                           (string-append (assoc-ref outputs "out")
+                                          "/share/man/man1/"))
+             #t)))))
     (inputs
      `(("ghc-aeson" ,ghc-aeson)
        ("ghc-diff" ,ghc-diff)
        ("ghc-quickcheck" ,ghc-quickcheck)
        ("ghc-regex-tdfa" ,ghc-regex-tdfa)))
+    (native-inputs
+     `(("pandoc" ,pandoc)))
     (home-page "https://www.shellcheck.net/")
     (synopsis "Static analysis for shell scripts")
     (description "@code{shellcheck} provides static analysis for
-- 
2.32.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Morgan.J.Smith <at> outlook.com
Cc: 49336-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#49336] [PATCH] gnu: shellcheck: Generate and install manpage
Date: Fri, 02 Jul 2021 20:37:44 +0200

[Message part 1 (text/plain, inline)]

Morgan,

Morgan.J.Smith <at> outlook.com 写道：
> From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
>
> * gnu/packages/haskell-apps.scm (shellcheck)
> [arguments]<#:phases>: Add build-manpage and install-manpage 
> phases
> [native-inputs]: Add pandoc

Thanks!  I added full stops to some lines and pushed it.

> +             #t))
> +             #t)))))

I removed these as well to avoid future noise: the requirement is 
obsolete on core-updates, but unfortunately the warning can't be 
removed on master.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.