GNU bug report logs - #49342
[PATCH 0/1] Fix libykpers reference in python-yubikey-manager

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49342 in the body.
You can then email your comments to 49342 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dhruvin Gandhi <contact <at> dhruvin.dev>
To: guix-patches <at> gnu.org
Cc: Dhruvin Gandhi <contact <at> dhruvin.dev>
Subject: [PATCH 0/1] Fix libykpers reference in python-yubikey-manager
Date: Sat,  3 Jul 2021 02:48:16 +0530

libykpers from yubikey-personalization package is required by
python-yubikey-manager to perform otp operations.

This patch fixes it. ($ ykman -v)

PS: The yubikey packages in the repo are quite old now and there are major
version changes upstream. I'll soon submit patches, fixing some of them.

Dhruvin Gandhi (1):
  gnu: python-yubikey-manager: Fix libykpers reference.

 gnu/packages/security-token.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

-- 
2.32.0

Message #8 received at 49342 <at> debbugs.gnu.org (full text, mbox):

From: Dhruvin Gandhi <contact <at> dhruvin.dev>
To: 49342 <at> debbugs.gnu.org
Cc: Dhruvin Gandhi <contact <at> dhruvin.dev>
Subject: [PATCH 1/1] gnu: python-yubikey-manager: Fix libykpers reference.
Date: Sat,  3 Jul 2021 02:51:59 +0530

* gnu/packages/security-token.scm (python-yubikey-manager): Fix libykpers reference.
---
 gnu/packages/security-token.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 49ca1dc01e..3c2f336497 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -657,6 +657,23 @@ implementing a Relying Party.")
                (base32
                 "11rsmcaj60k3y5m5gdhr2nbbz0w5dm3m04klyxz0fh5hnpcmr7fm"))))
     (build-system python-build-system)
+    (arguments
+     '(#:modules ((srfi srfi-1)
+                  (guix build utils)
+                  (guix build python-build-system))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-libykpers-reference
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "ykman/driver_otp.py"
+               (("Ykpers\\('ykpers-1', '1'\\)")
+                (string-append
+                 "Ykpers('"
+                 (find (negate symbolic-link?)
+                       (find-files (assoc-ref inputs "yubikey-personalization")
+                                   "^libykpers-.*\\.so\\..*"))
+                 "')")))
+             #t)))))
     (propagated-inputs
      `(("python-six" ,python-six)
        ("python-pyscard" ,python-pyscard)
-- 
2.32.0

Message #11 received at 49342 <at> debbugs.gnu.org (full text, mbox):

From: Dhruvin Gandhi <contact <at> dhruvin.dev>
To: 49342 <at> debbugs.gnu.org
Cc: Dhruvin Gandhi <contact <at> dhruvin.dev>
Subject: [PATCH v2 0/1] Update Copyright
Date: Sat,  3 Jul 2021 10:02:16 +0530

I missed updating the copyright in last patch. Here's v2.

Dhruvin Gandhi (1):
  gnu: python-yubikey-manager: Fix libykpers reference.

 gnu/packages/security-token.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)


base-commit: eef099a2e1648032c571567c6da29ccd86e72058
-- 
2.32.0

Message #14 received at 49342 <at> debbugs.gnu.org (full text, mbox):

From: Dhruvin Gandhi <contact <at> dhruvin.dev>
To: 49342 <at> debbugs.gnu.org
Cc: Dhruvin Gandhi <contact <at> dhruvin.dev>
Subject: [PATCH v2 1/1] gnu: python-yubikey-manager: Fix libykpers reference.
Date: Sat,  3 Jul 2021 10:02:17 +0530

* gnu/packages/security-token.scm (python-yubikey-manager): Fix libykpers reference.
---
 gnu/packages/security-token.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 49ca1dc01e..8af27176cc 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2020 Raphaël Mélotte <raphael.melotte <at> mind.be>
 ;;; Copyright © 2021 Antero Mejr <antero <at> kodmin.com>
 ;;; Copyright © 2021 Sergey Trofimov <sarg <at> sarg.org.ru>
+;;; Copyright © 2021 Dhruvin Gandhi <contact <at> dhruvin.dev>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -657,6 +658,23 @@ implementing a Relying Party.")
                (base32
                 "11rsmcaj60k3y5m5gdhr2nbbz0w5dm3m04klyxz0fh5hnpcmr7fm"))))
     (build-system python-build-system)
+    (arguments
+     '(#:modules ((srfi srfi-1)
+                  (guix build utils)
+                  (guix build python-build-system))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-libykpers-reference
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "ykman/driver_otp.py"
+               (("Ykpers\\('ykpers-1', '1'\\)")
+                (string-append
+                 "Ykpers('"
+                 (find (negate symbolic-link?)
+                       (find-files (assoc-ref inputs "yubikey-personalization")
+                                   "^libykpers-.*\\.so\\..*"))
+                 "')")))
+             #t)))))
     (propagated-inputs
      `(("python-six" ,python-six)
        ("python-pyscard" ,python-pyscard)
-- 
2.32.0

Message #17 received at 49342 <at> debbugs.gnu.org (full text, mbox):

From: Dhruvin Gandhi <contact <at> dhruvin.dev>
To: 49342 <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/1] Update Copyright
Date: Thu, 08 Jul 2021 11:42:31 +0530

Dhruvin Gandhi <contact <at> dhruvin.dev> writes:

> I missed updating the copyright in last patch. Here's v2.
>
> Dhruvin Gandhi (1):
>   gnu: python-yubikey-manager: Fix libykpers reference.
>
>  gnu/packages/security-token.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
>
> base-commit: eef099a2e1648032c571567c6da29ccd86e72058
> -- 
> 2.32.0

Are there any updates on the patch? It'd be great if we can merge it.
The patch only adds (links) a missing library at runtime. It can be
verified by running `ykman -v` before and after the patch.
Thanks.

Message #22 received at 49342-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Dhruvin Gandhi <contact <at> dhruvin.dev>
Cc: 49342-done <at> debbugs.gnu.org
Subject: Re: bug#49342: [PATCH 0/1] Fix libykpers reference in
 python-yubikey-manager
Date: Fri, 30 Jul 2021 22:50:27 +0200

Hi Dhruvin,

Dhruvin Gandhi <contact <at> dhruvin.dev> skribis:

> * gnu/packages/security-token.scm (python-yubikey-manager): Fix libykpers reference.

Applied.

Thank you, and apologies for the delay!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.