GNU bug report logs - #49357
[PATCH] gnu darktable update to 3.6.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49357 in the body.
You can then email your comments to 49357 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu darktable update to 3.6.0
Date: Sat, 03 Jul 2021 16:17:05 +0000

[Message part 1 (text/plain, inline)]

Update for darktable to latest release, 3.6.0 (tested build locally, no problems).

[darktable-3.6.0.diff (text/x-patch, attachment)]

Message #8 received at 49357 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 49357 <at> debbugs.gnu.org
Subject: [PATCH] gnu darktable update to 3.6.0
Date: Sat, 03 Jul 2021 16:29:41 +0000

Hello,

I noticed a warning in the build that darktable now expects LLVM-12,
and this:

> CMake Warning at src/CMakeLists.txt:332 (find_package):
>   Could not find a configuration file for package "OpenEXR" that is
>   compatible with requested version "3.0".
> 
>   The following configuration files were considered but not accepted:
> 
>     /gnu/store/rhixcbc778wwbi9g7j7qdcbbzpv5rgf7-openexr-
> 2.5.5/lib/cmake/OpenEXR/OpenEXRConfig.cmake, version: 2.5.5
> 

Is the openexr export working in the compiled package? If not, I'd
suggest renaming openexr to openexr-2, packaging openexr 3, and then
updating darktable to keep the same set of features. WDYT?

OpenEXR 3 seems to be incompatible with version 2 [1].

[1]
https://github.com/AcademySoftwareFoundation/Imath/blob/master/docs/PortingGuide2-3.md

Message #11 received at 49357 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "49357 <at> debbugs.gnu.org" <49357 <at> debbugs.gnu.org>
Subject: [PATCH] gnu darktable update to 3.6.0
Date: Sun, 04 Jul 2021 00:38:29 +0000

Thanks, did not catch those. For LLVM, I don't think Darktable cares about version, as this commit just shows they added v12 since it was reported to work: https://github.com/darktable-org/darktable/commit/4215f9995fdcc308eb9c6769b839ffac83ded5d9

As for OpenEXR, I have not tested it nor used that feature in the past. I just tried and "darktable --version" does show OpenEXR support. Also, it does export a photo with openexr without complaint and I can open it (I just tried in Gimp).

It seems like moving to openexr 3 should be done to address security issues: https://issues.guix.gnu.org/47509 This looks like it may involve patching many of the dependent packages, based on what I see in Arch (which only has openexr 3 and numerous small patches, though looked easy enough).

So I think this update to Darktable is okay, but we should move to openexr 3 for everything due to #47509. How does that sound to you?

Message #14 received at 49357 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 49357 <at> debbugs.gnu.org
Subject: [PATCH] gnu darktable update to 3.6.0
Date: Tue, 06 Jul 2021 00:03:33 +0000

> It seems like moving to openexr 3 should be done to address security
> issues: https://issues.guix.gnu.org/47509This looks like it may
> involve patching many of the dependent packages, based on what I see
> in Arch (which only has openexr 3 and numerous small patches, though
> looked easy enough).

I left a comment on that issue. OpenEXR addressed those vulnerabilities
in version 2.5.4, while we're at 2.5.5.

> So I think this update to Darktable is okay, but we should move to
> openexr 3 for everything due to #47509.

Looking at the releases page for openexr, it seems that both versions 2
and 3 are being actively maintained. We can have both, and IMO we
should. But there's no need to work on it immediately.

I built the package and executed darktable --version and also see that
openexr support is enabled. This patch LGTM then. I will now wait for a
committer to review.

Thanks,

Vinicius

Message #17 received at 49357 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "49357 <at> debbugs.gnu.org" <49357 <at> debbugs.gnu.org>
Subject: [PATCH] gnu darktable update to 3.6.0
Date: Tue, 06 Jul 2021 21:51:11 +0000

Thanks for the follow-up, that sounds good to me!

Message #22 received at 49357-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Cc: John Kehayias <john.kehayias <at> protonmail.com>,
 "49357 <at> debbugs.gnu.org" <49357-done <at> debbugs.gnu.org>
Subject: Re: [bug#49357] [PATCH] gnu darktable update to 3.6.0
Date: Thu, 08 Jul 2021 09:47:51 +0200

Hello,

John Kehayias via Guix-patches via <guix-patches <at> gnu.org> writes:

> Thanks for the follow-up, that sounds good to me!

I applied your patch, thank you! And thanks to Vinicius Monego for the
review.

I also added a proper commit message. Next time, please use "git
format-patch" to generate one. You may want to look at the "Submitting
Patches" section of the Guix manual for more information.

Regards,
-- 
Nicolas Goaziou

Message #28 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "49357 <at> debbugs.gnu.org" <49357-done <at> debbugs.gnu.org>,
 John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#49357] [PATCH] gnu darktable update to 3.6.0
Date: Thu, 08 Jul 2021 14:39:23 +0000

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, July 8th, 2021 at 3:47 AM, Nicolas Goaziou wrote:

> Hello,
>
> John Kehayias via Guix-patches via guix-patches <at> gnu.org writes:
>
> > Thanks for the follow-up, that sounds good to me!
>
> I applied your patch, thank you! And thanks to Vinicius Monego for the
>
> review.
>
> I also added a proper commit message. Next time, please use "git
>
> format-patch" to generate one. You may want to look at the "Submitting
>
> Patches" section of the Guix manual for more information.
>
Thanks, and will do for the next ones!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.