GNU bug report logs - #49366
[PATCH] services: bluetooth: Add 'extra-config' field.

Previous Next

To reply to this bug, email your comments to 49366 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: bluetooth: Add 'extra-config' field.
Date: Sat,  3 Jul 2021 22:50:15 +0200

* gnu/services/desktop.scm (bluetooth-configuration): Add 'extra-config'
field.
(bluetooth-configuration-file): Use it.
---
 gnu/services/desktop.scm | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index cd800fcc2b..7109d5d476 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -400,14 +400,18 @@ site} for more information."
   bluetooth-configuration make-bluetooth-configuration
   bluetooth-configuration?
   (bluez bluetooth-configuration-bluez (default bluez))
-  (auto-enable? bluetooth-configuration-auto-enable? (default #f)))
+  (auto-enable? bluetooth-configuration-auto-enable? (default #f))
+  (extra-config bluetooth-configuration-extra-config ;list of strings
+                (default '())))
 
 (define (bluetooth-configuration-file config)
   "Return a configuration file for the systemd bluetooth service, as a string."
-  (string-append
-   "[Policy]\n"
-   "AutoEnable=" (bool (bluetooth-configuration-auto-enable?
-                        config))))
+  (string-concatenate
+   (cons*
+    "[Policy]\n"
+    "AutoEnable=" (bool (bluetooth-configuration-auto-enable?
+                         config)) "\n"
+    (bluetooth-configuration-extra-config config))))
 
 (define (bluetooth-directory config)
   (computed-file "etc-bluetooth"
-- 
2.31.1

Message #8 received at 49366 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 49366 <at> debbugs.gnu.org
Subject: Re: bug#49366: [PATCH] services: bluetooth: Add 'extra-config' field.
Date: Wed, 07 Jul 2021 16:35:03 +0200

Hello Brice,

> * gnu/services/desktop.scm (bluetooth-configuration): Add 'extra-config'
> field.
> (bluetooth-configuration-file): Use it.

I guess you have a specific use case in mind, adding a short
documentation about the <bluetooth-configuration> and the new
extra-config field could be nice here.

Otherwise it seems fine to me.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.