GNU bug report logs - #49371
Removing the broken ‘corrode’ package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49371 in the body.
You can then email your comments to 49371 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Bug reports for GNU Guix <bug-guix <at> gnu.org>
Subject: Removing the broken ‘corrode’ package
Date: Sat, 03 Jul 2021 17:46:03 +0200

[Message part 1 (text/plain, inline)]

Guix,

Cool hack though it was, I propose to remove the broken ‘corrode’ 
package.  This is your chance to protest by fixing it!

With the patches below applied corrode still fails to build as it 
does elsewhere: 
<https://github.com/jameysharp/corrode/issues/181>.

The code hasn't seen commits since 2017, nor did I find any newer 
posts by the author on their GitHub issue tracker.  The project is 
quite dead.

Kind regards,

T G-R

[0001-gnu-Add-ghc-language-c-0.6.patch (text/x-patch, inline)]

From 879b32a49b606eef976062aee06bdf8a6ec028a0 Mon Sep 17 00:00:00 2001
From: Tobias Geerinckx-Rice <me <at> tobias.gr>
Date: Sat, 3 Jul 2021 17:39:13 +0200
Subject: [PATCH 1/2] gnu: Add ghc-language-c <at> 0.6.

* gnu/packages/haskell-xyz.scm (ghc-language-c-0.6): New public variable.
---
 gnu/packages/haskell-xyz.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index 4b80410346..daa64ac8fd 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -7000,6 +7000,18 @@ It features a complete, well-tested parser and pretty printer for all of C99
 and a large set of GNU extensions.")
     (license license:bsd-3)))
 
+(define-public ghc-language-c-0.6
+  (package
+    (inherit ghc-language-c)
+    (version "0.6.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://hackage.haskell.org/package/"
+                           "language-c/language-c-" version ".tar.gz"))
+       (sha256
+        (base32 "1s1pz8lxnc3fbs84a4spayzrww1avkn7jszmazn90r740jfxrji3"))))))
+
 (define-public ghc-language-glsl
   (package
     (name "ghc-language-glsl")
-- 
2.32.0

[0002-gnu-corrode-Update-to-0.0.0-1.3405334.patch (text/x-patch, inline)]

From 7fb3a504056862ca5577a3cfd6ce0eaa1b364551 Mon Sep 17 00:00:00 2001
From: Tobias Geerinckx-Rice <me <at> tobias.gr>
Date: Sat, 3 Jul 2021 17:40:52 +0200
Subject: [PATCH 2/2] gnu: corrode: Update to 0.0.0-1.3405334.

* gnu/packages/haskell-apps.scm (corrode): Update to 0.0.0-1.3405334.
[native-inputs]: Add ghc-tasty and ghc-tasty-quickcheck.
[inputs]: Use older ghc-language-c-0.6 instead of ghc-language-c.
---
 gnu/packages/haskell-apps.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/haskell-apps.scm b/gnu/packages/haskell-apps.scm
index 9e49bbfd9e..10c0dadbc4 100644
--- a/gnu/packages/haskell-apps.scm
+++ b/gnu/packages/haskell-apps.scm
@@ -145,8 +145,8 @@ installation of Haskell libraries and programs.")
    (license license:bsd-3)))
 
 (define-public corrode
-  (let ((revision "0")
-        (commit "b6699fb2fa552a07c6091276285a44133e5c9789"))
+  (let ((revision "1")
+        (commit "34053342c2f1ca04f23ad94d67057f14e74d9fb9"))
     (package
       (name "corrode")
       (version (git-version "0.0.0" revision commit))
@@ -158,10 +158,14 @@ installation of Haskell libraries and programs.")
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "02v0yyj6sk4gpg2222wzsdqjxn8w66scbnf6b20x0kbmc69qcz4r"))))
+          (base32 "0qwglbbcm96hm44yinzlyspfb60bi2iql750qv0psk5651jfrrdf"))))
       (build-system haskell-build-system)
+      (native-inputs
+       `(("ghc-tasty" ,ghc-tasty)
+         ("ghc-tasty-quickcheck" ,ghc-tasty-quickcheck)))
       (inputs
-       `(("ghc-language-c" ,ghc-language-c)
+       ;; XXX When updating, check if the 0.6 variant can be removed entirely.
+       `(("ghc-language-c" ,ghc-language-c-0.6)
          ("ghc-markdown-unlit" ,ghc-markdown-unlit)))
       (home-page "https://github.com/jameysharp/corrode")
       (synopsis "Automatic semantics-preserving translation from C to Rust")
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 49371 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 49371 <at> debbugs.gnu.org
Subject: Re: bug#49371: Removing the broken ‘corrode’
 package
Date: Tue, 06 Jul 2021 10:47:37 +0200

Hi Tobias,

On Sat, 03 Jul 2021 at 17:46, Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix <at> gnu.org> wrote:

> Cool hack though it was, I propose to remove the broken ‘corrode’ 
> package.  This is your chance to protest by fixing it!

Yeah, let remove it and I am consistent with myself [1]. ;-)

Please, close [1] when you push. :-)

1:  <http://issues.guix.gnu.org/43874>


Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.