GNU bug report logs - #49437
[PATCH core-updates] build-system/qt: Fix build failures when

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49437 in the body.
You can then email your comments to 49437 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] build-system/qt: Fix build failures when
Date: Tue, 06 Jul 2021 13:25:50 +0200

[Message part 1 (text/plain, inline)]

Hi guix,

From the commit message:

‘One of the features of 'qt-build-system' is that it automatically
creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
so.  If "bin/bash" doesn't exist among the 'inputs', then
'search-input-file' (used by 'wrap-all-programs') will raise an
exception.  Address this exception by adding "bash-minimal" to
'host-inputs' when cross-compiling.

This change does not impact native compilation; the derivations
for natively-compiled packages remain identical.’

I am unable to test this at the moment (too little substitutes
for core-updates, too little processing power locally ...), but
I intent to do so later.

Greetings,
Maxime/

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Thu, 08 Jul 2021 16:45:40 +0200

Hey Maxime,

> I am unable to test this at the moment (too little substitutes
> for core-updates, too little processing power locally ...), but
> I intent to do so later.

I think you are missing the attached patch here.

Thanks,

Mathieu

Message #11 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Thu, 08 Jul 2021 19:51:25 +0200

[Message part 1 (text/plain, inline)]

Mathieu Othacehe schreef op do 08-07-2021 om 16:45 [+0200]:
> Hey Maxime,
> 
> > I am unable to test this at the moment (too little substitutes
> > for core-updates, too little processing power locally ...), but
> > I intent to do so later.
> 
> I think you are missing the attached patch here.

Now attached!

Greetings,
Maxime.

[0001-build-system-qt-Fix-build-failures-when-cross-compil.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Thu, 08 Jul 2021 21:37:20 +0200

Hey,

> One of the features of 'qt-build-system' is that it automatically
> creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
> so.  If "bin/bash" doesn't exist among the 'inputs', then
> 'search-input-file' (used by 'wrap-all-programs') will raise an
> exception.  Address this exception by adding "bash-minimal" to
> 'host-inputs' when cross-compiling.

I'd like to test it but it looks like qt-build-system drags glib which
uses the meson-build-system that doesn't support cross-compilation.

Did you test this patch, on top of your meson series?

Otherwise, it looks fine to me.

Thanks,

Mathieu

Message #17 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Thu, 08 Jul 2021 22:59:08 +0200

[Message part 1 (text/plain, inline)]

Mathieu Othacehe schreef op do 08-07-2021 om 21:37 [+0200]:
> Hey,
> 
> > One of the features of 'qt-build-system' is that it automatically
> > creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
> > so.  If "bin/bash" doesn't exist among the 'inputs', then
> > 'search-input-file' (used by 'wrap-all-programs') will raise an
> > exception.  Address this exception by adding "bash-minimal" to
> > 'host-inputs' when cross-compiling.
> 
> I'd like to test it but it looks like qt-build-system drags glib which
> uses the meson-build-system that doesn't support cross-compilation.
> 
> Did you test this patch, on top of your meson series?

I had started "./pre-inst-env guix build qtsvg" but that's no
cross-compilation.  I'll rebase the meson series and test it!

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Wed, 22 Sep 2021 23:53:20 -0400

Hello,

Maxime Devos <maximedevos <at> telenet.be> writes:

> Mathieu Othacehe schreef op do 08-07-2021 om 21:37 [+0200]:
>> Hey,
>> 
>> > One of the features of 'qt-build-system' is that it automatically
>> > creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
>> > so.  If "bin/bash" doesn't exist among the 'inputs', then
>> > 'search-input-file' (used by 'wrap-all-programs') will raise an
>> > exception.  Address this exception by adding "bash-minimal" to
>> > 'host-inputs' when cross-compiling.
>> 
>> I'd like to test it but it looks like qt-build-system drags glib which
>> uses the meson-build-system that doesn't support cross-compilation.
>> 
>> Did you test this patch, on top of your meson series?
>
> I had started "./pre-inst-env guix build qtsvg" but that's no
> cross-compilation.  I'll rebase the meson series and test it!

Did it test fine?

Thanks,

Maxim

Message #23 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Sun, 03 Oct 2021 10:56:45 +0200

[Message part 1 (text/plain, inline)]

Maxim Cournoyer schreef op wo 22-09-2021 om 23:53 [-0400]:
> Hello,
> 
> Maxime Devos <maximedevos <at> telenet.be> writes:
> 
> > Mathieu Othacehe schreef op do 08-07-2021 om 21:37 [+0200]:
> > > Hey,
> > > 
> > > > One of the features of 'qt-build-system' is that it automatically
> > > > creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
> > > > so.  If "bin/bash" doesn't exist among the 'inputs', then
> > > > 'search-input-file' (used by 'wrap-all-programs') will raise an
> > > > exception.  Address this exception by adding "bash-minimal" to
> > > > 'host-inputs' when cross-compiling.
> > > 
> > > I'd like to test it but it looks like qt-build-system drags glib which
> > > uses the meson-build-system that doesn't support cross-compilation.
> > > 
> > > Did you test this patch, on top of your meson series?
> > 
> > I had started "./pre-inst-env guix build qtsvg" but that's no
> > cross-compilation.  I'll rebase the meson series and test it!
> 
> Did it test fine?

Didn't test it yet, because I first wanted the meson series merged.
Now the meson series and the gtk+ cross-compilation fixes are merged,
I'll take a look again.

> Thanks,
> 
> Maxim

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Tue, 28 Mar 2023 22:15:29 -0400

Hi Maxime,

I hope you are doing well.

Maxime Devos <maximedevos <at> telenet.be> writes:

> Maxim Cournoyer schreef op wo 22-09-2021 om 23:53 [-0400]:
>> Hello,
>> 
>> Maxime Devos <maximedevos <at> telenet.be> writes:
>> 
>> > Mathieu Othacehe schreef op do 08-07-2021 om 21:37 [+0200]:
>> > > Hey,
>> > > 
>> > > > One of the features of 'qt-build-system' is that it automatically
>> > > > creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
>> > > > so.  If "bin/bash" doesn't exist among the 'inputs', then
>> > > > 'search-input-file' (used by 'wrap-all-programs') will raise an
>> > > > exception.  Address this exception by adding "bash-minimal" to
>> > > > 'host-inputs' when cross-compiling.
>> > > 
>> > > I'd like to test it but it looks like qt-build-system drags glib which
>> > > uses the meson-build-system that doesn't support cross-compilation.
>> > > 
>> > > Did you test this patch, on top of your meson series?
>> > 
>> > I had started "./pre-inst-env guix build qtsvg" but that's no
>> > cross-compilation.  I'll rebase the meson series and test it!
>> 
>> Did it test fine?
>
> Didn't test it yet, because I first wanted the meson series merged.
> Now the meson series and the gtk+ cross-compilation fixes are merged,
> I'll take a look again.

core-updates is pretty "hot" at the moment, so it may be a good time to
test.

On the other hand, there aren't that many Qt packages, so it could also
go to staging IMO.  And if it only touches cross-compilation drv,
perhaps it's good for master too?

It just needs testing.

-- 
Thanks,
Maxim

Message #29 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Tue, 4 Apr 2023 20:59:13 +0200

[Message part 1 (text/plain, inline)]

Op 29-03-2023 om 04:15 schreef Maxim Cournoyer:
> Hi Maxime,
> 
> I hope you are doing well.
> 
> [...]
> 
> core-updates is pretty "hot" at the moment, so it may be a good time to
> test.
> 
> On the other hand, there aren't that many Qt packages, so it could also
> go to staging IMO.  And if it only touches cross-compilation drv,
> perhaps it's good for master too?
> 
> It just needs testing.

I am not participating in Guix development anymore, except perhaps for 
bug reports and for when Guix intersects GNUnet, and currently it 
appears a permanent decision.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #32 received at 49437 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 49437 <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Fri, 07 Apr 2023 17:15:00 -0400

Hi,

Maxime Devos <maximedevos <at> telenet.be> writes:

> Op 29-03-2023 om 04:15 schreef Maxim Cournoyer:
>> Hi Maxime,
>> I hope you are doing well.
>> [...]
>> core-updates is pretty "hot" at the moment, so it may be a good time
>> to
>> test.
>> On the other hand, there aren't that many Qt packages, so it could
>> also
>> go to staging IMO.  And if it only touches cross-compilation drv,
>> perhaps it's good for master too?
>> It just needs testing.
>
> I am not participating in Guix development anymore, except perhaps for
> bug reports and for when Guix intersects GNUnet, and currently it
> appears a permanent decision.

OK.  It's sad that it's come to this, but I respect your decision;
thanks for making it clear.  Your thoughtful inputs and high-impact Guix
contributions will be missed!

-- 
Maxim

Message #37 received at 49437-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 49437-done <at> debbugs.gnu.org
Subject: Re: bug#49437: [PATCH core-updates] build-system/qt: Fix build
 failures when
Date: Sat, 20 Jan 2024 16:11:25 -0500

Hi,

Maxime Devos <maximedevos <at> telenet.be> writes:

> Mathieu Othacehe schreef op do 08-07-2021 om 16:45 [+0200]:
>> Hey Maxime,
>> 
>> > I am unable to test this at the moment (too little substitutes
>> > for core-updates, too little processing power locally ...), but
>> > I intent to do so later.
>> 
>> I think you are missing the attached patch here.
>
> Now attached!
>
> Greetings,
> Maxime.
>
> From b9e46156e1f35303b56fbe2ed4694385b6104214 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Tue, 6 Jul 2021 10:57:49 +0200
> Subject: [PATCH core-updates] build-system/qt: Fix build failures when
>  cross-compiling.
>
> One of the features of 'qt-build-system' is that it automatically
> creates wrappers, but it needs 'bash' (or 'bash-minimal') to do
> so.  If "bin/bash" doesn't exist among the 'inputs', then
> 'search-input-file' (used by 'wrap-all-programs') will raise an
> exception.  Address this exception by adding "bash-minimal" to
> 'host-inputs' when cross-compiling.
>
> This change does not impact native compilation; the derivations
> for natively-compiled packages remain identical.
>
> * guix/build-system/qt.scm
>   (bash-for-wrappers): New procedure.
>   (lower): Add 'bash-minimal' to 'host-inputs' when cross-compiling.

I don't think our Qt packages can be already cross-built; hence there's
no current value in adding this before addressing cross-compilation of
the qt-build-system in the first place.

Also, 'guix lint' would still complain, so for now I'm opting to close
this without applying it.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.