GNU bug report logs - #49440
[PATCH core-updates]: Compile bdw-gc with support for disclaim procedures

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49440 in the body.
You can then email your comments to 49440 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates]: Compile bdw-gc with support for disclaim
 procedures
Date: Tue, 06 Jul 2021 17:00:22 +0200

[Message part 1 (text/plain, inline)]

Hi guix,

Disclaim procedures do not seem to be used in the wild,
but seem useful for implementing ephemerons in Guile
(to be investigated), hence this patch.

Guile seems to start building fine when using a bdw-gc packave
with "--enable-disclaim" added (I'm using (package (inherit ...) ...),
but that was on master. I'll verify on core-updates, but building
things will take some time.

Greetings,
Maxime.

[0001-gnu-bdw-gc-Compile-with-support-for-disclaim-procedu.patch (text/x-patch, inline)]

From 34f32618f8f9099eabbd7734337f455aa1c7e150 Mon Sep 17 00:00:00 2001
From: Maxime Devos <maximedevos <at> telenet.be>
Date: Tue, 6 Jul 2021 16:50:39 +0200
Subject: [PATCH core-updates] gnu: bdw-gc: Compile with support for disclaim
 procedures.

Disclaim procedures do not seem to be used in the wild,
but seem useful for implementing ephemerons in Guile
(to be investigated).

* gnu/packages/bdw-gc.scm
  (libgc)[arguments]<#:configure-flags>: Add --enable-disclaim.
---
 gnu/packages/bdw-gc.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
index 0d82889bac..dfa9a61101 100644
--- a/gnu/packages/bdw-gc.scm
+++ b/gnu/packages/bdw-gc.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2016, 2018 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2017 Rene Saavedra <rennes <at> openmailbox.org>
 ;;; Copyright © 2019, 2020 Marius Bakke <mbakke <at> fastmail.com>
+;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -47,6 +48,9 @@
        ;; Install gc_cpp.h et al.
        "--enable-cplusplus"
 
+       ;; Support GC_finalized_malloc and disclaim procedures.
+       "--enable-disclaim"
+
        ;; Work around <https://github.com/ivmai/bdwgc/issues/353>.
        "--disable-munmap"
 
-- 
2.32.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 49440 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 49440 <at> debbugs.gnu.org
Subject: Re: [bug#49440] [PATCH core-updates]: Compile bdw-gc with support
 for disclaim procedures
Date: Fri, 09 Jul 2021 21:12:23 +0200

[Message part 1 (text/plain, inline)]

Maxime Devos schreef op di 06-07-2021 om 17:00 [+0200]:
> Hi guix,
> 
> Disclaim procedures do not seem to be used in the wild,
> but seem useful for implementing ephemerons in Guile
> (to be investigated), hence this patch.
> 
> Guile seems to start building fine when using a bdw-gc packave
> with "--enable-disclaim" added (I'm using (package (inherit ...) ...),
> but that was on master. I'll verify on core-updates, but building
> things will take some time.

FWIW, I ran "./pre-inst-env guix build guile" and it succeeded.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 49440 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49440 <at> debbugs.gnu.org
Subject: Re: bug#49440: [PATCH core-updates]: Compile bdw-gc with support
 for disclaim procedures
Date: Wed, 21 Jul 2021 16:30:18 +0200

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Disclaim procedures do not seem to be used in the wild,
> but seem useful for implementing ephemerons in Guile
> (to be investigated), hence this patch.
>
> Guile seems to start building fine when using a bdw-gc packave
> with "--enable-disclaim" added (I'm using (package (inherit ...) ...),
> but that was on master. I'll verify on core-updates, but building
> things will take some time.

I have a slight preference for delaying ‘--enable-disclaim’ until we
have software that actually needs it.

WDYT?

Thanks,
Ludo’.

Message #14 received at 49440 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49440 <at> debbugs.gnu.org
Subject: Re: bug#49440: [PATCH core-updates]: Compile bdw-gc with support
 for disclaim procedures
Date: Wed, 21 Jul 2021 21:07:14 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op wo 21-07-2021 om 16:30 [+0200]:
> I have a slight preference for delaying ‘--enable-disclaim’ until we
> have software that actually needs it.
> 
> WDYT?

Makes sense to me.  I'll send a ping if (when?) I actually patch
Guile to use disclaim procedures.

The idea was to use ‘disclaim procedures’ for implementing ephemeral
hash tables (apparently ephemeral (not merely weak) hash tables are
required in ‘Spritely Goblins’, which currently only supports Racket
but Christopher Lemmer Webber intends to port to Guile at some point
or so I've understood).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 49440-done <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 49440-done <at> debbugs.gnu.org
Subject: Re: [PATCH core-updates]: Compile bdw-gc with support for disclaim
 procedures
Date: Tue, 6 Sep 2022 13:51:23 +0200

[Message part 1 (text/plain, inline)]

wingo has been working on a new GC for guile that supports ephemerals, 
so I don't think this patch will be necessary anymore.

Closing,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.