GNU bug report logs - #49465
28.0.50; project-kill-buffers: include shell buffers?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49465 in the body.
You can then email your comments to 49465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; project-kill-buffers: include shell buffers?
Date: Thu, 08 Jul 2021 13:48:30 +0200

Currently, `project-kill-buffers' won't touch shell buffers belonging to
the current project by default.

I know about the `project-kill-buffer-conditions' defcustom, but would
it perhaps be nice if `project-kill-buffers' includes buffers created by
`C-x p e' (`project-eshell') and `C-x p s' (`project-shell') by default?

Message #8 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> runbox.com>,
 49465 <at> debbugs.gnu.org
Cc: "Philip K." <philip <at> warpmail.net>
Subject: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
Date: Sat, 10 Jul 2021 02:43:32 +0300

Hi Simen!

On 08.07.2021 14:48, Simen Heggestøyl wrote:
> Currently, `project-kill-buffers' won't touch shell buffers belonging to
> the current project by default.
> 
> I know about the `project-kill-buffer-conditions' defcustom, but would
> it perhaps be nice if `project-kill-buffers' includes buffers created by
> `C-x p e' (`project-eshell') and `C-x p s' (`project-shell') by default?

Sure, why not.

You're suggesting to add eshell-mode to project-kill-buffer-conditions, 
right? We might as well add comint-mode there too (which will bring in 
shell-mode as well).

Cc'ing Philip as well.

Message #11 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: "Philip K." <philip <at> warpmail.net>, 49465 <at> debbugs.gnu.org
Subject: Re: bug#49465: 28.0.50; project-kill-buffers: include shell buffers?
Date: Sat, 10 Jul 2021 09:59:31 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> You're suggesting to add eshell-mode to
> project-kill-buffer-conditions, right?

Right.

> We might as well add comint-mode there too (which will bring in
> shell-mode as well).

Sure!

Message #14 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Philip Kaludercic <philipk <at> posteo.net>, 49465 <at> debbugs.gnu.org
Cc: Simen Heggestøyl <simenheg <at> runbox.com>
Subject: Re: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include shell
 buffers?
Date: Sat, 10 Jul 2021 13:26:22 +0300

On 10.07.2021 10:33, Philip Kaludercic wrote:
> I think that adding the shells created by C-x p {e,s} would be good, but
> I am not sure if we want to always kill a shell buffer, that might just
> happen to be in a project directory.

IDK, most of the time I create Eshell by calling the "plain" eshell 
command somewhere inside the project. And it still feels like belonging 
to that project. So I'd probably like for them to be cleaned out too.

Do you envision a particular scenario where you wouldn't want this to 
happen?

Message #17 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Simen Heggestøyl <simenheg <at> runbox.com>,
 49465 <at> debbugs.gnu.org
Subject: Re: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers: include
 shell buffers?
Date: Sat, 10 Jul 2021 13:17:58 +0000

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 10.07.2021 10:33, Philip Kaludercic wrote:
>> I think that adding the shells created by C-x p {e,s} would be good, but
>> I am not sure if we want to always kill a shell buffer, that might just
>> happen to be in a project directory.
>
> IDK, most of the time I create Eshell by calling the "plain" eshell
> command somewhere inside the project. And it still feels like
> belonging to that project. So I'd probably like for them to be cleaned
> out too.
>
> Do you envision a particular scenario where you wouldn't want this to
> happen?

A simple example would be if I start a shell session, later on cd into a
project, start working on it and then want to clean up the project. The
shell that might contain relevant information outside of the project I
just worked on would also be killed.

-- 
	Philip Kaludercic

Message #20 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Simen Heggestøyl <simenheg <at> runbox.com>,
 49465 <at> debbugs.gnu.org
Subject: Re: bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers:
 include shell buffers?
Date: Sun, 18 Jul 2021 02:46:23 +0300

On 10.07.2021 16:17, Philip Kaludercic wrote:
> A simple example would be if I start a shell session, later on cd into a
> project, start working on it and then want to clean up the project. The
> shell that might contain relevant information outside of the project I
> just worked on would also be killed.

But project-eshell basically creates an eshell buffer in the project 
root directory, and that's it. You could also 'cd' inside it to a 
different project and work there for a time.

Not sure if we should add some special distinctions or restrictions, 
like prohibiting 'cd'-ing outside of the current project.

Anyway, if people think it's a bad idea, we can leave this feature up to 
individual users' configurations. But I wonder what others think.

Message #23 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 49465 <at> debbugs.gnu.org
Subject: Re: bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers:
 include shell buffers?
Date: Wed, 15 Dec 2021 14:49:06 +0100

As of commit 38977b6134e7c57788ca92a31362d536d4c7687a to master
(project.el v0.8.2), shell-mode (and other comint-mode-based) buffers
are now included in the kill conditions.

I think that weighs in favor of including Eshell buffers too, for
alignment?

-- Simen

Message #26 received at 49465 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 49465 <at> debbugs.gnu.org
Subject: Re: bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers:
 include shell buffers?
Date: Fri, 17 Dec 2021 04:21:09 +0300

Hi Simen,

On 15.12.2021 16:49, Simen Heggestøyl wrote:
> As of commit 38977b6134e7c57788ca92a31362d536d4c7687a to master
> (project.el v0.8.2), shell-mode (and other comint-mode-based) buffers
> are now included in the kill conditions.
> 
> I think that weighs in favor of including Eshell buffers too, for
> alignment?

Makes sense, added.

Message #31 received at 49465-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 49465-done <at> debbugs.gnu.org, Philip Kaludercic <philipk <at> posteo.net>
Subject: Re: bug#49465: Fwd: Re: bug#49465: 28.0.50; project-kill-buffers:
 include shell buffers?
Date: Fri, 17 Dec 2021 08:56:28 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 15.12.2021 16:49, Simen Heggestøyl wrote:
>> As of commit 38977b6134e7c57788ca92a31362d536d4c7687a to master
>> (project.el v0.8.2), shell-mode (and other comint-mode-based) buffers
>> are now included in the kill conditions.
>> I think that weighs in favor of including Eshell buffers too, for
>> alignment?
>
> Makes sense, added.

Cool, thanks!

Closing this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.